- 25 Aug, 2020 40 commits
-
-
James Hollyer authored
On Windows we grab the raw mouse movements and stop actually moving the mouse when in unadjusted movement so moving to the center does not make sense. However, on ChromeOS and Linux we temporarily turn off mouse Acceleration in the settings and keep the mouse moving like normal so The move to center calculation should not change. Bug: 1119468 Change-Id: Ib318627340df98f55205f4489084d88c89a7fd37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373447Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#801295}
-
Fergal Daly authored
It was reenabled in https://crrev.com/c/2008079 but it is still flaky when run with leak detection. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak?limit=100 TBR=cassew@google.com,rakina@chromium.org Bug: 833655 Change-Id: I4268307e0549d38c6e653217776a5f31309badbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371948 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801294}
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: I209ebbcb89a616c91284c170ef251bbb4fd3091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371382Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801293}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bcca52ab84df..9ad0c9e91a7d 2020-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from ef7447334713 to c3e3c30b0d7f (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I154391e92e0f06e5ee3a01bcd6da69e567d367b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373748Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801292}
-
Eric Willigers authored
Two tests each installed 8 PWAs. These tests are now split in half, so we never install more that 4 PWAs in a single test. Flakiness Dashboard https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FWebAppBrowserTest_DisplayOverride.HasMinimalUiButtons%2FWebApps&testType=browser_tests Bug: 1120504 Change-Id: I5a853d65ad396c2f822edef9d8a7e805ad99662d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368697 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801291}
-
Caroline Rising authored
Bug: 982964 Change-Id: I095c1ae1828208dc797913e7ceb6fc4361afd0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372344Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#801290}
-
Emily Stark authored
This histogram records the time that the user spends on a page with a delayed warning until the interstitial shows or the user leaves the page. Bug: 1111078 Change-Id: Ice9cd219fed35386fd62e3dc4a86050ca3e8343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368449Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#801289}
-
Andreea Costinas authored
If the user has manually set a proxy in the network settings, a warning is shown in the tray to let them know that traffic may be monitored. This CL implements showing the proxy privacy disclosure message regardless of the proxy source or configuration mode (PAC, WPAD etc). Bug: 1119754, 919691 Test: unittest Change-Id: I6da49a72650614c1bd58c76e7bdb474ed4881c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367042Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#801288}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 163a87b7. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia27bcdfd162ef150f661e427b77853b25709a1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374085Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801287}
-
Alice Wang authored
This CL adds subtitle and button strings for web sign-in auth error. Screenshot: https://crbug.com/1116952#c3 Bug: 1116952 Change-Id: I251f3c6f24e98e3198828d8f25ae5eafd8c684dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368557Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801286}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_DidShowPrintDialog message to DidShowPrintDialog() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I1c73eb64fa7031ce2f2a35c12435e949d837dbf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362489 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#801285}
-
Karel Král authored
Implement scope objects to open / close a dictionary or array in their constructors / destructors. Thus provide an alternative and hopefully less bug-prone syntax for opening / closing of containers. Bug: 1043616 Change-Id: Ie9a51d2ac1b0cae7f95bae3906c253a44013ccdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372442Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#801284}
-
Kenichi Ishibashi authored
Some tests are still flaky. Use content::RunAllTasksUntilIdle() instead of RunLoop().RunUntilIdle() to try to run all scheduled mojo callbacks. Bug: 1115172 Change-Id: I0146698b9092b2aac48a357b69f4d2d7818d367c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374187Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801283}
-
Christopher Lam authored
This CL is a sanity check on ChromeContentRulesRegistry::AddRulesImpl() which will help diagnose system inconsistency issues. Bug: 1010336 Change-Id: Id4be21a63e966e2b0a81f74183489217b0768ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368613 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801282}
-
Kent Tamura authored
should not affect the internal layout" In LayoutNG, we use LayoutNGBlockFlow for input[type=file]. If flex/grid is specified, NGBlockLayoutAlgorithm is applied but children are blockified. So the internal [Choose File] button and "No file chosen" text were placed on different lines. This CL fixes it by skipping children blockify if the parent box is input[type=file]. The original approach was wrong because it exposed adjusted 'display' value via getComputedStyle(). Original change's description: > input[type=file]: display:inline-flex/flex/inline-grid/grid should > not affect the internal layout > > In LayoutNG, we use LayoutNGBlockFlow for input[type=file]. If > flex/grid is specified, NGBlockLayoutAlgorithm is applied but children > are blockified. So the internal [Choose File] button and > "No file chosen" text were placed on different lines. > > This CL fixes it by adding "display" adjustment code. > > Bug: 1119312 > Change-Id: Id15bfa5a047f56ee00adb43d74e6b3d09f1f6433 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371066 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801209} Bug: 1119312 Change-Id: I1df3580882dff125d1860dab9754d6707d4eedc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371727 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#801281}
-
edchin authored
The last position index is items.count-1 not items.count. Bug: 1115486 Change-Id: I6e9072d15dfbee0cc161d81c22441bb0c82bcb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373297Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801280}
-
Fergal Daly authored
Only crashes on ASAN. There's no good way to express that in the test expectations so it's [ Pass Crash ] TBR=smcgruer@chromium.org Bug: 1121429 Change-Id: Ia702dbbcf3175e17098c07f8f3b5271b4e2379be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371831Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801279}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /extensions/browser/api/app_window This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 1110266 Change-Id: I188590d228e449aaebed57a919b175cb2f7674de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371294Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#801278}
-
Bruce Dawson authored
The packaging script previously would generate environment variables with lots of ..\.. entries in environment variables, which is difficult to read and increases the odds of hitting MAX_PATH limits. crrev.com/c/2372727 changes the packaging and this change to setup_toolchain.py adjusts the setup code to handle both the old and new systems. Bug: 1120785 Change-Id: I7c3449a54cf6fba9f70f52db83d940ffd4c32573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370604 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801277}
-
Tsuyoshi Horo authored
This CL changes ResourceFetcher::GetCacheIdentifier() to use the bundle's URL as the cache identifier, when the resource is listed in the resource= attribute of <link rel="webbundle">, Bug: 1082020 Change-Id: I2035f9ef37bf40c8a636baecf38031ed1a585813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371424Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801276}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /components/safe_browsing This CL was uploaded by git cl split. R=drubery@chromium.org Bug: 1110266 Change-Id: Id895b4785eeea1828e2e2c753d24872412cf5984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370292Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801275}
-
JunHo Seo authored
Because we don't return any value for it, following warning is printed: .../wtf/casting.h: In static member function '.. bool DowncastTraits<T>::AllowFrom(const U&)': .../wtf/casting.h:60:3: warning: no return statement in function returning non-void [-Wreturn-type] Used compiler: gcc 8.2.0 To fix the warning, this CL returns false value. Change-Id: I19d7eef907619c272bdd790770a791aec4a5f03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362348Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#801274}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/notifications This CL was uploaded by git cl split. R=yoshiki@chromium.org Bug: 1110266 Change-Id: Ia3805830c319754c760ddf58fddba687f33d68c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371256Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801273}
-
Eliot Courtney authored
This interface lets a wayland client provide in-fences to a wayland server and receive out-fences (or an immediate release) back. Adding this interface to ozone/wayland is a required step for adding support for passing in-fences and out-fences between Chrome (wayland client) and the wayland server. Passing fences around lets buffers be used more efficiently by: 1. Moving the wait on a buffer to be available for scan-out closer to the place where it is scanned out. 2. Letting clients know when they can re-use buffers more quickly (rather than via IPC). Bug: 1120244 Test: compiles Change-Id: Ib864255f2d30e5b9c515f071e8336a4e62a6c916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368932 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#801272}
-
Nelson Billing authored
- This is a fixed version of https://chromium-review.googlesource.com/c/chromium/src/+/1995743 which was reverted because it caused a build failure for ToTLinux. -Build failure in ToTLinux is fixed by only adding "--generate-dwp" for the Android toolchain when building for Android OS. - Modify some compiler build definitions to allow symbol_level=2 with Chrome Android 32bit, and to make the build respect use_debug_fission in those cases. - Modify "link" and "solink" tools in Android toolchain so that DWP files can be generated for builds with use_debug_fission. - Modify partitioned_shared_library template/script so that DWP files can be generated for partitioned libs when use_debug_fission is set. Change-Id: I7f023de42e46aca1e8c56c9edf3858617e2ab5ad Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:mac-chrome Change-Id: I7f023de42e46aca1e8c56c9edf3858617e2ab5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330810 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#801271}
-
Minjeong Kim authored
Bug: None Change-Id: I6b5211e7cdc4c82bb0982311daef940ff6e71e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362492Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#801270}
-
Kent Tamura authored
Bug: 1116959 Change-Id: I10141b2bea344d320fe49a721b554de62a019449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371864 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801269}
-
Lei Zhang authored
Turn |blink::WebLocalFrameImpl::is_in_printing_| from a variable only used for DCHECKs into one that is always CHECKed. Do this to help debug a printing crash that happens to users but not with any printing tests. Bug: 1121077 Change-Id: Ieac894c4efdb67f028de13fc2a4bf5ed3a84c258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373217Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801268}
-
prashant.n authored
For classifying images, DarkModeImageClassifier creates bitmap from PaintImage. For empty paint images, this crashes. This patch prevents classifying such empty paint images. Bug: 1119761 Change-Id: I3961da716236b929cc5a6925ff5927d5e8f8ac60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368935 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801267}
-
Adrienne Walker authored
This patch is notably missing changes to IndexedDBDataItemReader which will require more extensive changes to LocalFileStreamReader and so is left for a follow-up patch. This patch also changes RemoveDirectory to return true in the case that the original directory doesn't exist, matching the behavior of base::DeleteFile. Bug: 1119547 Change-Id: I51413bee753d6c6a00f8ff1df791ada002f639f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365358 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#801266}
-
Yu Su authored
Change-Id: I76a890c336543365ebfe10c0acf5367632011908 Bug: 1111517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372889Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/master@{#801265}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/extensions/api/notifications This CL was uploaded by git cl split. R=dewittj@chromium.org Bug: 1110266 Change-Id: I439c0eb3fb6b5bd32a591f904c49430cf4d6825c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371242Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801264}
-
Vicky Min authored
Currently, the BluetoothSerialPortImpl interface isn't being reached from anywhere in the codebase. By updating SerialPortManagerImpl's GetPort() function, we can create a self-owned instance of BluetoothSerialPortImpl where a serial port can be hooked up and use its interface implementations later on. Bug: 1043300 Change-Id: I06911b4918dcba8c2b240a689454aeb8b9ae22e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363670 Commit-Queue: Vicky Min <vickymin@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#801263}
-
Wei Lee authored
We uses the same values to make it identical to the Platform app version. Bug: 980846 Test: Check the window size of SWA version CCA Change-Id: I7f3697b1327298422286e04aa657218004130862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345899 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#801262}
-
Chris Lu authored
InfobarUIDelegate is not being used with the Infobar migration to Overlays. Thus, looking up an InfobarIOS's Infobar type should use its new infobar_type() property. Bug: 1121143 Change-Id: I0d340939d038d366eaf0ad631503cae9188dd1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373665 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#801261}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/746445da75a4..cd8de1d295b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaa5537e9c4f56993c0f61db0fb579b71d0bd61df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801260}
-
Fergal Daly authored
Bug: 1121422 Change-Id: Idb8b39ece8bf8dadc3a89503b7b9ac07c46a6823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373725 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801259}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/extensions This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1110266 Change-Id: Ic604f5e20bf491f7ff569a45fb4a99c6e6da3542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371221Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801258}
-
Daniel Libby authored
As seen in crbug.com/1088484, we used to see crashes when accessibility mojo payloads exceeded the limit of 128MB. There is ongoing investigation into reducing the size of the payload, but in the meantime we'll be marking the method as [UnlimitedSize]. R=dmazzoni@chromium.org, rockot@chromium.org Bug: 1088484 Change-Id: Iad3ab62ca6095a3b158ccb7a05d4234d64e8ac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369443 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#801257}
-
Yuri Wiitala authored
This patch adds in the necessary plumbing, when launching desktop mirroring via the Media Router UI, to conditionally enable the audio stream in the Mirroring Service. It also fixes a bug in the Desktop Media Picker controller, in the case where the dialog is being auto- bypassed: The logic in the controller was not setting the |audio_share| property in the result (normally, the UI dialog code would have set this). Within the Media Router and Cast MRP, it is necessary to specify the audio choice in the Media Router's desktop source URN since that alone is used to turn audio capture on/off in the Mirroring Service when launching desktop mirroring. In addition, the code has been tweaked to clarify the distinction between an "unchosen desktop" URN versus the specific one the user chose from the dialog. Bug: 1110950 Change-Id: I31d437dfadc3372dc2024beba2f8591d78e91875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347374 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#801256}
-