GitLab

This CL lands server change 95010541 by mpw.

BUG=488484

Review URL: https://codereview.chromium.org/1172103002

Cr-Commit-Position: refs/heads/master@{#333724}

We currently rely on PostDelayedTask with a constant frame interval to get a specified frame rate.
This CL dynamically adapts the delay to PostDelayedTask to keep the frame rate in sync.

This CL is similar to https://codereview.chromium.org/1162903004/.

BUG=492189

Review URL: https://codereview.chromium.org/1153713006

Cr-Commit-Position: refs/heads/master@{#333723}

Currently there's no information printed when the
execution of the roll script is a no-op (e.g. when
the latest revision is already rolled).

BUG=

Review URL: https://codereview.chromium.org/1172323002

Cr-Commit-Position: refs/heads/master@{#333722}

This CL re-enables a certain number of content_browsertests on the browser-side
navigation Linux FYI bot.

BUG=475027

Review URL: https://codereview.chromium.org/1172033002

Cr-Commit-Position: refs/heads/master@{#333721}

Remove the Cancel button from the app banner infobar on desktop.

This makes the infobar consistent with the mobile implementation, which
only has an Accept button and a dismissal X.

BUG=491001
R=benwells

Review URL: https://codereview.chromium.org/1163323004

Cr-Commit-Position: refs/heads/master@{#333720}

BUG=138845
TBR=chirantan@chromium.org

Review URL: https://codereview.chromium.org/1172283002

Cr-Commit-Position: refs/heads/master@{#333719}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3a16a23..c1a27fe

TBR=yurys@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1172263004

Cr-Commit-Position: refs/heads/master@{#333718}

Use struct AlternativeService parameter in
SpdyFramerVisitorInterface::OnAltSvc() and SpdyDispatcher::OnSpdyAltSvc()
methods.  This is in preparation for handling multiple alternative services that
a single HTTP/1.1 header field or HTTP/2 frame can carry.

This CL lands server change 94293057 by bnc.

BUG=392575

Review URL: https://codereview.chromium.org/1171183002

Cr-Commit-Position: refs/heads/master@{#333717}

$ git log 73c2fb87e..da55a84be --date=short --format='%ad %ae %s'
2015-06-10 petrcermak Automatically expand nested rows in memory dump analysis details panes
2015-06-09 nduca Add skeleton RAIL score side panel and span to display RAILScore results
2015-06-09 nduca Fix namespace for RAIL folder
2015-06-09 nduca newTraceModel should not use any auditors
2015-06-09 benjhayden Implement RAILScore class
2015-06-09 dsinclair Move trace_viewer/core/importer to trace_viewer/importer.
2015-06-09 dsinclair Move trace_viewer/core/trace_model to trace_viewer/model.
2015-06-09 natduca Revert "Highlight the entire group of slices where flow events can reach"
2015-06-09 yuhaoz Highlight the entire group of slices where flow events can reach
2015-06-09 andrews.charlie Implements a few ProcessBase functions in terms of an already-written function.
2015-06-09 dsinclair Rename tv to tr namespace.
2015-06-09 aschulman Pulled the BattOr power correlation clock sync into its own function.
2015-06-09 petrcermak Add support for sorting memory columns by importance
2015-06-08 nduca Add generic_table_view
2015-06-08 ccraik Fix auditor EventInfo links
2015-06-08 ccraik Handle RecyclerView scrolling in Frame definition

Review URL: https://codereview.chromium.org/1177503004

Cr-Commit-Position: refs/heads/master@{#333716}

PrintPage should not return a bool parameter. The return type has been changed to void.

To keep it compatible with the blink code, old function has been kept.

R=pdr
BUG=496765

Review URL: https://codereview.chromium.org/1149983008

Cr-Commit-Position: refs/heads/master@{#333715}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fbad632..3a16a23

TBR=yurys@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1172263003

Cr-Commit-Position: refs/heads/master@{#333714}

Otherwise, subresource loads would also go to the broken SW, defeating the
fallback mechanism. It also would skew start worker metrics if the SW fails
to startup on each requst.

The eviction mechanism already takes case of this in
ServiceWorkerRegistration::DeleteVersion, but we don't
currently evict everytime a fetch event fails to dispatch.

BUG=498661,448003

Review URL: https://codereview.chromium.org/1173943002

Cr-Commit-Position: refs/heads/master@{#333713}

This CL enables newly added nacl_helper_nonsfi_unittests on trybots.

TEST=Ran bots.
BUG=358465

Review URL: https://codereview.chromium.org/1173543002

Cr-Commit-Position: refs/heads/master@{#333712}

BUG=437411
TBR=dmichael@chromium.org

Review URL: https://codereview.chromium.org/1176853002

Cr-Commit-Position: refs/heads/master@{#333711}

This is to avoid static initializers that would make the code slower.
See the linked bug for discussion.

This patch deprecates Log#makeTag(String) and adds presubmit checks
to enforce at submit time what makeTag was trying to do: length and
naming rules

BUG=485772

Review URL: https://codereview.chromium.org/1131903007

Cr-Commit-Position: refs/heads/master@{#333710}

BUG=498688
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/1180433004

Cr-Commit-Position: refs/heads/master@{#333709}

BUG=498665
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1173933003

Cr-Commit-Position: refs/heads/master@{#333708}

WebRTC 9397:9407
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3da998b..53e1dff

Libjingle 9392:9404
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/76def90..9b056ad

TBR=
BUG=

Review URL: https://codereview.chromium.org/1171413002

Cr-Commit-Position: refs/heads/master@{#333707}

The "DidExtensionEscalatePermissions" flag is basically equivalent to HasDisableReason(DISABLE_PERMISSIONS_INCREASE | DISABLE_REMOTE_INSTALL), so check that instead of storing a separate pref.

BUG=493610

Review URL: https://codereview.chromium.org/1164603003

Cr-Commit-Position: refs/heads/master@{#333706}

Change constructor of StartupTaskRunnerService to directly receive the
base::SequencedTaskRunner to use for the deferred task runner that is
injected by the factory.

Move the startup_task_runner_service.{cc,h} to //components/bookmarks
and the factory to //chrome/browser/bookmarks as this code is only used
by the bookmark code.

BUG=485146

Review URL: https://codereview.chromium.org/1165913004

Cr-Commit-Position: refs/heads/master@{#333705}

deleteSurroundingText() only deletes one character even for multi-character
codepoint.

On the blink side, we have InputMethodController::extendSelectionAndDelete()
to make sure selection and deletion respect Unicode boundaries. However,
AdapterInputConnection keeps track of selection region separately, and this
value is incorrectly updated.

On top of adding a new test for this case, it extends
waitAndVerifyEditorCallback to also check the outbound calls to
InputMethodManager.

The above extension found that testEnterKeyEventWhileComposingText fails
because there is hidden discrepancy between blink implementation and
what we report to InputMethodManager. So I've added a TODO for that.

BUG=497091

Review URL: https://codereview.chromium.org/1165793007

Cr-Commit-Position: refs/heads/master@{#333704}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fb3cca5..fbad632

TBR=yurys@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1174883002

Cr-Commit-Position: refs/heads/master@{#333703}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9efbfe82..3e265c6d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1163383007

Cr-Commit-Position: refs/heads/master@{#333702}

BUG=492939

Review URL: https://codereview.chromium.org/1176483002

Cr-Commit-Position: refs/heads/master@{#333701}

Revert of Don't peek messages in the MessagePumpForUI class when we receive our kMsgHaveWork message. (patchset #13 id:240001 of https://codereview.chromium.org/1156503005/)

Reason for revert:
I suspect this CL breaks Windows 8 content_unittests, as it's listed both in
https://build.chromium.org/p/chromium.fyi/builders/Win8%20Tests%20%281%29/builds/8675 and our WebRTC-specific waterfall: https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/14164

I'll try to reland if it turns out not to solve the breakage.

Original issue's description:
> Don't peek messages in the MessagePumpForUI class when we receive our kMsgHaveWork message.
>
> Currently the MessagePumpForUI class peeks Windows messages when we receive the kMsgHaveWork message in
> our main message loop and in nested modal loops. This is because the posted message starves the message loop
> of input and other lower priority messages. While this is ok for the main message loop our peeking and dispatching
> messages in nested loops is wrong and violates the silent contract where in the nested loop should be the one peeking
> and dispatching messages.
>
> To fix this the approach we are taking is to create a worker thread which uses a waitable timer of 3 ms which posts
> the kMsgHaveWork message to the main loop when the timer fires. As a result we can safely delete all the code
> in the MessagePumpForUI::ScheduleWork function and simplify the ProcessPumpReplacementMessage function.
>
> The MessagePumpForUI::ScheduleWork function now checks the delay for the task at the head of the queue
> If it is 0 then we post the message right away as it is a regular task. Added functions (GetNewlyAddedTaskDelay) to the MessagePump::Delegate class and the IncomingTaskQueue for this.
>
> The other change here is to change the GPU process to use the IO message pump by default and use the UI pump only
> if we are using opengl. Reason being this patch causes a delay in processing tasks due to the worker thread which
> causes tests like webgl_conformance to fail. We will continue working on addressing this over the coming days.
>
> BUG=492837
> R=cpu
>
> Committed: https://crrev.com/b8e126c8b532b1327f38afe2bdf59aa5ff933971
> Cr-Commit-Position: refs/heads/master@{#333572}

TBR=cpu@chromium.org,jar@chromium.org,kbr@chromium.org,geofflang@chromium.org,scottmg@chromium.org,ananta@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=492837

Review URL: https://codereview.chromium.org/1163423006

Cr-Commit-Position: refs/heads/master@{#333700}

content::BrowserPpapiHostImpl references ppapi::host::PpapiHost but dependency in missing in gn.

BUG=

Review URL: https://codereview.chromium.org/1173583002

Cr-Commit-Position: refs/heads/master@{#333699}

This is IMF refactoring according to the design:
 - For @google.com:
  https://docs.google.com/document/d/14PQN4fbbSTlJmIk6qk7RzsuNr7O22DUTfNQ6slxKWV0
 - For @chromium.org:
  https://docs.google.com/document/d/1sDES_kuEVUjb_FwCvKsg0Ef48edq5lAx589r0qUtG4g

This cl includes some fundamental changes:
1) ui::InputMethod is created & owned by aura::WindowTreeHost.
   Therefore, the InputMethod instance can be accessed through
   root_window->GetHost()->GetInputMethod, and no need to save
   kRootWindowInputMethodKey instance to the root window
   anymore.
2) Removed InputMethodEventFilter, therefore no need the flag
   IsTranslated()/SetTranslated() on ui::KeyEvent.
3) Makes aura::WindowTreeHost as a ui::EventSource, because all
   kinds of WindowTreeHost are also ui::EventSource. Therefore,
   WindowTreeHost can override DeliverEventToProcessor method
   to intercept key events for input method processing.

Note:
1) The key events processing by input method happens after event
   rewriters and before the EventHandler's, which remains no
   change to original on desktop environment. For Ash, the IME key
   event handling is moved ahead of some other handles:
   - MagnifierKeyScroller (CrOS only): handles Arrow keys when
     magnification is enabled.
   - SpokenFeedbackToggler (CrOS only): handles F6 key when
     SpokenFeedbackToggler is enabled.
   - OverlayEventFilter: handles ESC/OEM_2/HELP/F14 keys to
     cancel the overlay UI.
2) For Ash, remains the singleton ui::InputMethod instance,
   owned by DisplayController. Because if let each
   AshWindowTreeHost own separated ui::InputMethod instances,
   it will break things:
   a) There is a test: ExtendedDesktopTest.KeyEventsOnLockScreen,
      which tests the text field in root window X can be inserted
      with text while dispatching key events to root window Y. I
      think this test makes no sense and will confirm with oshima@.
   b) For now for Ozone, DrmWindowHost::CanDispatchEvent()
      always returns true, so that only primary window tree host
      can receive the key events, which makes the "primary"
      InputMethod can receive the key events.
   c) For Virtual Keyboard on CrOS, it listens to the notification
      through InputMethodObserver::OnShowImeIfNeeded(), which is
      bound to the specific InputMethod instance. However, the
      Virtual Keyboard should work cross multiple root windows &
      InputMethod instances.

BUG=474828
TEST=Verified on local builds, including linux, cros, win7 & win8.1. And all tests passed.

Review URL: https://codereview.chromium.org/1155013005

Cr-Commit-Position: refs/heads/master@{#333698}

Offline pages metadata store:
* Creates interface for the store
* The following actions are available on the store:
  - AddOfflinePage,
  - RemoveOfflinePage,
  - Load,
* Updates to the components_unittests to include offline
  pages

BUG=491352

Review URL: https://codereview.chromium.org/1160283003

Cr-Commit-Position: refs/heads/master@{#333697}

Revert of content: Single process support for native GpuMemoryBuffers. (patchset #8 id:140001 of https://codereview.chromium.org/1120873002/)

Reason for revert:
Breaks Mac10.6 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3331

Original issue's description:
> content: Single process support for native GpuMemoryBuffers.
>
> This adds single process support for IOSurface and
> SurfaceTexture backed GpuMemoryBuffers.
>
> Also makes the SurfaceTexture code more consistent
> with IOSurface code by using a singleton instead of
> leaking a raw pointer.
>
> BUG=497559
> TEST=content_browsertests --gtest_filter=ChildThreadImplGpuMemoryBufferBrowserTests/*
>
> Committed: https://crrev.com/d5395d05e7f006ef9d1efaf8ec84030d24fb9fef
> Cr-Commit-Position: refs/heads/master@{#333625}

TBR=avi@chromium.org,dcastagna@chromium.org,reveman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497559

Review URL: https://codereview.chromium.org/1171293005

Cr-Commit-Position: refs/heads/master@{#333696}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ae3f140..fb3cca5

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1171203006

Cr-Commit-Position: refs/heads/master@{#333695}

Revert of Combine 'pssh' parsing routines. (patchset #8 id:140001 of https://codereview.chromium.org/1149023002/)

Reason for revert:
Breaks compile on 'Google Chrome Win' bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/1066

Original issue's description:
> Combine CENC 'pssh' box parsing routines.
>
> Also update the routines to ignore 'pssh' boxes with version 2 or
> later.
>
> BUG=460359, 460360
> TEST=new unittests pass
>
> Committed: https://crrev.com/b666d7874efac44b359a95329f0cb890e97671df
> Cr-Commit-Position: refs/heads/master@{#333556}
>
> Committed: https://crrev.com/7a84443597e92a03f90806712f8629df40bf408e
> Cr-Commit-Position: refs/heads/master@{#333611}

TBR=sandersd@chromium.org,ddorwin@chromium.org,xhwang@chromium.org,jrummell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460359, 460360

Review URL: https://codereview.chromium.org/1165313003

Cr-Commit-Position: refs/heads/master@{#333694}

Cr-Commit-Position: refs/heads/master@{#333693}

Currently, the variable containing ViewsDelegate singleton object can be
set by anyone and there are cases (at least in tests) where it is freely
replaced without properly deleting the old one which can lead to
situations where multiple ViewsDelegate objects are in existence. This
patch tries to ensure that there is at most one instance available at
each time.

Also, cleaned up some ViewsDelegate related includes.

BUG=492991

Review URL: https://codereview.chromium.org/1159033008

Cr-Commit-Position: refs/heads/master@{#333692}

device_command_screenshot_job.cc:132:70: warning: 'result_code' may be used uninitialized in this function [-Wmaybe-uninitialized]

Review URL: https://codereview.chromium.org/1159163006

Cr-Commit-Position: refs/heads/master@{#333691}

Avoid depending on (or including) extensions related code when enable_extensions
gyp/gn flag is not set. This fixes 'gn gen' for android with toolkit_views turned
on.

BUG=488576

Review URL: https://codereview.chromium.org/1160773004

Cr-Commit-Position: refs/heads/master@{#333690}

BUG=none
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1172803003

Cr-Commit-Position: refs/heads/master@{#333689}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/75eb674..ae3f140

TBR=enne@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1172683004

Cr-Commit-Position: refs/heads/master@{#333688}

This parameter is always passed "false", and it doesn't do anything
sensible if you pass "true". It purports to be processing bidi text for
a URL, but it does not do anything of the sort.

Specifically, if the overall text direction of the string is RTL, it
tells ICU to use the UBIDI_REORDER_RUNS_ONLY algorithm, which disables
the bidi algorithm and places all strong characters (LTR and RTL) at
Level 0. This is not designed to produce a display ordering and has
nothing to do with the formatting requirements for a URL. It might have
made sense back when BiDiLineIterator was solely used by
AutocompleteResultView in 2008 (it did some sort of post processing on
the reversed runs), but I don't want this misleading parameter to stay
around now.

BUG=351639

Review URL: https://codereview.chromium.org/1144303004

Cr-Commit-Position: refs/heads/master@{#333687}

BUG=

Review URL: https://codereview.chromium.org/1168793002

Cr-Commit-Position: refs/heads/master@{#333686}

To prevent MediaStreamPermissionTest* flakiness:
(1) Instead of relying on the old infobar notification system, switch to
    the new infobar responder. (As per crbug.com/354380, observers are now
    preferred to notifications.)
(2) Instead of relying on mock permission bubbles, switch to the new
    PermissionBubbleManager responder.
(3) Remove the polling and timeouts.

To satisfy the requirements of the media test cases, I also updated the
InfoBarResponder. It now can handle infobar replacement and dismissing an
infobar without making a choice.

BUG=295723
R=tommi@chromium.org

Committed: https://crrev.com/ccc25707b9788597c55fb4eaa90109500e1f92cb
Cr-Commit-Position: refs/heads/master@{#333360}

Review URL: https://codereview.chromium.org/1161153003

Cr-Commit-Position: refs/heads/master@{#333685}