- 11 Sep, 2014 39 commits
-
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/d9ec549071581d9d1dc2e5fac3163305ae935a39..97bf60ff7f3dd7d6e782b706ec94efb2b414b27e CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/566443002 Cr-Commit-Position: refs/heads/master@{#294299}
-
tonyg authored
It's not launched nor are there plans to do so. The last commit was Dec, 2012 and there was a thread about removing it on chromium-dev in May. My immediate use-case is to quelch the periodic idle wakeups due to the performance monitor, but at this point, simply removing it seems preferable to digging in to fix the timer. BUG=411488,130212 Review URL: https://codereview.chromium.org/547063003 Cr-Commit-Position: refs/heads/master@{#294298}
-
oshima authored
This CL removes redundant widget created by Activity, and use NativeAppWindow instead. Activity APIs needs to some cleanup and I'll look into it once hashimoto-san finished app_window transition. step3 will replace ChromeAppNativeWindowViews with athena's impl. BUG=410448 Review URL: https://codereview.chromium.org/558243002 Cr-Commit-Position: refs/heads/master@{#294297}
-
tapted authored
This gets 3 views_unittests passing: - ViewTargeterTest.HitTestCallsOnView, - ViewTest.CanProcessEventsWithinSubtree, - ViewTest.GetEventHandlerForRect. These were failing because the size of the RootView was being reset to the Widget size when first added. This happened because NativeWidgetMac was not ensuring the RootView was set up properly immediately after a call to Widget::Init() for all Widget types (i.e. those without a NonClientView). When there _is_ a NonClientView, Widget::Init() calls SetContentsView() which would eventually trickle down to NativeWidgetMac::ReorderNativeViews(), which is where NativeWidgetMac would set up the root view. BUG=378134 Review URL: https://codereview.chromium.org/559873002 Cr-Commit-Position: refs/heads/master@{#294296}
-
rtenneti authored
Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always removing all old transmissions. When truncated acks start arriving, they don't stop until least_unacked is raised, which takes an entire RTT, so this is the eventual effect of all those truncated acks. Instead, remove all of them the first time. Merge internal change: 74881713 https://codereview.chromium.org/556103002/ Discard old packets from the QuicSentPacketManager which are only present for RTT purposes(typically acks) when the map exceeds 200 packets. Merge internal change: 74814618 https://codereview.chromium.org/551223002/ Fix a flaky QUIC end_to_end_test when the socket was suddenly unwritable and the connection closed, but CanWrite returned true. Merge internal change: 74798317 https://codereview.chromium.org/550703003/ Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived. Merge internal change: 74792668 https://codereview.chromium.org/554993002/ Send an ack when it 20 packets have been received since the last ack was sent. This allows the peer to discard data from the SentPacketManager. Merge internal change: 74741188 https://codereview.chromium.org/555653002/ R=rch@chromium.org Review URL: https://codereview.chromium.org/561513003 Cr-Commit-Position: refs/heads/master@{#294295}
-
jshin authored
Noto Sans CJK {Japanese,Korean,Simplified Chinese,Traditional Chinese} are renamed Noto Sans CJK {JP,KR,SC,TC} to make their names future-proof (to work around the length restriction on another platform). We want to minimize the potential confusion (on the part of developers) due to this name change by adding the fonts with new names in the trunk and Chrome OS 38 branch asap. This CL will be landed along with the corresponding Chrome OS CL to actually update the font files and a Skia CL. Skia CL: https://codereview.chromium.org/554943002/ CrOS CL: https://chromium-review.googlesource.com/217290 BUG=412151 TEST=Once the fonts are updated on Chrome OS, Noto Sans CJK {SC,JP,KR} fonts are used in {zh,ja,ko}.wikipedia.org. They can be checked with DOM Inspector. TEST=`data:text/html,<span style="font-family:sans-serif;" lang="ja">一</span>` uses 'Noto Sans CJK JP`. TEST=Same as above with lang={ko,zh-CN,zh-TW} and font="Noto Sans CJK {KR,SC,TC}" as indicated in the DOM Inspector. Review URL: https://codereview.chromium.org/551963003 Cr-Commit-Position: refs/heads/master@{#294294}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/546303003 Cr-Commit-Position: refs/heads/master@{#294293}
-
orglofch authored
Flickering no longer evident on Note 3 Device. BUG=317928 Review URL: https://codereview.chromium.org/560123002 Cr-Commit-Position: refs/heads/master@{#294292}
-
raymes authored
This removes the DCHECK from PepperTryCatch which checks that the current context is equal to the plugin context. This assumption is not always true. In particular, if we call into the plugin directly from another frame (which is in the same origin) the current context will differ. The same is true for background scripts. This should be ok; we should always use the calling context so as to not leak v8 objects across contexts. BUG=412062 Review URL: https://codereview.chromium.org/555583003 Cr-Commit-Position: refs/heads/master@{#294291}
-
jamiewalch authored
This doesn't yet do the most interesting test--whether or not scroll-bars work correctly when connected to a host--but that should be simple to add once a ClientPlugin mock is implemented. Review URL: https://codereview.chromium.org/552923002 Cr-Commit-Position: refs/heads/master@{#294290}
-
hjd authored
Get the android_webview_glue DEPS entry back in sync with the aosp_manifest.xml. BUG= Review URL: https://codereview.chromium.org/560023003 Cr-Commit-Position: refs/heads/master@{#294289}
-
raymes authored
It is safer to hold a handle to v8 context in PepperTryCatchVar than to try retrieving it again on destruction from the frame (through the plugin instance) which has a chance of being torn down. BUG=411445 Review URL: https://codereview.chromium.org/562763005 Cr-Commit-Position: refs/heads/master@{#294288}
-
alekseys authored
- show 'More options' section only if there are more than 6 sections avaialble - add ARIA labels for the color, copies, margins, layout and paper settings - group Paper size section with other collapsible sections - adjust Advanced options button size to fit the text BUG=397741 Review URL: https://codereview.chromium.org/556363003 Cr-Commit-Position: refs/heads/master@{#294287}
-
nednguyen authored
BUG=412713 Review URL: https://codereview.chromium.org/560823003 Cr-Commit-Position: refs/heads/master@{#294286}
-
michaelpg authored
On the BrowserOptions page, sections that are supposed to hide with an upward sliding transition instead hide instantly. This is apparently because the style recalc that adds the CSS transition also sets the new section height (i.e., the first style recalc usually doesn't happen before the setTimeout is triggered in animatedSectionHeightChange_). To work around this, force a recalc before setting the new height. BUG=394053 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/393943003 Cr-Commit-Position: refs/heads/master@{#294285}
-
bengr authored
These histograms are used to analyze the performance of the data reduction proxy. BUG=412461 Review URL: https://codereview.chromium.org/553273002 Cr-Commit-Position: refs/heads/master@{#294284}
-
jackhou authored
Windows that have a shape applied via AppWindow.setShape lose their shape after being minimized. This is because minimizing invokes HidingWindowAnimationObserverBase::DetachAndRecreateLayers. BUG=408737 Review URL: https://codereview.chromium.org/547283003 Cr-Commit-Position: refs/heads/master@{#294283}
-
wez authored
Now that views widgets can be rendered with transparency there is no need to shape the widget for the visual effect, and the impact on hit- testing is negligible, so there's really no point shaping the widget. BUG=408728 Review URL: https://codereview.chromium.org/547673003 Cr-Commit-Position: refs/heads/master@{#294282}
-
fsamuel authored
This CL fixes resize, focus and cursor issues for interstitial pages inside Browser Plugin. Interstitial page RenderViewHosts are not a part of the main page's WebContents. Thus, BrowserPluginGuest's (a WebContentsObserver) OnMessageReceived method will not catch IPCs coming from interstitials. However, guest interstitials have RenderWidgetHostViewGuests. By hanlding focus, resize, cursors and the like through RenderWidgetHostViewGuest, we ensure that interstitial pages get the same treatment inside a BrowserPlugin as RenderViewHosts that belong to the guest WebContents. BUG=273089 Review URL: https://codereview.chromium.org/549323002 Cr-Commit-Position: refs/heads/master@{#294281}
-
vmpstr authored
This patch adds an occlusion checker to get the state of occlusion tracker for permanent checks. That is, occlusion checker does not have to be queried during a layer walk. BUG=410932 R=danakj Committed: https://crrev.com/1af780529157c94a9e0f05bcf478543b85714f6b Cr-Commit-Position: refs/heads/master@{#294205} Review URL: https://codereview.chromium.org/547723002 Cr-Commit-Position: refs/heads/master@{#294280}
-
kmarshall authored
Add tests for new functionality. Surround single-line blocks with curly braces in CastSocket for consistency/safety. R=mfoltz@chromium.org BUG= Review URL: https://codereview.chromium.org/505453002 Cr-Commit-Position: refs/heads/master@{#294279}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/560903003 Cr-Commit-Position: refs/heads/master@{#294278}
-
sammc authored
This also removes some null checks for the now non-nullable fields. BUG=407683 Review URL: https://codereview.chromium.org/562563002 Cr-Commit-Position: refs/heads/master@{#294277}
-
sammc authored
This call isn't meaningful with a null ServiceProvider&. BUG=407683 Review URL: https://codereview.chromium.org/555373003 Cr-Commit-Position: refs/heads/master@{#294276}
-
ccameron authored
Observation 1: It was discovered in crbug.com/410402 that deleting the GL textures bound to IOSurfaces before releasing the CGL context from the CAOpenGLLayer can result in crashes. Observation 2: It was discovered in crbug.com/411782 that not deleting the GL textures bounds to IOSurfaces before destroying the CGL context can result in crashes. As way speculative workaround for this, retain the CGL context when the texture is created (when it is known to be valid), and the post a task to - make that CGL context current - delete the GL texture - make no CGL context current - release the CGL context - release the IOSurface used by the GL texture The theory here is that by doing this in a posted task, having a fresh stack and having manually retained the CGL context when it was known-valid will work around the crash in Observation 1, and manually destroying the texture while its IOSurface is still retained and before the CGL context is destroyed will work around the crash in Observation 2. BUG=411782 Review URL: https://codereview.chromium.org/558803002 Cr-Commit-Position: refs/heads/master@{#294275}
-
ananta authored
The lock mouse operation invoked by plugins or pages hides the mouse cursor and ensures that the cursor stays within the bounds of the webpage. To ensure that the mouse stays within the bounds of the page, the SetCursorPos operation is executed by the host. In ASH, the SetCursorPos API is executed by the viewer process for historical reasons. As a result on Windows 8 there is a faint possibility that the user may move the mouse to the charms section of the OS, which causes the cursor to become visible. Fix for this is to track if the mouse changed from what was last set in the viewer process and restore it. The other change is in the RemoteWindowTreeHostWin class where the member ignore_mouse_moves_until_set_cursor_ack_ has been changed to a count from a bool flag. This is because the RemoteWindowTreeHostWin::MoveCursorToNative function can be called multiple times before the acks are received causing DCHECKs to fire on the ignore_mouse_moves_until_set_cursor_ack_ flag. BUG=398792 Review URL: https://codereview.chromium.org/560633002 Cr-Commit-Position: refs/heads/master@{#294274}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/d500af4bd27fde579b1dfbe4f2a42c93ec702066..9d49ffe0fa4d942757e3ed296fb8653f1b812ae5 TBR=keishi@chromium.org,jianli@chromium.org Review URL: https://codereview.chromium.org/560093003 Cr-Commit-Position: refs/heads/master@{#294273}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/cc0e3110bde60201882a2c512a5cdd73c838f351..d9ec549071581d9d1dc2e5fac3163305ae935a39 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/561833005 Cr-Commit-Position: refs/heads/master@{#294272}
-
boliu authored
Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7 id:120001 of https://codereview.chromium.org/557593002/) Reason for revert: Suspected to break tough_video_cases. See crbug.com/412897 for details. BUG=412897 Original issue's description: > Clean up WebMediaPlayerAndroid needs_establish_peer_ > > needs_establish_peer_ has been used to skip actual estalishing a surface > texture peer based on many conditions. Not all places that modify > actually checks all these conditions so there are bound to be some bugs. > > This CL aims to tease out all these different conditions and put them in > a single function EstablishSurfaceTexturePeerIfNeeded. This function > should be called any time these conditions are changed. Makes for much > saner reading. > > BUG=412578 > > Committed: https://crrev.com/701cb640efb326aa107b5b0c25dcf91766fe765f > Cr-Commit-Position: refs/heads/master@{#294068} TBR=qinmin@chromium.org,avayvod@chromium.org,ycheo@chromium.org NOTREECHECKS=true NOTRY=true BUG=412578 Review URL: https://codereview.chromium.org/562803002 Cr-Commit-Position: refs/heads/master@{#294271}
-
scottmg authored
Revert of -fno-exceptions only on .cc files (patchset #1 id:1 of https://codereview.chromium.org/560873003/) Reason for revert: Causes ASAN LSAN Linux bot to fail (not in the CQ/try set): [191/22134 | 8.047] CC obj/third_party/speex/libspeex/libspeex.filters.o FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated -c ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:50:13: error: cannot use 'throw' with exceptions disabled throw std::bad_alloc(); ^ ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:77:5: error: cannot use 'try' with exceptions disabled try ^ ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:118:5: error: cannot use 'try' with exceptions disabled try ^ 3 errors generated. FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated -c ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:24:5: error: cannot use 'throw' with exceptions disabled throw std::bad_cast(); ^ ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:29:5: error: cannot use 'throw' with exceptions disabled throw std::bad_typeid(); ^ 2 errors generated. FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated -c ../../third_party/libc++abi/trunk/src/cxa_personality.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1269:21: error: cannot use 'throw' with exceptions disabled throw; ^ ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1290:17: error: cannot use 'throw' with exceptions disabled throw be; ^ ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1203:5: error: cannot use 'try' with exceptions disabled try ^ 3 errors generated. ninja: build stopped: subcommand failed. I'm not quite sure what the actual problem is, but revert for now. Original issue's description: > -fno-exceptions only on .cc files > > R=thakis@chromium.org > BUG=335824 > > Committed: https://crrev.com/fad91907037b2616fe446bfbb880f8c19418de43 > Cr-Commit-Position: refs/heads/master@{#294266} TBR=thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=335824 Review URL: https://codereview.chromium.org/564493003 Cr-Commit-Position: refs/heads/master@{#294270}
-
mostynb authored
Followup to CL 478153003 which added a lambda expression even though we haven't officially switched to c++11 yet. Review URL: https://codereview.chromium.org/565443002 Cr-Commit-Position: refs/heads/master@{#294269}
-
jmadill authored
The goal is to run gpu_unittests on the GPU bots, starting with the FYI bots. BUG=391895 Review URL: https://codereview.chromium.org/562733003 Cr-Commit-Position: refs/heads/master@{#294268}
-
jamiewalch authored
Apply bump scroll to the entire client-plugin-render hierarchy, not just the plugin, which doesn't handle rendering when MediaSource is enabled. BUG=411996 Review URL: https://codereview.chromium.org/558283002 Cr-Commit-Position: refs/heads/master@{#294267}
-
Scott Graham authored
R=thakis@chromium.org BUG=335824 Review URL: https://codereview.chromium.org/560873003 Cr-Commit-Position: refs/heads/master@{#294266}
-
erikchen authored
Revert of Mac: Fix rounded corners on browser windows on retina display. (patchset #4 id:80001 of https://codereview.chromium.org/463263002/) Reason for revert: When the download bar is present, the rounded corners are on the wrong view. https://code.google.com/p/chromium/issues/detail?id=412580 Original issue's description: > Mac: Fix rounded corners on browser windows on retina display. > > When a window's bottom corner is covered by a layer on a retina display, the > corner is incorrectly rounded. I added a layer mask to do the corner rounding > ourselves. > > BUG=396264 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289811 TBR=andresantoso@chromium.org,ccameron@chromium.org,shess@chromium.org NOTREECHECKS=true NOTRY=true BUG=396264 Review URL: https://codereview.chromium.org/560913004 Cr-Commit-Position: refs/heads/master@{#294265}
-
mseaborn authored
This pulls in the following Native Client changes: r13711: (mseaborn) Move syscall definitions to pure C code, replacing nacl_syscall_handlers_gen.py r13712: (dbrazdil) Fixed signatures of _Unwind_* stubs in PNaCl support library r13713: (uekawa) Minor consistency style fixes. r13714: (dschuff) Move REV file to metadata package and include all repos r13715: (mseaborn) Remove the old "SecureRandom" service, formerly used by get_random_bytes() r13716: (dyen) Unify the way irt_ext libc how tests are declared and defined. r13717: (dyen) Asserts used by irt_ext are now done through error_report.c. r13718: (dschuff) Update revision for PNaCl r13696->r13714 r13719: (dschuff) Build host libc++ and host tools with clang on Linux and Mac r13720: (bradnelson) Switching pnacl download script to use gsutil for download too. r13721: (dyen) In IRT Extension API, added file stat support and tests. r13722: (dbrazdil) Add MinSFI loader r13723: (bradnelson) Vary build settings on fastbuild + configuration + buildtype (reland). r13724: (dbrazdil) Update signature of MinSFI's entry point BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk,linux_chromium_dbg Review URL: https://codereview.chromium.org/553323002 Cr-Commit-Position: refs/heads/master@{#294264}
-
scottmg authored
TBR=brettw@chromium.org BUG=335824 Review URL: https://codereview.chromium.org/560143002 Cr-Commit-Position: refs/heads/master@{#294263}
-
jochen authored
Currently, blink creates its own isolates. We want to always use an IsolateHolder to create the isolates. To be able to do this, I introduce an Initialize method that setups V8. The new IsolateHolder ctor now doesn't take any parameters but just creates new isolates according to the configuration. All non-blink gin users are cut over to the new API BUG=none R=abarth@chromium.org,andrewhayden@chromium.org,eroman@chromium.org Review URL: https://codereview.chromium.org/553903003 Cr-Commit-Position: refs/heads/master@{#294262}
-
nednguyen authored
BUG= Review URL: https://codereview.chromium.org/560923002 Cr-Commit-Position: refs/heads/master@{#294261}
-
- 10 Sep, 2014 1 commit
-
-
miletus authored
It is useful for linking the BeginFrame sent from browser side and the BeginFrame received in renderer side. Often, the BeginFrame IPC message gets delayed and it becomes hard to track the BeginFrame received in renderer side is from which browser VSync. By dumping the frame_time, we can then do the cross-reference. BUG=406112 TEST=RenderWidgetHostViewAndroid::SendBeginFrame now shows frame_time. Review URL: https://codereview.chromium.org/561883003 Cr-Commit-Position: refs/heads/master@{#294260}
-