- 20 Feb, 2020 40 commits
-
-
Jiaqi Han authored
Adds a URL filter for generic Activity third party applications. This introduces filter logic for http and websocket requests according to a provided whitelist. A follow up CL to introduce the whitelist entry in cast_web_contents that enable the filters. Bug: 1054535 Test: CQ, verified url request blocking in devtools Change-Id: I6a6a50bea79b70e7e91e08832bf9807c91faa53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050038Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#743314}
-
tby authored
Change-Id: I15a437a11922af307a7cbf800b01529131429dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064229Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#743313}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //chrome/app to Once or Repeating Bug: 1007634 Change-Id: Ie12853158482a1d16e8074dc3eeaf98f1e610d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067453Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#743312}
-
Sadrul Habib Chowdhury authored
Report the following aggregated to UKM, since these are the aggregation of some of the other UKM metrics already reported: Graphics.Smoothness.Throughput.AllAnimations Graphics.Smoothness.Throughput.AllInteractions Graphics.Smoothness.Throughput.AllSequences BUG=852482, 790761 Change-Id: I86d40ba677bd3b8e01e7b9a04b2787651f06d9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053843 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#743311}
-
sczs authored
- Changes both positioners to weak from assign. - Removes a DCHECK since it seems that the positioner can be niled in certain conditions like shutdown, in order to make sure these are set they are now part of the initializer. - Adds a containerViewWillLayoutSubviews super call to both positioners. Bug: 1034635 Change-Id: Iee46b2b2313831a289100f47e3ef8a96c4e20dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067382Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743310}
-
Reilly Grant authored
For the WebNFC Origin Trial the feature flag needs to be enabled by default and configured as "disable only" in runtime_features.cc so that it can still be used as a kill switch but will not enable the feature on sites which don't have a valid Origin Trial token. Bug: 1035048 Change-Id: I139a79dd0f93013bc59d5023017b49c820532fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052198 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743309}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4357d46c6c6..166875eb84cc git log b4357d46c6c6..166875eb84cc --date=short --first-parent --format='%ad %ae %s' 2020-02-20 jgilbert@mozilla.com Don't clamp in glBlendColor if context supports renderable [half-]float. 2020-02-20 jmadill@chromium.org Vulkan: Fix store ops with linear command recording. Created with: gclient setdep -r src/third_party/angle@166875eb84cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I5a14cbf8aedac6559ccc0a924ad5dcfeb3b6b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743308}
-
Stefan Zager authored
viz::HitTestManager::submit_hit_test_region_list_index_ is used to avoid sending hit test information to the browser if the underlying hit test data hasn't changed. It increments the index every time a new batch of hit test data arrives from a renderer process. However, there is another way that hit test data can be invalidated, requiring hit test data to be re-aggregated and sent to the browser: HitTestAggregator::Aggregate is not a simple pass-through for the data collected by HitTestManager. It also modifies flags on the hit test regions, based on whether or not a surface is active (see HitTestRegionFlags::kHitTestNotActive). "Active", in this case, does *not* mean that the surface has submitted a compositor frame. Rather, it means that the surface has submitted a compositor frame *and* the frame was included in the output of SurfaceAggregator::Aggregate. It is possible for a surface to change from inactive to active without triggering the re-aggregation of hit test data. In particular: - child surface submits a compositor frame with hit test data - SurfaceAggregator omits the child surface, because the parent surface has not yet reported bounds for the child surface. - HitTestAggregator marks the child surface's hit test regions as kHitTestNotActive. - parent surface submits a compositor frame with bounds for the child surface, but without new hit test data. In this situation, HitTestAggregator will never send new hit test data to the browser with updated flags for the child surface's regions. I have not seen this fail in the wild, but then again I don't generally pay attention to viz bugs. For the bug in question, I have a separate fix in blink; but that fix causes some changes in the order of data sent from the renderer to viz, which exacerbates this hit test data problem, causing failures in SitePerProcessHitTestBrowsertest. BUG=1033746 Change-Id: Ic338ad64465a1427ed29017b20370b54ed747d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044435 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743307}
-
rbpotter authored
Bug: 1026426 Change-Id: Idc3a899fd41f2a215013549731dd73483614ff0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065853Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743306}
-
Gil Dekel authored
This CL adds a test to ensure the changes made in crrev.com/c/2040201 behave as expected and will not regress with time. In essence, this ensures we can no longer go back to occluders with a single rect in cases where more than one should be used. Bug: 1022544 Test: viz_unittest Change-Id: I7a7cda96bde232143d20e24b41ae9b306ad195f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063917Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743305}
-
Caleb Raitto authored
The new source.chromium.org site accepts the link as-is, but for cs.chromium.org, I get a "Request to Git backend failed." error. After this CL, the link should work for both code search versions. Change-Id: I576d88b3a6eb8bcbf7fcd26fa5ef6d3bba40d31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067478Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743304}
-
ckitagawa authored
Compile Paint Previews on official builds. This has already been compiled/tested on trybots/waterfall for a long time so shouldn't cause any issues. The goal is to get this code shipping so we can start some experiments. Binary-Size: Regression is known about and approved by agrieve@. Bug: 1035118 Change-Id: I9ff9f053cf0149e2aa68eeea9e052eb5edd1293c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067282Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#743303}
-
Luke Zielinski authored
Bug: 1054577 Change-Id: Id016a5d8f3f511851dfd91861b2ec42f03068e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067638 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#743302}
-
Andrew Luo authored
Bug: 1054502, 1023833, 836460 Change-Id: I3c5b7f91dcd7bef66307bb0706dd0b9dee8c2ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067328Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743301}
-
Xiaohan Wang authored
See discussion thread at https://groups.google.com/a/chromium.org/forum/#!topic/cxx/h4bdRqbduNY The recommendation style is as follows: // Declaration class Foo : public IComIsFun { IFACEMETHODIMP IsFun(BOOL* fun) override; }; // Implementation HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; } Tbr: dmazzoni@chromium.org Change-Id: I06abe1c69a67a954cc346ec936018bcfe8d12825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050742 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#743300}
-
Xinghui Lu authored
url_lookup_service is currently managed in database_manager, which does not operate at profile level. To make each profile have its own url_lookup_service, create a singleton which owns all url_lookup_service, and make url_lookup_service a keyed service. This is the first CL of refactoring url_lookup_service to be profile based. The actual service change will be implemented in a follow-up CL. For more details, see: go/chrome-protego-refactor-profile. Bug: 1050859 Change-Id: If1862546c2cf8fc9a23375e680c790c72a5913e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061119Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743299}
-
Megan Jablonski authored
Bug: 976352 Change-Id: I39ec8f4364554f7650a484c41d6134ac01a62d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065423Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#743298}
-
Piotr Bialecki authored
Part 3/3 - Add support for anchor creation from hit test result, independent of plane detection feature being enabled on WebXR session. Previous work: - part 1: https://crrev.com/c/2055587 - part 2: https://crrev.com/c/2057092 Changes: - Hit test result now optionally contains ID of the entity that was hit. For now, this can only be a plane. This ID is is internal to the hit test result and not exposed to JS. - ArCorePlaneManager now returns a plane id given plane object address. This is the only instance of plane objects being handled outside of the plane manager (ArCoreImpl has access to ArPlane* but does not access the object itself). - Refactor anchor creation in XRSession. - XRHitTestResult needs to store XRSession so that it can call create anchors via added (JS-visible) `createAnchor()`. - Rename XRHitTestResult::pose_ into `mojo_from_this_`. - XRHitTestSource now stores a vector of XRHitTestResults instead of matrices in `last_frame_results_` since a matrix is now insufficient to create an XRHitTestResult. - Extract string constants internal to XRSession out so that they can be shared (XRHitTestResult also needs them). - Correctly handle anchor creation failure. - Add XRSpace::MojoFromOffsetMatrix() helper that combines XRSpace::MojomFromNative() * XRSpace::NativeFromOffsetMatrix(). - Adjust sample code for hit test - use feature detection to leverage anchors and fall back to the old approach if the feature is not available. Change-Id: Ifc708631970f5cfe64378d27a3b1ca7a84954a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057631 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#743297}
-
Wei Li authored
The original demo survey is out of its capacity, so we change to this survey which still have capacity to collect more responses. Change-Id: I97d0ed351c6fba880804143869afe45142adc20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062944 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#743296}
-
Yue Li authored
The Assistant service will use gRPC to get the SA bit from the mothership API service. Also, the Assistant will have more usages of gRPC calls while the Libassistant is transferring to V2 Design: see go/libassistant-v2-api. Bug: b/144870198 Test: Test with later changes Change-Id: I5fa421b94c855cf6a69d6797e42a6464c30ff90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055362Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#743295}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: Ic3f173cf51c5bec48b4fc75cf4449590a861c2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064947 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743294}
-
Sajjad Mirza authored
The code_coverage recipe module will explicitly pass --per-cl-coverage to the merge script in a per-CL build. Once that is done we can delete the use of the patch_storage property, which is no longer going to be set. Bug: 1050858 Change-Id: Ie4698b313716bb222071b88185759be23c8ba518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048904 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#743293}
-
rbpotter authored
PS 2 includes fix for test failure that caused revert. Verified by reproducing the test failure locally, and running the test successfully with the fix applied. Bug: 1026426 Change-Id: If6b540bc418e9ed698a57f6586788b4682467930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067442Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743292}
-
Sean Kau authored
A system daemon needs a signal that indicate the printers list has changed so it can query Chrome again. This generates the PrintersChanged signal from org.chromium.PrintersService. Bug: b:143242799 Change-Id: I4424603b05f89691d568f03f220e7eaf37bd0cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949041Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743291}
-
Stephen Chenney authored
Add a HitTest section to Blink.*.UpdateTime UMA (and derived UMA) and Blink.UpdateTime UKM and Blink.PageLoad UKM. The new metric is capturing data that is already incorporated into the ForcedStyleAndLayout and Style and Layout metrics, but broken out for just the hit testing update component. Bug: 1041295 Change-Id: If1420f88618f4a9164aef1fa2d811d289e971b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062635 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#743290}
-
Caleb Rouleau authored
TBR=sadrul@chromium.org NOTRY=true Bug: 1054597 Change-Id: I2eafbf0f8d32ca50aa336e8e557306b3bf164b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067456 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743289}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/793a4fe52960..018d99e46edf git log 793a4fe52960..018d99e46edf --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sullivan@chromium.org Load about:blank after navigations to correctly report PageLoadObserver UMA metrics Created with: gclient setdep -r src/third_party/catapult@018d99e46edf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1049160 Tbr: crouleau@google.com Change-Id: I08463acd2082f03879216930cee49b5985bf9080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743288}
-
Bo Liu authored
Componentize the code to covert content/public/common/context_menu_params.h into a Java object into a content_embedder component. This will be reused by weblayer for its context menu implementation. The only value left in the chrome ContextMenuParams is PerformanceClass. Refactor it into its own java API inside chrome code, which is a bit complicated by making sure metrics are not affected by this change. Pass around WebContents where necessary in order to call the new PerformanceClassObserver API. Bug: 1035469 Change-Id: I5352ac62b3603721e76c2313df3288073cdf8bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058828Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743287}
-
Kenneth Russell authored
deqp/functional/gles3/transformfeedback/ basic_types_interleaved_lines.html basic_types_interleaved_triangles.html basic_types_separate_lines.html basic_types_separate_triangles.html random_interleaved_lines.html random_interleaved_triangles.html random_separate_lines.html random_separate_triangles.html interpolation_flat.html Seem to all be passing now. conformance2/rendering/attrib-type-match.html Hopefully no longer flaky. Bug: 680754, 782254, angleproject:2236 Change-Id: Ieebb6c93ee39eb29d3c530cb6ec091a771bbd5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067388 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#743286}
-
Ionel Popescu authored
Prior to this CL when a high contrast like setting was enabled, it meant that the high contrast colors were going to be used for drawing the controls. For non-Windows platform, the high contrast colors are wrong, because there is no support yet to map the system colors to the high contrast colors. This CL restricts the usage of high contrast colors just for Windows where we have the correct colors. Bug: 1022118 Change-Id: I20dbd4b364619b759b4843f4e974332a6e1ffa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065397 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743285}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3cfba7f05be4..1ee36c9fa7e5 git log 3cfba7f05be4..1ee36c9fa7e5 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support 2020-02-20 bclayton@google.com Remove rr::Thread 2020-02-20 capn@google.com Support JIT on a separate thread Created with: gclient setdep -r src/third_party/swiftshader@1ee36c9fa7e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2835efb7ad4012213cb41edff4cb6d70b5368e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743284}
-
Nico Weber authored
It existed for Windows, and we currently don't do WPO on Windows. When we bring it back, it'll likely be different from /GL cl.exe-style WPO. Depends on https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/2065789 Bug: 1053958,598772 Change-Id: Ie2ea04ad54f0d3b6711ffb7682fe1ae15662cb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066106 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#743283}
-
Owen Min authored
Policy parsing error or unknown policy error is cause by admin and is not a critial issue for the browser. Lower the log level from error to warning because error level confuses users. Bug: 1054418 Change-Id: I10b7397fc6d3476d1375bdb2e256a91b52f7cbca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067303 Commit-Queue: Yann Dago <ydago@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#743282}
-
Austin Eng authored
Corentin, Austin, and Kai are responsible for WebGPU in Chromium and the integration between Dawn's remoting protocol and Chromium's IPC. Bug: none Change-Id: I2b3b5d9cd6fea6c1d235d52cca144c35479f1522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067220Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#743281}
-
Ella Ge authored
This reverts commit fd191139. Reason for revert: [Sheriff] compile failure https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/157215 Original change's description: >
🛃 Move Client Data header out of ClientManager. > > Bug: 1040143 > Change-Id: Ife79cfe1f0c5963bf4c6c7bee0c810e936b0a9a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062208 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743100} TBR=mvanouwerkerk@chromium.org,peconn@chromium.org Change-Id: I372b18ffaf679ba933129ce5f3ac65bf0ee8b661 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067717Reviewed-by:Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#743280}
-
Clark DuVall authored
There is a slight difference in the code after refactoring: PermissionContextBase::IsPermissionAvailableToOrigins() now uses PermissionsClient::CanBypassEmbeddingOriginCheck() which checks both if the requesting scheme was chrome-extension or if the embedding origin was chrome://newtab. This is slightly different from the existing logic which only checks for chrome-extension. I believe this should be fine, since content::IsOriginSecure() returns true for chrome://newtab anyway. This small change allows us to use CanBypassEmbeddingOriginCheck() in PermissionContextBase::DecidePermission() as well, and avoids adding another method to PermissionsClient. Bug: 1025609 Change-Id: I674f8ef5fb9f0d0eca1460c9756759cbe457327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063672 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743279}
-
Xiaocheng Hu authored
CSSMathExpressionVariadicOperation::ResolvedUnitType() currently returns kUnknown when its operands have different unit types, which is wrong. When there are both integer and float operands, the returned type should still be kNumber. This patch fixes it by returning kNumber on kCalcNumber category. Note that this follows the approach in binary operations. Bug: 10543262 Change-Id: I2123a4efacc80931556577cd2c657731de6fff01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067283Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743278}
-
Mila Green authored
Bug: 1053729 Change-Id: I7eab41596dd6da5573cf302bcd53ef3e4df1abfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063538Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743277}
-
Caleb Rouleau authored
R=rmcilroy@chromium.org Bug: 1039801 Change-Id: I1a8bf9246f734954f52c05f439aabae80c9ed2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067452Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743276}
-
rajendrant authored
This is a reland of 653f075d (After deflaking the test) Original change's description: > Clear the subresource redirect hints when navigation is started > > RenderFrames could be reused for same-origin navigations. This causes > the hints from previous navigations to be used in next navigation > until the new hints fetch finishes and updates the hints. This CL clears > the hints. > > Unfortunately this causes race conditions between the image fetch and > the hints update, which causes images to not redirected to compressed > versions. So the image fetches are delayed a bit to circumvent this. > > Bug: 1051283 > Change-Id: Ie9e5351e68c0081ab9dbfe23faed2c3c5e8e4d42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056207 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742326} TBR=mcrouse@chromium.org Bug: 1051283 Change-Id: I0336295bc6120c16e02dd28f787f2edcfe37e9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065984Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#743275}
-