- 26 Sep, 2020 40 commits
-
-
Xianzhu Wang authored
When we switch on "create layers after paint" and back, the contents of the original GraphicsLayer::CcLayer() and RasterInvalidator which are not used during "create layers after paint" may not be valid. Invalidate them to ensure correct rendering. Bug: 1132218 Change-Id: Ia717e8202e2627cedbc9e5305619223a5a833f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432766Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811013}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601120384-ccbe20c9dce38060cfc0c250cd4b8585e6424eb6.profdata to chrome-linux-master-1601143179-7e0fff784977a232da08a71c4f8ef38f5aa5597c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I346e705ef76f4b574574927890bf4198065442ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811012}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4262.0-1600690455-benchmark-87.0.4274.0-r1 to 87-4262.0-1600690455-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ief8ad06528ef242e6036d32a113faacd2948e691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433514 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie88132967e5eb3e66096ddc99bcc00270167c3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432288Reviewed-by:
-
Tibor Goldschwendt authored
Screenshot: https://screenshot.googleplex.com/8XenkGQNbhfpQKv Fixed: 1130855 Change-Id: Ieb2ab938047b5fcc4fe1bc689661369ec5bf22c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431783 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811009}
-
Caleb Raitto authored
This includes supporting MaybeShared and raw pointers in addition to NotShared, and supporting all view types. Bug: 973801 Change-Id: I6bf50dbda181ee33a47b12618601302eb50dba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432813 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#811008}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5fadda5c3cf995619bb17aa2da01ca86584724a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432128 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811007}
-
Gayane Petrosyan authored
When TextFragmentFinder finds no match for the provided selector, TextFragmentSelectorGenerator should be notified so that it notifies the user that generation failed. As selector provided by TextFragmentSelectorGenerator is constructed for the selection from the user, this can happen only if selector is incorrectly constructed. Bug: 1129649 Change-Id: I10b5a49602128b532166a66354faa905493fb7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426464 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811006}
-
David Bienvenu authored
This reverts commit 085b583f. Reason for revert: <crbug.com/1132543> Original change's description: > Make Launch.Modes an enum histogram, not sparse. > > In response to comment on crrev.com/c/2384332. > > Per mpearson@: For enums versus sparses, the underlying UMA > data / logs will look the same. It's only the implementation > in Chromium that would be different. > > Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975 > Reviewed-by: Peter Boström <pbos@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810438} TBR=pbos@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia7edc131b855a4ceb384b8e2d76055386d1044c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433060Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811005}
-
Dirk Pranke authored
In an email to a Google-internal group a while ago I talked about the various mechanisms we potentially have for disabling tests and their advantages and disadvantages. This seems like something worth preserving, so I'm moving it into a doc checked into the repo. Change-Id: If8288eac8704354c92ffe12b9e79c930e0738c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419612 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#811004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/766eeb2ac325..eabce08bb2f2 2020-09-26 mtklein@google.com move paint color to Params 2020-09-26 mtklein@google.com Revert "moved SkSL BoolLiteral data into IRNode" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I2bf8276142f973e909b706682182952f1d340f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433509Reviewed-by:
-
Haiyang Pan authored
This reverts commit 57b51303. Reason for revert: Likely the causes of test failures in FileSystemChooserBrowserTest.* and NativeFileSystemDragDropBrowserTest.* in a couple of android builders. Examples are: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/190 * https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27111 * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2737 Original change's description: > [FS] Remove Native File System base::Feature. > > The base::Feature has been enabled by default for many many milestones > now, so it seems unlikely we'd ever want to turn it off again. Remove it > to make code simpler to maintain. > > Embedders can still turn off the API using the blink runtime feature. > > Change-Id: Ifad92d39adac1e656cf75a02918f33409aea44ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427287 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810742} TBR=dcheng@chromium.org,tapted@chromium.org,michaelpg@chromium.org,mek@chromium.org,pwnall@chromium.org,lucmult@chromium.org Change-Id: I70017eb9fe7c77e84d04341a061e0fa4fa22305e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433308Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#811002}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4274.0-r1 to 87-4247.0-1600681610-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5cf1e4a4778d7ddbb09630d52ff742666eaf6543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433511Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bacaef3237c5..1815d86a224b 2020-09-26 cstout@chromium.org [Wconversion] Suppress glslang issue (#2404) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I73671d6a27099470855c55dcf2f63346ae3d394b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433544Reviewed-by:
-
Jordan Bayles authored
This patch rolls JsonCpp to HEAD. Bug: 989851 Change-Id: I062f7d398190b61a66d48952b7504848ab1d75ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433107Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#810999}
-
Fredrik Söderqvist authored
Tbr: schenney@chromium.org Bug: 1128962 Change-Id: If37cdb8571920fa42844d50455451f0f7d4dfdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431969Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#810998}
-
Roman Arora authored
Updated screenshots: Default view: https://drive.google.com/file/d/1KLzsAnrQa4UomlH4HtWpUeRyhZzo315E/view FixedEntrypoint view (guarded by chrome UI flag): https://drive.google.com/file/d/1nHTx-GdNtOJBN6Zxp-YMh3E6zPYnXSYE/view Bug: 1128599 Change-Id: I0db6a5400ff0cd8e5558576ec59537e0288d2b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427103Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#810997}
-
Asanka Herath authored
There's a few more on the way so let's move them into a separate directory. Bug: 973801 Change-Id: I94b638b7d6bae045502fc2265fd644a567416cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432863 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Dylan Cutler <dylancutler@google.com> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#810996}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/2be1c17fda0d..a5548b3d5782 $ git log 2be1c17fd..a5548b3d5 --date=short --no-merges --format='%ad %ae %s' 2020-09-25 junyer Point to the official Python wrapper. 2020-09-25 junyer Disable fail-fast in GitHub Actions. 2020-09-25 junyer Fix a template that will break with GCC 11.x. 2020-09-22 junyer Try to use the Clang packages instead. 2020-09-22 junyer Try to make the Clang containers work. 2020-09-22 junyer Configure a build matrix for Clang using containers. 2020-09-22 junyer Address `-Wclass-memaccess' warnings from GCC 10.x. 2020-09-22 junyer Configure a build matrix for GCC using containers. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I79a4dafa2eba5e18966dd637ca5b5b144bcc56e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433249 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810995}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a8e978ac76a8..7950eb55c076 2020-09-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba8f3a94a5f6ff76b06d8cf1adb48c99e1072e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432213Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iec678436180a1e4281e17421a6b06a3cdd0f174c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432221Reviewed-by:
-
Shakti Sahu authored
This CL adds the MVC components and necessary resources for showing the language picker. The UI will be matched to specs in a later CL. UX : https://bugs.chromium.org/p/chromium/issues/detail?id=1130682 Bug: 1117182 Change-Id: I7dfc809309c6e1c6f6f5daeac97906d7a207e2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414573 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#810992}
-
Mason Freed authored
Per the conversation here [1], there is a desire to add more testing of the :defined pseudo state, prior to the call to super(). Note that `this` is not accessible prior to super(), so the instance itself is used. Also note that :defined already does not match anywhere inside the constructor, for upgrades. [1] https://github.com/whatwg/dom/pull/894#discussion_r495092027 Bug: 1042130 Change-Id: I2372900981247ea5624e737d2597d004398de477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431558 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810991}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601098956-8dc5f241a60ad3bbaa0b96777ed5d4c55f872428.profdata to chrome-linux-master-1601120384-ccbe20c9dce38060cfc0c250cd4b8585e6424eb6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I108cf4f67484dd1d786432210e919e83cdeebc22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432215Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I63d3fda1c87629dc9a128ee21e80059c83759d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432223Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601098956-7b62f3c084a877589de82f5f57c5b346e35e22e9.profdata to chrome-mac-master-1601120384-3673cc2f8767c2ae76b18a20724f2e99ef5174cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8eb088f98fb1e412a61d05a3940af9cac499f5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432217Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e1545fa00c8..766eeb2ac325 2020-09-26 fs@opera.com Return target rect for SkPictureImageFilter forward bounds mapping If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: Id2cf7a71bfd431f241e6faa7d517a11e16201c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432214Reviewed-by:
-
Jamie Madill authored
The tests do not yet upload to Skia Gold. That will be implemented as a follow-up. This will run on ANGLE CQ builders, e.g.: https://ci.chromium.org/p/chromium/builders/try/win-angle-rel-64 https://ci.chromium.org/p/chromium/builders/try/linux-angle-rel https://ci.chromium.org/p/chromium/builders/try/android_angle_vk64_rel_ng Bug: angleproject:4090 Bug: b/168049670 Change-Id: Ied638002c4080cb081121ab5b091fc091f82c6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423905 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810986}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/NV_ZV-z9XX-Yv6UVmMCUAHjBiVWkCwmVmCDBB59wP4YC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id09f208359035fc2fae6b53e90ac7cb23e983f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810985}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/mVKYYOx8-pidKaj9alMphEN2AZUhCsmPzuRBc-FsDhMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Iafaf200cf306f20bb2157908fb1a12429d5f8f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432220Reviewed-by:
-
Haiyang Pan authored
This reverts commit 8c7e525a. Reason for revert: (Copied from crrev.com/c/2433419) Findit (https://goo.gl/kROfz5) identified CL at revision 810966 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhjN2U1MjVhODhiNmI5OGQzYmJmM2UyZmQ1NzUyNmM5ZGMwZWUyMmQM Sample Failed Build: https://ci.chromium.org/b/8868097753228061152 Sample Failed Step: compile Original change's description: > Roll ANGLE from fc4e3cf24f9b to ae24f28a0ba6 (8 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/fc4e3cf24f9b..ae24f28a0ba6 > > 2020-09-26 cclao@google.com Vulkan: Move mReadOnlyDepth out of FramebufferDesc > 2020-09-26 cclao@google.com Vulkan: Use DepthStencilReadOnly when it is read only. > 2020-09-26 jmadill@chromium.org Add a small unit test that dumps system info. > 2020-09-25 syoussefi@chromium.org Vulkan: Workaround vkCmdClearAttachment bug on Pixel > 2020-09-25 jmadill@chromium.org Enable Vulkan SystemInfo on more platforms. > 2020-09-25 syoussefi@chromium.org Vulkan: Make UtilsVk not contribute to occlusion queries > 2020-09-25 ynovikov@chromium.org Skip BootAnimationTest.DefaultBootAnimation on Win NVIDIA Vulkan > 2020-09-25 timvp@google.com Vulkan: Link PPO during draw validation > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC syoussefi@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: syoussefi@google.com > Test: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: dEQP.GLES31/functional_separate_shader_validation_es31_* > Change-Id: I293417fd73361302fccf41d3e56e807395025e7d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432960 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#810966} TBR=syoussefi@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Id831c460fccb6dc2a6cab84e7e577a110f0b6960 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433059Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ied5e91efba88265bc12e2213f62b5b48ae75f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432772Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae24f28a0ba6..dff9331631e4 2020-09-26 jmadill@chromium.org Add Skia Gold CIPD package to DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I785c86ba9f27525e715edbee587dfb1308b624df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433394Reviewed-by:
-
DongJun Kim authored
This patch uses WeakPtr instead of raw pointers of PaymentRequestState,PaymentRequestSpec, PaymentRequestDialogView and PaymentRequest. Bug: 1086284 Change-Id: I8307a81e6fc633ed5fda8f848eba261378f98a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400547 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe9da604c428..dc972dc72cd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ife3fa63beb619cf2627a1fb47a2cc36e542f7d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433393Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4c9c15c156284df3eedeb8f3de964df24c10aca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431667Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810978}
-
Benoit Lize authored
Bug: 998048 Change-Id: I9c8cdbec7b7748d6d4f9b473affb6d3948a374ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428896 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810977}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I276ce29d1c2aaeddd06c4c4d16fd601ab0aac606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432953Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d08de1904727..5b4d110a2b90 2020-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Iadc7f8e4446cbe04398bbe5e9427558dc9183bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433385Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68861e391313..5e1545fa00c8 2020-09-26 csmartdalton@google.com Finish recording tessellation pipelines 2020-09-25 ethannicholas@google.com moved SkSL BoolLiteral data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I27e4fad5f0377252c7a9b7af724b37fdd1f20780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432951Reviewed-by:
-
