- 26 Sep, 2017 40 commits
-
-
danakj authored
ReleaseCallbacks aren't part of CompositorFrames, they are for resource management in-process, so move them to resources/. CopyOutputRequests can be in a CompositorFrame atm, but also go to frame sinks in other ways too, so move them up a level to frame_sinks, along with the CopyOutputResults which are not part of a CompositorFrame at all. TBR=jam NOTRY=true Bug: 722935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iab8d8268b13d8eb81568dbf4a0222135c4a12d57 Reviewed-on: https://chromium-review.googlesource.com/682760 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#504409}
-
Sergey Ulanov authored
The script stopped working with more recent versions of Fuchsia. packages/gn/gen.py now expects full path for --modules argument. Updated the script to pass full path for packages/gn/sdk. Change-Id: I32c511cae73075a7b37c26035e8bea764605a332 Reviewed-on: https://chromium-review.googlesource.com/683342Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504408}
-
Nicolas Dossou-gbete authored
Preview: https://photos.app.goo.gl/2NJzRQ31Js9ltKeC3 Bug: 762932 Change-Id: I47d47928cf4f1708bfc1ea96689e81362e166ca8 Reviewed-on: https://chromium-review.googlesource.com/664578Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504407}
-
Rouslan Solomakhin authored
Before this patch, calling PaymentRequest.show() would bring the background window to the foreground, which allows a page to open a pop-under. This patch adds a check for the browser window being active (in foreground) in PaymentRequest.show(). If the window is not active (in background), then PaymentRequest.show() promise is rejected with "AbortError: User cancelled request." No UI is shown in that case. After this patch, calling PaymentRequest.show() does not bring the background window to the foreground, thus preventing opening a pop-under. Bug: 768230 Change-Id: I2b90f9086ceca5ed7b7bdf8045e44d7e99d566d0 Reviewed-on: https://chromium-review.googlesource.com/681843Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504406}
-
John Abd-El-Malek authored
http/tests/devtools/service-workers/service-workers-navigation-preload.html was failing and now it's crashing. TBR=yzshen@chromium.org NOTRY=true Change-Id: I46478782f0be345957d06f89d19365876fae9fbb Reviewed-on: https://chromium-review.googlesource.com/685294Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#504405}
-
Jiaquan He authored
- This reverts commit 2f873e14, "cros:Enable PlaystoreSearch and AnswerCards by Default on Eve Only". - Full-screen is already ON, blur is ON on selected devices. Enabling for Answer Cards and Play Store app searching. This will be landed when prod server is 100%. Bug: 766784 Change-Id: Ie4c685a82c6e6f2e89ec082480f33e4ecc57039f Reviewed-on: https://chromium-review.googlesource.com/678735Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Vadim Tryshev <vadimt@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#504404}
-
John Wu authored
//ios/web_view would like to be able to sign in to chrome to sync data like autofill and passwords. This change sets up some initial services that are needed to implement //components/signin. Change-Id: I91229229767447f0c33f25f217d6b8c426cc5437 Bug: 753659 Reviewed-on: https://chromium-review.googlesource.com/606811 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#504403}
-
Pavel Yatsuk authored
The issue is that call to AndroidSyncSettings.ctor in setUp() posts asynchronous task that can take a while to complete and run well into actual test causing unexpected calls to getIsSyncable. The change adds a callback to AndroidSyncSettings.overrideForTests that allows test to block waiting for the flow to complete before proceeding with the test. BUG=737862 R=bsazonov@chromium.org Change-Id: Id33137d791954a3558fbe8dd76c33719c4fcf428 Reviewed-on: https://chromium-review.googlesource.com/679462Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#504402}
-
Sergey Ulanov authored
This version: - Fixes getaddrinfo(). - Adds media_client library. TBR=yzshen@chromium.org NOTRY=true Bug: 707030, 737802, 731302 Change-Id: I271d9681194d81d2979635784b3f0ca2c0a946d0 Reviewed-on: https://chromium-review.googlesource.com/683311 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504401}
-
Michael van Ouwerkerk authored
Bug: 760618 Change-Id: I9670fc2f4ab36e080d67ed41d8503d5ca2a17b73 Reviewed-on: https://chromium-review.googlesource.com/684734Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#504400}
-
Eric Holk authored
This is a reland of bbd7b898 Original change's description: > Add browser_tests for WebAssembly out-of-bounds behavior > > Trap-based bounds checking requires interaction with the crash reporter > to catch out of bounds accesses. These browser tests make sure this > behavior is working in the context of a full Chrome browser. > > Bug: chromium:722585 > Change-Id: I1993540f85f5d3500681cd3fbd7a9af817fe4ce8 > Reviewed-on: https://chromium-review.googlesource.com/648363 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503907} Bug: chromium:722585 Change-Id: Ic76c769af88134be215127c190706f8ae4fb6ed1 Reviewed-on: https://chromium-review.googlesource.com/682114Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#504399}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/c03c2181901fe44e0eec700aaf645769ea2d240a..42e93b6cf5e0a5c958b6b59cf4842b3dc275561a BUG=none Change-Id: I343451f157a2172227b3223919690d8ae7269c77 Reviewed-on: https://chromium-review.googlesource.com/682835Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504398}
-
Evan Stade authored
Most of the lines of change in this patch are just from splitting the declaration and definition for ConstrainedWebDialogDelegateViewViews. This entire file is a painful morass of similarly named classes that are all defined inline. Bug: 766774 Change-Id: I4ebfece91d9398571232cf350a2dd27f117d88f4 Reviewed-on: https://chromium-review.googlesource.com/674179Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#504397}
-
Chris Mumford authored
In 328d3bee InitWithOptions was modified to no longer require a SharedReadCache parameter. A few leftover forward declarations of leveldb_env::SharedReadCache were not removed. TBR=johnme@chromium.org,qinmin@chromium.org,nyquist@chromium.org,jkrcal@chromium.org TBRing reviewers: johnme@chromium.org: chrome/browser/budget_service/budget_database.cc qinmin@chromium.org: components/download/internal/download_store.cc nyquist@chromium.org: components/leveldb_proto/proto_database_impl_unittest.cc jkrcal@chromium.org: components/ntp_snippets/remote/remote_suggestions_database.cc Bug: 762587 Change-Id: Ib0b515b0d6bf7b11bbee05fcabc60c59d0981d1a Reviewed-on: https://chromium-review.googlesource.com/683002Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#504396}
-
Ran Ji authored
Bug: 763380 Change-Id: Ic039c88bb2faf28dc43244a01ade177712a0b55d Reviewed-on: https://chromium-review.googlesource.com/684875Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#504395}
-
Christopher Grant authored
This target really needs to get into the CQ party. BUG= R=bshe Change-Id: Ie276f66f7db7f09b019226c90a2ea0570c558a37 Reviewed-on: https://chromium-review.googlesource.com/684694Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#504394}
-
Eugene But authored
Bug: 728776 Change-Id: Id135e60fb228a664fe456d74ce1b60752d6eb7dc Reviewed-on: https://chromium-review.googlesource.com/682015Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#504393}
-
Gauthier Ambard authored
Title for Recent Tabs' sections should be title cased. Bug: 426576 Change-Id: I6aadca930ad8925e11cb221d508c926c2e2c83a7 Reviewed-on: https://chromium-review.googlesource.com/684841Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#504392}
-
Xiyuan Xia authored
- Make AuthSyncObserver observe SigninErrorController in addition to sync service so that auth errors caused by other services are caught as well. - Fix an edge case that OAuth2LoginManager marks valid oauth2 token when it thinks /MergeSession succeeds regardless of whether there is any auth error; Bug: 760610 Test: OAuth2Test.SetInvalidTokenStatus Change-Id: Idbaee9f7faa1aa2aff939a1540bfcfdd9f49c96c Reviewed-on: https://chromium-review.googlesource.com/658378 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#504391}
-
Christian Dullweber authored
The title of the site settings / content settings section depends on the value of switches::kEnableSiteSettings, so the option in Clear Browsing Data should use the same logic to decide which title to show. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0cdd9642759f9cc321ec9a591445a4c17606c2ef Reviewed-on: https://chromium-review.googlesource.com/681215 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504390}
-
John Mellor authored
It's commonly assumed that GUIDs generated by base::GenerateGUID are unguessable and will not collide, and this is in practice true since it's backed by base::RandBytes. The header for base::RandBytes did not guarantee being secure, but the implementations were all required to be cryptographically strong random number generators since crypto::RandBytes and base::UnguessableToken already both depend on base::RandBytes (see https://crbug.com/140076). This patch: - Marks base::GenerateGUID as secure in the code comments. - Migrates base::GenerateGUID from base::RandUint64 which is not guaranteed to be secure to base::RandBytes which is - see above. (It's not possible to migrate to crypto::RandBytes since that would introduce a circular dependency between base and crypto - see UnguessableToken::Create for a similar case). - Marks base::RandBytes as secure random in its header, but clarifying that code outside base/ that depends on it being secure should continue to use the crypto/ wrapper. - Cleans up some duplicated code in the implementations of base/rand_util_*.cc Bug: none Change-Id: I282bbd7d1883ba120c01280b941b9d7ecbef404c Reviewed-on: https://chromium-review.googlesource.com/678731Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#504389}
-
Daniel Bratell authored
Change-Id: Id3e0139beeca89444f4100de67c21da579c49047 Reviewed-on: https://chromium-review.googlesource.com/684739Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#504388}
-
chrome://instantMarc Treib authored
After crrev.com/c/678719, the debug log isn't populated anymore (and even before that, the logged events weren't particularly meaningful anymore). Bug: 627747 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iff770ddb5f7867ae36b3e8cacbac480707654aeb Reviewed-on: https://chromium-review.googlesource.com/678721Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504387}
-
Mohamad Ahmadi authored
Bug: 759904 Change-Id: I1a66f126cc2c47b76e1fdb2acbf9eeec61d96ea9 Reviewed-on: https://chromium-review.googlesource.com/677985 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504386}
-
Ned Nguyen authored
THis benchmark doesn't use our supported harnesses Bug: 717539 Change-Id: Id90301a5d8632d81edab30d815fb15479b7d2fe2 Reviewed-on: https://chromium-review.googlesource.com/684416Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504385}
-
Sami Kyostila authored
This patch turns on crash reporting in headless mode by default. This helps us diagnose headless-only crashes. Crash reporting can be disabled with the --disable-crash-reporter command line flag. Note that this only affects Headless Shell and --headless; C++ embedders of headless are not affected. BUG=691507 Change-Id: I5f100908a9fdaf6ddeac0c3bd13d07ba50e89402 Reviewed-on: https://chromium-review.googlesource.com/684020 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504384}
-
Henrique Nakashima authored
Bug: 55776 Change-Id: I4eb37792a2c6ec4e04ab0f43b3eddd75ca31c98c Reviewed-on: https://chromium-review.googlesource.com/675707Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#504383}
-
Ian Vollick authored
With this CL, a number of conditions that were glommed together and checked with one EXPECT_TRUE are not separated to make test failures easier to understand. Bug: None Change-Id: I849bb26befc52b89a61422a4ff63059c376cd60d Reviewed-on: https://chromium-review.googlesource.com/684538Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#504382}
-
Evan Stade authored
NotificationDisplayService. Allow notification sources, like EolNotification, to register their custom handlers with NotificationDisplayService. Bug: 578868,755413 Change-Id: Ie7c4464c174625dc4de4c8e5f3053a47659e6d66 Reviewed-on: https://chromium-review.googlesource.com/648474 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#504381}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ba14c0a5f12b..a7caeb529121 $ git log ba14c0a5f..a7caeb529 --date=short --no-merges --format='%ad %ae %s' 2017-09-26 dsinclair Rename CFPDF_* classes Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ibfb22ebb7dc67b5ba1af8ff56d73c7411333fa7b Reviewed-on: https://chromium-review.googlesource.com/684674 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504380}
-
Daniel Bratell authored
V8ScriptValueSerializerTest and V8ScriptValueSerializerTestForModules had a few methods in common. This patch makes those methods be shared, or in the case or non-identical methods, renamed to not collide in jumbo builds. Bug: 745732 Change-Id: Ia51d9f8dba1910902465dc4cffc193031b47ee3f Reviewed-on: https://chromium-review.googlesource.com/677446Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#504379}
-
Marc Treib authored
This reverts commit 71921771. Reason for revert: telemetry_perf_unittests failing again: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests Original change's description: > Reland "[tools/perf] Re-enable meadia system health smoke tests" > > This reverts commit ed15e687. > > Reason for revert: Tests should now fit within the allotted time. > > Original change's description: > > Revert "[tools/perf] Re-enable meadia system health smoke tests" > > > > This reverts commit 359bafda. > > > > Reason for revert: > > > > Seeing telemetry-perf bot failures. > > > > Original change's description: > > > [tools/perf] Re-enable meadia system health smoke tests > > > > > > These are running fine on bots now. > > > > > > Bug: 726439 > > > Change-Id: I97a5f9e85d873c685af14085f9534081fd3a5ee5 > > > Reviewed-on: https://chromium-review.googlesource.com/655299 > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#500564} > > > > TBR=perezju@chromium.org,nednguyen@google.com > > > > Change-Id: Ib3d38babf138c04ea32fa62cf257d20727593888 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 726439, 763379 > > Reviewed-on: https://chromium-review.googlesource.com/657917 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500594} > > TBR=rogerm@chromium.org,perezju@chromium.org,nednguyen@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 726439, 763379 > Change-Id: I309dfdd0f7b32bd4dc275904fc24ef1e251f8c85 > Reviewed-on: https://chromium-review.googlesource.com/684024 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504352} TBR=rogerm@chromium.org,perezju@chromium.org,nednguyen@google.com Change-Id: Ib027b20abc609bab8a6269fe658ad5b135eb66b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726439, 763379 Reviewed-on: https://chromium-review.googlesource.com/685094Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504378}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/6bba6de94461..f6f7cf60985d $ git log 6bba6de94..f6f7cf609 --date=short --no-merges --format='%ad %ae %s' 2017-09-25 brianosman Invalidate path VBs when paths are destroyed Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I561c148fe6131b4f923e122a99400e67dad7ee21 Reviewed-on: https://chromium-review.googlesource.com/684555Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504377}
-
Theresa Wellington authored
* Disable animation when changing content in the bottom sheet on low-end devices * Set a background color on the content displayed in the sheet to compensate for a JB bug * Use #setBackgroundColor instead of #setBackgroundResource to fix a JB bug BUG=766237,749959 Change-Id: Ic300905d8c79a137f55bc6732d70d65444f6a921 Reviewed-on: https://chromium-review.googlesource.com/683216Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#504376}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99e3e3dd. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2435 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry-1 TBR=qyearsley@chromium.org No-Export: true Change-Id: I35ab110b68b64b063cf9dc3699f4a5aedfc6a86c Reviewed-on: https://chromium-review.googlesource.com/684117 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504375}
-
Edward Lemur authored
Bug: 745469 Change-Id: I1c97a913769352d9e352e2cbb2d99fd52e655439 Reviewed-on: https://chromium-review.googlesource.com/681817 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#504374}
-
Elodie Banel authored
The iPhone X being quite tall, the 100em page was not tall enough and since it fit on one page, the toolbar could not be scrolled out of the way. Additionally, I've noticed that in the iPhone X simulator the JSCompletionTimeout is getting hit regularly when loading a page but it works fine with a slightly longer delay, so extended that as well. Bug: none Change-Id: I22a1ca799853b38801b9c50b87a47f3cac7a09b5 Reviewed-on: https://chromium-review.googlesource.com/684735 Commit-Queue: Elodie Banel <lod@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#504373}
-
Nathanael Alcock authored
This change reimplements the import/export functionality to the PM settings as it existed in the previous version, before the Material redesign. Bug: 674536 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I686dc1152e95bc74ad21c3137b5aebf226801aed Reviewed-on: https://chromium-review.googlesource.com/663380 Commit-Queue: Nathanael Alcock <varkor@google.com> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504372}
-
Biao She authored
Bug: 767572 Change-Id: I7a9c90372c719bc423603d9e6a9a4ce33f292191 Reviewed-on: https://chromium-review.googlesource.com/677988 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#504371}
-
Mike Reed authored
https://skia-review.googlesource.com/c/skia/+/50980 Bug: Change-Id: Ibab6c30df52f78269c8f16fc2f5e21f362668385 Reviewed-on: https://chromium-review.googlesource.com/684774 Commit-Queue: Mike Reed <reed@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#504370}
-