- 27 Jul, 2018 40 commits
-
-
Simeon Anfinrud authored
The new name: * pairs well with the concept of "Observable" * describes the role rather than the implementation details * is consistent with other reactive frameworks * is more concise Additionally, the Observer's interface method has been renamed to open(), instead of create(). This intuitively pairs better with Scope.close(), hopefully reducing the amount of jargon one needs to learn to use this reactive framework. Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I20803a484951f886182eb078b07b7c9bfe11acca Reviewed-on: https://chromium-review.googlesource.com/1152120Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578683}
-
Rohit Rao authored
If the BookmarkModel finishes loading after the BookmarkHomeViewController is created, but before it is displayed, then it is possible that a root node is never set on the VC. This leaves the VC in an invalid state, causing crashes when its views are eventually loaded. This crash can be avoided by always setting the VC's root node when the bookmark model finishes loading, even if the VC's views have not yet loaded. BUG=862592 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d5fb9519a07f901c0e4dcd7622c9dbac276443a Reviewed-on: https://chromium-review.googlesource.com/1153136Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578682}
-
Johannes Henkel authored
AppendTask schedules this method, and it's possible that after it's been scheduled, dispose() nulls out the isolate_task_runner_. TakeNextTask will handle this situation properly - if the runner is gone, it returns Task(). So, moving the DCHECK should avoid the following stack trace which I've seen twice thus far when running tests with always DCHECK enabled. Thank you for your suggestion for this fix, Dmitry. [1:41:0725/182513.246104:FATAL:scoped_refptr.h(219)] Check failed: ptr_. Change-Id: Ic24aef83876de05159a7cd9805ff8d2015d52629 Reviewed-on: https://chromium-review.googlesource.com/1151950Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#578681}
-
Xiangjun Zhang authored
Replaced the current interfaces with mojo interfaces. No functional change. Bug: 734672 Change-Id: I0f54fdb63fe6179d1296c1e5132e1f09a4a4b4b2 Reviewed-on: https://chromium-review.googlesource.com/1137103 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578680}
-
Scott Violet authored
It's flakey, and has been flakey for quite a while. BUG=868409 TEST=test only change TBR=riajiang@chromium.org Change-Id: I4d4a57c9eed04563cdad114075c197244ea7ccdd Reviewed-on: https://chromium-review.googlesource.com/1153207Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578679}
-
Tommy Steimel authored
This CL adds logic to CustomTabActivity's toolbar initialization to remove the menu button when it is empty. This happens when the UI is a media viewer (which disables all default menu items) and when the media is opened via the MediaLauncherActivity (which doesn't add any custom menu items). In addition to removing the menu button, the margin on the custom action button bar is removed in order to shift the custom buttons over to where the menu button was. Bug: 865103 Change-Id: I19fa270bf30d80d711a0b288b97c9edde79bad2f Reviewed-on: https://chromium-review.googlesource.com/1149019Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578678}
-
rbpotter authored
Key handling for number inputs was accidentally deleted in https://crrev.com/c/975825. Restore the handling and add a test. Bug: 868142 Change-Id: I33f24ded29a58154a8987368c2de1001444755c1 Reviewed-on: https://chromium-review.googlesource.com/1150901 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578677}
-
Marc Treib authored
WeakHandle is a wrapper around WeakPtr, which only cares about sequence-affinity, not thread-affinity. Also fixes two unrelated-looking-but-actually-related IWYU violations. Bug: 846238 Change-Id: Iafffea16a38728f0c3dd6852954da509e0eab633 Reviewed-on: https://chromium-review.googlesource.com/1152821Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578676}
-
Xiaocheng Hu authored
For the following two layout tests: - fast/events/background-tab-on-submit-ctrl-click.html - fast/events/background-tab-on-submit-synthesized-ctrl-click.html Their baselines were updated by crrev.com/c/1119380, which left their NG-specific baselines stale, and made them fail on layout_ng bot. This patch updates the baselines to make them pass again. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia51d79bae429f7d62a4c034f181c02f9c9538e66 Reviewed-on: https://chromium-review.googlesource.com/1152419 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578675}
-
chrome://safe-browsingDaniel Rubery authored
To streamline the debugging of referrer chain logic, add the ability to view the referrer chain for any given URL. Render: https://screenshot.googleplex.com/go6P5jn3LpD Bug: 864237 Change-Id: Ifc83662fd3e9eed44a6966f951c594857ed79e1e Reviewed-on: https://chromium-review.googlesource.com/1151539 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578674}
-
Johannes Henkel authored
It was added here: https://chromium-review.googlesource.com/c/chromium/src/+/1108509 Every time I run the tests, it deletes this. I don't know why, but it's a little annoying having to avoid committing it. So, I figure, I should just try to commit it once and be done with it. :-) I've learned that others are having the same issue, but maybe aren't suffering as much as I am (I have a happy trigger finger and often do git commit -a -m foo ...). If this file is needed and you have an idea why, please enlighten me and apologies for the attempt to remove it. Thanks much! Change-Id: I873211c98bc3158638c5abde59bc7acf060be8c7 Reviewed-on: https://chromium-review.googlesource.com/1152540Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#578673}
-
Guohui Deng authored
Rename MediaPipelineBackendManager::CreateMediaPipelineBackend() to MediaPipelineBackendManager::CreateCmaBackend. Bug: internal b/111850629. Test: Build cast_shell. Change-Id: I4134ed18f5dc0972d3e93d07c17a53d1753b8241 Reviewed-on: https://chromium-review.googlesource.com/1152292 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Bailey Forrest <bcf@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#578672}
-
rbpotter authored
This will be needed when Print Preview is updated to Material Design, for the copies and scaling inputs. Bug: None Change-Id: I42ed62f5ca323f9ed1c93b89e9588506653469b5 Reviewed-on: https://chromium-review.googlesource.com/1150927Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578671}
-
Aidan Wolter authored
CastAudioOutputStream can now use internal backends with multizone. In order for multizone to work, we first need to retrieve the multiroom info and pass it to the backend. BUG=b:111694183 TEST=Build, cast_media_unittests Change-Id: I128a6b0cc1a389d01102007244fdb5594dd4c637 Reviewed-on: https://chromium-review.googlesource.com/1145892Reviewed-by:
-
Devlin Cronin authored
Add a URLPattern::CreateIntersection() method to return the intersection of two URLPatterns, if any. This can construct a new URLPattern in many cases. For instance, the intersection returned between http://*.google.com/* and *://google.com/maps is http://google.com/maps. This CL does not add any (non-test) usages of the new method. Bug: 867549 Change-Id: I590081fa6d57bcc88c831095b50d21e20e9ec049 Reviewed-on: https://chromium-review.googlesource.com/1150413Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578669}
-
Katie D authored
The system voice is chosen using the Text-to-Speech settings page and depends on locale. Bug: 866550 Change-Id: I249a023d9f018ef8ef1f242f82cf3c9d5b6d788b Reviewed-on: https://chromium-review.googlesource.com/1150773Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#578668}
-
Bo Liu authored
When draw constraints have not changed. Fairly obvious and hopefully safe change. Bug: 864436 Change-Id: I6cb4165c34411fa81d1644edb262496e82f8044e Reviewed-on: https://chromium-review.googlesource.com/1150964Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578667}
-
Tommy C. Li authored
This implements the previously-removed textfield jogging behavior behind a feature flag accessible from chrome://flags. Followup work: We may implement a special accommodation to the jog flag to make the keystroke-backspace case less jarring of a transition. Bug: 868157 Change-Id: I63fbb8f8f171f1d5ccf09f1cd92332963f567ae3 Reviewed-on: https://chromium-review.googlesource.com/1152459 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#578666}
-
Martin Robinson authored
Instead of using ATK_ROLE_WINDOW by default for the internal Window accessibility role, use ATK_ROLE_FRAME. ATK_ROLE_FRAME is used for windows that have titlebars and buttons, while ATK_ROLE_WINDOW is reserved for those that don't. Since most windows have buttons and a titlebar in Chromium, ATK_ROLE_FRAME is probably a better default. TEST=accessibility_unittests --gtest_filter=AXPlatformNodeAuraLinuxTest.* Bug: 867006 Change-Id: Ia0366f7088465f123f00e250c4cc6f7393c0c64e Reviewed-on: https://chromium-review.googlesource.com/1148445 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578665}
-
Rayan Kanso authored
On browser startup we attempt to resume all previously active fetches. The DownloadService might not be ready though, so this change only resumes the fetches if the DownloadService is ready, and also goes through all the jobs and resumes the active fetches once the OnServiceInitialized event is triggered. Note that ResumeDownload might be called twice on the same guid in some cases, but that will not cause any problems since the second call will be ignored. Change-Id: I1d06c944496cd0f1b711ae91d15c003abc70f8c3 Reviewed-on: https://chromium-review.googlesource.com/1152820 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578664}
-
Aaron Leventhal authored
In event test output, don't use document object's value, which is a URL. This helps avoid arbitrary differences in tests, as the port numbers change between runs. Bug: None Change-Id: I7c8d5aee6267b8863a5c8712db1287ded551e5c8 Reviewed-on: https://chromium-review.googlesource.com/1150434 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#578663}
-
Farah Charab authored
Bad-cast to base::TestMockTimeTaskRunner from invalid vptr in base::TestMockTimeTaskRunner::MockClock::NowTicks test_task_runner_ was getting destructed before the sequence manager (which calls the test_task_runner_ upon its destruction). Bug: 867790 Change-Id: I412b6a720b4607deeaad1ce80d8bd601dfc04814 Reviewed-on: https://chromium-review.googlesource.com/1152979 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578662}
-
James Cook authored
We no longer have mash vs. classic configs in ash, and there's only one implementation of ShellPort. As a step towards eliminating ShellPort, remove the cursor handling methods from it. Also clean up some code that checks to see if we have a cursor manager -- ash always has one, for the lifetime of Shell. This manually reverts parts of https://codereview.chromium.org/2857963003/ Bug: 866523 Test: ash_unittests Change-Id: Ic905b26587af6c2cebdd4fcbcf07f85d69515d1e Reviewed-on: https://chromium-review.googlesource.com/1152544Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578661}
-
danakj authored
VisualProperties are passed to the RenderViewImpl::Create() method via the IPC params, then are passed along to the RenderWidget, but in a lot of different steps. 1st, screen info is passed to the RenderWidget constructor. 2nd, the display mode is set directly on the RenderWidget. [ a bunch of other initialization here ] 3rd, the whole set of properties is passed to OnSynchronizeVisualProperties like an IPC was just received. The 3rd step sends the screen info and the display mode again, though they won't be changed of course. This combines step 1 and 2 into one step where they are passed to the RenderWidget::Init() method. Then we can look at combining with step 3. R=ajwong@chromium.org, avi@chromium.org Bug: 419087 Change-Id: Ifcb8eaa0915bb235172e8c5b7bee188e863c18c3 Reviewed-on: https://chromium-review.googlesource.com/1150673 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578660}
-
Sadrul Habib Chowdhury authored
Tab-switch requests that are made through devtools for telemetry tests are not treated as user-gesture. So this metric can not reported in telemetry tests. However, the cost of this function is not directly related to the user-gesture itself. So always report this metric and associated trace event. This allows this to be measured and monitored in telemetry tests. BUG=858944 Change-Id: Ib7112b4939c44af099ecfb751fe108bbe8ecec86 Reviewed-on: https://chromium-review.googlesource.com/1152888Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578659}
-
Robert Kroeger authored
Fix a typo in https://chromium-review.googlesource.com/c/chromium/src/+/1142449,that resulted in over-eager execution of ozone/drm/mojo and hence the firing of DCHECKs on CrOS in certain configurations. BUG=867077 TEST=Run with DCHECKs always on. Change-Id: I239f7927894a9d766d9057f3145e458a0fb2aa6b Reviewed-on: https://chromium-review.googlesource.com/1152900Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#578658}
-
Randy Rossi authored
This is a temp fix for a bug on chromecast screen reader whereby the item that has a focus ring is not invoked after the user double taps the screen. When the touch exploration controller sets an anchor point explicitly, it issues a click gesture rather than a simulated tap when the user double clicks the screen. The click never gets processed properly by the background page because the ax tree thinks no window has 'keyboard' focus. This change defaults the focus_id field of AXTreeData to be 1 (the root node) since we only ever have one tree and one window to focus on anyway. A long term fix involves fixing other focus issues including (but not limited to) 1) giving the root window focus via Focus() call, 2) making sure the root window doesn't lose focus and 3) registering a native widget with the aura::Window or altering the ax_object_cache logic to not require it when trying to find the ax tree node corresponding to a window. Bug: b/111911092 Change-Id: Ide68dbae72288f58711d436db99ef495e5ea9eb0 Reviewed-on: https://chromium-review.googlesource.com/1152897Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578657}
-
Douglas Creager authored
We changed the MIME type in https://github.com/w3c/reporting/issues/51 as part of the TAG review of the spec. Bug: 868065 Change-Id: I4d8020bb39ef12b0695d5f5b16c56eaf2cf0a50e Reviewed-on: https://chromium-review.googlesource.com/1152069Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#578656}
-
Ioana Pandele authored
The string explaining that generated passwords are saved by the Chrome has changed and does not include a link anymore. This CL removes the link logic from the modal dialog. Bug:867572,835234 Change-Id: Id984e5cebbf6bf7fc6e98006ca06b997cdf2575d Reviewed-on: https://chromium-review.googlesource.com/1151204 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578655}
-
Jose Dapena Paz authored
Commit 19105bf3 introduced using constexpr for lots of methods. It introduced two kinds of regressions building with GCC: - Some depended on FloatSize::IsZero, which is not only non constexpr, but it cannot be constexpr either, as it depends on fabs, that is not constexpr. - Some depended on methods that were not constexpr (but we could fix them to be, as FloatQuat::P1() or FloatSize::SetWidth(). Those do not break in clang as it is a less picky in the scenario of defining a constexpr method that depends on non-constexpr methods. This patch fixes usage of constexpr in both cases adding constexpr implementations when needed. In particular it replaces fabs calls that are not constexpr at least in libc++ with a constexpr replacement, fixing GCC build and adding some extra constexpr that were missing. Bug: 819294 Change-Id: Ia1143ad4be1067bb8a918f0224b657523599ea97 Reviewed-on: https://chromium-review.googlesource.com/1150529 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#578654}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/787a378926fb..6a67dd77dfc3 git log 787a378926fb..6a67dd77dfc3 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 mattcary@chromium.org Tracing: Fix native library stats for pre-N devices. Created with: gclient setdep -r src/third_party/catapult@6a67dd77dfc3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:758566 TBR=sullivan@chromium.org Change-Id: I21b7d9a9d8d414220c338583ca44b04263a5c27f Reviewed-on: https://chromium-review.googlesource.com/1152618Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578653}
-
Scott Violet authored
This reverts commit c31de326. Reason for revert: Findit thinks this is the cause for SingleClientAppsSyncTest.StartWithSomePlatformApps is Flaky becoming flaky. Debug output from the bot shows CHECK in process_handle_win: [5744:6016:0727/011726.878:FATAL:process_handle_win.cc(29)] Check failed: result != 0 || GetLastError() != ERROR_INVALID_HANDLE. process handle = 00000FB4 Backtrace: base::debug::StackTrace::StackTrace [0x73D7A1D6+102] base::debug::StackTrace::StackTrace [0x73D7927B+27] logging::LogMessage::~LogMessage [0x73DDEFA4+148] base::GetProcId [0x73EC8E8E+254] content::ChildConnection::IOThreadContext::SetProcessHandleOnIOThread [0x617A7C58+232] base::internal::FunctorTraits<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),void>::Invoke<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *> [0x617A8001+81] base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *> [0x617A7F0C+124] base::internal::Invoker<base::internal::BindState<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *>,void __cdecl(void)>::RunImpl<void (__thiscall content::ChildConnectio [0x617A7E3F+111] base::internal::Invoker<base::internal::BindState<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *>,void __cdecl(void)>::RunOnce [0x617A7CE4+84] base::OnceCallback<void __cdecl(void)>::Run [0x73D1CA90+80] base::debug::TaskAnnotator::RunTask [0x73D7E9F3+1075] base::MessageLoop::RunTask [0x73E19A64+884] base::MessageLoop::DeferOrRunPendingTask [0x73E1A249+73] base::MessageLoop::DoWork [0x73E1A5BA+442] base::MessagePumpForIO::DoRunLoop [0x73E2775C+28] base::MessagePumpWin::Run [0x73E25CA7+119] base::MessageLoop::Run [0x73E19366+486] base::RunLoop::Run [0x73EDF518+488] base::Thread::Run [0x73FF8EF7+375] content::BrowserProcessSubThread::IOThreadRun [0x61B456A0+48] content::BrowserProcessSubThread::Run [0x61B45589+313] base::Thread::ThreadMain [0x73FF97BA+1402] base::PlatformThread::GetCurrentThreadPriority [0x73FEBC76+934] BaseThreadInitThunk [0x74AD336A+18] RtlInitializeExceptionChain [0x771F9902+99] RtlInitializeExceptionChain [0x771F98D5+54] Original change's description: > Fix invalid handle errors found with App Verifier > > ChildProcessData was holding a raw ProcessHandle which meant that there > was no guarantee that the handle would be valid when it was used. This > change switches to a ScopedHandle on Windows, with the associated > duplication of the handle, so that it is guaranteed to be valid. This > fixes a frequently encountered use of an invalid handle that was > detected by Application Verifier. This change also adds a CHECK to > base::GetProcId to check for use of invalid handles even when not using > Application Verifier. > > ChildProcessData::handle is now a private member so all references to > it were updated to use accessors. > > When ChildProcessData::SetHandle is called the handle is duplicated. > When a ChildProcessData object needs to be copied an explicit > Duplicate function is called. > > An IsHandleValid helper function was added. > > An invalid test was removed because it was triggering the CHECK in > base::GetProcId. > > Bug: 417532,821453,865805 > Change-Id: I7e38140335c0140536919341f011f144f150c88f > Reviewed-on: https://chromium-review.googlesource.com/1145767 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578419} TBR=brucedawson@chromium.org,jochen@chromium.org Change-Id: I8569cb32ec0cd9cbd99ecf6d5bba7feb672a88cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 417532, 821453, 865805, 868384 Reviewed-on: https://chromium-review.googlesource.com/1152374Reviewed-by:
-
Maajid authored
Bug: 866757 Test: chrome://histograms Change-Id: I232a2869cae577c0fe9ca61f95cf43eb0f8b0416 Reviewed-on: https://chromium-review.googlesource.com/1144904Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#578651}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55b1e6168454..9acfc6cac2c6 git log 55b1e6168454..9acfc6cac2c6 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 csmartdalton@google.com Add kAAHairline to GpuPathRenderers Created with: gclient setdep -r src/third_party/skia@9acfc6cac2c6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I56878c9191e3e8ade77b7c5220a6401fee7e8dcf Reviewed-on: https://chromium-review.googlesource.com/1152619Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578650}
-
Boris Sazonov authored
This CL changes the descriptions of the strings used in personalized sign-in promos to add more context for the translators. Bug: b/111761802 Change-Id: If1064ce114f1c7f4998f4afcce4d65b49a0e8629 Reviewed-on: https://chromium-review.googlesource.com/1152976Reviewed-by:
-
Sheng-Hao Tsao authored
This reverts commit a73dae7e. Reasons for revert: This CL breaks jpeg_encode_accelerator_unittest The test failed with a SIGTRAP. After reverting the CL, the test passes. TBR: dcastagna@chromium.org Bug: b:111832630 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If13254b68a0bbc08863cb477df13810a66874b30 Reviewed-on: https://chromium-review.googlesource.com/1152539 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#578648}
-
Colin Blundell authored
The current IdentityTestEnvironment APIs to wait for access token requests and issue responses operate in a shotgun manner: when the next access token request is received, the test API implementation issues a response for *all* pending access token requests. However, unittests that is targeted in an upcoming conversion requires more flexibility: as the production code that it is testing interacts with multiple accounts, the test issues access token requests for multiple accounts, and then sequentially issues responses and checks that a specific flow for each account in question was initiated in response to the specific response. Moreover, one of these unittests issues responses in an order different to the order in which the requests were made. To accommodate porting of these tests, this CL adds the ability to wait for an access token request for a given account and then issue a response only for that account. If while waiting for a request from a specific account a request for a *different* account is seen, the waiting code forwards on the handling of the request for that other account to the next iteration of the runloop; this allows for the case where a test wants to handle requests for multiple accounts in an order different to the order in which those requests were made. We leave in a variant that does not take in the account ID and operates as before, as this is convenient for the common case of tests that don't care about this level of detail (usually because they are testing a production flow that operates on the primary account). Bug: 798699, 809923 Change-Id: I6b1d93efd47b1eba128ac0b62c833736700e5196 Reviewed-on: https://chromium-review.googlesource.com/1149876 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578647}
-
Bo Liu authored
After r541507, requesting functor is not blocked until renderer side generates a frame. However if functor is called without a frame, it currently leaves the frame buffer untouched, which is a problem for parts of the frame buffer that is otherwise untouched. The ideal solution is to have functor draw the background color. But hooking this up is relatively complicated. Instead have java side draw the background color until UI thread receives returned resources from render thread, which indicates that parent side has received frames. Bug: 864436 Change-Id: I8bbf5c6c1353138dff071ff9cfbf58eb6e217eb3 Reviewed-on: https://chromium-review.googlesource.com/1150779Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/604d873e1df5..21e9baf71e6e git log 604d873e1df5..21e9baf71e6e --date=short --no-merges --format='%ad %ae %s' 2018-07-27 thomasanderson@chromium.org Roll Vulkan-Loader to a835880 Created with: gclient setdep -r src/third_party/angle@21e9baf71e6e The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic1232acf3a639dc3df17982206dbfc0faef287bc Reviewed-on: https://chromium-review.googlesource.com/1152617Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578645}
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true BUG=868367 BUG=750896 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If48cb102f9c217d5e4fcd5c86e2f94907619b10c Reviewed-on: https://chromium-review.googlesource.com/1152991 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578644}
-
