- 03 Apr, 2019 5 commits
-
-
Ian Wells authored
This change adds new fields to the pages and thumbnails tables. Bug: 841516 Change-Id: I79144f0debb3d4ffdc067ee9299b5bb6af4bfe9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549687 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#647044}
-
Fabrice de Gans-Riberi authored
* Implements the fuchsia.web.MessagePort API in MessagePortImpl. * Adds LegacyMessagePortBridge to bridge with the legacy chromium.web.MessagePort API. * Minor cleanups in MessagePortImpl. Bug: 946732 Change-Id: I64e16902ebcc4a913e0591c7131a57eaaeff188a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546521 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#647043}
-
David Bokan authored
Event Sender doesn't support being run from within remote frames for some operations (e.g. drag and drop) . In these cases it is a legacy test hook. Add a documented DCHECK so this results in clearer output rather than mystery nullptr crashes further along in execution. Bug: 945077 Change-Id: I0487731074ebe10580cb80db0091fb52ff46a47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546635Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647042}
-
Jessica Tallon authored
Bug: 918438 Change-Id: Ia0ff8a57743e29db384198c350446d2e7ff36ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486351 Commit-Queue: Jessica Tallon <jtallon@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#647041}
-
James Cook authored
Make the system tray "gear" settings icon open a blank settings window when the feature is enabled. PRD: go/cros-settings-2019 TODO: New chrome://os-settings/ URL and host. TODO: Sub-page support. Bug: 948298 Change-Id: I81a812f605f403f043022779eee349cbab147da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549198 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#647040}
-
- 02 Apr, 2019 35 commits
-
-
siyua authored
Two experiments involved: AutofillCreditCardLocalCardMigration, AutofillLocalCardMigrationShowFeedback Bug: 897998 Change-Id: I83d9e785de47d679393fa5ede09ddd7592d26e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530828Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#647039}
-
manuk authored
This is the 4th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. The search and shortcut providers use AutocompleteProvider::ClassifyAllMatchesInString to classify their suggestions. Specifically: a) Search results from the search provider classify their contents using ClassifyAllMatchesInString; their descriptions (e.g. ‘Google Search’) are always classified as DIM regardless of user input. b) 'nav-suggest' results from the search provider have unique classification logic at NavigationResult::CalculateAndClassifyMatchContents which delegates to ClassifyLocationInString. c) Both search and navigation results from the shortcut provider call ClassifyAllMatchesInString with the parameter 'text_is_search_query' set accordingly. ClassifyAllMatchesInString is a bit redundant and a bit inconsistent with other providers' classification code. Therefore, this CL: 1) Adds FindTermMatches to autocomplete_match_classification. It is responsible for creating TermMatches from the user text and suggest text. Similar methods exist, but this one is meant to be generic and replace the duplicates. For now, it only replaces ClassifyAllMatchesInString. 2) Replace ClassifyAllMatchesInString unique classification code with a few function calls. 3) Removes the no longer used methods CreateWordMapForString, GetOrCreateWordMapForInputText, and GetWordMapCache. These methods were used to split a string to words and create a map from the first letter of each word to all words starting with that letter, sorted shortest first. This was useful for the previous ClassifyAllMatchesInString implementation. These changes modify the search and shortcut providers classification behavior: a) Search results from the search provider previously did not match word break on symbols (e.g. 'fast.' would not match 'fast espn', 'fast com' would not match 'fast.com', and '//fast.com' would not match 'https //fast.com'). With this CL, search results will break on symbols. Also, search results lowercased suggest text but not user text (e.g. 'Fast' would match neither 'fast' nor 'Fast'). With this CL, both strings are lowercased for comparing (displayed text is unaffected). b) Classification behavior for 'nav-suggest's are unchanged, since they don't delegate to ClassifyAllMatchesInString. c) The shortcut provider was the only provider to allow mid-word matching in non-URLs (e.g. 'ello' matched 'h[ello]'). With this CL, this is no longer allowed. Bug: 366623 Change-Id: I5cda160d1a8c8a66a6c841d91a8e05461d12e33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544886 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#647038}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/83f899ce0f61..7a292fcdb49f git log 83f899ce0f61..7a292fcdb49f --date=short --no-merges --format='%ad %ae %s' 2019-04-02 bgoodwin@google.com Promote Littlejoe and viking boards to important, since they've shown themselves stable. 2019-04-02 zamorzaev@chromium.org Revert "chromeos_config: Enable Skylab for CTS qual tests" 2019-04-02 mikenichols@chromium.org repository: Allow fetch-all to fail silently 2019-04-02 mikenichols@chromium.org chromeos_config: Migrate release builders back to Prod bot group 2019-04-02 yueherngl@google.com nami: add builder for firmware-nami-10775.108.B branch 2019-04-02 zamorzaev@chromium.org chromeos_config: Enable Skylab for CTS qual tests Created with: gclient setdep -r src/third_party/chromite@7a292fcdb49f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I02666cd40d4bfc1ba31cb585bb6e9872fba2c86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549780Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647037}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e30d05137000..422c432dd25d git log e30d05137000..422c432dd25d --date=short --no-merges --format='%ad %ae %s' 2019-04-02 jmadill@chromium.org Add ANGLE revision to gclient config. 2019-04-02 nodir@google.com [bot_update] Set output commit of the build 2019-04-02 tandrii@chromium.org Revert "git cl status: differentiate "dry-run" from generic "commit"." Created with: gclient setdep -r src/third_party/depot_tools@422c432dd25d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:940214 TBR=agable@chromium.org Change-Id: If9f7824e7136f41d0e7bf17b0c2e9a868ae53c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549351Reviewed-by:
-
Natalie Chouinard authored
The Asset and Offline Page Downloads suggestions are no longer used on the Simplified NTP. A follow-up CL will mark the DOWNLOADS category as deprecated. Bug: 947080, 947082 Change-Id: I665f6b67a96d6206a4d1e203d6275b171c1346e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544613 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#647035}
-
Jia authored
We will soon use finch flags to run experiments. This cl removes the "special" treatment to atlas, so that it will enabled/disabled from finch. Bug: 881215 Change-Id: Ib45eb0c40aea0ad993df0c5cb2a430ab52047a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546792 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647034}
-
Anastasia Helfinstein authored
Bug: 914658 Change-Id: I34859660184fd3d1ac4d97cd1febf899665927b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548600Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#647033}
-
Jimmy Gong authored
- Moves the existing user provided PPD file name to its input field for consistency. - Deletes text that displays the currently selected PPD file in edit dialog. Bug: 947748 Change-Id: I94f4e747c9f8131138503fde18d3970a23b9c8a8 Tests: end to end Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546773Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#647032}
-
Tommy C. Li authored
These two calls to GetSecurityLevel(false /* ignore_editing */) can be harmlessly flipped to GetSecurityLevel(true /* ignore_editing */). In both code contexts, it's already established that the user is NOT editing the omnibox contents: - iOS View has an if-statement that does that. - CustomTabBarView is read-only, so cannot be edited. We are flipping them to GetSecurityLevel(true), because in the future, LocationBarModel will always ignore edits, and this call will not take any parameters. This is part of a larger plan to make LocationBarModel no longer track the user's edit state, but instead always return the secure display information for the current navigation state. Bug: 912722 Change-Id: I79850334430edb5497aca6033001f8b4c02e5065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549618 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#647031}
-
Maggie Cai authored
This CL restores the unit test temporarily removed with the refactoring in https://crrev.com/c/1517332 BUG=939205 Change-Id: I36c517fcd46d996d4ecb1d1977fbd5e52694b464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534589 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#647030}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1044ce07764d..4a9952abf1d0 Created with: gclient setdep -r src-internal@4a9952abf1d0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=alexmos@chromium.org,calamity@chromium.org,adithyas@chromium.org,grunell@chromium.org Change-Id: I59079ac60821938fe334378240823cdf72f1684d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549452Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647029}
-
Matthew Jones authored
Bug: 930785 Change-Id: I0382107c143dd8fc272eadee9e273eef42bef449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549695 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#647028}
-
dpapad authored
The inner button was used as a work-around for a Blink setPointerCapture() bug resulting in an unexpected 'click' event to be fired. The bug is now fixed and therefore the work-around is not needed. direction of the knob). Toggle's state should not change. Bug: 689158 Test: pointerdown on the toggle, pointerup outside the toggle (towards the Change-Id: I76203f288bb4c0c2719a8a56c8cd24eb0330893e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549206Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#647027}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/57a7c38dd51c..e1fc0b0b3dfc git log 57a7c38dd51c..e1fc0b0b3dfc --date=short --no-merges --format='%ad %ae %s' 2019-04-02 oysteine@chromium.org Allow setting trace buffer size for trace-based metrics 2019-04-02 sadrul@chromium.org vinn: Speculative fix for windows. Created with: gclient setdep -r src/third_party/catapult@e1fc0b0b3dfc The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:946517,chromium:946012 TBR=sadrul@chromium.org Change-Id: Ide9c1648a0084783a4cd10ce1133dbb1c6b76089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549451Reviewed-by:
-
John Abd-El-Malek authored
This isn't used by any code after r646920. Bug: 825242 Change-Id: Ib99ca22bad4c01df1e57e8302a33a9b82f413cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546252Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#647025}
-
Raymond Toy authored
Add some documentation on how we handle tail processing of nodes so that the output state is flushed instead of abruptly producing silence for nodes that have state. Bug: 946609 Change-Id: I27bdb082fa05ecd9f1870d2abdb13d9f77da86aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548537 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647024}
-
Mike Wittman authored
Allows the native unwinders to be used to unwind from arbitrary frames, not just from the context frame. This is required to support restarting native frame unwinding after v8 unwinding. This is a reland of 8967586b with a fix for an MSAN crash. Bug: 909957, 948302 Change-Id: If0172f8ffac4f056817d32de0c6ef27d403843b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540285 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#646333} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549684 Cr-Commit-Position: refs/heads/master@{#647023}
-
David Benjamin authored
C++14 extends std::set to fix the std::unique_ptr problem. No sense in paying an O(N) removal when we have a std::set. Bug: none Change-Id: I5e98830cdc1d989bbc9b68a84932c2f8d388b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534113 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#647022}
-
Yaron Friedman authored
Adds handling for a new intent action to launch the dino game, only enabled on notouch builds. In addition if Chrome is launced this way, don't show error message. BUG=938182 Change-Id: I50bc9f41d42d0aa9b7e6ce48280a27a3c35faebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543451Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#647021}
-
Jared Saul authored
Also gives jsaul@ owners over autofill_payments_strings Bug: 940042 Change-Id: Ia9410d5c9920f3b64deec7551ece2069ce402444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536760 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
This reverts commit 03f18d65. Reason for revert: causing chrome crash Original change's description: > Register Alarms Timers Manager event listener for timer events. > > Bug: b:119116816 > Change-Id: I00359bb21a310fb230459d8f651d50a01d45e5fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1461505 > Commit-Queue: Li Lin <llin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645599} TBR=dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,llin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 948857 Bug: b:119116816 Change-Id: Ida4cb1ab90cebb2a54335376497d98a77d056a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549570 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#647019}
-
Scott Chen authored
Bug: 876253 Change-Id: I4bb7bee11315717cdc9cd8875104fbdfc1c681d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546611 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#647018}
-
Dana Fried authored
Before, GetThemeProvider() from any view in the bubble would result in an invalid theme and placeholder colors (i.e. bright red). There is probably a better way to handle this and I'm open to suggestions but we're starting a user study on hover cards tomorrow and I need a reasonable way to get at the theme colors. Bug: 948859 Change-Id: Iabc504d4d812e5cba3389a5cfc008452a793ea3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549600 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Liquan(Max) Gu authored
The main change in this patch is to change the type used in image/text's queue for paint time. The type used to be node-id, this patch changes it to be the record pointer. The purpose of this change is to avoid exposing node id after turning text/image into record. This will lay the ground work for supporting the tracking of background image individually. Avoiding node id will help to make background-image and non-background-image handling more consistent. Others: * insert --> emplace * push --> emplace Bug: 936149 Change-Id: Ia71af7100e84bcd24c29bc55e4b9ef6d1f24b7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544877Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#647016}
-
Marcin Wiącek authored
Patch is making APK smaller by moving ICON_MAP, DEFAULT_APP_CAPTION_MAP and FALLBACK_CAPTION_MAP maps to functions inside file mentioned in the header. Benefit: -132 bytes main dex size -333 bytes normalized apk size InstallSize: -201 bytes APK size -356 bytes Estimated installed size (Android Go) -734 bytes Estimated installed size InstallBreakdown (-814 bytes): -1 bytes Package metadata size -813 bytes Java code size Dex: -3 entries fields +2 entries methods BUG=948866 Change-Id: I2c576fd1597cc9a053ca1cb858091cbbc444a962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545927 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#647015}
-
Becca Hughes authored
Disable the expanded notification if we do not have enough actions to display it. Also changes the way actions are displayed to use priority based ranking and space allocation. BUG=897836 Change-Id: I5c01fee93b38e71f8499057e25d1753338553074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546131Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#647014}
-
Parastoo Geranmayeh authored
Change-Id: I1473cd38549de68340b209a1f62bdc5260f612d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548548Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#647013}
-
Miyoung Shin authored
The overflow of the integer type would make the crash since base::CheckedNumeric was added at https://crrev.com/c/1520847, and the previous patch pulled out the potential crash issue by clusterfuzz, and the total fixed size was fixed at https://crrev.com/c/1526065 to prevent from the overflow but other total sizes have still the overflow issue. This patch changes int type to int64_t for a total percentage size and a total relative size of the grid's columns because each column could have a maximum value of |int| type. Fuzzer report: https://clusterfuzz.com/testcase?key=5719192052563968 Bug: 946874 Change-Id: I4395d3283868e71e41393046203917dddd2ba8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547538Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647012}
-
Avery Musbach authored
Minor refactoring to address inconsistencies in how code is written. Test: manual Change-Id: I90a1617a4aa04fe1fe6a9afa48b55875ec817ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548329 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#647011}
-
Kent Tamura authored
If a renderer process crashed just after creating FileChooserImpl, FileChooserImpl::RenderFrameDeleted() is called and render_frame_host_ is cleared. Then a mojo message for the FileChooserImpl might be processed, and FileChooserImpl::OpenFileChooser() or EnumerateChosenDirectory() is called with null render_frame_host_. We need to check render_frame_host_ nullness in them. Bug: 945201 Change-Id: I7282784642f5259d19ae2fbfdec3ff72d4994f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547542Reviewed-by:
-
Mike Dougherty authored
The workaround is no longer necessary because WebState::SetKeepRenderProcessAlive(bool) can be used to ensure the web view stays alive. Bug: 944077 Change-Id: If4190287cde7887b997b55d1cac5866d416de956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549613 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#647009}
-
Chris Harrelson authored
If a table cell spans multiple rows, then the row needs to expand its visual overflow to include the visual overflow of that cell, even if the cell is self-painting. This is because the table row is the delegated painter of the background and collapsed borders of such cells. Bug: 947713 Change-Id: I690991de15ad4c527a8647ab11e5fb302269a2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548868 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#647008}
-
Siddhartha S authored
BUG=925148 Change-Id: I5c6359eec2f406fa19e88d047386465d2e0df9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542963 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#647007}
-
Brian White authored
Bug: 695880 Change-Id: Ibe5caeb8b9033c3c0527c716feb2364c0243a354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548246 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#647006}
-
khmel@chromium.org authored
This analyzes CPU events from system tracing and reconstruct CPU events model. TEST=Locally BUG=b:122555793 Change-Id: I8f5a7de6650dd41297d414f0ee1907731a54b613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546871 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647005}
-
