GitLab

A touch event can be blocking or non-blocking. They can be sent to the
main thread if the compositor determines that the main thread must know
about the event. If the event is sent as blocking, the browser will
avoid dispatching further events until the main thread responds by
ACK'ing the event. This allows author script to call preventDefault to
change how gestures are dispatched. A non-blocking event is sent to the
main thread but as purely informational; the main thread won't ACK the
event and the browser won't block before dispatching successive gesture
events

The compositor can turn a blocking touch event into a non-blocking one.
This is done while a fling is in progress to prevent janking fling
boosting (see https://crbug.com/595327). In this case, if a user touches
down during a fling we want the browser to dispatch scroll events
immediately without waiting on an ACK so that the scroll can continue or
boost the fling without interruption. The compositor does this by
setting the touch as DID_NOT_HANDLE_NON_BLOCKING_DUE_TO_FLING which will
cause it to be forwarded as non-blocking to the main thread.

Compositor touch action[1] lets the browser receive an ACK from the
compositor to let it know a set of "safe" whitelisted touch actions that
can be dispatched before the ACK from the main thread arrives. This
allows scrolls to be dispatched with less latency in some cases if the
compositor can determine that the main thread won't block certain touch
actions. The whitelisted touch action is sent back to the browser at the
same time as the event is forwarded to the main thread.

The bug here is caused by the whitelisted touch action not accounting
for the "non-blocking fling" behavior. When the touchstart hits a
blocking region (e.g. non-passive event listener) the whitelisted touch
action set to kNone (the compositor can't guarantee the main thread wont
block any gestures)[2,3]. However, if we're in a fling the event will be
made non-blocking so that the main thread *cannot* block scrolls. Worse,
because it's non-blocking the main thread won't ACK the event at all so
the browser will block dispatching any gestures until a new one is
started.

This CL fixes the issue by setting the whitelisted touch action to kAuto
(allow all) when we enter a "non-blocking due to fling" state.


[1] https://docs.google.com/document/d/1bSv_qNsLLnpXImuH7sHa6D3R_0GdDYkTiNjxso8Rgxo/edit#heading=h.jvxrm66og6z0
[2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_object.h?l=2229&rcl=b9275f87a13183e295a7a55bc6cef6eaea4ed86c
[3] https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.cc?l=1016&rcl=25ed318ba5c24057ea2a402c62f25649fda5093f

Bug: 1048098
Change-Id: Ifa2fdd2fb7124f6f350f05e08f905229731297bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132843Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756833}

This CL introduces the concept of a compositor IO seqeuence for the
Paint Previews compositor. Functionally this sequence is used to
interact with the compositor and serializes/deserializes mojo responses.
This is critical to ensuring bitmaps are not deserialized on the UI
thread as they can take up to 1 second to deserialize.

I'd like to avoid exposing the sequence to callers if acceptable as:
- This avoids confusion about what sequence the mojo::Remote is bound to
- This helps ensure weak ptrs and callbacks are handled on the expected
  sequence (caller's sequence) rather than the sequence on which the
  remote is bound.

The low test coverage is somewhat incorrect as this code is covered via
a javatest.

Bug: 1068180
Change-Id: I01fe9ef5f8918656a8821f95f1f850d65b8995e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136090
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756832}

This change removes a DCHECK from the result of updating Progressive
Web App (PWA) launchers, to prevent debug builds of Chrome from
crashing when an update fails.

PWA launcher update could fail for any of the following reasons:
* Latest launcher version path does not exist
* Failed to create a temporary directory
* Failed to rename any launcher path to "_old"
* Failed to create a hardlink/copy of the latest launcher

Because some of the above failures are file operations that could
reasonably fail, a DCHECK on their success is misleading as it implies
"this should never happen".

A more appropriate way to handle update failure is to stop the update
(without crashing) and emit a UMA metric indicating the failure
reason. This change adds TODOs for that as a next step.

Bug: 1067241
Change-Id: If2f2145fc62619618917c80f26234930d3a26d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134584Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#756831}

Bug: 1055540
Change-Id: I03621fa68a0606b210e31e0d45a8b0e78228c355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134573Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756830}

This CL allows for HDR to be queried with MediaCapabilities.decodingInfo
with hdrMetadataType, colorGamut, and transferFunction. Both Blink- and
Media-side changes are included. The feature is flagged by
MediaCapabilitiesDynamicRange.

Bug: 1048045
Change-Id: I9f144726bbc7aaead4dcc1c9f69cf536da1bf2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035053
Commit-Queue: Vi Nguyen <ving@microsoft.com>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756829}

It's present during the initial model load.
We'll need to add the load-more spinner logic
later when we have load-more loading logic.

I went ahead and removed UiEvent since we are moving away
from using protos for events.

Bug: 1044139
Change-Id: I1a180b601cf34d16ef8e58e119577195c39f0cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136033Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756828}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb7cf9786cf1..4b1d2c8a9015


Created with:
  gclient setdep -r src-internal@4b1d2c8a9015

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com
Change-Id: I2bf02fc7548b98cbe923b8b1f8e6fb26b5352b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137666Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756827}

We need to handle it in the browser for navigation redirects;
which by upcoming security rules means that the network service
should parse it, which requires the code to be in services/network

The renderer also needs to parse it, so it needs to be in
services/network/public/cpp.

Also ParseAceptCH got split into ParseAcceptCH and FilterAcceptCH along the way,
since it feels like network service shouldn't know about browser
experiments on what hints to support.

Bug: 1050726
Change-Id: I4b10ce6ddf97efd852a44d4c8a4f85a9a6a0c404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124734
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756826}

(Making it save/restore them along with regular UA overrides).

Bug: 1061917

Change-Id: I97d11d52d522a83a49221e25612a833e311836d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118586Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756825}

Disable the test on ASAN and MSAN due to flaky.

Bug: 1067461
TBR: rsorokin@chromium.org
TBR: xiyuan@chromium.org
Change-Id: I37fd5dbf1d9a8a8d5898c4ada97461fb300cf532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137917Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756824}

Gives hosted webviews the same facility that normal cast applications
have to enable devtools debugging for themselves and their inner
contents.

Bug: internal b/152230325
Test: manual
Change-Id: I80b60c0d26d5de6183325c7dfb36ced3b459de35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136140
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756823}

This CL plumbs the image loader, a wrapper of image fetcher, to tile
service.

Bug: 1058534
Change-Id: I1fa98246bf5f9527a9d15bdf9b88c15180e8b5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137672
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756822}

Change-Id: I9d6530e96c781b3be2f5d5363950569a9a64175f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137485Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756821}

These tests end with an asynchronous close of the dialog's widget.
This means that, depending on the current weather, either the view
under test (owned by the widget) will be destroyed before or after
the test ends. This *currently* doesn't usually cause problems,
because Widget::Close calls DialogDelegate::Cancel, which sets the
object's state so that ~ExtensionInstallDialogView doesn't do
anything. However, if ::Cancel is ever not called, these tests will
start to flakily pass or fail depending on whether the async close
finishes before or after the test ends.

This change causes the tests to wait for the close to complete, to
make their execution deterministic.

It also removes some dead code. As part of "fixing" issue 851167,
r566186 added a MAYBE stanza for one of these tests, but never
actually used it.

Bug: 851167
Change-Id: Ifeac4c7791a79ea8a7c9fab7c398ea87bd62646a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136866Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756820}

Bug: 1063566
Change-Id: I631ba68718cf69c5972555d7826b089e27fa5150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137872Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756819}

This is a reland of 5d12d84a

Original change's description:
> Make chrome://terms on Chrome OS same as on desktops
>
> To show "Google Chrome and Chrome OS Additional Terms of Service"
>
> Bug: 1058348
> Change-Id: I1b37825fe6970bbc7cc59f0c1b26041e350c8fa4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132419
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756677}

TBR=alemate@chromium.org,tedchoc@chromium.org

Bug: 1058348
Change-Id: I5af75f5a1e503e4a0f6b125aba749e610e7319a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138012Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756818}

This CL adds Jobs API perftests as a way to show use case and
measure performance overhead.

Local results (mac laptop):

Naive:
No-Op = 4627 tasks/ms
BusyWait = 793 tasks/ms

Dynamic:
No-Op= 14771 tasks/ms
No-Op disrupted= 14285 tasks/ms
BusyWait= 791 tasks/ms
BusyWait+disrupted= 750 tasks/ms

Loop around:
No-Op= 14044 tasks/ms
No-Op disrupted= 13386 tasks/ms
BusyWait= 773 tasks/ms
BusyWait disrupted= 729 tasks/ms

Change-Id: I0d625293fa95dc5a4f4f8dfc01eb84b9b5d438f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943539Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756817}

This CL attaches the Kaleidoscope tab helper when Kaleidoscope is
enabled.

Bug: 1053587
Change-Id: I1cc9b39df58ff754298e14b647527dfd913c477b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132376Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756816}

This changes how deps checking is implemented for mojoms, though
functionally the end result is the same.

Given write_file's support for JSON emission, sources_list and
deps_sources_list files are now combined into a single JSON "build
metadata" file for each target. These are accumulated recursively
and used to derive a set of acceptable imports against which mojoms are
checked during an intermediate build step.

This CL moves the logic from mojom_bindings_generator.py to
mojom_parser.py and rolls it into the parsing step rather than being its
own separate build step.

Bug: 1060471
Change-Id: I4a6ae5e719c819b7db893c4e64ca013262b83688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132957Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#756815}

Bug: 1053262, 1053263, 1050654
Change-Id: I14071508b62855d65349763aae50c3a11dec8b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136120
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756814}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7767e4fa4792..029854ebc997

git log 7767e4fa4792..029854ebc997 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 mathias@chromium.org Follow punctuation standards for release note text

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@029854ebc997

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I32b5064f50420badffee0fb932d04556567aab7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138051Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756813}

CL:2134417 and predecessors fixed ProvidePictureBuffersWithVisibleRect()
so that GetRectSizeFromOrigin() is used to calculate the texture
dimensions and the coded size of a VideoFrame. However, I forgot to
update the test implementation of VideoDecoder (TestVDAVideoDecoder).
This test does just that to be consistent with CL: 2134417.

Bug: b:153085451
Test: ran video.DecodeAccel.* on kevin, kukui, and veyron_minnie.
Change-Id: I647bed4271da186e0658fb5ba03e5c991f27d6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136846Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756812}

Bug: 1052429
Change-Id: Ie47119c0352f94b4120f104f31726b3a991fabdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137813
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756811}

This change fixes flakes found in the ConversionHostTest suite. These
flakes are currently caused by a race between storage initialization and
test profile deletion. If the test profile is deleted prior to the
storage initialization task finishing, the task can hang in the middle
due to so undefined behavior of operating on the db causing the test to
timeout.

These tests do not need a real ConversionManager and only require
a valid pointer. This change allows ConversionHostTest to specify a
TestConversionManager which is injected via new layer of abstraction,
the ConversionManagerProvider. It also switches ConversionManager to an
impl pattern rather than marking all methods virtual.

This test manager does not need to
initialize a storage layer, fixing the timeout issue.

This is also a pre-requisite for https://crrev.com/c/2012883, which
requires a mock manager to fully test ConversionHost functionality.

Bug: 1051334
Change-Id: I376382c2d859e7c2ee8512227d40657082348310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135061
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756810}

There are two deduplication steps currently in the filter list
generation procedure. One simply removes duplicated rules. The other
consolidates rules that differ only by the domains to which they apply.
The removal of duplicated rules should be done before the consolidation
step as the current ordering can lead to domains being repeated in a
rule.

Bug: 1067711
Change-Id: I3126e28f8232c0b5eaf8c021432542fad4e5ca03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134776Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756809}

The user policy will control the permission for using ADB sideloading on
a per-user basis. It currently has two possible values, 0 (disallow) and
1 (allow), but it is of type int-enum to allow future extensions.

Apart from this policy the behavior is controlled by the type of the
user. Additionally a separate device policy will be added for managed
devices.

The functionality for managed ADB sideloading is currently hidden behind
a feature flag.

This CL only contains the initial definition of the policy and the
corresponding preference, along with wiring them together.

Bug: 1053908
Change-Id: I7a24468adb6ba5374e3a4c1561e94c18e4330093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122528
Commit-Queue: Jana Grill <janagrill@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756808}

The ExtensionApiTest.ContentScriptStylesInjectedIntoExistingRenderers
was disabled on 2012-06-22 for being flaky. It is no longer a valid
test.

Bug: 120762
Change-Id: Id3b89ec7e04a83c1b38cea3d671672b7ca3277c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132670Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756807}

Bug: 1044139
Change-Id: I5b8c19c2f57f6dc1e713df96f5ece54298a69a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138151Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756806}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/26e6018d..6be23fae

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5f5c5f8d74e34fdc7f3b2ad9b83cf93d62eb68f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136430Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756805}

TBR=rsleevi@chromium.org

Change-Id: I824978c39a257e4c8a1fe2809cf5fad38ca300f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137549Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756804}

With the new suggestion headers that are coming, go/omniboxtransparency,
some rows are going to have need to paint headers above the
OmniboxResultView.

I considered adding the header to OmniboxResultView, but this didn't
make sense for reasons detailed in some in-code comments.

So I'm adding a new lightweight OmniboxRowView class to be a parent of
both the OmniboxResultView and the optional header View that sits right
above it.

The header View is not implemented yet.

Bug: 1052522
Change-Id: I693fa2dec0aa194da69f5fc744fe1099817f5ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130814
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756803}

Bug: 1067102
Change-Id: Ie2ea46a7973577421ce543b8bccf1850543480ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134686Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756802}

Adds the button as specified by the doodle specification. Button doesn't
do anything yet. Button action will be added in follow up CL.

Bug: 1039910
Change-Id: I62bf6379c9c36fce2cd3ad0e53a2d471f0dea140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135903
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756801}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f175adffa9d2..c2fb0f637ece

git log f175adffa9d2..c2fb0f637ece --date=short --first-parent --format='%ad %ae %s'
2020-04-06 rharrison@google.com Rolling 5 dependencies and updating exceptions (#1035)

Created with:
  gclient setdep -r src/third_party/shaderc/src@c2fb0f637ece

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I5e8bde85db0cb708da69eb89054ece35b83335cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137662Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756800}

This arg is almost enabled on all platforms (except Fuchsia) and
actually controls very few files. Most of the mojo media related
features are controlled by subsidiary buildflags like ENABLE_MOJO_CDM.

This CL removes this arg to make the code cleaner.

Bug: 1067786
Change-Id: I49cb56afefc08902734ab861c87cbbf98cc6366f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133851Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756799}

From M83 to M88.

TBR=morlovich@chromium.org

Bug: 953306
Change-Id: Ic2fa5a9a841dbf0fbb4831f5f2d181cc141090d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135837Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756798}

Add a pixel diff threshold to NTP render tests to mitigate flakinesss on
Android CFI bot. Additional detail in linked bugs.

Bug: 945293, 1068294
Change-Id: Ia49455905dbb9f3ce2ff1809a73c8b0f30ff7f6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137811Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756797}

* Change the string of the button of the safety check password check
  child from "Change password(s)" to "Review".

Bug: 1015841
Change-Id: I32a9cc39fd078d53828d8c4e6b7bc8f8bfa897c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132384Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756796}

Bug: 1066200, 1045608
Change-Id: I953209f3da2799fdf8b4383794023c33b010dab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134615Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756795}

(This fixes a linter complaint from crrev.com/c/2136864. An alternative
would be NOLINTing the constructor.)

R=jbroman

Bug: None
Change-Id: I4a950ecf92062da310e5fc9c8631cbe9e5041443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136044Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756794}