- 02 Jul, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/079d2806..39f347b1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6b6761fd02398509e246ece9c90b2f24f31957dc Reviewed-on: https://chromium-review.googlesource.com/1123033Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571974}
-
Christopher Cameron authored
This is no longer needed. Bug: 859152 Change-Id: I31001d0a03b3ef5dfbea81f3d68f7d2d4af538a9 Reviewed-on: https://chromium-review.googlesource.com/1121957Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#571973}
-
Lei Zhang authored
Change-Id: I2d2be9d78f2fdc36929fafac0986b4b58ca0efa2 Reviewed-on: https://chromium-review.googlesource.com/1121635 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#571972}
-
Becky Zhou authored
+ Update button background, icon tint, toggles color to #1A73E8 Bug: 834884 Change-Id: I8f7ed70245926edcf8336cd962526463573df174 Reviewed-on: https://chromium-review.googlesource.com/1119200 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571971}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/621c9d28c3d0..d38a2da9f150 git log 621c9d28c3d0..d38a2da9f150 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 sergiyb@chromium.org Use cwd from context instead of kwargs Created with: gclient setdep -r src/third_party/depot_tools@d38a2da9f150 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:793687 TBR=agable@chromium.org Change-Id: I442d01dd680b1af267783424256013ba00b69252 Reviewed-on: https://chromium-review.googlesource.com/1122898Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571970}
-
Scott Chen authored
Detect focus or blur in a more straight-forward way. Bug: 857424 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5be06c7cdbdbaedf20a1c6bc9198bcc539c1be32 Reviewed-on: https://chromium-review.googlesource.com/1119160 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571969}
-
Stephen Martinis authored
This reverts commit 89c5e790. Reason for revert: Testing possible fixes Original change's description: > Revert "Reland "gtest perf tests: Output well formed test results json"" > > This reverts commit f02c92e1. > > Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315 > > Original change's description: > > Reland "gtest perf tests: Output well formed test results json" > > > > This reverts commit 9eeaba4e. > > > > Reason for revert: Will re-land with fix > > > > Original change's description: > > > Revert "gtest perf tests: Output well formed test results json" > > > > > > This reverts commit 71b865f4. > > > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) > > > > > > Original change's description: > > > > gtest perf tests: Output well formed test results json > > > > > > > > This CL changes the run_gtest_perf_test.py script to output well formed > > > > test results json. > > > > > > > > Bug: 855234 > > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > > > > Reviewed-on: https://chromium-review.googlesource.com/1112635 > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#570943} > > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 855234 > > > Reviewed-on: https://chromium-review.googlesource.com/1118238 > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > > Cr-Commit-Position: refs/heads/master@{#571083} > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 855234 > > Reviewed-on: https://chromium-review.googlesource.com/1118789 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#571245} > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 855234 > Reviewed-on: https://chromium-review.googlesource.com/1119445 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#571321} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1120798Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#571968}
-
Erik Luo authored
- Non-empty text filters retain their blue outline even when not focused. - Searching the the StylesSidebarPane no longer highlights the toolbar yellow, just the selector/prop matches. Screenshots: https://imgur.com/a/suybNVy https://imgur.com/a/s0R04ar Bug: 808159 Change-Id: I7dc5b89ca96ca181e767bd271cd648bee4cb0ca1 Reviewed-on: https://chromium-review.googlesource.com/1060574Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#571967}
-
kristipark authored
Bug: 854009 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I79ac7258d3b35541f0c87188e0cfe944e31635d9 Reviewed-on: https://chromium-review.googlesource.com/1122958Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#571966}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3836c556c4c6..a14d6738e1fb git log 3836c556c4c6..a14d6738e1fb --date=short --no-merges --format='%ad %ae %s' 2018-07-02 nednguyen@google.com Rename benchmark @Owner decorator to @Info decorator Created with: gclient setdep -r src/third_party/catapult@a14d6738e1fb The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859524 TBR=sullivan@chromium.org Change-Id: Id18e3580f596b177fa3173041ddd596bb3d638de Reviewed-on: https://chromium-review.googlesource.com/1122996Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571965}
-
Ryan Sleevi authored
CachingCertVerifier::AddEntry is now dead code after r571588 BUG=590875 Change-Id: I4e5bc5845e7ca33972e768ae619033f447cda744 Reviewed-on: https://chromium-review.googlesource.com/1122696Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571964}
-
Xiaocheng Hu authored
Bug: 859233 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifefe2b4f1b25627c53a467c27937271de9efe450 Reviewed-on: https://chromium-review.googlesource.com/1121584 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571963}
-
Sky Malice authored
Bug: 831648 Change-Id: I2ca7dd2fd1422fa44b0b5e297a0ba8bd7ac196e3 Reviewed-on: https://chromium-review.googlesource.com/1102003 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#571962}
-
Xianzhu Wang authored
I have confirmed that the unused adjusted_paint_offset is not a code error. It had been used to calculate bounds of DrawingRecorder before https://chromium-review.googlesource.com/729322. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id9f0c71e36842e30f9c96fd093f209c90a276209 Reviewed-on: https://chromium-review.googlesource.com/1122965Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571961}
-
Kurt Horimoto authored
This CL updates ReadingListMediator to support both UICollectionViews and UITableViews. Additionally, ReadingListDataSource and ReadingListDataSink have been updated to use ReadingListListItems rather than CollectionViewItems. ReadingListMediator now takes a ReadingListListItemFactory, which handles supplying the correct subclass of ListItem to the data sink. This item factory will take ownership of the custom a11y action factory as well. Additionally, this CL moves ReadingListCollectionViewController to its own file, and renames ReadingListListViewItem* classes to remove the "View" in their names. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b22768212a03b661a8b60913948eed6116de461 Reviewed-on: https://chromium-review.googlesource.com/1104896 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#571960}
-
James Cook authored
Accessibility values are typically UTF-8 strings. This addresses a comment on: https://chromium-review.googlesource.com/c/chromium/src/+/1118828 TBR=rmrossi@chromium.org Bug: 851578 Test: bots Change-Id: I05f5cf68d5731b3c22956d86da3a2e865cd8bf1d Reviewed-on: https://chromium-review.googlesource.com/1121539Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Emily Hanley authored
Bug: 855063,713357 Change-Id: I79e5e5eac6283493f0eb83771fe6edbde1a0496e Reviewed-on: https://chromium-review.googlesource.com/1122843Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#571958}
-
Becca Hughes authored
Change-Id: Ibd351ecb8565b9dc83fe4a6a4109c8fb376eeb7f Reviewed-on: https://chromium-review.googlesource.com/1122713Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571957}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d818ebf4a317..3913287d8c2c git log d818ebf4a317..3913287d8c2c --date=short --no-merges --format='%ad %ae %s' 2018-07-02 kjlubick@google.com Roll vpython to (speculatively) fix tree Created with: gclient setdep -r src/third_party/skia@3913287d8c2c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I3f50f60a259fb65e90ee80ffc6d93113f835678f Reviewed-on: https://chromium-review.googlesource.com/1122899Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571956}
-
Hasan Khalil authored
Allow users of BBR to change the high gain value for STARTUP. Early versions of BBR used 2, which may be preferable for latency sensitive applications. Merge internal change: 202484730 https://chromium-review.googlesource.com/c/1120507/ Add a comment to QuicConnection about why the send alarm is being cancelled. Merge internal change: 202483358 https://chromium-review.googlesource.com/c/1120509/ Deprecate FLAGS_quic_reloadable_flag_quic_use_incremental_ack_processing4. Merge internal change: 202125402 https://chromium-review.googlesource.com/c/1121698/ Instead of triggering early termination based on current smoothed rtt and the rtt upon the start of most recent monitor interval, track the whole rtt inflation period, during which the latest rtt sample keeps being larger than smoothed rtt. This can avoid the case when the rtt inflation is within tolerance with respect to the rtt upon the start of current interval, which in the worst case can lead to continuous inflation until packet losses appear. Update the pcc enable flag with a new one, so that we can check that this change is protected by the new flag. Merge internal change: 202030099 https://chromium-review.googlesource.com/c/1121697/ In QUIC, do not reset ideal_next_packet_send_time_ in pacing sender. Protected by FLAGS_quic_reloadable_flag_quic_donot_reset_ideal_next_packet_send_time. Merge internal change: 201861910 https://chromium-review.googlesource.com/c/1121696/ Mark QUIC app-limited if we run out of data to write after writing retransmissions or queued packets. Protected by FLAGS_quic_reloadable_flag_quic_retransmissions_app_limited. Merge internal change: 201739950 https://chromium-review.googlesource.com/c/1121295/ Deprecate FLAGS_quic_reloadable_flag_quic_send_max_header_list_size. Merge internal change: 201726616 https://chromium-review.googlesource.com/c/1121294/ Add a flag count for FLAGS_quic_reloadable_flags_quic_ack_reordered_packets. Merge internal change: 201725762 https://chromium-review.googlesource.com/c/1121293/ Make sure to force a new port when doing H:P1 -> H:P2 migrations to avoid the case that occurs when binding to the same port. Merge internal change: 201717747 https://chromium-review.googlesource.com/c/1121292/ In QUIC, remove the code path closing connection after 3 RTOs. This has no effect as currently no client is sending the connection option. Merge internal change: 201708082 https://chromium-review.googlesource.com/c/1121291/ Mark all QUIC BBR bandwidth samples in recovery as app-limited if recovery is entered while app-limited. Protected by FLAGS_quic_reloadable_flag_quic_bbr_app_limited_recovery. Merge internal change: 201677811 https://chromium-review.googlesource.com/c/1121290/ Add QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_optimize_inflight_check. Merge internal change: 201632376 https://chromium-review.googlesource.com/c/1121289/ Stop checking QuicUnackedPacketMap::HasUnackedRetransmittableFrames and instead rely on the existing check that bytes_in_flight > 0. Protected by FLAGS_quic_reloadable_flag_quic_optimize_inflight_check. Merge internal change: 201567200 https://chromium-review.googlesource.com/c/1121288/ In QUIC, ignore EMSGSIZE write error. Protected by FLAGS_quic_reloadable_flag_quic_ignore_emsgsize_write_error. Merge internal change: 201533812 https://chromium-review.googlesource.com/c/1121287/ Disable QUIC v42, protected by FLAGS_quic_reloadable_flag_quic_disable_version_42 Merge internal change: 201519801 https://chromium-review.googlesource.com/c/1121286/ In QuicWriteBlockedList, change static_streams_ from a QuicLinkedHashMap to a StaticStreamCollection. Protected by FLAGS_quic_reloadable_flag_quic_use_static_stream_collection_in_write_blocked_list. A StaticStreamCollection is a vector of StreamIdBlockedPair(s) plus a eagerly-computed number of blocked static streams. This is an optimization base on this profile from sof14: https://screenshot.googleplex.com/eaffXNhVcZ8. The parts in the red rectangle are optimized in this cl. - Since number of static streams is small, and they don't change during the course of a QuicSession's lifetime, saving them into a vector ought to make iteration faster compared to QuicLinkedHashMap. This should make QuicWriteBlockedList::IsStreamBlocked faster. - The eagerly-computed number of blocked static streams should make QuicWriteBlockedList::NumBlockedSpecialStreams must faster. Merge internal change: 201519764 https://chromium-review.googlesource.com/c/1121285/ Only send an ack immediately when a previously missing packet is received if an ack with a larger largest acked has already been sent. Protected by FLAGS_quic_reloadable_flag_quic_ack_reordering_packets. Also renames QuicUnackedPacketMap::largest_observed_ to largest_acked_ for consistency with the new field. Merge internal change: 201454269 https://chromium-review.googlesource.com/c/1121284/ Do not log when ack packets get out of order. Merge internal change: 201249046 https://chromium-review.googlesource.com/c/1121283/ Deprecate FLAGS_quic_reloadable_flag_quic_bbr_fix_probe_bw. Merge internal change: 201246814 https://chromium-review.googlesource.com/c/1121281/ Disable QUIC v41. Protected by FLAGS_quic_reloadable_flag_quic_disable_version_41_2 (renamed from FLAGS_quic_reloadable_flag_quic_disable_version_41) Merge internal change: 201241634 https://chromium-review.googlesource.com/c/1121280/ Make a constant drain gain in QUIC BBR settable via set_drain_gain. Not flag protected, no functional change. Merge internal change: 201230613 https://chromium-review.googlesource.com/c/1121279/ Removing unused rtt_variance_weight from QUIC's BBR implementation. It was used when trying to fix BBR's bandwidth crashes due to lack of CWND and is no longer necessary. No functional change, not flag protected. Merge internal change: 201182279 https://chromium-review.googlesource.com/c/1121278/ Deprecate FLAGS_quic_reloadable_flag_quic_bbr_slower_startup2. Merge internal change: 201175853 https://chromium-review.googlesource.com/c/1120999/ Deprecate FLAGS_quic_reloadable_flag_quic_disable_version_38 Merge internal change: 201065250 https://chromium-review.googlesource.com/c/1120998/ Deprecate FLAGS_quic_reloadable_flag_quic_disable_version_37 Merge internal change: 201061334 https://chromium-review.googlesource.com/c/1120997/ Deprecate quic_enable_l1_munge flag. Merge internal change: 201061065 https://chromium-review.googlesource.com/c/1120996/ R=rch@chromium.org Change-Id: I44e2a62fe78e15d6a63c1ce9bc3984fb59cd9fc5 Reviewed-on: https://chromium-review.googlesource.com/1121700 Commit-Queue: Hasan Khalil <hkhalil@google.com> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#571955}
-
Victor Vasiliev authored
The copy on GitHub is a canonical source of truth. Originally, that file was in Chromium source, but I was aware of third parties that were interested in embedding it, so I moved it out to a separate repository. It's currently only used in the unit tests, though it's possible it will be used in stand-alone tool binaries in the future. Change-Id: I74be47f2d317c949732eec44c432a36610650938 Reviewed-on: https://chromium-review.googlesource.com/1086967 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571954}
-
Becca Hughes authored
Launch the Display Cutout API and the media controls cutout gesture on Android. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Fim-KmT08PE/LIHNNXALBAAJ BUG=848890 Change-Id: If799b9ef553ddfdc7a13bd9a355e0f2f67ac6907 Reviewed-on: https://chromium-review.googlesource.com/1122855Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571953}
-
Sky Malice authored
RunCallbackAndroid was very commonly bound into a callback itself, and due to being overloaded, it was difficult for base::Bind to figure work correctly. This change changes each version to have a unique name and updates all call sites. If there was a useless method previously disambiguating this change removes it. Additionally any lint violations were fixed. TBR=nyquist, carlosk, treib, tedchoc, fgorski, boliu, maxmorin Bug: 857155 Change-Id: Ia09c936983b95f466c831bade04821ab29ebb14a Reviewed-on: https://chromium-review.googlesource.com/1117619 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Markus Heintz authored
Bug: 850161 Change-Id: Id7a976c6a3a4430fb263a9f6de317cf1df7d3b8d Reviewed-on: https://chromium-review.googlesource.com/1120501 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Chris Lu authored
Instead directly link button action method to method in tableview in cellForRowAtIndexPath Change-Id: Ic571e8e49190e55bcb86277f2a4846f7b7088dc3 Reviewed-on: https://chromium-review.googlesource.com/1120844 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571950}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09646f2d0497..e353d72449a9 git log 09646f2d0497..e353d72449a9 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 tsepez@chromium.org Use UnownedPtr<> in cfwl_event.h and cfwl_message.h Created with: gclient setdep -r src/third_party/pdfium@e353d72449a9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie8071d0889ebe8744462ee47d28da66f670a8298 Reviewed-on: https://chromium-review.googlesource.com/1122777Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571949}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ic1b7c5c411a37a93371ea623aa3f696b2c365e76 Reviewed-on: https://chromium-review.googlesource.com/1112254 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571948}
-
Ahmed Fakhry authored
- Avoid copying mega bytes of feedback data when sending reports. - Explicitly use OnceCallback and RepeatingCallback when appropriate. BUG=748742 TEST=manual + unittests. Change-Id: I6fb76e50f41f01a6df57e401cbfe1a1033e4db82 Reviewed-on: https://chromium-review.googlesource.com/1121077Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#571947}
-
Douglas Creager authored
When processing a report, we can't assume that the report's origin matches the origin that the corresponding policy belongs to. If the policy uses include_subdomains, then it might be used for reports for any subdomain of the policy's origin. We had a couple of places where we did assume they were the same, and used a DCHECK to verify this. That caused segfaults whenever we tried to process a subdomain report. Bug: 854248 Change-Id: I251d82664c7deee2293144ceed199e084795152c Reviewed-on: https://chromium-review.googlesource.com/1106304Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#571946}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5c71e74331bd..9f2e62402443 git log 5c71e74331bd..9f2e62402443 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 henrik.lundin@webrtc.org Break out NetEqEventLogInput to separate source files 2018-07-02 aleloi@webrtc.org Flags and settings for AGC2 in AgcManagerDirect. Created with: gclient setdep -r src/third_party/webrtc@9f2e62402443 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I21452705d07dd365d790775b31bb98fa6c5d4b71 Reviewed-on: https://chromium-review.googlesource.com/1122896Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571945}
-
Kyle Horimoto authored
Previously, it resided in: //chromeos/services/secure_channel/public/cpp/shared. It was placed in the shared directory because it was planned to be shared with client code, but this ended up not being true. The files are now in: //chromeos/services/secure_channel. Bug: 824568 Change-Id: I380d7f796e42fa775ba69dabe0373f18321b1f84 Reviewed-on: https://chromium-review.googlesource.com/1117864Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#571944}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1e9ed0d8edee50f2ad194ee92bcc248219f9273a Reviewed-on: https://chromium-review.googlesource.com/1122150Reviewed-by:
-
sczs authored
Fixes a TableVIew model inconsistency crash. Whenever an item was inserted somewhere other than the end of the model, a crash occurred. Example: If the item was inserted second to last at index 9, then the tableViewDidInsert value was also 9. This meant that tableViewDidInsert was called twice (once for the item just inserted and once for the previous item) and that the item that used to be at 9 shifted to 10. The problem is that tableViewDidInsert was never called for index10. This was causing an inconsistency crash at the end of tableUpdates. Now we always call tableViewDidInsert with the total count of items, in order to successfully let the tableView a new row as been inserted. Bug: 836562 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3705cf6bd78364f04f99f29393695c1b00d613bd Reviewed-on: https://chromium-review.googlesource.com/1121792 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 851163 Change-Id: I852e1c1bcab17d250ddd5dcb7f69ca7d81d0ccdc Reviewed-on: https://chromium-review.googlesource.com/1122964Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#571941}
-
Matt Swartwout authored
Bug: None Test: Unit tests that add/remove more than 1 observer now pass. Change-Id: I097eaa3bea90501e9325b969963e2e02caf62878 Reviewed-on: https://chromium-review.googlesource.com/1119627Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#571940}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6856800e..079d2806 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I29c241ffaaf3d8a70b62df738cd8719512c55466 Reviewed-on: https://chromium-review.googlesource.com/1122481Reviewed-by:
-
Mei Liang authored
In TasksUma.java, the histogram Tabs.Tasks.TabsInGroupRatio and Tabs.Tasks.TabGroupDensity requires to record sample in integer format and have unit in percent. The code had a casting error when we cast the ratio (in double) to integer first then multiply by 100 to convert the unit to percent. This CL fixes the casting error by multiplying the ratio by 100 first to get the correct unit then cast that result to an integer. Bug: 856275 Change-Id: Id5d1d6a3450e3d733b27ee437f1e0c3f1fb94d0d Reviewed-on: https://chromium-review.googlesource.com/1115800Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571938}
-
Vaclav Brozek authored
When parsing FormData into PasswordForm, the new parser tries to keep results from different types of analysis separate: if autocomplete attributes or server hints only provide the password fields, the parser currently does not try to figure out username with structural analysis. The server data currently lack username quite often, and also autocomplete mark-up often lacks the username. As a result, the new parser fails to find the username in many cases when the old parser could. Once server data improve, this issue will get much smaller (the autocomplete data will also get replaced by server hints). However, it is unlikely that this happens soon enough. Therefore, to keep the effect of the change of parsers in M69 small, this CL adds the ability to merge username from structural analysis / HTML classifier with the results from server hints or autocomplete attributes. The CL also renames ParseResult to SignificantFields, because both "parse" and "result" are somewhat overloaded in this file. The CL further does a few similar minor changes to naming, comments and code structure, in an attempt to increase readability Bug: 845426 Change-Id: Ie5a6297a2f7eb1a0d89421ea91a93bdd5a7112b5 Reviewed-on: https://chromium-review.googlesource.com/1117183 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571937}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bc72265ebab00210b4853cb6f842749351f1f3b Reviewed-on: https://chromium-review.googlesource.com/1122973Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#571936}
-
Nasko Oskov authored
This CL adds a test case to verify that navigating away from an error page properly swaps SiteInstance when error page isolation is enabled. Bug: 838161 Change-Id: Ibe16bf39b24dd1d18666c4383bfba5777f8c965e Reviewed-on: https://chromium-review.googlesource.com/1122840Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#571935}
-
