- 16 Jan, 2020 40 commits
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1041419 Change-Id: I4b2a38df9f4ec3c86b5cf57380f44a1bd271a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994439 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732450}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=sergeyu@chromium.org Bug: 1041419 Change-Id: I75346d1b1f7232a79fc0b335102f05bbd943ebe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998634 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732449}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d203754bc116..3ed344dd784e git log d203754bc116..3ed344dd784e --date=short --first-parent --format='%ad %ae %s' 2020-01-16 cepheus@frii.com Fix #2059, and also attempt to skip test bots [skip ci] 2020-01-16 johnkslang@users.noreply.github.com Merge pull request #2033 from ShchchowAMD/binding_contradictory 2020-01-15 johnkslang@users.noreply.github.com Merge pull request #2058 from KhronosGroup/vulkan-1.2 Created with: gclient setdep -r src/third_party/glslang/src@3ed344dd784e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I9addc7661b6325d01f85b8bb9a06626e54e5017e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732448}
-
Jan Wilken Dörrie authored
TBR=masonfreed Bug: 1026712 Change-Id: Ic310d987a4215d7aff325ece76424bdf6499bc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002916Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732447}
-
Jeremy Roman authored
This reverts commit 4ba80e19. Reason for revert: crashes in content::AncestorThrottle::ProcessResponseImpl are in top 5 crashes on multiple platforms Original change's description: > CSP: Enable out of blink enforcement of frame-ancestors. > > Bug: 1032139 > Change-Id: Iac59a5e6c8452da0cf7e7ebc549a10d8970cc8c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988684 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729823} TBR=nasko@chromium.org,jam@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032139,1041133 Change-Id: Id8eb28a5f2b6fc82ae94e0abb6f6d3c965bc6937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003553Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732446}
-
Xianzhu Wang authored
When creating a paint chunk for a SVG inline flow box, use the inline flow box instead of the containing layout object as the DisplayItemClient because the layout object may create multiple paint chunks for multiple inline flow boxes. Bug: 1039070 Change-Id: I9a4b332205f22d3b57b0794b6d52ddb696835693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002898Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732445}
-
behdad authored
Skip failing tests of vulkan_pixel_skia_gold_test: Pixel_WebGLGreenTriangle_AA_NoAlpha Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear Pixel_WebGLGreenTriangle_NoAA_NoAlpha TBR=bsheedy@chromium.org Bug: chromium:1042693 Change-Id: I9dc03d61a9e28a6b035a33058acff27697f23df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003557Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732444}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pfeldman@chromium.org Bug: 1041419 Change-Id: I45a68dce550384b6788c1d666d39d7dfbd94fb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998858 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1035895 Change-Id: I25bd0b0202540210c698263ef702dec48d62de78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003364 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732442}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1041419 Change-Id: Ic52468b78c9fc7623519e87af64397452228d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997973 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0d2c75f4d56a..01c0d6bd8d7f git log 0d2c75f4d56a..01c0d6bd8d7f --date=short --first-parent --format='%ad %ae %s' 2020-01-16 m.maiya@samsung.com Vulkan: Use dynamic buffers for staged updates Created with: gclient setdep -r src/third_party/angle@01c0d6bd8d7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: Iefb11eb2324fddd9bda9bd8c12c4b4725ee62f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004889Reviewed-by:
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Idd37d5d5624167e836cd49c2887e748f0d966566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001118 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#732439}
-
Stefan Zager authored
GeometryMapper is much faster than MapLocalToAncestor. Running a release build of chrome on my linux workstation, this patch decreases the average run time of perf_tests/intersection-observer/scroller.html by ~65%, and perf_tests/intersection-observer/many-objects.html by ~50%. Change-Id: Ifcc97d02297ce9a5ff205b0178cb524c0570a0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999455Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#732438}
-
Stephan Hartmann authored
Fix compilation issue in GCC with CrossThreadCopierPassThrough and VideoTrackInterface. Bug: 819294 Change-Id: Id453c3a7bc63fc75a0f882af450730ada5b717de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002512Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#732437}
-
David Tseng authored
This recently came up in the Gerrit code review UI (see enclosed test for snippet). Given a node which has ChromeVox focus, this change uses the node's name even when it is generated from contents. Previously, ChromeVox attempted to generate its own descendant name computation which omitted some details. In particular, Chrome uses the nested div's aria-label to mean an override of the static text descendant. Change-Id: I38f96a38915a23448ce1a6302de4cfd67e5089fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001739Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732436}
-
Khushal authored
Importing a mailbox to an SkImage may fail. Null check for that before using an SkImage from AcceleratedStaticBitmapImage. R=fserb@chromium.org Bug: 1034231 Change-Id: Id281a2cbafd79c2ca56b240d7690cf60b1ea2672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001526 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732435}
-
Eric Seckler authored
Now including updated TrackDescriptor fields. Bug: 928738 Change-Id: I3236448bc995732724ecfd576c72d9352956ab03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002523 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#732434}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 1041419 Change-Id: Ifd8d08b1a26e308bf3d25dfa8cb7a4e8e5853a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998199 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732433}
-
Marcin Radomski authored
- Add MixerUnderrun proto for reporting mixer input/output underruns to OutputStreamConnections - Add MixerInput::Source::OnOutputUnderrun virtual method, called on every mixer input whenever StreamMixer detects an output underrun - Add OutputStreamConnection::Delegate::OnMixerUnderrun virtual method, called in response to MixerUnderrun proto simulated poor network conditions Bug: b/142084721 Test: manual verification of values logged from RecordUnderruns() in Merge-With: eureka-internal/350603 Change-Id: I6ad4dcdd573a5a6b9d89baf5f15abac0a109ee92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992068Reviewed-by:Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Marcin Radomski <dextero@google.com> Cr-Commit-Position: refs/heads/master@{#732432}
-
Kyle Milka authored
This also causes the tint to be applied to the third party apps we show in the share sheet: http://screen/gvhOS1M534a.png Likely the tint need to be applied in Java or create separate xml files for 1P vs 3P share options. Bug: 1009124 Change-Id: Ie6e283c1a283efd1ec238bb8f337f77350a2518e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003191Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#732431}
-
Robbie Gibson authored
This CL adds the TextZoomMediator to handle communication between the UI and the FontSizeTabHelper that actually does the zooming. The actual zoom does not happen yet, but that will be added in the next CL. Bug: 1028938 Change-Id: I9e90814990beddd674285d5fdd7025351cc1ce51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991621 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732430}
-
Philip Rogers authored
Painting will early-out unless a non-empty frame size is used. This patch makes the CompositingSimTest setup set a frame size. This issue sunk several hours when writing https://crrev.com/732194. Bug: 1014273 Change-Id: Id1d95daa8c96397bdccc36b0bc498a1ba8a24ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003556 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732429}
-
Leonard Grey authored
Bug: None Change-Id: I3a1e8849a9fe97c44f0fa537124bdca29c4d4ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001178Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#732428}
-
Peter Kotwicz authored
This CL introduces CustomTabTabObserver which observes both the tab (extends EmptyTabObserver) and observes the CustomTabActivity's current tab changing. The new class is useful because it reduces the number of observers which need to be registered/unregistered. The new class is similar to ActivityTabTabObserver. BUG=None Change-Id: I9e7a938c802a119081be46914a78825103753e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001250 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#732427}
-
Tricia Crichton authored
Previously, an additional call to Debugger.enable was needed to take a heap snapshot. But this is no longer needed. Bug: chromedriver:3299 Change-Id: I0c5fd66390ea84370e4a408fe1d44f0a916700a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988986Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#732426}
-
Dan Beam authored
This effectively means that if you cancel the dialog, your checkbox selection changes will be dropped. This is desired and how most dialogs work. Fixed: 35098 Change-Id: I1d3086c86440528e7b6002b177c690d51030f1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003393 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732425}
-
Mikel Astiz authored
The histogram has gathered sufficient information to draw conclusions and has expired already so it can be formally marked as obsolete. Change-Id: I2eaee204d60560c45cc79823b0edb8d8f4bfac23 Bug: 975965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000941 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732424}
-
Ioana Pandele authored
The manual generation tests were broken because the tab view in the keyboard accessory could not be found. This CL changes the matcher used. All tests used to depend on server predictions for filling, which marked the field as eligible for generation or not. This broke when the predictions where not as expected. Bug: 1010540, 1010344 Change-Id: I8ca5392d80b81a67d414eec33cc7a7a2e282d725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995273 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#732423}
-
Theodore Olsauskas-Warren authored
To support adjustments to the clock used by a UserModifiableProvider during testing, the SetClockForTesting function is elevated to be a virtual member of the class. Most subclasses provided this functionality by an identical function, with NotificationChannelsProviderAndroid providing it via custom constructors. This CL refactors NotificationChannelsProviderAndroid local clock to align with other existing subclasses and updates associated test code. Additional changes to the SetClockForTesting on the HostContentSettingsMap allow it to set the clock on all user_providers it is aware of. Bug: 1032584 Change-Id: I068b7179375c0e6ce668ae2f2e4d8c0fcfc71cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000028 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#732422}
-
Jeremy Roman authored
This is already used for determining whether ancestors are permitted. It needs to be used also for figuring out which ancestor's console to log in. A web test that reaches this code using X-Frame-Options: DENY is included. Without the change to content/, this test fails with the same stack trace as in the linked bug. Bug: 1038256 Change-Id: Iad3623d82e0b2192eab626a2184d09d9d3e7be62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002967Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732421}
-
Rodney Ding authored
Bug: 1038837 Change-Id: Ib53707932ff3091a427bbbc1f7bad97d469f10e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995640Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#732420}
-
arthursonzogni authored
1) Merge - content::CSPDirective::Name - network::mojom::CSPDirective::Name 2) Mojo code generation do not forward declare enum nested into a class. The file "[...].mojom-forward.h" do not contain them". To avoid slowing compilation down, this patch makes the enum to be declared outside of the class. See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: I9a3166e86f00577aac78bf29d0e655e5220c754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000025 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732419}
-
Gauthier Ambard authored
This CL fixes the constraints used for the elements at the top of header of the NTP. Some were badly updated after changing using content inset vs resizing of the collection view. Others were broken because the SafeArea of the HeaderView is wrongly updated when the NTP is rotated after scrolling a bit. Fixed: 1041831, 1039795 Change-Id: I5ca7caf3bd41cdcf8c1b1018f32ccf6125d28788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000758 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732418}
-
Sigurd Schneider authored
TBR=yangguo@chromium.org Bug: chromium:1030746 Change-Id: Ie9a933d7ae5423429ad46e2ed533c6ea794b9705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002522 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#732417}
-
Andrew Xu authored
The current minimization animation, which is triggered by going to home screen from in-app shelf, uses the bounds of the icon which corresponds to the active window to be minimized as the animation's target bounds. However, hotseat's bounds change due to entering the home screen. As a result, the target bounds are not the final bounds. This CL fixes the issue by providing an interface to calculate the icon's bounds according to the hotseat's target bounds instead of the actual bounds. There are four ways to show the home screen from in-app shelf: (1) Press the home button. (2) Gesture fling up on the hotseat. (3) Back gesture. (4) Tap on the shelf icon. In case (1), hotseat's target bounds have been set before starting the window scaling animation. In other cases, target bounds are not set yet. Thanks to https://crrev.com/c/1999443, case 3 and case 4 are solved. The last one, case 2, will be fixed in the following CL. Bug: 1030819 Change-Id: I63cafabe6527aba49e9f98e338f9f248284e1d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996268 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732416}
-
Charlene Yan authored
There is currently a border around each part of the visible circle that is part of the button and receives events. In order to have each color have equal target hit sizes, the group modifier container is made slightly larger (to contain the entirety of its children) and then the title field is inset-ted inwards by the same amount. The title field also needs its own container since views::Textfield has special logic for its borders. Bug: 1015634 Change-Id: Ia9431f125da7ee654acf0d327e15e7f1b513c9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999104Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732415}
-
Leonard Grey authored
This reverts commit 0593d72b. Reason for revert: Compiles failing, examples: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1791 https://ci.chromium.org/p/chrome/builders/ci/win32-builder-perf/148062 Looks mostly like ifdefed callsites that weren't migrated. Original change's description: > [base] Migrate PostTaskAndReplyWithResult to OnceCallbacks > > This change migrates users of base::PostTaskAndReplyWithResult to > use base::OnceCallbacks. This allows removing the CallbackType template > from the API, making sure future users are required to use OnceCallbacks. > > TBR=danakj > > Bug: 714018 > Change-Id: I8453c351e406a98fc8b9fddce2637331fdbbf5c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965664 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732403} TBR=lambroslambrou@chromium.org,danakj@chromium.org,jdoerrie@chromium.org Change-Id: I9a417e1d289c750f5ce5e1f43972bf09c0b23e4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004968Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#732414}
-
vitaliii authored
We want to propagate failed commit item errors all the way from server to bridge. This is first step. Propagate failed commit items from NonBlockingTypeCommitContribution to ClientTagBasedModelTypeProcessor. Bug: 1034923 Change-Id: I9599fa09907ee1e59c390559f9a1b7593a815ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985969 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732413}
-
Annie Sullivan authored
These are obsolete now that the experiment has completed. Bug: 1041531 Change-Id: I3669019eba1fbd0b8425a02a6b2deeb0f1f05204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999771 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732412}
-
Florent Castelli authored
Bug: 803494 Change-Id: I8e2997bae643f2b5f2f4ae82a3aff8496dd25483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002573 Commit-Queue: Florent Castelli <orphis@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732411}
-
