- 26 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4224b3bbc76c..fc4e3cf24f9b 2020-09-25 courtneygo@google.com Vulkan: fix ASSERT issue in ResourceSerialFactory 2020-09-25 jmadill@chromium.org Capture commit position into Android Manifest. 2020-09-25 syoussefi@chromium.org Vulkan: Disable MSRTT on AMD/Windows 2020-09-25 m.maiya@samsung.com Vulkan: Add GL_EXT_buffer_storage extension support 2020-09-25 jmadill@chromium.org Suppress flaky Multithread Android end2end_test. 2020-09-25 jmadill@chromium.org Rename version/commit headers. 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from c9f4fb2fccda to 02da53e45d9e (7 revisions) 2020-09-25 jmadill@chromium.org Add ANGLE commit position to version.h. 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 67525bded1de to 9e17b9d07a25 (10 revisions) 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a09406249fa3 to b94db86cf9b3 (1 revision) 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 4dcc12d1a441 to bacaef3237c5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132366 Tbr: syoussefi@google.com Change-Id: I59cb94fbb77410ba5c498acff6c64ed570d6b2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810939}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601066350-493c228f7ec3e1753262b764503b9735ef24657c.profdata to chrome-win32-master-1601078369-47e552b1186c97497a87b26292e838c6fba2ff82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I68e0b05557a43a74668461689a74127a461d8748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432955Reviewed-by:
-
Brandon Jones authored
This method only served to pause inline sessions from updating their poses in VRB. Now that VRB has been removed we no longer need it. Bug: 1017477 Change-Id: I1d93ce690550b5e8c282c4ceacb731b59799dc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422708Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810937}
-
Khushal Sagar authored
Instead of relying on the sync token returned by AcceleratedStaticBitmapImage to ensure synchronization with the raster stream used by skia, perform this when the mailbox is returned. This is temporary to allow merging a safer change to 86 release branch. R=dalecurtis@chromium.org Bug: 1131123 Change-Id: I639a0d864fae29ddb32182aeda5ba2e854b1f5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433049 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810936}
-
Aaron Leventhal authored
Reverts CL:2148035 as it seems to relate to some IPC crashes. The reason is unknown, but this safely reverts the change for now. See repro steps for crash in issue 1094848. The repro steps work on Canary but not for own-built versions. TBR: dmazzoni@chromium.org Bug: 1131848,1094848 Change-Id: I5d13fb13f7b5e9473bdad1f8f80c11a6ca449df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433026 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810935}
-
wutao authored
This patch adds a mask layer to generate gradient fade effect on the media string. Bug: b/167236615 Test: added new tests Change-Id: I4c812c678031d0680c039c2c629aca082550ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414670 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810934}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601034748-5f32abe1706fc69f825acfb2aace1a93eeb5474f.profdata to chrome-mac-master-1601078369-ffc6308083b80c42d5e1d99c83f54bc820d7ceab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8dfd49dd1a4e04980c85a5fb59f27049512c736a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433068Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1131881 Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#810932}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I8efb8969075297d3ac604ad90f80c26f49fee8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431967 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810931}
-
Mason Freed authored
Per some recent spec discussions/changes, declarative shadow roots should manually set the "available to element internals" flag, rather than assuming that in the check. See [1]. [1] https://github.com/whatwg/html/pull/5912#discussion_r489750553 Bug: 1042130 Change-Id: If50fa8bff4cddb566edf95cbd1b1a8f1afe11b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429852 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810930}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib68aa86d6ea08ab6febdd61d768dcc151d0a2906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431669Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810929}
-
Dirk Pranke authored
The GN roll in https://crrev.com/c/2360685 started enforcing visibility of configs, and this caused the compile to break on 'ChromiumOS ASAN Release'. This CL fixes the visibility rule accordingly. Bug: 1132431 Change-Id: Ic702f7a48b4de80a5dba46345ced9f9d9220763d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432670Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810928}
-
Lukasz Anforowicz authored
This CL introduces CastExtensionURLLoaderFactory::Create static method that allows creating an CastExtensionURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<CastExtensionURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing CastExtensionURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I6802fe556698bcba84e8332bcaae4665410c2f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410579 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#810927}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601034748-03f3a1d8372e4cec2560424c34442e7c7e8238b8.profdata to chrome-linux-master-1601078369-72819caf89b317b2996377bd72281bf52f735fa7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I0002816530a7084d890ce01e9dee858170d2c2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432950Reviewed-by:
-
Reilly Grant authored
This reverts commit 412cff1e. Reason for revert: Figured out why the change had no effect. Original change's description: > Revert "serial: Add option to switch enumeration methods" > > This reverts commit fdbcb258. > > Reason for revert: The new flag didn't resolve the issue. > > Original change's description: > > serial: Add option to switch enumeration methods > > > > A potential solution for issue 1119497 is to switch from enumerating > > devices implementing GUID_DEVINTERFACE_COMPORT to using the "bus > > enumerator" identified by GUID_DEVINTERFACE_SERENUM_BUS_ENUMERATOR. > > > > I'm putting this behind a flag so that developers can try it out in > > canary-channel. If it works I can enable it by default and keep the flag > > around for a couple releases in case it causes other problems. > > > > Bug: 1119497 > > Change-Id: Icad9008799ed331c3da15e5a70e0184144c47a58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417460 > > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > > Auto-Submit: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808368} > > TBR=reillyg@chromium.org,odejesush@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1119497 > Change-Id: I3e39d5de932e94b980e7fb5f6de71a2cfa45b0f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423053 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809207} Bug: 1119497 Change-Id: I39bb97d5e1cc5ca5dc971ba2dfad3e9eb987141d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432005 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#810925}
-
Xi Han authored
In this CL, we remove the check of stack tab switcher in TabUiFeatureUtilities#supportInstantStart(). Thus instant start can be enabled in MVP++. These changes can be verified by: - StartSurfaceTest#testShow_SingleAsHomepage_V2__Instant*. The following changes are made to support stack tab switcher in instant start: 1) Defer the creation of TabList in StackLayoutBase. It allows the StackLayoutBase/StartSurfaceStackLayout to be created pre-native. 2) Add pending observer list in TabModelFilterProvider. Any observer which is added before the TabModelFilterProvider is initialized, will be cached and notified when the initialization is completed. 3) StartSurfaceLayout and StackLayoutBase will create its SceneLayer if hasn't yet before calling updateSceneLayer(). Bug: 1116449, 1076449 Change-Id: I42a730045d4b9799d4bb08dc7d7dc947956f42ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356167Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810924}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c826e1a6. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7c8842c2773604122cbf1b5677e3369dd83c235d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432387Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810923}
-
Findit authored
This reverts commit 9d061cca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810917 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlkMDYxY2NhZTAxZGQ2NWE2NjQxMmEyOTE0ZmJhZmFiOTMxOGUwOTUM Sample Failed Build: https://ci.chromium.org/b/8868132345808855984 Sample Failed Step: compile Original change's description: > Roll src/net/third_party/quiche/src/ ba9d95e43..f2e0d90a9 (3 commits) > > https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..f2e0d90a970b > > $ git log ba9d95e43..f2e0d90a9 --date=short --no-merges --format='%ad %ae %s' > 2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets). > 2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed. > 2020-09-25 quiche-dev Fix a latent query-of-death in a GFE+QUIC+Leto codepath > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > Change-Id: I8c71cc9b663b6c2287661a999b7f72a02ecf6579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432758 > Commit-Queue: Renjie Tang <renjietang@chromium.org> > Commit-Queue: David Schinazi <dschinazi@chromium.org> > Auto-Submit: Renjie Tang <renjietang@chromium.org> > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810917} Change-Id: I089d72f0478d9d8b992a18845d6eb9edbe0e8366 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432326 Cr-Commit-Position: refs/heads/master@{#810922}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I5868cb8f31024ff4009be22a58640ab184e800f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432763Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810921}
-
Findit authored
This reverts commit 22e4c40d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810904 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIyZTRjNDBkNWE1NmU4Njg1MDk1MmFlZDNiMDdhZGE3YzNlYzczNzQM Sample Failed Build: https://ci.chromium.org/b/8868133565492231744 Sample Failed Step: compile Original change's description: > [libvpx] Use HighBD config for ARM64 Mac > > Also adds unit tests to cover HighBD support on various platforms. > > Bug: 1128445 > Change-Id: I9951a49f0fca311f48ff55c1618f3d18343dfca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427556 > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: James Zern <jzern@google.com> > Cr-Commit-Position: refs/heads/master@{#810904} Change-Id: I8182741ee91739c9ff313adf35ad9ab8044e081a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432878 Cr-Commit-Position: refs/heads/master@{#810920}
-
Hui Yingst authored
This CL adds supports for navigating to view destinations with fit type 'XYZ' (See table 151 in ISO 32000-1 standard for more details about syntax of "XYZ"), which specifies the coordinates of the page's origin inside the view window and the zoom factor of the page. Bug: 55776,748852 Change-Id: I4f449f006ec9dda4be282aea75c2a6e36a35b87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390997Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810919}
-
Kelvin Jiang authored
This CL logs when declarativeContent actions are added to determine usage of the API and its various action types. Note: showPageAction is not logged because it is converted internally into showAction. Bug: 1127585 Change-Id: I764bc0a518097f20f0b2522bafdf4509653b6afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415227 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810918}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..f2e0d90a970b $ git log ba9d95e43..f2e0d90a9 --date=short --no-merges --format='%ad %ae %s' 2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets). 2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed. 2020-09-25 quiche-dev Fix a latent query-of-death in a GFE+QUIC+Leto codepath Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8c71cc9b663b6c2287661a999b7f72a02ecf6579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432758 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810917}
-
Chris Lu authored
If the Browser is destroyed, then OverlayPresentationContextImpl will soon be as well. Thus, OverlayRequestCoordinator's reference to it will be invalid, so OverlayPresentationContextImpl should remove itself as the delegate. This change also uses __weak references to self InfobarBannerOverlayCoordaintor. Bug: 1129962, 1129788 Change-Id: I082ad3f7acf671b61e23434f918d22d900d5227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427407Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#810916}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5eff1172..e577a1c6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e623f0ef08d8567f63f61aae36714f2835ff5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432426Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810915}
-
Daniel Classon authored
Fix the "Smart lock screen lock options" search tag behavior to only appear when the smart lock feature is enabled by the user and the corresponding options buttons are visible. Bug: 1116553 Change-Id: Ib5a7194b8a97a639ba4df6b96952a92e4fb47270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429935 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810914}
-
Orin Jaworski authored
This CL prevents the Translate page pedal from appearing when the current_url is any builtin chrome:// URL, including chrome://newtab . This prevents bad message crashes when in guest mode (see bug). Bug: 1131136 Change-Id: Id0c05a66d3bd6509c0f5f3b242555607fc6dcec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432209 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810913}
-
Hidehiko Abe authored
According to the document, the zwp_test_input_v1_send_keysym's argument named |code| should be XKB keysym. Currently, XKB keycode is sent, so fixed to the collect one. BUG=1123705 TEST=Ran locally. Made sure expected keysym is sent to client. Change-Id: I9db31cf84b21a7c9a400d75bcbec2fbfe69a2ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432165Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#810912}
-
Lukasz Anforowicz authored
This CL introduces ExtensionURLLoaderFactory::Create static method that allow creating an ExtensionURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<ExtensionURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing ExtensionURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I16565e8200a6d7190d6ce06ea5c0250cef696f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357523Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Michael Hansen authored
This addresses a bug in which advertising was not starting on sign-in. This was because Bluetooth adapter was not acquired in time for the initial round of checks. Bug: 1132063 Change-Id: I6ce9ad8ad9ca5c02a0cb00eb60b8d80f852a355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431586Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#810910}
-
Xiaocheng Hu authored
Finch experiments results on M85 [1] look good, so this patch enables it by default on trunk. A follow up patch will ship in all channels it via finch. [1] https://docs.google.com/document/d/1HenoksopNhJKvUfITMnfBPTllPSNcUVH06yCJB3asj4/edit?usp=sharing Bug: 441925 Change-Id: Ibd4f308875ff89979af83cf7b9a5e74709b5fba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429514Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810909}
-
Kevin Marshall authored
Allows fuchsia-out-dir to be set independent of whether it will actually be consumed by the target type. Targets which don't use external Fuchsia outdirs, e.g. "qemu" and "aemu", simply ignore the arg. Otherwise, the arg parsing step is broken when the "default_fuchsia_build_dir_for_installation" GN arg is set. This is a likely event on x64 builds which run equally well on emulators and baremetal hardware. Bug: 1080854 Change-Id: I4690737a36f7d60c9992421a8752caeffed9084f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402100Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810908}
-
Xiaocheng Hu authored
Following the CSSWG resolution to add metric override descriptors to @font-face, this patch also adds these descriptors as attributes to the JavaScript FontFace interface. Bug: 1098355 Change-Id: Ia5ef4ad870559457834fe9fafaaab79b24a0e08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425484Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aeae3a58e3da..68861e391313 2020-09-25 johnstiles@google.com Add unit tests for assignment and invalid field access. 2020-09-25 mtklein@google.com factor out some helpers in SkVMBlitter 2020-09-25 mtklein@google.com split apart uniformPremul() 2020-09-25 mtklein@google.com to_foo() -> to_Foo() 2020-09-25 bsalomon@google.com Remove deprecated Vulkan GrBackendRenderTarget constructor 2020-09-25 johnstiles@google.com Disallow assignment to unfoldable ternaries in SkSL. 2020-09-25 johnstiles@google.com Fail gracefully when Metal encounters a geometry shader. 2020-09-25 csmartdalton@google.com Move user stencil settings from GrPipeline to GrProgramInfo 2020-09-25 bsalomon@google.com Relax matrix check for fast case in rect blur shader 2020-09-25 fs@opera.com More conservative reverse mapping bounds for SkDisplacementMapEffect 2020-09-25 kjlubick@google.com [canvaskit] Followup feedback from shaping demo 2020-09-25 johnstiles@google.com Remove sk_ClipDistance. 2020-09-25 kjlubick@google.com [canvaskit] Expose Glyph ID APIs 2020-09-25 johnstiles@google.com Migrate setRefKind assignability checker into SkSLAnalysis. 2020-09-25 ethannicholas@google.com moved SkSL Block's data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1087705,chromium:1128962 Tbr: csmartdalton@google.com Change-Id: I12b5fd74673d90dae31183265169e7c072d714ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432796Reviewed-by:
-
rbpotter authored
Bug: 1132403 Change-Id: Ib476e0a84de6e441f82c35029b2952d45a093993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427309 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#810905}
-
Xiaohan Wang authored
Also adds unit tests to cover HighBD support on various platforms. Bug: 1128445 Change-Id: I9951a49f0fca311f48ff55c1618f3d18343dfca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427556 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#810904}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsNetworkSummaryItem* Change-Id: I9b18f35389a7b496a2a656c7fd93fa1738f587aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432659Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I669161cfd6e625dff62cde7b6cb6c79b4c249d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432346Reviewed-by:
-
David Black authored
Previously opening holding space via keyboard would keep focus on the holding space tray and not be able to enter the holding space bubble. Also, we weren't previously watching for destruction of the holding space bubble widget so if it was closed without going through HoldingSpaceTray::CloseBubble(), we got in a bad state. This could happen if the user closed holding space via the ESC key. This has now been fixed. Bug: 1131261 Change-Id: Iad72a25e3798192c111bbdb929b4c70f22dd2c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432678Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#810901}
-
Etienne Bergeron authored
This CL is fixing the fallback selection for Emoji. The problem got introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/2075222 The original fallback implementation rely on CTFontCreateForString(...) over the whole text of a run. This was causing problem since the API on some versions of Mac (see crbug/1036652) is broken with ignorable codepoints (e.g. ZWJ and ZWNJ on arabic script). The skia implementation is calling CTFontCreateForString(...) but over a single codepoint. An algorithm is trying to find the best match by taking the font with the most codepoints. While this is working well for script, this is not working well for emoji. Emoji can have joiners (ZWNJ) between codepoints. The codepoints that are joined can be on different blocks. Emoji can have a presentation codepoint (<emoji> u+FE0E or <emoji> u+FE0F). The fallback font was broken because the algorithm tries to find a font for codepoints {u+2699, u+fe0f}. The codepoint u+fe0f is an ignorable codepoint and was not taken into account while choosing the fonts. The "Menlo" font was returned. The codepoints u+2699 favor the textual representation and was not taking the emoji color font. The Apple Emoji Color font support both codepoints. We could take into account the ignorable u+fe0f, but this is causing problem with this example: {u+2699, u+fe0e}. There is no font that has both of them. The selection can choose any font with {u+2699} or with {u+fe0e}. Selecting font with only {u+fe0e} is also wrong. Same issue can happen with the ZWNJ/ZWJ that can be found in emoji sequence. The proposal is to have a specific font for handling emoji. Bug: 1099591 Change-Id: Id02952b2fa2c7b4052611c06c3b2a535e20600ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429503 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810900}
-
