- 11 Mar, 2011 40 commits
-
-
yurys@chromium.org authored
Unreviewed. Roll out r80837. git-svn-id: svn://svn.chromium.org/blink/trunk@80839 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
caseq@chromium.org authored
Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests. * inspector/report-API-errors.html: git-svn-id: svn://svn.chromium.org/blink/trunk@80838 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost https://bugs.webkit.org/show_bug.cgi?id=56173 * inspector/protocol/console-agent-expected.txt: * inspector/protocol/console-agent.html: 2011-03-11 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost https://bugs.webkit.org/show_bug.cgi?id=56173 Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController. * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSInjectedScriptHostCustom.cpp: * bindings/js/JSInjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp. (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow): * inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): * inspector/ConsoleMessage.h: * inspector/InjectedScript.cpp: (WebCore::InjectedScript::canAccessInspectedWindow): * inspector/InjectedScript.h: * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::disconnect): (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl): * inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::setFrontend): (WebCore::InjectedScriptHost::clearFrontend): * inspector/InjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::create): (WebCore::InjectedScriptManager::InjectedScriptManager): (WebCore::InjectedScriptManager::~InjectedScriptManager): (WebCore::InjectedScriptManager::disconnect): (WebCore::InjectedScriptManager::injectedScriptHost): (WebCore::InjectedScriptManager::injectedScriptForId): (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::discardInjectedScripts): (WebCore::InjectedScriptManager::releaseObjectGroup): (WebCore::InjectedScriptManager::injectedScriptSource): (WebCore::InjectedScriptManager::injectScript): * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h. * inspector/Inspector.idl: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): * inspector/InspectorAgent.h: * inspector/InspectorBrowserDebuggerAgent.cpp: * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage): * inspector/InspectorConsoleAgent.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): * inspector/InspectorController.h: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::resolveNode): * inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames): * inspector/InspectorDebuggerAgent.h: * inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup): * inspector/InspectorRuntimeAgent.h: * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): git-svn-id: svn://svn.chromium.org/blink/trunk@80837 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
philn@webkit.org authored
Reviewed by Martin Robinson. [GTK] close-web-view emitted on disposed WebView https://bugs.webkit.org/show_bug.cgi?id=55932 * WebCoreSupport/ChromeClientGtk.cpp: (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib source before destruction of the ChromeClient. git-svn-id: svn://svn.chromium.org/blink/trunk@80836 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
sergio@webkit.org authored
Unreviewed. Skipping two test cases that are failing on GTK debug bots. * platform/gtk/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@80835 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
hans@chromium.org authored
Reviewed by Jeremy Orlow. IndexedDB: Make IDBBackingStore abstract https://bugs.webkit.org/show_bug.cgi?id=56013 Make IDBBackingStore abstract to allow for multiple implementations. Move the SQLite implementation to IDBSQLiteBackingStore. No new tests: refactoring only. * WebCore.gypi: * storage/IDBBackingStore.h: (WebCore::IDBBackingStore::~IDBBackingStore): * storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): * storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore): (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore): (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::getDatabaseSchemaVersion): (WebCore::migrateDatabase): (WebCore::IDBSQLiteBackingStore::open): (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData): (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData): (WebCore::IDBSQLiteBackingStore::getObjectStores): (WebCore::IDBSQLiteBackingStore::createObjectStore): (WebCore::doDelete): (WebCore::IDBSQLiteBackingStore::deleteObjectStore): (WebCore::whereSyntaxForKey): (WebCore::bindKeyToQuery): (WebCore::lowerCursorWhereFragment): (WebCore::upperCursorWhereFragment): (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord): (WebCore::bindKeyToQueryWithNulls): (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::clearObjectStore): (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber): (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore): (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::getIndexes): (WebCore::IDBSQLiteBackingStore::createIndex): (WebCore::IDBSQLiteBackingStore::deleteIndex): (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord): (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord): (WebCore::IDBSQLiteBackingStore::getObjectViaIndex): (WebCore::keyFromQuery): (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBSQLiteBackingStore::keyExistsInIndex): (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor): (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor): (WebCore::IDBSQLiteBackingStore::openIndexCursor): (WebCore::IDBSQLiteBackingStore::createTransaction): * storage/IDBSQLiteBackingStore.h: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80834 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
gyuyoung.kim@samsung.com authored
Unreviewed build error fix. [EFL] Fix build break when SHARED_CORE is ON https://bugs.webkit.org/show_bug.cgi?id=56155 * platform/efl/ContextMenuEfl.cpp: (WebCore::ContextMenu::ContextMenu): * platform/efl/ContextMenuItemEfl.cpp: (WebCore::ContextMenuItem::nativeMenuItem): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): git-svn-id: svn://svn.chromium.org/blink/trunk@80833 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
caseq@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: resource load cancellation is reported to console as an error https://bugs.webkit.org/show_bug.cgi?id=55764 - mark interruptionForPolicyChangeError as cancellation - do not log resource cancelation as an error - always push resource to front-end before console message, so front-end can use resource info while formatting message. * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::didFailLoading): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::stopLoadingForPolicyChange): 2011-03-11 Andrey Kosyakov <caseq@chromium.org> Reviewed by Pavel Feldman. Web Inspector: resource load cancellation is reported to console as an error https://bugs.webkit.org/show_bug.cgi?id=55764 * http/tests/inspector/console-resource-errors-expected.txt: * http/tests/inspector/console-resource-errors.html: Added test for lack of console messages during policy change (at download) * http/tests/inspector/console-xhr-logging-expected.txt: * http/tests/inspector/console-xhr-logging.html: Added test for reporting of cross-origin XHR errors. * http/tests/inspector/resources/empty.zip: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80832 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
apavlov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1 https://bugs.webkit.org/show_bug.cgi?id=56096 No new tests, as this is a refactoring. * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): * inspector/front-end/DetailedHeapshotView.js: * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.BaseStorageTreeElement): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement): (WebInspector.FrameTreeElement): (WebInspector.FrameResourceTreeElement): (WebInspector.DatabaseTreeElement): (WebInspector.DatabaseTableTreeElement): (WebInspector.DOMStorageTreeElement): (WebInspector.CookieTreeElement): (WebInspector.ApplicationCacheTreeElement): (WebInspector.ResourceRevisionTreeElement): * inspector/front-end/utilities.js: (Element.prototype.removeStyleClass): (Element.prototype.addStyleClass): (Element.prototype.hasStyleClass): git-svn-id: svn://svn.chromium.org/blink/trunk@80831 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tony@chromium.org authored
Reviewed by Ojan Vafai. kill hung lighttpd processes on the chromium win bot https://bugs.webkit.org/show_bug.cgi?id=56152 Sometimes this process doesn't exit and it holds on to a log file that we can't delete or copy, causing the tests to go red. * BuildSlaveSupport/win/kill-old-processes: git-svn-id: svn://svn.chromium.org/blink/trunk@80830 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rdar://problem/9120161mrowe@apple.com authored
Reviewed by Alice Liu. * UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): If we're navigating to a back/forward item as part of the restoration, call setPendingAPIRequestURL. When there's a provisional URL this will be done by our call to loadURL elsewhere in the function. git-svn-id: svn://svn.chromium.org/blink/trunk@80829 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Kent Tamura. [Chromium] missing HTMLInputElement::setValueForUser() to tests https://bugs.webkit.org/show_bug.cgi?id=55854 * platform/chromium/test_expectations.txt: Removed onchange-setvalueforuser.html 2011-03-11 Ilya Sherman <isherman@chromium.org> Reviewed by Kent Tamura. [Chromium] missing HTMLInputElement::setValueForUser() to tests https://bugs.webkit.org/show_bug.cgi?id=55854 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setValueForUser): Added. * DumpRenderTree/chromium/LayoutTestController.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80828 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
philn@webkit.org authored
Unreviewed, skip tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html on GTK again after being unskipped by accident in r80738. * platform/gtk/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@80827 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. Adds GrContext flush call to PlatformContextSkia destructor. Calls GrContext flush with int parameter instead of bool due to skia revision. No new tests needed. * platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer): * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): git-svn-id: svn://svn.chromium.org/blink/trunk@80826 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ap@apple.com authored
Reviewed by Jon Honeycutt. WebKit2 UI process crashes if web process crashes while computing page rects for printing https://bugs.webkit.org/show_bug.cgi?id=56160 <rdar://problem/9027410> * UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _suspendAutodisplay]): Added a null check for page, matching one that we have when resuming autodisplay. (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Added a FIXME. (pageDidComputePageRects): Sanitize results coming from the web process (and avoid crashing when there is a communication error, so results are all null). (-[WKPrintingView knowsPageRange:]): If there is no page any more, we can't tell how many pages it had. (-[WKPrintingView rectForPage:]): Handle the case where we are neither calculating pages nor knowing them, as it happens when the web process crashes. git-svn-id: svn://svn.chromium.org/blink/trunk@80825 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by James Robinson. Fix for Coverity discovered NO_EFFECT (self-assign) defect. https://bugs.webkit.org/show_bug.cgi?id=54143 * platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::setMaxTextureSize): git-svn-id: svn://svn.chromium.org/blink/trunk@80824 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
eae@chromium.org authored
Reviewed by Alexey Proskuryakov. The web colours palevioletred and mediumpurple are incorrect https://bugs.webkit.org/show_bug.cgi?id=46658 Added test for named colors. * fast/css/named-colors-expected.txt: Added. * fast/css/named-colors.html: Added. 2011-03-10 Emil A Eklund <eae@chromium.org> Reviewed by Alexey Proskuryakov. The web colours palevioletred and mediumpurple are incorrect https://bugs.webkit.org/show_bug.cgi?id=46658 Changed value for the palevioletred and mediumpurple colors to match the css3 specification. Test: fast/css/named-colors.html * inspector/front-end/Color.js: * platform/ColorData.gperf: git-svn-id: svn://svn.chromium.org/blink/trunk@80823 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rolandsteiner@chromium.org authored
Unreviewed: update Chromium test expectations. * platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added. * platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added. * platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added. * platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added. * platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added. * platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added. * platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added. * platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added. * platform/chromium-mac/fast/js/kde/function_length-expected.txt: Removed. * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added. * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added. * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added. * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added. * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added. * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added. * platform/chromium-win/fast/js/kde/function_length-expected.txt: Removed. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@80822 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Alexey Proskuryakov. document.compatMode is incorrect for javascript: protocol URLs in IFRAMEs https://bugs.webkit.org/show_bug.cgi?id=27845 This bug was randomly fixed by the HTML5 parser. * fast/parser/javascript-url-compat-mode-expected.txt: Added. * fast/parser/javascript-url-compat-mode.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80821 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by David Levin. video-controls-in-media-document.html used to silently rely on timeupdate firing immediately upon playback start, and before any frames changed. This was (unsurprisingly, in retrospect) super-brittle. This change instead uses an explicit seek to put the video in a predictable state. The expected.png change is only to change the "pause" button to "play" (which is part of what's required to have the video be in a predictable state for the pixel diff). An equivalent rebaselining needs to happen for chromium mac & win. * media/video-controls-in-media-document.html: * platform/chromium/media/video-controls-in-media-document-expected.checksum: * platform/chromium/media/video-controls-in-media-document-expected.png: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@80820 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rolandsteiner@chromium.org authored
Unreviewed: tweak Chromium test_expectations.txt * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@80819 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Andreas Kling. Fixed a qdoc warning and terminology (WebKit instead of Webkit). https://bugs.webkit.org/show_bug.cgi?id=55756 * Api/qwebhistoryinterface.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@80818 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Clean up some gross code in TestShellWin.cpp. No functional change. https://bugs.webkit.org/show_bug.cgi?id=56048 * DumpRenderTree/chromium/TestShellWin.cpp: (checkLayoutTestSystemDependencies): git-svn-id: svn://svn.chromium.org/blink/trunk@80817 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
laszlo.1.gombos@nokia.com authored
Reviewed by Laszlo Gombos. [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian) * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): Guard X11-specific code with Q_WS_X11. git-svn-id: svn://svn.chromium.org/blink/trunk@80816 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
gyuyoung.kim@samsung.com authored
Unreviewed build fix. [WML] Fix build error https://bugs.webkit.org/show_bug.cgi?id=56078 * wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler): git-svn-id: svn://svn.chromium.org/blink/trunk@80815 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jeremy@chromium.org authored
Reviewed by Darin Adler. Fix navigation menus on a bunch of sites in WebKit. https://bugs.webkit.org/show_bug.cgi?id=52535 Add test to make sure that offsetLeft matches FF/IE for a relatively positioned TD and IFRAME elements. Testcase is a reduction from doula.co.il. * fast/block/positioning/offsetLeft-relative-iframe-expected.txt: Added. * fast/block/positioning/offsetLeft-relative-iframe.html: Added. * fast/block/positioning/offsetLeft-relative-td-expected.txt: Added. * fast/block/positioning/offsetLeft-relative-td.html: Added. 2011-03-10 Jeremy Moskovich <jeremy@chromium.org> Reviewed by Darin Adler. Fix navigation menus on a bunch of sites in WebKit. https://bugs.webkit.org/show_bug.cgi?id=52535 WebKit doesn't support position:relative for several table elements and overwrites the style internally when position:relative is encountered. Unfortunately position:relative affects the choice of nodes returned by offsetParent. This CL adds a bit to RenderStyle to track whether position:relative was overwritten. The value is then consulted in offsetParent which makes us match FF/IE. Tests: fast/block/positioning/offsetLeft-relative-iframe.html fast/block/positioning/offsetLeft-relative-td.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): * rendering/RenderObject.cpp: (WebCore::RenderObject::isOriginallyRelPositioned): (WebCore::RenderObject::offsetParent): * rendering/RenderObject.h: * rendering/style/RenderStyle.h: Add a bit to track the original value of position:relative. (WebCore::InheritedFlags::positionWasRelative): (WebCore::InheritedFlags::setPositionWasRelative): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80814 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
gyuyoung.kim@samsung.com authored
Reviewed by Kenneth Rohde Christiansen. [EFL] Make single backing store the default for EWebLauncher https://bugs.webkit.org/show_bug.cgi?id=55753 Set single backing store the default for EWebLauncher. * EWebLauncher/main.c: (main): git-svn-id: svn://svn.chromium.org/blink/trunk@80813 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Darin Adler. REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel() https://bugs.webkit.org/show_bug.cgi?id=51357 Test that we don't crash when calling close immedately after print. * printing/print-close-crash-expected.txt: Added. * printing/print-close-crash.html: Added. 2011-03-10 Adam Barth <abarth@webkit.org> Reviewed by Darin Adler. REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel() https://bugs.webkit.org/show_bug.cgi?id=51357 Previously, we would try to print from a callstack that didn't want a nested event loop, leading to re-entrancy problems. In this patch, we complete the print call asynchronously, giving us a clean stack on which to run the nested event loop. Test: printing/print-close-crash.html * page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::printTimerFired): * page/DOMWindow.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80812 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rolandsteiner@chromium.org authored
Reviewed by Ryosuke Niwa. Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/ https://bugs.webkit.org/show_bug.cgi?id=55570 Add a virtual function toInputElement() to Node that has a default implementation of returning 0. For HTMLInputElement and WMLInputElement (which derive from InputElement) override this to return the object. Change all calling sites of the old toInputElement to use the new member function. This also allows us to save some casts. No new tests. (refactoring) * WebCore.exp.in: * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): (WebCore::AccessibilityRenderObject::isIndeterminate): (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): (WebCore::AccessibilityRenderObject::isChecked): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): * dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::removeButton): * dom/InputElement.cpp: * dom/InputElement.h: * dom/Node.cpp: (WebCore::Node::toInputElement): * dom/Node.h: * html/HTMLInputElement.h: (WebCore::HTMLInputElement::toInputElement): * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::inputElement): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isChecked): (WebCore::RenderTheme::isIndeterminate): * wml/WMLInputElement.h: (WebCore::WMLInputElement::toInputElement): 2011-03-11 Roland Steiner <rolandsteiner@chromium.org> Reviewed by Ryosuke Niwa. Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/ https://bugs.webkit.org/show_bug.cgi?id=55570 Add a virtual function toInputElement() to Node that has a default implementation of returning 0. For HTMLInputElement and WMLInputElement (which derive from InputElement) override this to return the object. Change all calling sites of the old toInputElement to use the new member function. This also allows us to save some casts. No new tests (refactoring). * src/WebInputElement.cpp: (WebKit::toWebInputElement): 2011-03-11 Roland Steiner <rolandsteiner@chromium.org> Reviewed by Ryosuke Niwa. Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/ https://bugs.webkit.org/show_bug.cgi?id=55570 Add a virtual function toInputElement() to Node that has a default implementation of returning 0. For HTMLInputElement and WMLInputElement (which derive from InputElement) override this to return the object. Change all calling sites of the old toInputElement to use the new member function. This also allows us to save some casts. No new tests (refactoring). * src/WebInputElement.cpp: (WebKit::toWebInputElement): * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setValueForUser): git-svn-id: svn://svn.chromium.org/blink/trunk@80811 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Tony Chang. Remove default parameter declaration for familiForChars(), which is no longer necessary. * public/gtk/WebFontInfo.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80810 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
gyuyoung.kim@samsung.com authored
Reviewed by Kenneth Rohde Christiansen. [EFL] New mediaControl css file for EFL https://bugs.webkit.org/show_bug.cgi?id=55460 Add new mediaControl css file for html5 video UI. * CMakeLists.txt: * CMakeListsEfl.txt: * css/mediaControlsEfl.css: Added. (audio): (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): (video:-webkit-full-page-media::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button): * platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): git-svn-id: svn://svn.chromium.org/blink/trunk@80809 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
eae@chromium.org authored
Reviewed by Dimitri Glazkov. style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically https://bugs.webkit.org/show_bug.cgi?id=53860 Add tests for selectedIndex when changing the multiple property on a select element. * fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added. * fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added. 2011-03-10 Emil A Eklund <eae@chromium.org> Reviewed by Dimitri Glazkov. style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically https://bugs.webkit.org/show_bug.cgi?id=53860 Preserve selection when changing between multi-select and single-select for <select> boxes even if it has not yet been rendered. Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple): git-svn-id: svn://svn.chromium.org/blink/trunk@80808 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ojan@chromium.org authored
Reviewed by Tony Chang. update comment to reference new DOM Core spec https://bugs.webkit.org/show_bug.cgi?id=56079 I'm excising all instances of WRONG_DOCUMENT_ERR from WebKit. This is the only one that's actually specified to fire in the latest DOM Core spec. * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): git-svn-id: svn://svn.chromium.org/blink/trunk@80807 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Tony Gentilcore. Fix that allows fixed length values to be floating point https://bugs.webkit.org/show_bug.cgi?id=52699 Transitions now return matrices in floating point. 2 of the transition tests were failing because they expected integer values. * transitions/matched-transform-functions.html: * transitions/retargetted-transition.html: 2011-03-10 Rik Cabanier <cabanier@gmail.com> Reviewed by Tony Gentilcore. Fix that allows fixed length values to be floating point https://bugs.webkit.org/show_bug.cgi?id=52699 * WebCore.xcodeproj/project.pbxproj: * css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations): * platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue): * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): git-svn-id: svn://svn.chromium.org/blink/trunk@80806 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Added 3 http tests to Windows port's skipped list. Tracked by https://bugs.webkit.org/show_bug.cgi?id=56167 * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@80805 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Unreviewed, rolling out r80800. http://trac.webkit.org/changeset/80800 https://bugs.webkit.org/show_bug.cgi?id=56163 Caused hundreds of tests to crash on Windows 7 (Requested by rniwa on #webkit). * page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::updateMouseEventTargetNode): * page/FocusController.cpp: (WebCore::FocusController::setActive): * page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): * page/FrameView.h: * page/Page.cpp: * page/Page.h: * platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent): * platform/ScrollView.h: * rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): git-svn-id: svn://svn.chromium.org/blink/trunk@80804 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. NULL pointer crash when using :empty and :first-line pseudoclass selectors together https://bugs.webkit.org/show_bug.cgi?id=53316 * fast/css/empty-first-line-crash-expected.txt: Added. * fast/css/empty-first-line-crash.html: Added. 2011-03-10 Alice Boxhall <aboxhall@chromium.org> Reviewed by Dimitri Glazkov. NULL pointer crash when using :empty and :first-line pseudoclass selectors together https://bugs.webkit.org/show_bug.cgi?id=53316 :empty is calculated for each element during parsing, but then not recalculated after any child elements are attached. Force style re-calculation on elements which have :empty in their style when their children are changed. Test: fast/css/empty-first-line-crash.html * dom/Element.cpp: (WebCore::checkForEmptyStyleChange): Pull out empty style checking logic from checkForSiblingStyleChanges(). (WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChanges() method. (WebCore::Element::childrenChanged): Call checkForEmptyStyleChanges() when called with changedByParser = true. git-svn-id: svn://svn.chromium.org/blink/trunk@80803 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
eae@chromium.org authored
Unreviewed build fix. Fix Leopard Release build broken by r80797. * html/CollectionCache.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80802 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rdar://problem/8728860mrowe@apple.com authored
Rubber-stamped by Sam Weinig. The presence of CFBundleDevelopmentRegion in the application's Info.plist prevents the default localization that we set during launch from being respected. * PluginProcess/Info.plist: Remove CFBundleDevelopmentRegion. * WebProcess/Info.plist: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@80801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/8944558bdakin@apple.com authored
send notifications appropriate times (showing up, resizing) -and corresponding- https://bugs.webkit.org/show_bug.cgi?id=56067 Reviewed by Darin Adler. The general strategy here is to add a HashSet of ScrollableAreas to the page that can be accessed when necessary to send notifications to all ScrollableAreas. Find layers for relevant node and if the layers are in the Page's ScrollableArea set, then send the relevant notification. * page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::updateMouseEventTargetNode): When the page is set active or not active, iterate through the Page's ScrollableAreas to send hide/show notifications. * page/FocusController.cpp: (WebCore::FocusController::setActive): When a FrameView is created, add it to the ScrollableArea set. When it's destroyed, remove it. * page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): Iterate through the Page's ScrollableAreas to send the paint notification. (WebCore::FrameView::notifyPageThatContentAreaWillPaint): * page/FrameView.h: Add the new ScrollableArea set. * page/Page.cpp: (WebCore::Page::addScrollableArea): (WebCore::Page::removeScrollableArea): (WebCore::Page::pageContainsScrollableArea): * page/Page.h: (WebCore::Page::scrollableAreaSet): notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView. * platform/ScrollView.cpp: (WebCore::ScrollView::notifyPageThatContentAreaWillPaint): Call notifyPageThatContentAreaWillPaint() instead of calling contentAreaWillPaint() just for the ScrollView. (WebCore::ScrollView::paint): * platform/ScrollView.h: Add/remove ScrollableAreas to the set. * rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): Should have implemented this ScrollableArea-interface function a while ago. (WebCore::RenderLayer::currentMousePosition): * rendering/RenderLayer.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80800 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
