GitLab

Struct already had attributes, but were discarding the result. Module attributes will be used by the java generator to set the java package.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/262633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268177 0039d316-1c4b-4281-b951-d872f2087c98

1) The first one only happens when running UDP over localhost: The connect() call
   call fails and the sender stops listening to incoming packets. I fixed this by
   re-starting the packet listening if needed after each successfully sent packet.

2) The second problem is that the packet storage times out packets based on time,
   with the assumption that no packet should have to be re-sent if it's older than
   the max history time. However, if packets are not ACKed in a timely fashion, the
   video_sender may need to re-send arbitrarily old packets. To fix this, I change
   the packet storage to remember "max outanding frames" regardless of timing.

BUG=366911

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268142

Review URL: https://codereview.chromium.org/252923007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268176 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268175 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=1&start=14564
TBR=
BUG=

Review URL: https://codereview.chromium.org/265703013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268174 0039d316-1c4b-4281-b951-d872f2087c98

The current v8 roll breaks this test due to the activation of Object.observe.

BUG=370004
TBR=ishell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/260903024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268173 0039d316-1c4b-4281-b951-d872f2087c98

Introduced UsbServiceImpl class. Reworked USB Extensions API tests.

BUG=367094
R=pfeldman@chromium.org, rockot@chromium.org

Review URL: https://codereview.chromium.org/258783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/262673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268171 0039d316-1c4b-4281-b951-d872f2087c98

We'll important the BUILD.gn into v8 instead to make maintaining it
easier

BUG=none
R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/253843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268170 0039d316-1c4b-4281-b951-d872f2087c98

Instead of passing libc++.so and libc++abi.so on the command line to the linker,
we want to be able to simply pass -stdlib=libc++ to the clang driver and let it
make the decision about linking the DSOs. In this way we can avoid linking
libc++ into C executables.

To this effect we introduce a proxy target which adds -stdlib=libc++ to direct
dependents' flags but does not link the actual DSO. We also link libc++abi
statically into libc++. The latter change is necessary because clang's
-stdlib=libc++ mode is set up to use libsupc++ as the ABI implementation, and
will not automatically pick up libc++abi.so.

BUG=318770
R=glider@chromium.org, thakis@chromium.org
NOTRY=true
TEST=msan

Review URL: https://codereview.chromium.org/264613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307750

Review URL: https://codereview.chromium.org/246253014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363776
TEST=browser_tests:NetworkPortalDetectorImpl*
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267169

Review URL: https://codereview.chromium.org/245113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268167 0039d316-1c4b-4281-b951-d872f2087c98

Instead, just hardcode it directly where we used to reuse the constant
from extensions library.

BUG=368334
TEST=green trybots
R=grt@chromium.org

Review URL: https://codereview.chromium.org/269793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268166 0039d316-1c4b-4281-b951-d872f2087c98

All WebRTC bots used to have software webcams on them, but they don't
anymore since we have transitioned to use internal fake video in Chrome
for almost all the tests. However, Firefox doesn't AFAIK have the any
fake device support which means this test needs a webcam on the
executing system. This patch makes the code look for a webcam and skips
the test if there is no webcam on the executing system.

BUG=364418
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/269813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=wibling@chromium.org

Review URL: https://codereview.chromium.org/261973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362179

Review URL: https://codereview.chromium.org/260053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368351
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/254293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268161 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/266473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268160 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces a new browser command to open the Manage Passwords bubble,
and converts the ManagePasswordsIconView class into a subclass of
BubbleIconView, which uses the new command to control the bubble's state.
This allows us to more easily test the view and the UI controller, as each
object's job is now more clearly defined (and the view is now doing a good
deal less work), and to independently verify that the command is doing the
right thing.

After this CL, we'll (finally!) have something approaching reasonable test
coverage for the core of the views code.

----------------------------------------------------------------------------
This is a re-land of r267195, which was reverted due to Windows errors. That
was a reland of r266859, which was reverted due to LSAN errors. The
original review is https://codereview.chromium.org/246393004/.
----------------------------------------------------------------------------

BUG=365678
TBR=vabr@chromium.org,pkasting@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/264713010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369466
R=asargent@chromium.org, bauerb@chromium.org

Review URL: https://codereview.chromium.org/265563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268158 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where reparenting would hide the folder grid view that
was hosting the drag view, causing the root level to get visible drag view. To
get around this, allow the folder grid view to tell the root grid view to show
its drag view until the synchronous drag sets up.

BUG=368948

Review URL: https://codereview.chromium.org/265723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353403

Review URL: https://codereview.chromium.org/264043009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268154 0039d316-1c4b-4281-b951-d872f2087c98

This events will be used instead of existing implementation in InspectorTimelineAgent.cpp after switching Timeline to trace events as backend.

BUG=361045

Review URL: https://codereview.chromium.org/254313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268152 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
We still need this feature on ios and android

Original issue's description:
> Remove Referrer Policy from URLFetcher.
> 
> There were no consumers of this.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267757

TBR=mmenke@chromium.org,noyau@chromium.org,cbentzel@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/265253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268151 0039d316-1c4b-4281-b951-d872f2087c98

> Disabling WebRtcApprtcBrowserTest.MANUAL_FirefoxApprtcInteropTest since it times out and I can't reproduce locally or find any change to blame. Seems flaky and is already disabled on other platforms.
> 
> TBR=vrk
> BUG=364418
> 
> Review URL: https://codereview.chromium.org/240783004

The test seems to be fine as far I can tell; speculative re-enable

TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/266973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268150 0039d316-1c4b-4281-b951-d872f2087c98

RULE_INPUT_DIRNAME is empty for input files in the same directory as the
gyp file.

Review URL: https://codereview.chromium.org/267743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268149 0039d316-1c4b-4281-b951-d872f2087c98

Currently mojo runs all services in the same process. We have separate
services that manage the display and one that runs aura. The display
one needs to create PlatformEventSource (as it gets events). The
service running aura doesn't need a PlatformEventSource as it gets
events from the display one. This means I need the ability to create
aura::Env without a PlatformEventSource.

I believe the long term plan is to move some services out of
process. When this happens this boolean shouldn't be needed.

BUG=365012
TEST=none
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/262883011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268148 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Unused variable:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/66198

Original issue's description:
> Cast: Fix two video freezing problems
> 
> 1) The first one only happens when running UDP over localhost: The connect() call
>    call fails and the sender stops listening to incoming packets. I fixed this by
>    re-starting the packet listening if needed after each successfully sent packet.
> 
> 2) The second problem is that the packet storage times out packets based on time,
>    with the assumption that no packet should have to be re-sent if it's older than
>    the max history time. However, if packets are not ACKed in a timely fashion, the
>    video_sender may need to re-send arbitrarily old packets. To fix this, I change
>    the packet storage to remember "max outanding frames" regardless of timing.
> 
> BUG=366911
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268142

TBR=hclam@chromium.org,palmer@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366911

Review URL: https://codereview.chromium.org/268983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268147 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268146 0039d316-1c4b-4281-b951-d872f2087c98

Persists the entire in-memory representation of the database so that
SBDatabase::ContainsBrowseUrl() will return the same prefix hits after
startup as after the last update.

BUG=172527

Review URL: https://codereview.chromium.org/266793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268145 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173283:173285&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/262173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268144 0039d316-1c4b-4281-b951-d872f2087c98

enabled.
This is one of the two changes required. The other one is:
https://chrome-internal-review.googlesource.com/#/c/162426/

BUG=368820

Review URL: https://codereview.chromium.org/265093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268143 0039d316-1c4b-4281-b951-d872f2087c98

1) The first one only happens when running UDP over localhost: The connect() call
   call fails and the sender stops listening to incoming packets. I fixed this by
   re-starting the packet listening if needed after each successfully sent packet.

2) The second problem is that the packet storage times out packets based on time,
   with the assumption that no packet should have to be re-sent if it's older than
   the max history time. However, if packets are not ACKed in a timely fashion, the
   video_sender may need to re-send arbitrarily old packets. To fix this, I change
   the packet storage to remember "max outanding frames" regardless of timing.

BUG=366911

Review URL: https://codereview.chromium.org/252923007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268142 0039d316-1c4b-4281-b951-d872f2087c98

Previosly VideoDecoder interface allowed only one pending Decode()
request. This meant that decoders that want to decode multiple buffers
simultaneously had to delay frames in order get multiple buffers from
demuxer. Now VideoDecode implementation may allow multiple concurrent
Decode() requests, which is determined by the new
VideoDecoder::GetMaxDecodeRequests(). Also updated DecodeStream to
allow decoding multiple frames in parallel.

BUG=338529

Review URL: https://codereview.chromium.org/239893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268140 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268139 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173281:173283&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/265213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268138 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268137 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173280:173281&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/268073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268136 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/269893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321833
NOTRY=true

Review URL: https://codereview.chromium.org/266133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268133 0039d316-1c4b-4281-b951-d872f2087c98