GitLab

Bug: 976645
Change-Id: Id5de30ade3821d6ace315411a41932841b2370c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735583
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683994}

Also adds a dark color for iOS 12 compatibility.

Bug: 976645
Change-Id: Ia5fca38c00fa9f5cbe7275093695ab4c979e4a8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731846Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683993}

Change-Id: Idd54e0d77d3e7a5949db9c284acb319c208f33da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733092Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683992}

This reverts commit 0c4a415f.

Reason for revert: reverting to see if this is causing consistent failures on Linux MSan Tests, browser_tests, DevToolsSanityTest.TestDeviceEmulation (timeout)

Original change's description:
> Paint non-fast scrollable regions for resize handles
>
> Non-fast scrollable regions are regions on a cc::Layer where the
> compositor should not handle scroll events. These are primarily for non-
> composited scrollers but are also used for resize handles and plugins.
> This patch paints non-fast scrollable regions for resize handles.
>
> The interesting code change is in ScrollableAreaPainter::PaintResizer
> where we now emit a ScrollHitTestDisplayItem for resizers. This fixes
> a class of bugs such as non-fast regions being on the wrong cc::Layer
> (https://crbug.com/968691) and having the wrong offset
> (https://crbug.com/989038).
>
> Design doc:
> https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj
>
> Bug: 864567, 968691, 989038
> Change-Id: I8193077279617418433306912d712c31d99149f3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730521
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683670}

TBR=pdr@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864567, 968691, 989038, 990692
Change-Id: I1986b58522d7658109155e811419a6d3ae1d2dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736702Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683991}

Replaced --enable-blink-features=HeapConcurrentMarking
with --enable-features=BlinkHeapConcurrentMarking.

Bug: 989278
Change-Id: Iab12b8784f413d6bb5e47b3c0a360d34dab9ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728585
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683990}

When we receive a high priority push message, Android puts us in a
temporary whitelist to launch background tasks. This is especially
important if the device is in doze mode, as no other tasks (e.g.
scheduled via JobScheduler) will run at that time. We try to start our
service and fallback to the default BackgroundTaskScheduler if we were
not whitelisted.

This new behavior can be enabled on a per-subscription basis by passing
a flag to the InstanceID::GetToken call. This CL includes a refactoring
of that method to be able to pass multiple flags, instead of the
|is_lazy| flag alone.

TBR=khorimoto@chromium.org,carlosk@chromium.org,dcheng@chromium.org

Bug: 987192
Change-Id: I534478dbe535162bdc59ee4b3eac2cd5f77e286f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710317
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683989}

Test is often timing out on Linux ChromiumOS MSan Tests bot.

TBR=alemate@chromium.org

Bug: 990362
Change-Id: Id5cf58d7cbbf9045bad7d12f72812525371ba298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736432Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683988}

https://webrtc.googlesource.com/src.git/+log/ad5c4accad00..3d351c688586

git log ad5c4accad00..3d351c688586 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 srte@webrtc.org Revert "Adds PeerConnection scenario test framework."

Created with:
  gclient setdep -r src/third_party/webrtc@3d351c688586

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: If1b5572a10ef7457959f38ccb8700400b3a029c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736107Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683987}

In another CL, I noticed that the CreditCardAccessoryMediator class is
unused. Since there were no tests, nobody noticed that the metrics for
it were never recorded.

This CL unifies all three sheets to use the same mediator which records
the same metrics (impressions for actions and the manage XX link).
Tests are added for all metrics and the credit cards in general.

Bug: None
Change-Id: Iea80f67eca31ab1287d92ca0178789fe271aba47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736667
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683986}

Change-Id: I51b476895be6d7b072e899e28f4d53f84b21f598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736705
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#683985}

This reverts commit https://chromium.googlesource.com/chromium/src/+/9f9dd5090001e41fb0a33f08cc5bb1779ed28148.

$ git log 7deaf37e9..c691071e9 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 dschinazi Add missing QUIC_EXPORT_PRIVATE to test client ALPN
2019-08-02 fayang Fix tests to make chromium compile.
2019-08-02 fayang Fix a chromium compile error where local variable shadows member variable.
2019-08-01 dschinazi Support 20byte connection IDs in QUIC v99
2019-08-01 dschinazi Add connection ID length checks
2019-08-01 dschinazi Make QUIC enforce ALPN when using TLS handshake
2019-07-31 bnc Add helper methods to QpackSpdyStreamTest instead of hard-coding QPACK-encoded headers.
2019-07-31 fayang gfe-relnote: Close QUIC connection is there are too many (> 1000) buffered control frames in control frame manager. Protected by gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames.
2019-07-31 renjietang Add version DCHECK for SPDY frames that are already replaced by HTTP/3 frames in v99.
2019-07-31 dschinazi Deprecate quic_do_not_override_connection_id
2019-07-31 dschinazi Fix a QUIC end_to_end test when some flags are enabled
2019-07-31 bnc Remove Http3FrameLengths.
2019-07-31 bnc Change HeaderBlocksForStream from QuicDeque to std::list.
2019-07-31 fayang gfe-relnote: Let GFE be able to use HTTP2(tree-style) priority write scheduler in QUIC and enable it via a connection option H2PR. Protected by gfe2_reloadable_flag_quic_use_http2_priority_write_scheduler.
2019-07-31 dschinazi Introduce IsConnectionIdLengthValidForVersion
2019-07-31 fayang gfe-relnote: Replace SpdyPriority priority with const spdy::SpdyStreamPrecedence& precedence in GfeQuicServerSession::CreateServerPushStream. No functional change expected. Not protected.
2019-07-31 fayang gfe-relnote: Add a FifoWriteScheduler where the stream with the smallest stream ID will have the highest priority. Not used in prod, not protected.
2019-07-31 fayang Add a const_cast to make chromium build.
2019-07-31 dschinazi Support LengthPrefixedConnectionIds in v99
2019-07-30 bnc Add QpackBlockingManager to track blocked streams and blocking entries.
2019-07-30 fayang Fix comparison of signed to unsigned in htt2_priority_write_scheduler_* and spdy_intrusive_list_test.
2019-07-30 renjietang Remove headers stream from IETF QUIC.
2019-07-30 bnc Refactor incoming SETTINGS logic to QuicSpdySession::OnSetting().
2019-07-30 fkastenholz Wire in the ack exponent trransport config for IETF QUIC
2019-07-29 quiche-dev Create a QuartcMultiplexer which separates streams and datagrams into channels.
2019-07-29 bnc Add QpackHeaderTable::MaxInsertSizeWithoutEvictingGivenEntry().
2019-07-29 renjietang Make OnPushPromiseFrameEnd() return the same value as OnHeadersFrameEnd().
2019-07-29 bnc Clean up HTTP/3 and QPACK settings.
2019-07-29 bnc Internal QUICHE change
2019-07-29 fkastenholz Connect up IETF QUIC Max ACK Delay transport parameter
2019-07-29 fayang gfe-relnote: Fix Http2PriorityWriteScheduler::UpdateStreamParent. Not used in prod. Not protected.
2019-07-27 bnc Update QuicSpdySessionTestClient.Http3ServerPush* tests.
2019-07-26 renjietang Write push promise on request streams.
2019-07-26 fayang gfe-relnote: In QUIC, let write_blocked_list be able to use HTTP2 priorities. Not used yet. Not Protected.
2019-07-26 fayang gfe-relnote: Fix Http2PriorityWriteScheduler::ShouldYield. Not used in prod. Not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Please note quartc_multiplexer_test.cc is not added to BUILD.gn because it failed on Linux MSAN Tests:
https://luci-milo.appspot.com/p/chromium/builders/ci/Linux%20MSan%20Tests/18389

Change-Id: I35bbd7a1920f2d075f3cc638d2dd1e6570505e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736463
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683984}

https://skia.googlesource.com/skia.git/+log/594583382d4e..00c9f0dc9225

git log 594583382d4e..00c9f0dc9225 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 robertphillips@google.com Increase specificity of GrColorType computed for YUV planes (take 2)

Created with:
  gclient setdep -r src/third_party/skia@00c9f0dc9225

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@google.com

Bug: None
Change-Id: I08045f42218539f288e110bea6fbfa45acc6dad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734764Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683983}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ibf33ad4f45a420ddae482b945ae68a9825c8ec07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736108Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683982}

https://chromium.googlesource.com/catapult.git/+log/8c1079cc71d7..a5468613faff

git log 8c1079cc71d7..a5468613faff --date=short --no-merges --format='%ad %ae %s'
2019-08-05 perezju@chromium.org [Telemetry] Write 'benchmark/story' test paths in LUCI format

Created with:
  gclient setdep -r src/third_party/catapult@a5468613faff

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: chromium:966835,chromium:983993
Change-Id: I48166ba007ed9b5853e2a06e0206376d9bb6243e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734762Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683981}

See https://crrev.com/c/1704282 for context.

Change-Id: Ifcfd3b7b9b7867176a90a092056f453fb74124c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736692
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683980}

This reverts commit 75b38795.

Reason for revert: Adding expectation to address Linux Leak failure

Original change's description:
> Revert "Add web tests virtual suite for audio service - Take 2"
> 
> This reverts commit 8d648953.
> 
> Reason for revert: Causing failures on WebKit Linux Leak
> 
> Failure output:
> 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed:
> 06:31:06.621 2998 worker/6  leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]})
> 
> Original change's description:
> > Add web tests virtual suite for audio service - Take 2
> > 
> > Adds extra expectations with respect to reverted
> > https://chromium-review.googlesource.com/c/chromium/src/+/1715811
> > 
> > Bug: 976696
> > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088
> > Reviewed-by: Armando Miraglia <armax@chromium.org>
> > Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#683565}
> 
> TBR=guidou@chromium.org,armax@chromium.org
> 
> Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 976696
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508
> Reviewed-by: Chris Sharp <csharp@chromium.org>
> Commit-Queue: Chris Sharp <csharp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683600}

TBR=csharp@chromium.org,guidou@chromium.org,armax@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 976696
Change-Id: I9172e204adef935eb4ae4a60045a54b6c9c157f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735378Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683979}

With this change, tests that wait for onboarding systematically call
AutofillAssistantUiTestUtil.waitUntilViewMatchesCondition, which waits
longer than expresso normally does.

Bug: 990118
Change-Id: Ie6ae12786eec2d4fab04b49aa13cdbfa6088e943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736706Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683978}

Bug: 988068, 984945
Change-Id: Ia095904e4d07ded1814af0d35ed2cff3c50b6946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736669Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683977}

MessageLoopForIO will go away soon use ScopedTaskEnvironment instead.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=miu@chromium.org

Change-Id: I692e8ce91f43e17c5d0ad58dc1b194145490a4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733613
Commit-Queue: Carlos Caballero <carlscab@google.com>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683976}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/12af46b649fd..ad3443c93121

git log 12af46b649fd..ad3443c93121 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 wl@gnu.org Minor documentation improvement.

Created with:
  gclient setdep -r src/third_party/freetype/src@ad3443c93121

The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
TBR=bungeman@google.com,drott@google.com,thestig@google.com

Bug: None
Change-Id: I93ee5bf566c0c5cc87149069120e121300592ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735999Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683975}

WKWebView's -takeSnapshotWithConfiguration:completionHandler: may call
its completion handler more than once under some circumstances. Since
we typically embed a callback bound with BindOnce into this callback,
repeated calls will CHECK() and crash.

This CL changes the snapshot callback to be a repeating callback. The
callback will remain owned by the block passed into WKWebView, and will
be destroyed only when WKWebView discards the block.

Bug: 981893
Change-Id: I9ae72fd8ca42ca4ac704b23df942931a3afd1310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728553
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683974}

This CL implements page eviction. When JavaScript is executed on one
document in the back/forward cache, the full page is evicted.

This uses V8's SetAbortScriptExecution, which aborts execution and
instead executes the registered hook. In the hook, eviction is triggered
via mojo.

In the current implementation, the page is evicted even when the frame is
frozen not by bfcache, but this eviction works only when the feature flag
is set. Detecting the reason why the frame is frozen is a remaining task.

Design Doc:
https://docs.google.com/document/d/1E6efB594SqODZX5_PRxmv8eZ9YsmheqhKFg3KoDh3vs/edit?usp=sharing

This CL includes the change:

* Browser-side implementation
  https://chromium-review.googlesource.com/c/chromium/src/+/1614163

Bug: 980111

Change-Id: I7d2779441aab118612a666304ff2366cffeffc75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654739
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683973}

The CL introducing the results processor [1] broke reporting of
Telemetry's return_code when called via run_benchmark.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1692986

This is a quick fix for that.

Adding tests to make sure we don't break this again in the future as
follow up CLs.

TBR=crouleau@chromium.org

Bug: 990472
Change-Id: I4139d4b7503bad6555b5ee8d919499dd32fbff37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735581Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683972}

BUG=894773

Change-Id: I57c5c7cea3effd7a09bc72b3fe4893bb094eebb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731908Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683971}

https://webrtc.googlesource.com/src.git/+log/fedd625e0cc6..ad5c4accad00

git log fedd625e0cc6..ad5c4accad00 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 srte@webrtc.org Adds PeerConnection scenario test framework.
2019-08-05 asapersson@webrtc.org QualityScaler: Add option to try fast adapt down at start up based on initial bw estimates.

Created with:
  gclient setdep -r src/third_party/webrtc@ad5c4accad00

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:none
Change-Id: I2fa0da36342295598e1d0a82b4dbba6d33d0e6c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683970}

https://chromium.googlesource.com/angle/angle.git/+log/73ec5b06ff9e..b8a27c5e6bb1

git log 73ec5b06ff9e..b8a27c5e6bb1 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src a0eb5efd2bad..3cea2e5882e3 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@b8a27c5e6bb1

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: chromium:None
Change-Id: I351cf6e75d5e0593f6f97786b4e3f94af9454b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683969}

Removes the blur effect in the background view, which is not required
anymore.

Bug: 976645
Change-Id: Ic2d120dc163c471a67cf47451f1381dde495ec93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735375Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683968}

Replaced code which waits for Quick Look UI presentation for EG2. EG1
still relies on checking for presented UIViewController, while EG2 can
use XCUITest API to test that "good" static text is displayed.

Bug: 987646
Change-Id: I7394c7b49249307cecf60617bf99250353022638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733461
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683967}

https://chromium.googlesource.com/catapult.git/+log/93ee550c1fe8..8c1079cc71d7

git log 93ee550c1fe8..8c1079cc71d7 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 taylori@google.com Update systrace to use traceconv

Created with:
  gclient setdep -r src/third_party/catapult@8c1079cc71d7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: None
Change-Id: Ic9663d9d7645e4017f21fd4089eb62dda590a5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734758Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683966}

This change upgrades RTCVideoEncoder output_buffers_ from
base::SharedMemory to the new API base::UnsafeSharedMemoryRegion.
The only functional difference is that the region is mapped for
each BitstreamBufferReady() rather than only once when the shared
memory is allocated.

Bug: 849207
Change-Id: I6404b395d3b676f677ff9e9d6ccab3ff206e4099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697642
Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683965}

Ongoing effort to deprecate this API

Bug: chromium:913887
Change-Id: I01f1390d0006d8a8ffc5271f722c5d12dd39931a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736352Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683964}

on_terminate_prompt_ is left over from a previous refactoring. It was
checked but never actually set. This change removes it completely.

Bug: 981363
Change-Id: I8ca8142b6bfe66f0e36d186b8559a31fcbf92313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735151Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683963}

Currently, Trusted Types are enforced also in extensions'
worlds, which is unintentional.

Bug: 986209
Co-Authored-By: koto <koto@google.com>
Change-Id: I5c4bbb03b715d1d0d3c3bfbcd7dbdb05caa88d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712683
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683962}

Bug: webrtc:3098
Change-Id: I58b1b22d13259102294a00914e05b42b2b41b36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731931
Commit-Queue: Eldar Rello <elrello@microsoft.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683961}

We started not marking Document with ChildNeedsReattach() in [1], hence
the common ancestor for LayoutTreeRebuildRoot would be null instead of
Document when marking documentElement().

That caused an issue with documentElement() not becoming a common root.
The plan is to always use documentElement() instead of Document as the
top-most root node for all traversal roots and simplify this again.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1727290

Bug: 989659
Change-Id: Id6f71d98f130e3f9d84930e28e90f14175f44718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733527Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683960}

We need some test coverage for benchmarks still using the legacy
Telemetry value system.

Bug: 990036
Change-Id: I597a1c0149031adf6ec65353634beab6ca5ae48f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731840Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683959}

Bug: 983940
Change-Id: I5a64cdec49eec883d2ac1d9933c101d05ee8a47d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724513Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683958}

Bug: 982229
Change-Id: I2000e18b7e5bfe3a9ec7d9b8906251bec68d2937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735450
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683957}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=braveyao@chromium.org, wez@chromium.org

Bug: 968047
Change-Id: I5223612c9d4bf031e86a570bec68bd75c68dbcd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729163
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683956}

This CL introduces the PrefetchRedirectError flag. When enabled,
prefetch requests get a redirect mode of kError, instead of the default
kFollow. Consequently, prefetches that redirect are "cancelled", however
the corresponding redirect responses are not evicted from cache, and can
be matched later, which is our goal. The current proposal mentions that
redirect mode should be manual, with the goal being:
 - To not follow redirects
 - Store redirect responses in the HTTP cache

In Chromium, to satisfy the above conditions with kManual redirect mode,
we'd have to implement extra behavior to treat kManual requests differently.
We can satisfy the above conditions with kError in Chromium, and avoid the
extra special-handling work. This is sufficient for initial experimentation.

This CL also includes prefetch browsertests ensuring this behavior
is both correct, and tied to the flag.

R=kinuko@chromium.org, yhirano@chromium.org

Bug: 988956
Change-Id: I449be39a02b3806d3ab14c45a6cb491fcab9bb66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725554
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683955}