- 24 Jan, 2019 40 commits
-
-
Corentin Wallez authored
https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/909f0d3d31e7..ce7d92182b8c $ git log 909f0d3d3..ce7d92182 --date=short --no-merges --format='%ad %ae %s' 2019-01-22 fjhenigman Use the full spirv-cross dependency. (#550) 2019-01-22 corentin BUILD.gn: fix build error on is_component_build=true (#549) 2019-01-21 corentin BUILD.gn: Make libraries Chromium-style "components" (#548) 2019-01-17 fjhenigman Disable spvc build by default. (#542) (#547) 2019-01-16 fjhenigman Fix build with exceptions off. (#546) 2019-01-16 dneto Fix MinGW: Format %lu must be unsigned long. (#544) 2019-01-16 dneto Fix leaks in tests (#545) 2019-01-15 fjhenigman Fix ASAN build. (#543) 2019-01-15 fjhenigman Add libshaderc_spvc interface to SPIRV-Cross. (#524) 2019-01-15 fjhenigman Fix NDK build. (#540) 2019-01-11 dneto Android.mk: better fallback for SPIRV-Tools dir (#538) 2019-01-09 dj2 Roll RE2 Dep (#537) 2019-01-07 dj2 Fixup source matching test (#534) 2019-01-03 fjhenigman Fix Windows test script return value. (#533) 2019-01-02 dj2 Switch GLSLang to upstream (#515) 2018-12-28 alex Generate source text debug info if requested (#455) (#532) 2018-12-27 ehsann [kokoro] Stop running tests on VS 2013 builds. (#531) 2018-12-21 fjhenigman Update Android NDK. (#530) 2018-12-17 dneto Test shader uniforms need descriptor set and binding (#523) 2018-12-17 kknb1056 Add git clone of re2 and effcee to the Dockerfile (#527) 2018-11-28 dj2 Update to use Android.mk from glslang (#520) 2018-11-22 dneto Add unit tests for mesh and task shaders 2018-11-21 arseny.kapoulkine Add support for NV_EXTENSIONS in #pragma shader_stage() 2018-11-19 dj2 Build file updates. (#514) 2018-11-15 dj2 Fixup shadowed variables (#513) 2018-10-11 dneto Unpin googletest. It has been fixed upstream 2018-11-13 dj2 Add effcee and re2 when building spirv-tools tests (#510) 2018-10-24 dj2 Only include third_party directories if needed. (#507) Created with: roll-dep src/third_party/shaderc/src TBR=dsinclair@chromium.org BUG=dawn:29 Change-Id: I1c6c740bfa91404e9523769924d0bdbd7b4b9b46 Reviewed-on: https://chromium-review.googlesource.com/c/1434095Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625685}
-
Nicolas Pena authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/LN92hkaKCzw/Y-ryVxu5AgAJ Bug: 823744, 841224 Change-Id: Ic4d3d67facd0d717b929b9798650eb502057fea6 Reviewed-on: https://chromium-review.googlesource.com/c/1368826 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#625684}
-
Anthony Vallee-Dubois authored
This CL changes InitiateTranslation in 2 ways: - It decouples the actual decision making from the triggering, metrics recording, and Ranker Event logging - It avoids returning early, to enable some upcoming behavior that would have required inserting the same function call in multiple places in the function Functionally, there should be no change introduced from this CL, although the TranslateManager performs marginally more work on cases that would previously return early. Change-Id: Ib78f7f5d42c651c1089711e0f6e14f362fdddebd Reviewed-on: https://chromium-review.googlesource.com/c/1431480 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#625683}
-
jonross authored
A check was added to RenderWidgetHostImpl::SynchronizeVisualProperties in https://chromium.googlesource.com/chromium/src/+/9746a213f859bf3ce39f73c20b57e3bd24f8c130 However we have found reproduction cases of this failing on Android. I'm removing the check from Android until we can fix the root cause. TBR: samans@chromium.org Bug: 923742 Change-Id: I8aa9d524b1bc2f92bc6b6eb4ebfa4e32db07307a Reviewed-on: https://chromium-review.googlesource.com/c/1433936Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#625682}
-
Moe Ahmadi authored
video: https://drive.google.com/file/d/1rRJgtGsgFPsFgcoUCwqcYT-dHDKguuhk/view?usp=sharing Starting from the leading edge, it features an icon followed by the source and the target languages. Toggling between the languages results in the page to be translated or the translation to be reverted. At the trailing edge, the infobar features an options button that opens a popup menu that allows changing translate preferences followed by a close button to dismiss the infobar. The view hierarchy is as follows: TranslateInfobarView -> TranslateInfobarTabStripView -> TranslateInfobarTabView Bug: 910994 Change-Id: Icc9d06f43a4a91ba0ec967ce3e9b372b5e9b9bfb Reviewed-on: https://chromium-review.googlesource.com/c/1426014 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#625681}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f580d4907862..c4f1acd86f1d git log f580d4907862..c4f1acd86f1d --date=short --no-merges --format='%ad %ae %s' 2019-01-24 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c4f1acd86f1d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8e169c971a49aba718efd02057d25e31459bb8eb Reviewed-on: https://chromium-review.googlesource.com/c/1433914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625680}
-
Henrik Boström authored
This was previously marked as flaky but the "webrtc-wpt-unified-plan" virtual test suite does not exist anymore and has been replaced by "webrtc-wpt-plan-b". NOTRY=True TBR=hta@chromium.org Bug: 924990 Change-Id: I9a85dfeefe22c5a6596c447f8db6b23e30107386 Reviewed-on: https://chromium-review.googlesource.com/c/1434279Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625679}
-
Randy Rossi authored
CL to catch up chromecast's implementation of automation and extension apis. Chrome switched to native bindings for extension/tabs apis. Need to bring in the same native binding init code to chromecast. Automation classes also updated to stay in sync with chrome impl. Bug: None Test: Manual build cast_shell and test on estelle Change-Id: I01272b80c5123349d3e795c93e6fa758ceee03bf Reviewed-on: https://chromium-review.googlesource.com/c/1431337Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625678}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/970cd8e6beba..f68a7687983a git log 970cd8e6beba..f68a7687983a --date=short --no-merges --format='%ad %ae %s' 2019-01-24 lalitm@google.com Merge "trace_processor: remove log spam when encountering unknown counters and unify swap" Created with: gclient setdep -r src/third_party/perfetto@f68a7687983a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic4f4c8a9132f122ef2a550e00eba7ff0e17cfd20 Reviewed-on: https://chromium-review.googlesource.com/c/1434114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625677}
-
Lukasz Anforowicz authored
See also https://fetch.spec.whatwg.org/#cross-origin-resource-policy-header Bug: 853723 Change-Id: I1bafc0c75c84dc0fff36fcf92fab34ea4206d689 Reviewed-on: https://chromium-review.googlesource.com/c/1416813 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625676}
-
Marc Treib authored
In sync_service.h, the methods are in a (mostly) sensible order, so let's use that. This only changes profile_sync_service.h but leaves the .cc as it is. Reordering the methods there is probably not worth the churn and "lost" history. Bug: none Change-Id: If96a9bc5a4fb0e9a7e4d7827dcfde0294e1dd697 Reviewed-on: https://chromium-review.googlesource.com/c/1433757Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#625675}
-
chrome://invalidationsTanja Gornak authored
Bug: 801985 Change-Id: I7f02c991e8407ffb30c49438bebddd03478bbe5e Reviewed-on: https://chromium-review.googlesource.com/c/1433622 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#625674}
-
Peter Beverloo authored
Create a mock Mojo interface through which individual test cases can modify behaviour of the call. This enables us to extensively test the Web Exposed behaviour. Bug: 860467 Change-Id: I90da5fb37e600466e488c49ef52b3d14b98d262f Reviewed-on: https://chromium-review.googlesource.com/c/1431512 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#625673}
-
Dominik Röttsches authored
Adding an assertion failure on a failed FindFamily DWriteFontProxy sync IPC call to gather more information on failing clients. Sync IPC calls should only be returning false in very rare cases, which would mean an error here. More discussion on this on the bug. Note to Crash reporting sheriffs: This will likely trigger additional crash reports, which we assume to be a subset of the crash reports collected for issue 561873. Bug: 922403 Change-Id: I054e65e5f01ff646329a6174b908305519fef3d6 Reviewed-on: https://chromium-review.googlesource.com/c/1412029Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#625672}
-
Leonard Grey authored
Bug: 850098 Change-Id: I454c77d5c47fcdc90ed7a4265cf4f268186a983b Reviewed-on: https://chromium-review.googlesource.com/c/1431715Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625671}
-
Dominik Röttsches authored
Change-Id: I432a1eecefe1996bbb33b10f9d6309fad5a0f51b Reviewed-on: https://chromium-review.googlesource.com/c/1415308Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#625670}
-
Andrew Grieve authored
Detects the ABI required by the apk (if any), and selects only devices that support the ABI (when no devices are explicitly requested). Main use-case for this is to have x86 tests run on emulators without having to unplug local devices or passing "-d". Bug: 853280 Change-Id: Iabd5002c185f4e370b3f7504d6d742eef38fb688 Reviewed-on: https://chromium-review.googlesource.com/c/1414490Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#625669}
-
A Olsen authored
Particularly migrating away from calls to ReplaceDeviceSettingsProviderWithStub. They are not ideal for the following reasons: 1. They are not straightforward calls to make - they need to be made after initialization and should be matched with RestoreRealDeviceSettingsProvider. Because of this, the stub cannot be used until initialization is finished. So putting test data in the stub has to be done carefully: not too early, before initialization is finished, and not too late, after it is already read. 2. Both a real and a stub DeviceSettingsProvider are initialized, even though the real one is not be needed for the test. The real one depends on the local state, which may also not be needed for the test. Test helpers that depend on local state makes separating code into packages more difficult, since in test packages inside chrome/browser, the local state used should be the browser local state, but in packages outside the browser, there should be no dependencies on chrome/browser. For more details, see the bug Bug: 909635 Change-Id: Ia6c8c0f2f9b22f82aceed565158f050c9a6e4b9e Reviewed-on: https://chromium-review.googlesource.com/c/1400684 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625668}
-
Ian Clelland authored
This adds a method to return the names of all policy-controlled features supported by the browser. Because this list is determined by the set of features implemented by Chrome, rather than conformance to any particular spec, the tests are in /webexposed/ rather than WPT. (Existing IDL tests in WPT cover the existence of the new method and the data types that it returns, without depending on the exact values returned.) Bug: 917070 Change-Id: I35ccbdce794e236500d15afe5419057a8f162ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1387151 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#625667}
-
Daniel Vogelheim authored
This also removes TrustedDOMTypes from workers since we had difficulty bringing it into the origin trial. They will be re-added later. Bug: 739170 Change-Id: Iec6206f1c3c8121f30d7fbdb13054e4e30255fd2 Reviewed-on: https://chromium-review.googlesource.com/c/1411775 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#625666}
-
Vladislav Kuzkokov authored
Bug: 660612 Change-Id: Ieea560a5fbd4118c69e31e24f37e2f80593ac842 Reviewed-on: https://chromium-review.googlesource.com/c/1417593Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625665}
-
Dominic Farolino authored
This CL adds support for Priority Hints on the <script> element, gated by the Priority Hints Origin Trial. It also adds the necessary tests. The "importance" is only set for classic scripts and top-level module scripts, as the effect of importance on a script's imports, if any, has not been decided yet. Furthermore, ResourceFetcher currently makes it difficult to down-prioritize a ResourceRequest whose priority is already set. https://crbug.com/882344 describes this problem. Since module scripts already have their priority set to kHigh before reaching ResourceFetcher, they are currently exempt from the effects of importance="low". It is also true that importance="high" will not raise the priority of module scripts any higher than their default, so after this CL, only top-level classic scripts are affected by Priority Hints. This should enable us to collect better data during the Origin Trial, as people are interested in <script async importance="high">. R=kinuko@chromium.org, kouhei@chromium.org, yoavweiss@chromium.org Bug: 821464 Change-Id: If3665bddcbd10842071cd91627f18bfb67ba1e98 Reviewed-on: https://chromium-review.googlesource.com/c/1433393Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#625664}
-
Alan Cutter authored
This CL adds a missing null check for GetBrowser in RenderViewContextMenu when opening the emoji panel. If no browser is found default to opening the emoji panel in the current process instead of crashing. Bug: 924439 Change-Id: Idabcc6e4da022d1fbfee9e76260479b87953d2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1433375 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625663}
-
Peter Beverloo authored
Bug: 860467 Change-Id: I2f46596d842a2720aeac5ba41d5b5ccea9f2b4a6 Reviewed-on: https://chromium-review.googlesource.com/c/1429967 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#625662}
-
Ian Kilpatrick authored
We were performing an unnecessary layout of a relative positioned element, and as a result creating a new ng_paint_fragment which caused the additional invalidation. This checks if we can safely re-use the layout result, and clears layout if needed. Bug: 635619 Change-Id: I3b5f9056cd8b3447c36b6bbc20f55108b937a3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1427452Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#625661}
-
Elly Fong-Jones authored
This change: 1) Introduces ui::CaptionStyle, which represents a text caption style; 2) Introduces ui::NativeTheme::GetSystemCaptionStyle, which retrieves the system's configured text caption style; 3) Adds a command-line flag '--force-caption-style' which overrides the system-supplied caption style (also useful for testing); 4) Wires up WebPreferences members and IPC struct members to pass caption style information into renderers. The overall flow of information is: 1) ui::NativeTheme produces a ui::CaptionStyle from the system settings and/or a command-line override flag; 2) ChromeContentRendererClient fills WebPreferences' newly-added text style members in from the NativeTheme-provided CaptionStyle; 4) WebPreferences are sent over IPC to renderers; 5) RenderView uses the WebPreferences text style members to configure a blink Settings object; 6) The Blink WebVTT code converts the blink Settings text style members into CSS rules applied to the WebVTT caption container HTML elements. Next steps: * Add Mac and Windows implementations of ui::NativeTheme::GetSystemCaptionStyle() which fetch the system settings * Add more caption style options based on which system options are already implemented at the OS level on desktop platforms * Support the macOS "default" / "mandatory" tri-state caption settings * Figure out how to add test coverage for WebVTT captions Important testing notes: WebVTT caption files are ignored on file:// origins - make sure that a video that you are testing with and its caption file are both served from web origins. Also, beware that chromium builds lack many common video codecs - the best format to test with is a .ogv video. The Blender foundation published the trailer for their open-source movie "Sintel" here <https://download.blender.org/durian/trailer/>, which is a decent test data file. Bug: 897730 Change-Id: Id909e650a3c284b47f787635481d75157651f469 Reviewed-on: https://chromium-review.googlesource.com/c/1418399Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#625660}
-
Oskar Sundbom authored
It seems broken on ChromeOS. Bug: 924976 Tbr: aleventhal@chromium.org Change-Id: I9f4c0e44f234fe118193563885ff36994f36f75d Reviewed-on: https://chromium-review.googlesource.com/c/1433767Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625659}
-
Tim Dresser authored
Bug: None Change-Id: I6631573a82e0c75cb84bf4683a9e871d7888e300 Reviewed-on: https://chromium-review.googlesource.com/c/1431532Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#625658}
-
Anna Malova authored
Bug: 924118 Change-Id: Ib57cc3eda841c0b24352d972b9341ae4b03a5998 Reviewed-on: https://chromium-review.googlesource.com/c/1432845Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#625657}
-
Fabio Tirelo authored
Also removes code that will no longer be executed. Bug: 923960 Change-Id: I1fdc63c8e9737501bb793c221bce7ea134d3bc93 Reviewed-on: https://chromium-review.googlesource.com/c/1426165Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625656}
-
Andrew Grieve authored
More appropriate than Test>Android I think. Change-Id: Ic6bcf691b60ac20b77cfa4d27474bfdf74605339 Reviewed-on: https://chromium-review.googlesource.com/c/1434094Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#625655}
-
Maksim Sisov authored
ClipboardOzone needs to depend on ui/ozone in order to call OzonePlatform::GetPlatformClipboard, but as long as all the base::clipboard classes are part of ui/base source set, and ui/ozone depends on ui/base, it's impossible to depend on ui/ozone. And that creates a circular dependency. Thus, factor out clipboard source files and make appropriate source sets, which will be used by clients on their needs instead of depending on everything. Bug: 922465 Change-Id: I97cd4013be096a1dd1af8e1da4678aa83f93ca42 Reviewed-on: https://chromium-review.googlesource.com/c/1369933Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#625654}
-
Rohit Rao authored
This will enable us to move TabModel creation directly into Browser in a future CL. BUG=783777 Change-Id: Id42f9f825e1179d7b932b376454ed0c9335179bd Reviewed-on: https://chromium-review.googlesource.com/c/1431212Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625653}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d2052fde8d4..c683e1e6a3aa Created with: gclient setdep -r src-internal@c683e1e6a3aa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7bec44aed87a466ef6b04730f9be06b0a6b17519 Reviewed-on: https://chromium-review.googlesource.com/c/1433915Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625652}
-
Findit authored
This reverts commit e4f65702. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625626 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTRmNjU3MDI1OGFlZTI3Nzc3YTk5ZTliNmUyOGJmNDc2YjI4NTBlMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/75269 Sample Failed Step: webkit_layout_tests Sample Flaky Test: http/tests/html/validation-bubble-oopif-clip.html Original change's description: > [Validation bubble][OOPIF] Do not show cut-off validation bubble on OOPIF > > If a validation bubble is shown on an element in a remote frame, we > adjusted its position with the main frame viewport, and rendered the > bubble at a position at which the remote frame can't render. > > In a remote frame, we should refer to 'remote viewport intersection', > which is a visible rectangle of a remote frame. > > Bug: 910979 > Change-Id: I1497f6980c6e5d3758689b4b7fd8ac89113f8540 > Reviewed-on: https://chromium-review.googlesource.com/c/1433638 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625626} Change-Id: I2e5349472982a087a0c498cc1032457262469991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910979 Reviewed-on: https://chromium-review.googlesource.com/c/1434214 Cr-Commit-Position: refs/heads/master@{#625651}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3432970f. With Chromium commits locally applied on WPT: bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 05cdb4d1 "Add tentative WPT tests for stale while revalidate handling." 875e732f "Revert "Add tentative WPT tests for stale while revalidate handling."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jrummell@chromium.org: external/wpt/encrypted-media NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Icd948d64a54d4f484b18ff7dc77b2bbf2efbfb84 Reviewed-on: https://chromium-review.googlesource.com/c/1433855Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625650}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e402437aad51..970cd8e6beba git log e402437aad51..970cd8e6beba --date=short --no-merges --format='%ad %ae %s' 2019-01-24 treehugger-gerrit@google.com Merge "UI: make shadow disappear" Created with: gclient setdep -r src/third_party/perfetto@970cd8e6beba The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7e8f5f313035d9e45f5c30bfc29d9e4176f72229 Reviewed-on: https://chromium-review.googlesource.com/c/1433836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625649}
-
Lei Zhang authored
Switch to std::make_unique or base::MakeRefCounted. Fix some nits and lint errors as well. Change-Id: I2a75aa2c626ad3ea6523159edf4b981336771c8f Reviewed-on: https://chromium-review.googlesource.com/c/1433595 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#625648}
-
Mario Sanchez Prada authored
Use IdentityManager's API instead and only use the AccountTrackerService instance to construct instances of classes still depending on it. Bug: 922777 Change-Id: Ib21cb594a208b7ee5f15f3777f61dda570a11113 Reviewed-on: https://chromium-review.googlesource.com/c/1433617Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#625647}
-
Kush Sinha authored
|AccountManagerMigrator| migrates accounts to the new Chrome OS Account Manager. During this migration it asserts that the Primary (Device) Account is a valid (Google or Active Directory) account. This assertion is not triggered for ephemeral sessions (Guest / Incognito etc.). Unfortunately a lot of browser tests on Chrome OS run with an invalid (AccountType::UNKNOWN) account type. Fix this by removing the assertion. Bug: 915628 Change-Id: Ie6e73e7128ec57ac9b5239b534d185c4758a17e7 Reviewed-on: https://chromium-review.googlesource.com/c/1433623Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#625646}
-