GitLab

This histograms tracks the sum of CPU memory allocations of Buffer11
copies in order to measure the impact of copy pruning methods.

BUG=angleproject:516

Review URL: https://codereview.chromium.org/1280743003

Cr-Commit-Position: refs/heads/master@{#342355}

BUG=506498

Review URL: https://codereview.chromium.org/1276233002

Cr-Commit-Position: refs/heads/master@{#342354}

Disable InstantExtendedTest.OmniboxMarginSetForSearchURLs on Linux Asan due to flaky crashes at shutdown

BUG=517886
TBR=pkasting@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1282483002

Cr-Commit-Position: refs/heads/master@{#342353}

BUG=517806
TBR=sullivan
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect

Review URL: https://codereview.chromium.org/1271203004

Cr-Commit-Position: refs/heads/master@{#342352}

This change makes it possible to provide a Service derived from
CustomTabsConnectionService and make some fields and methods protected
in CustomTabsConnection.

BUG=504479

Review URL: https://codereview.chromium.org/1261893002

Cr-Commit-Position: refs/heads/master@{#342351}

UDP TURN servers are already used as STUN servers at the PortAllocator
level, so we don't need to do anything any longer at the
PeerConnectionDependencyFactory level.

BUG=webrtc:4215

Review URL: https://codereview.chromium.org/1273213004

Cr-Commit-Position: refs/heads/master@{#342350}

Disable FLAGS_quic_require_handshake_confirmation for ZeroRTT test.

relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable
QUIC 0-rtt

Adding a reloadable flag to allow quickly disabling QUIC's 0-rtt
handshake as an interim measure (0-rtt DoS protection) to allow
StrikeServer turndown before full DoSServer integration.  See b/20122788

Merge internal change: 99600488
https://codereview.chromium.org/1272153006/

relnote: Deprecate FLAGS_quic_send_fec_packet_only_on_fec_alarm.

Merge internal change: 99599597
https://codereview.chromium.org/1279433004/

relnote: Limit the number of burst tokens in QUIC's pacing sender to the
min of 10 and the current CWND in packets.

Protected by FLAGS_quic_limit_pacing_burst.

Should decrease retransmit rate for low CWND flows.

Merge internal change: 99597412
https://codereview.chromium.org/1276983003/

Preparation for changing SpdyHeaderBlock to be ordered. This just reduces
the number of files in upcoming CL by 2. No behavior change as these are
currently entries into a map, and the key:value pairs haven't changed.
However after changing to ordered SpdyHeaderBlock, the pseudo-header
order of authority,path,scheme,method is what ends up getting written,
and thus I'm changing the order here in advance.

relnote: n/a (test only)

Merge internal change: 99394725
https://codereview.chromium.org/1281463002/

relnote:  Close QUIC connections due to too many open streams earlier in
processing.  No significant behavior change.  Flag-protected by enabled
FLAGS_exact_stream_id_delta.

Replace the "maximum delta in stream ID" test on a newly-created stream
with an exact test for the max number of open streams.  Change the error
in this case from QUIC_INVALID_STREAM_ID to QUIC_TOO_MANY_OPEN_STREAMS.

FIXED=22477228

Merge internal change: 99369742
https://codereview.chromium.org/1277753002/

relnote: Minor format changes to keep the code similar to internal source.

Merge internal change: 99250353
https://codereview.chromium.org/1274003002/

relnote: Change the QuicStreamSequencer to call OnDataAvailable instead
of OnFinRead when the fin is consumed.

Make ReliableQuicStream::OnFinRead() non-virtual and remove overrides in
subclasses.

Merge internal change: 99214926
https://codereview.chromium.org/1261273003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1277723003

Cr-Commit-Position: refs/heads/master@{#342349}

BUG=517871

Review URL: https://codereview.chromium.org/1276623003

Cr-Commit-Position: refs/heads/master@{#342348}

For AutofillFieldMetadata.

Review URL: https://codereview.chromium.org/1275073002

Cr-Commit-Position: refs/heads/master@{#342347}

Review URL: https://codereview.chromium.org/1279843003

Cr-Commit-Position: refs/heads/master@{#342346}

Review URL: https://codereview.chromium.org/1274513004

Cr-Commit-Position: refs/heads/master@{#342345}

Adding some material design assets in
chrome/app/theme to be used for the omnibox.

BUG=505803,495654
TEST=none
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1276093002

Cr-Commit-Position: refs/heads/master@{#342344}

The change in https://crrev.com/2438a3e2acb1318a4e59c78764b532bac3649161
removed the call to start the notification thread and instead always returned
"false".

This CL fixes this by starting the thread (and thus actually getting status
changes).

BUG=420623
R=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1263353004

Cr-Commit-Position: refs/heads/master@{#342343}

OmniboxMetricsProvider will be shared with iOS, which is decoupling from
//chrome. This CL abstracts the usage of chrome::IsOffTheRecordSessionActive()
with a callback that is passed in from the creator of OmniboxMetricsProvider.

BUG=508022

Review URL: https://codereview.chromium.org/1278473002

Cr-Commit-Position: refs/heads/master@{#342342}

The IVF parser would be shared among VP8 and VP9 unittests.

BUG=509500

Review URL: https://codereview.chromium.org/1269473002

Cr-Commit-Position: refs/heads/master@{#342341}

There is no need to keep a copy of the print_settings in aw_pdf_exporter anymore
because it is owned by AwPrintManager now.

BUG=465802

Review URL: https://codereview.chromium.org/1253423003

Cr-Commit-Position: refs/heads/master@{#342340}

Not knowing the GpuMemoryBuffer format that the compostor will use, the host is
hard to determine the image texture target properly. This CL changes
switches::kContentImageTextureTarget to a list of targets for each format, so
that the compositor can decide what format it wants to use without having to
worry about the target being wrong.

BUG=490362,512665

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1251693003

Cr-Commit-Position: refs/heads/master@{#342339}

 This is UI for saving password on change password form when there is no username on a change password form and no accounts in the PasswordManager. It looks like in mocks
https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update#%2F00%20password%20update%20bubbles%20-%20UI%20review.png%3Fc=show  (case 1)

BUG=359315

Review URL: https://codereview.chromium.org/1271283002

Cr-Commit-Position: refs/heads/master@{#342338}

BUG=514575

Review URL: https://codereview.chromium.org/1275853003

Cr-Commit-Position: refs/heads/master@{#342337}

Revert of Modifies size of ring buffer in shared memory on the audio capture side (patchset #3 id:40001 of https://codereview.chromium.org/1254793002/ )

Reason for revert:
This was an speculative change and should now be reverted. There is no sign that this change would fix or improve the issue.

Original issue's description:
> Modifies size of ring buffer in shared memory on the audio capture side.
>
> We have seen reports in Chrome where segments of repeated input audio has
> damaged AEC performance in WebRTC clients. This patch is an attempt to limit
> the number of possible places in Chrome where such a patter could be created.
>
> It is a speculative patch and the idea is that it should live in Canary
> for a while so we can see if there are any positive effects.
>
> TBR=tommi
> BUG=b/13976602
> TEST=manual tests of different WebRTC clients running in loopback to ensure that no
> audio artifacts can be detected
>
> Committed: https://crrev.com/bda4fc7018c3ce93d88b74461a065f9eaf0b8b5f
> Cr-Commit-Position: refs/heads/master@{#340261}

TBR=tommi@chromium.org,dalecurtis@chromium.org,henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/13976602

Review URL: https://codereview.chromium.org/1277173002

Cr-Commit-Position: refs/heads/master@{#342336}

BUG=

R=shess@chromium.org,rkaplow@chromium.org

Review URL: https://codereview.chromium.org/1266993002

Cr-Commit-Position: refs/heads/master@{#342335}

The code was forcing the output buffer size to be an even divisor
of endpoint buffer size; in seemingly 90%+ of cases this worked
prior to Windows 10. With Windows 10, the device period is no
longer an even divisor of the endpoint buffer size; e.g. my
local machine has a period of 512 and a endpoint buffer of 1126.

In retrospect this restriction seems incorrect; instead it seems
like we just want to ensure that the buffer size is an even divisor
of the device period (which ultimately determines the callback
schedule). I've changed the code to log a warning when this is not
the case, as things will still work, we'll just get glitches. The
log will help us identify users who file bug reports.

The code was also looping over the available end point buffer size,
which seems incorrect, we should fulfill only one period at a time to
avoid shared-memory induced glitches; this was added to fix
http://crbug.com/170498

BUG=516196
TEST=Windows 10 audio works on two devices, Windows 7 works fine,
traces show that callbacks are regular in all cases. Confirmed that
http://crbug.com/170498 is not regressed on X-Fi.

Review URL: https://codereview.chromium.org/1276523004

Cr-Commit-Position: refs/heads/master@{#342334}

Revert of Added Signin Utilities (patchset #21 id:390001 of https://codereview.chromium.org/1258563005/ )

Reason for revert:
Tests are failing: https://code.google.com/p/chromium/issues/detail?id=517849

Original issue's description:
> Tools for being able to sign into fake OS accounts and fake app accounts
> when running tests. Real OS accounts are also supported, but take
> significantly longer because accounts must be authenticated. It is
> recommended to use fake OS accounts unless real ones are necessary.
>
> CQ-DEPEND=CL:1259253007
>
> Committed: https://crrev.com/6832765af577d32c774763e5abe8486aa8db7478
> Cr-Commit-Position: refs/heads/master@{#342190}

TBR=mikecase@chromium.org,jbudorick@chromium.org,yfriedman@chromium.org,skirmani@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1270423006

Cr-Commit-Position: refs/heads/master@{#342333}

The goal is to put as much of the platform-independent logic to the shared code, and leave the CPMC just a dumb redirector to the embedding system. This is one of many steps.

Also, this CL removes IsPasswordManagementEnabledForCurrentPage() from the client mock in the client unit test. It is dangerous to mix mocking methods with testing the real implementations, and none of the tests actually needs this method mocked.

BUG=474577, 515108

Review URL: https://codereview.chromium.org/1260263002

Cr-Commit-Position: refs/heads/master@{#342332}

chrome.enterprise.DeviceAttributes.getDirectoryDeviceId().
An API to allow extensions to get the cloud directory API device Id.

BUG=502330

Review URL: https://codereview.chromium.org/1240283002

Cr-Commit-Position: refs/heads/master@{#342331}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0c1ebe48..b531751e

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1280023002

Cr-Commit-Position: refs/heads/master@{#342330}

This adds a simple throttling policy for mayLaunchUrl(). Each
accepted mayLaunchUrl() request increases the delay before accepting the
next one. Initial delay is 100ms, and the maximum delay is 10s. Waiting
at least 2*current_interval resets the interval to 100ms, as well as
correctly predicting the destination URL.

Note that the tracking is done by UID (~app) instead of session, as a
misbehaving application can open a large number of sessions.

BUG=514825

Review URL: https://codereview.chromium.org/1264013005

Cr-Commit-Position: refs/heads/master@{#342329}

Added AddSameCenterXConstraint which add constraints to a
parent view to horizontally align two subviews.
Added BOOL IsRTLUILayout() which take into account RTL pseudo
language. This will be removed once base::i18n::IsRTL() supports it.

BUG=None

Review URL: https://codereview.chromium.org/1280913003

Cr-Commit-Position: refs/heads/master@{#342328}

Adopt and customize a ICU message format wrapper used at Google to meet
Chromium's need.

This will enable formatting of 'complex messages' requiring plural and/or
selector (e.g. gender or 'single vs multiple') support with more than one
parameters.

Besides, l10n_util::GetPluralStringF* is rewritten to use this API.

I'm also planning to use this API to add a similar support to Chromium's
JavaScript-based UI and extensions.

References:
MessageFormat specs:
  http://icu-project.org/apiref/icu4j/com/ibm/icu/text/MessageFormat.html
  http://icu-project.org/apiref/icu4c/classicu_1_1DecimalFormat.html#details
Examples:
  http://userguide.icu-project.org/formatparse/messages
  message_formatter_unittest.cc
  go/plurals inside Google.

BUG=481734
TEST=base_unittests --gtest_filter="MessageFormat*"

Review URL: https://codereview.chromium.org/1140153005

Cr-Commit-Position: refs/heads/master@{#342327}

WebRTC 9684:9685

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/4b50880..6e87bbe

Libjingle 9683:9686

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/942a295..751b295

TBR=
BUG=

Review URL: https://codereview.chromium.org/1276213002

Cr-Commit-Position: refs/heads/master@{#342326}

Move protocol_event_observer to sync_driver.

BUG=512075

Review URL: https://codereview.chromium.org/1272863003

Cr-Commit-Position: refs/heads/master@{#342325}

Revert of Add channel-specific product logo to chrome://help (patchset #3 id:40001 of https://codereview.chromium.org/1269383005/ )

Reason for revert:
Reverting due to missing files.  See comments in cl:
https://codereview.chromium.org/1269383005/

Original issue's description:
> Add channel-specific product logo to chrome://help
>
> BUG=511000
>
> Committed: https://crrev.com/9836302ea4ffb887ce6ffa597c1ee5484d2f1091
> Cr-Commit-Position: refs/heads/master@{#342183}

TBR=oshima@chromium.org,dbeam@chromium.org,estade@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=511000

Review URL: https://codereview.chromium.org/1280033002

Cr-Commit-Position: refs/heads/master@{#342324}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/18967215..0c1ebe48

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1281683002

Cr-Commit-Position: refs/heads/master@{#342323}

Since ChromeVox does not support Shadow DOM for now, paper-input with
Shadow DOM is not accessible. As temporary solution until it supports
Shadow DOM, we replace paper-input with HTMLInputElement.

BUG=517774
TEST=none

Review URL: https://codereview.chromium.org/1275323002

Cr-Commit-Position: refs/heads/master@{#342322}

Previously, size of crop overlay was same with it of an image. But since
size calculation logics for crop overlay and an image are different, it
causes gaps as issues describe. This CL changes crop overlay to cover
entier window.

BUG=498783, 516638
TEST=manually tested as described in the issues.

Review URL: https://codereview.chromium.org/1281823002

Cr-Commit-Position: refs/heads/master@{#342321}

Unmanaged raw pointers to managed(GC) classes aren't safe across GCs,
hence fields with raw pointer types to such GCed classes are identified
and reported as errors or warnings.

Extend that checking to also apply to reference pointer types.

R=haraken
BUG=420515

Review URL: https://codereview.chromium.org/1274403002

Cr-Commit-Position: refs/heads/master@{#342320}

OmniboxMetricsProvider is targeted for sharing with iOS, which means that its
use of //content needs to be eliminated. This is a little tricky, as it
currently listens for the notification that a URL was opend from the omnibox
from all Profiles.

To move away from listening for this notification, this CL makes use of
OmniboxEventGlobalTracker (previously an //ios-specific class).
OmniboxEditModel calls out to the OmniboxEventGlobalTracker singleton when a
URL is opened from the omnibox. Listeners interested in receiving notifications
when a URL is opened in *any* OmniboxEditModel register with the
OmniboxEventGlobalTracker.

This CL changes OmniboxMetricsProvider to make use of the new class instead of
listening for the notification.

BUG=508022
TBR=droger

Review URL: https://codereview.chromium.org/1278433002

Cr-Commit-Position: refs/heads/master@{#342319}

By setting "ffmpeg_component=shared_library" you can build ffmpeg as library
while the rest of Chromium is statically compiled.

In this case, the "ffmpeg.dll" was not included in the installer archive which
is fixed with the CL.

Review URL: https://codereview.chromium.org/1260963007

Cr-Commit-Position: refs/heads/master@{#342318}

Revert of Add mac_chromium_10.10_rel_ng to CQ (patchset #1 id:1 of https://codereview.chromium.org/1270223002/ )

Reason for revert:
We're hitting pending queues on mac_chromium_10.10_rel_ng, see e.g. http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.10_rel_ng/builds/2885 (spent over 1 hour in the pending queue).

Also, http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.mac%20Builder%20mac_chromium_10.10_rel_ng%20Queue/Running .

And screenshot: https://goto.google.com/ctnhe (Googlers only).

Original issue's description:
> Add mac_chromium_10.10_rel_ng to CQ
>
> BUG=498330
> R=tandrii@google.com
>
> Committed: https://chromium.googlesource.com/chromium/src/+/67b3d8a862ba79524b3ef36da0408a5532d663c8

TBR=akuegel@google.com,tandrii@chromium.org,phajdan@google.com,sergiyb@chromium.org,tandrii@google.com,akuegel@chromium.org,smut@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498330

Review URL: https://codereview.chromium.org/1278113002

Cr-Commit-Position: refs/heads/master@{#342317}

We don't support bitcode yet and open source version of clang does not
support the embed-bitcode-marker flag.
Turn off bitcode at the moment.

BUG=516530

Review URL: https://codereview.chromium.org/1265373003

Cr-Commit-Position: refs/heads/master@{#342316}