- 16 Jul, 2020 40 commits
-
-
Sahel Sharify authored
The test has been flaky on Mac: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXgsSBUZsYWtlIlNjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAc2Nyb2xsYmFycy9jdXN0b20tc2Nyb2xsYmFyLWFkanVzdC1vbi1pbmFjdGl2ZS1wc2V1ZG8uaHRtbAw TBR=tkent@chromium.org Bug: 1105271 Change-Id: Ia94cbbb1cc84f27846bedc42f50b7b5c46c066ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303091Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789171}
-
Sahel Sharify authored
flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0aW9uLWJhY2tncm91bmQuaHRtbAw TBR=wangxianzhu@chromium.org Bug: 1104910 Change-Id: I017a9e76b54725bafa403c55927efc5e00e41ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303113 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594899981-52deb7a5a818691ecf42e5c040aa970329d9defe.profdata to chrome-mac-master-1594922139-2e74d5a60ec66c9d9f020f69b34f84d613c708fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I40878e1041f74072faf30be183a8d91bd0b3bdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789169}
-
Corentin Wallez authored
Bug: chromium:1101491 Change-Id: I8028ffbe7031d38ae392239d17f51c6983ec29cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302194 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789168}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f224f744249c..cab02df7a5c5 2020-07-16 lalitm@google.com Merge "Revert "tp: move thread state implementation to trace processor"" 2020-07-16 lalitm@google.com Merge "ci: more fixes form fallout of redone CI" 2020-07-16 lalitm@google.com Merge "ci: update worker to Python3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06879b6dfd154d8c39a52e5757e84553813acba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302679Reviewed-by:
-
Garrett Beaty authored
Bug: 1106029 Change-Id: Ice3f5575963ba0f31faf3cd45411c2b6c89589ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302740 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789166}
-
Alex Newcomer authored
Problem Background: Some applications take considerable time before finishing a paste. Also, some applications read the clipboard multiple times per paste. When the user selects an item from CBHistory that is not the first item, we need to take the selected item and put it on the clipboard. Then we create a synthetic paste event. With no delay, we were then replacing the old top of the clipboard. Paste is async and can take some time. This means that we may replace the top of the clipboard before the paste is completed. To avoid this, add a 100ms wait before returning the original item to the top of the clipboard. Bug: 11055737 Change-Id: I2f229ebccc00b8241d22bd0341a8c67eeb0b57ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303450Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789165}
-
Brian Sheedy authored
Changes the experimental GPU Windows 10 NVIDIA Quadro P400 builder to target machines in the chromium.tests.gpu.experimental pool running Windows 10 1909, which is the version we are planning to upgrade to. Bug: 1085489, 1106076, 1106078 Change-Id: I92e43bb0baff75e1061e57a0336f3658c769d825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276658 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789164}
-
Toby Huang authored
We will create a new PolicyData field to distinguish K-12 EDU from Enterprise accounts in ChromeOS for the initial version of metrics. This flag should only be used for metrics as the Enterprise team does not want any differential treatment of EDU and Enterprise users in ChromeOS beyond this particular use case. This method of distinguishing EDU and Enterprise accounts only works for the primary account, as user policy doesn't apply for secondary accounts. Bug: 1103077 Change-Id: I1f27cd1b0b4ffe62bcb85459e070627dfdd509fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292703Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789163}
-
Tommy C. Li authored
We currently classify ZeroSuggest search results against the current omnibox text. This was a holdover from the Query in Omnibox experiment, when we only did ZeroSuggest against the displayed query on SERP. Now that Query in Omnibox is completely dead, and we are doing ZeroSuggest against arbitrary page URLs, we want to change the behavior to never classify ZeroSuggest search results, and leave them all unbolded. This patch is minimal and designed to be mergeable back to M85. Bug: 1095837, 1106096 Change-Id: Icceec38d9d8697b69999115af4db9ae3dabd32d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300990 Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#789162}
-
Aaron Leventhal authored
Users need to be informed when pressing down arrow would allow perusing options for filling in a textfield. This does not work in JAWS for autocomplete, but does for autofill. The difference is whether we expose STATE_SYSTEM_HASPOPUP. This CL exposes the haspopup state across all platforms, for both autofill and autocomplete. From the user's point of view they are choosing options from a list either way. R=akihiroota@chromium.org,dmazzoni@chromium.org AX-Relnotes: more consistent announcements for autocomplete textfields Bug: 1106044 Change-Id: I4f0b291c3d3478a3980f73e83474d022f541df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299851Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789161}
-
Etienne Bergeron authored
This CL is making the class ScopedHandleVerifierInfo movable to reduce the cost of putting this class into C++ map. The field StackTrace is expensive to copy. It should be lightweight to move into stl containers. This is done by adding a level indirection (i.e. std::unique_ptr; which has a fast move operation) to the field StackTrace. Bug: 1104342 Change-Id: I4ec0df3e5d57310ea75d5d604a2318c73121b011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287812Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789160}
-
Robert Ma authored
--additional-expectations takes a path relative to the CWD. Previously, disable-site-isolation-trials had a wrong path to the expectation file which caused a warning: additional_expectations path 'src/third_party/blink/web_tests/FlagExpectations/disable-site-isolation-trials' does not exist (https://chromium-swarm.appspot.com/task?id=4d6fcee1081fa710) Fortunately, run_web_tests.py automatically loads flag expectations based on the flag names, so nothing breaks. This change only removes the warning. Though unnecessary, --additional-expectations is kept in consistency with other variants of web tests. Change-Id: I098ec61272c362f82354c7d2ea42203e898b43af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303350 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789159}
-
Miriam Zimmerman authored
These metrics are emitted solely on Chrome OS and are needed to establish a more firm value of a timeout for invocations of crash_sender. BUG=chromium:1104269 TEST=Clicked upload on chrome://crashes; checked chrome://histograms Change-Id: I864d9a6bf36ee3c71fe2c6e642be615e84061a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297965Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#789158}
-
David Van Cleve authored
There are some cases (e.g. arbitrary UA overrides from Android WebView) where clients can set UA header values that are not valid header values in the sense of containing no newlines and no carriage returns. This is causing a CHECK failure in net::HttpRequestHeaders (previously, the requirement was implicitly specified by a DCHECK; the DCHECK was upgraded to a CHECK in crrev.com/c/22703544 because allowing setting invalid headers can be a security vulnerability if input is untrusted). This CL changes WebContents to - document the precondition (previously implicit) that UA string overrides must, if nonempty, be valid header values - enforce this with a CHECK (since it is security-relevant: if we permit invalid header values, callers can add arbitrary protected headers). Bug: 1105745 Change-Id: I349baef33d1f010d5850c7d91453003d4e113fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299528Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#789157}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ced0044c7c5c..832dab01db1d 2020-07-16 alexrudenko@chromium.org Quote font family names in single quotes 2020-07-16 tvanderlippe@chromium.org Remove checks for generated files from devtools_entrypoint 2020-07-16 tvanderlippe@chromium.org Cleanup usages of resources_out_dir 2020-07-16 bmeurer@chromium.org [bindings] Fix useless use of `Promise.resolve()`. 2020-07-16 aerotwist@chromium.org Asserts that all devtools_module files are listed in all_typescript_modules 2020-07-16 aerotwist@chromium.org Asserts that each entrypoint is listed in devtools_module_entrypoints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105861,chromium:1106221 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3df2cff6728e7193265395f33f076f5634ff335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302678Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9674de2630535a6e3538c7b2a99f7b3318c78613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302935Reviewed-by:
-
Alex Newcomer authored
Clipboard history did not previously read bitmaps in the initial CL. Bitmaps are read async, just needed some basic refactoring to handle it. Bug: 1102906 Change-Id: I488a0ad239f07c08dec5f93b8d2f03b5cc256e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293464 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#789154}
-
Wan-Teh Chang authored
"Displayable frame" is the term used in libgav1 to refer to an AV1 video frame that can be output and is in the selected operating point. "Displayable buffer" is less clear. Change-Id: I1cfe176d6595e0cea37a2abf7f11e017d85e7eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302738Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#789153}
-
Xiaohan Wang authored
PlayerTracker used to serve two purposes: notify when new usable key is available and when the CDM is destructed. The latter is not needed since the CDM will always outlive the media element now (in fact we pass base::DoNothing() for that). The standard way to notify new key is via CdmContext::EventCB. This CL removes PlayerTracker and use CdmContext::EventCB for new key notification, as the rest of media pipeline does. Bug: 413413,821288 Change-Id: I08b81a8e63902632d516bb8542b5b70d42038afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296268Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789152}
-
chrome://appsAngela Yoeurng authored
Clicking Switch To Tab on chrome://settings just opened chrome://settings in current page, rather than switching to the previously open tab. This fix reverts back to intended behavior. Bug: 1105788 Change-Id: Ied4d19567b2c7da604a57de142d27d53cbdc887b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301122Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#789151}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ic7558a96d95314011ae81ad1c62e27bd82aef63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295815 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789150}
-
K. Moon authored
Various small changes to simplify the copy of PaintManager in pdf/: 1. Unify PaintAggregator::ReadyRect and PaintManager::ReadyRect. 2. Drop |ReadyRect::offset| field, which is always (0, 0). 3. Drop |is_always_opaque| option, which is always true. 4. Move PaintAggregator and PaintManager into chrome_pdf::. R=dhoss@chromium.org Bug: 1099020 Change-Id: Ic68d9c32ff24baac5d5a63185da688b11556b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300989 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: K. Moon <kmoon@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789149}
-
Vladimir Levin authored
This patch refactors SurfaceAggregator::RemapPassId into a separate class. The intent of this is to clean up the code a bit, and to allow the remapper to be extended in the future by allowing persistent ids for certain render passes. R=kylechar@chromium.org, weiliangc@chromium.org Bug: 1106418 Change-Id: I4ffffd15dd4fcd6a51df88f4d14666a5ff320d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280262 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#789148}
-
Peter Wen authored
Removed //net* from the allowlist and added missing deps. Replaced javax annotations with androidx annotations to avoid adding unnecessary deps on //third_party/android_deps:com_google_code_findbugs_jsr305_java. Bug: 1082904 Change-Id: Ib41144c3eff11f5b6321db0b7cd7bdea96ac40f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302491 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789147}
-
Xiaohan Wang authored
The EME spec says that the expiration time should stay NaN if no such time exists or if the license explicitly never expires, which is the case for Clear Key. Therefore, AesDecryptor never needs to update the expiration. Currently we didn't update it in UpdateSession(), and the update in RemoveSession() pretty much has no effect. To avoid confusion, this CL removes the call in RemoveSession() as well. Change-Id: I3439ef9ecb31b5b788880a2b352f45b0bf494030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297692 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Alfonso Garza authored
Bug: 1099862 Change-Id: Iff787baa5cc7c65a39e23a4f20a77d710cee9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264610Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#789145}
-
Sonny Sasaka authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/6b977833f062..b582eea93ac1 $ git log 6b977833f..b582eea93 --date=short --no-merges --format='%ad %ae %s' 2020-07-13 sonnysasaka system_api: bluetooth: Add Battery interface constants Created with: roll-dep src/third_party/cros_system_api Bug: b:160905767 Change-Id: I453f0eeb68044d67c6316b9ff426fec62aeda80f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301045Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#789144}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b4404b14b04..7fe0359130f9 2020-07-16 rmistry@google.com Add Canary task driver and bots for Android/Chromium/Flutter 2020-07-16 jlavrova@google.com Revert "ICU API: only in SkParagraph, simplified (relanding reverted)." 2020-07-16 adlai@google.com Migrate MakeTextureImage to take GrDirectContext 2020-07-16 jlavrova@google.com ICU API: only in SkParagraph, simplified (relanding reverted). 2020-07-16 jcgregorio@google.com Add more tests to the Pixel4 R Preview devices. 2020-07-16 rmistry@google.com Rename G3 framework bot to Canary-G3 2020-07-16 mtklein@google.com add HALF support to PixelFormat 2020-07-16 herb@google.com SkSpan cleanup 2020-07-16 reed@google.com Revert "Revert "remove support for serialized pictures before aug 2019"" 2020-07-16 robertphillips@google.com Clean up GrContext references in the src/gpu If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I360c172151d75098d0d0ffe9863e8568944c3e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302677Reviewed-by:
-
Steve Becker authored
Increases the Win32 app user model ID max length assert from 64 to 128. 128 is the documented limit that applies to Win7, Win8 and Win10. See https://docs.microsoft.com/en-us/windows/win32/shell/appids#how-to-form-an-application-defined-appusermodelid Bug: 1096850 Change-Id: I42ed9e211421fb5837b1f6ecfcb3b0e57e285502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280591Reviewed-by:
-
Chris Hamilton authored
Subsequent CLs will migrate Shared and Service workers to use similar tokens. This is in support of the performance.measureMemory API, endowing workers with tokens that can be used as an identifier when communicating information regarding V8 memory usage. BUG=1085129, 1096617 Change-Id: I184eabcd1a421ffcfb561f388f620eaf9471d9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297702Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#789141}
-
Anastasia Helfinstein authored
Do not navigate to a node which Switch Access users can't interact with. Fixes a bug where users were entering the dropdown options in a combo box without the options being shown. AX-Relnotes: n/a. Bug: 1095221 Change-Id: Ia7418ca610bc065f525ea5fc9684489f506196d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295802Reviewed-by:
-
Archana Simha authored
This is the first stage in a larger refactor, which adds support for better typing in prefs while allowing extension prefs to remain agnostic. This CL implements the getter and setter methods for profile wide ExtensionPrefs with string, integer and boolean values. Design Doc: http://go/extprefrefactor Bug: 1069560 Change-Id: I6b8901bd1856d9afbadf358229377fc2db665cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276497 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789139}
-
Justin Cohen authored
Change-Id: Ia74705629553f7070108f76642d40cdbb7838dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300868 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789138}
-
Brian Sheedy authored
Refactors the GPU Telemetry code to do the following: 1. Move arguments that are used more than once to constants in a new file. 2. Standardize how browser arguments are determined. Now, tests only call either CustomizeBrowserArgs() or RestartBrowserIfNecessaryWithArgs() with any non-default args to use. The base class now handles application of child class-specific default arguments using the GenerateBrowserArgs() class method. 3. Move the --disable-metal-test-shaders argument to be applied to all GPU tests, not just WebGL ones. Bug: 1085899, 1090480 Change-Id: I9f73d5953420cb5b5c8bd3f71d4b091751a92595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300801 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Scott Violet authored
ThumbnailDatabase takes a HistoryBackendClient, but it doesn't actually use it. This removes the unnecessary argument/field. BUG=1076463 TEST=covered by tests Change-Id: Ib1566a8ec2cd5eb5e3c61c2d3d3950eb20ca05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299856 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789136}
-
Marijn Kruisselbrink authored
Adds an assertion to idlharness to check the name attribute of methods, and fixes the bindings code to make sure we actually set the name correctly. Bug: 1106097, 1097814 Change-Id: I73dea7b96a94a9b2925c23156e6ef8146291cbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300824Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#789135}
-
Yue Zhang authored
This CL adds e2e test to cover item 1.6.2 and 1.6.3 in https://testtracker.googleplex.com/testplans/details/32981. Bug: 1105511 Change-Id: I029399c0ccbbc0d64975042c2a4915fdbe172bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289937 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789134}
-
Kristi Park authored
This should be OS_CHROMEOS, not OS_LINUX. TBR=reillyg@chromium.org Bug: 1069695 Change-Id: Ib1c3e42ee0110fca5a14d256ca00db2ff737a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303032Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#789133}
-
Robert Ma authored
Manual import due to https://crbug.com/1106413. Manual changes in disable-site-isolation-trials: * Add two expectations for two new tests * Drive-by: clean up some stale expectations Using wpt-import in Chromium 39d5e00d. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mek@chromium.org: external/wpt/webmessaging mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Bug: 933880, 1106413 Change-Id: Ie829dbb479195ebe94ab9f662578db453b6841ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303349Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#789132}
-
