- 29 May, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590710362-c13fe441c8f420f4cd2f4cff6b98279f2ecbf633.profdata to chrome-win64-master-1590724612-5db2101d2a61d33e1335d92c89441aeea9c7ea20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7e8163649d33b1bd40d224cbf7f3be4d8d5d59fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773072}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/468f8fff..14aed087 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53c98a50d732ec99460cd186ff27e87f0d690698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773071}
-
Hiroki Nakagawa authored
We have no plans to work on this TODO. Bug: 616721 Change-Id: Ifb7a5803f9494936c50c164d655e754db87a6dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222063 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773070}
-
Marc Treib authored
This reverts commit 54b1dc4f. This is a *temporary* revert to investigate some unexplained metrics changes, see linked bug. Bug: 1075587 Change-Id: I4c4a3c0b1ac5e0f6a39dc15f5fd8aafc87ffec35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218171Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#773069}
-
Alan Cutter authored
This CL refactors WebAppInstallFinalizer database write code to not plumb through bool is_new_install. Instead the database write callsites encode what they want to happen afterwards as part of the CommitCallback. This is a refactor only CL in preparation for: https://chromium-review.googlesource.com/c/chromium/src/+/2216143 Bug: 1084405 Change-Id: Ib71740878d9e339fd8cc6ee73b6bd6fa1b782272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217835 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#773068}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590710362-35a7ecd8a402bd31319e2be75ae7373248116b8a.profdata to chrome-mac-master-1590724612-c1421d9824c914ff15feb610fd2b028bed82b9e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idc6406933af55e570acd4d0c9e9246ddc6aaa060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222124Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c272f416f07..dd9feece3750 2020-05-29 dberris@chromium.org operations: Fixup style config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Ibd749a0eee5958ef247cbffbcdb6db0d08f752da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222127Reviewed-by:
-
Omid Tourzan authored
Bug: 953308 Change-Id: I13b337fe205e897e0350a007d690a24ce582787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220409Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#773065}
-
Clemens Arbesser authored
Closing the keyboard before attempting to click the button should finally fix those flaky tests. Bug: 1087042 Bug: 1084324 Change-Id: Iae013984e3b844eb665aac7f363f2111f139e378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218834 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#773064}
-
Matt Giuca authored
Change-Id: Ie6eeeffc8c29e30388a7958dbbbfb9477dfd96f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222181 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#773063}
-
Richard Townsend authored
This fixup addresses a regression in blink_perf.parser tiny-innerHTML by avoiding the creation of some expensive objects when parsing DocumentFragments. Bug: 1087199, 901056 Change-Id: Ie9cc5e50c138a66e2c7c1beaad26a8a653614506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218846 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#773062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4c9e6c19cc8..7d311f594622 2020-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6a6d030e68533fb1e59cdf9664191eee828e593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222122Reviewed-by:
-
François Beaufort authored
This CL adds 'boolean or DoubleConstraint' support for pan, tilt, and zoom constraints in getUserMedia. Spec says that `pan: true` is just syntactic sugar for `pan: {}` and `pan: false` the same as pan being undefined/not provided. Spec: https://github.com/w3c/mediacapture-image/issues/225 Change-Id: I0f5788ff91bceda14bc9cdad0852e1195755a3f4 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210237Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#773060}
-
Oriol Brufau authored
The ListMarker class contains common logic for LayoutNGOutsideListMarker and LayoutNGInsideListMarker. But it's not a superclass, since multiple inheritance would be slow. Instead, the layout marker classes have a ListMarker member. But the ListMarker methods need to reference back their LayoutObject owner, this could have been done with a pointer, but it would take more memory. Instead, the ListMarker methods accept a LayoutObject& parameter, which is supposed to be the marker that owns that ListMarker instance. The problem was that there was no check that the LayoutObject argument was actually the owner of that ListMarker, or even that it was a marker. So if by mistake some caller passes another LayoutObject, something will go wrong but it may go unnoticed, or the cause of the misbehavior may not be obvious. This patch adds some DCHECKs to address this. Bug: 457718 Change-Id: I6cd34fceaf763f8d8ce8032c288a8066eaf90a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218311Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#773059}
-
Dale Curtis authored
The coefficients were completely wrong. I verified the correct values suggested in the bug against ITU-T H.273. This also resolves two comments in the test file remarking that YCOCG and SMPTEST428_1 were "weird" due to negative values... which was due to both matrices being wrong. 76fb0d6f fixed YCOCG, but didn't resolve the test comments. R=ccameron Fixed: 1087073 Change-Id: If1d9bfe1810de81ddee1cabdf410c1f41e4602ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218859 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773058}
-
Callistus authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/voJICdrAJXQHr-PwOYa17rQCqEsW2U1T1672WgefrioC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202005280800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I82c384b360abf1ce8119c3b46913c20ee9a36163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217838Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#773057}
-
Hayato Ito authored
The web-packaging team is going to implement a new feature: Subresource loading with Web Bundles. Create a runtime flag to put the feature behind for now. Bug: 1082020 Change-Id: I953262ddfe2d3937ed1e1a37c35cb0281255de75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214793Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#773056}
-
Makoto Shimazu authored
TBR=droger@chromium.org Bug: 1087189 Change-Id: I2e9b96dad3be4ffd541546e5df6332a0ed5f8500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217979Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773055}
-
David Staessens authored
This CL adds usage documentation for the new video_encode_accelerator_perf_tests, providing in-depth information on how to run the encoder performance tests. TEST=gitiles BUG=953114 Change-Id: I82c445e2923d57dea16b0febddd0e03b67330da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060366Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#773054}
-
Yuichiro Hanada authored
The feature will allow ARC apps to handle a key event before it's sent to IME and potentially consumed by it. Please refer to go/arc-key-event-dispatch for the details. Bug: b:148193316 Test: component_unittests Test: manual - enable the feature and confirms a key event is sent to an app Change-Id: I81da94d92400e91ff1e4c2fca23bc22da9ed2569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214850 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#773053}
-
Reilly Grant authored
This change captures a few cases where SYSTEM_ERROR could be returned without a more detailed error being printed for debugging purposes. Bug: 1070798 Change-Id: I9450d1f89b87483f5e7442736752d4b199f62161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220743 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#773052}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4ae21d7942e1..f32ae562fe52 2020-05-29 tsepez@chromium.org Merge INT_MAX % -1 patch to pdfium 2020-05-29 hikakar@microsoft.com Fix enter/space key press events on Combobox 2020-05-29 hikakar@microsoft.com Handle Enter/Space key events for read-only check box and radio button. 2020-05-29 nigi@chromium.org Add a helper function for creating text rendering options. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086092 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ied1e8acf92a220986c7a51e498eb1d8fbc9fe536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222120Reviewed-by:
-
Patrick Monette authored
Change-Id: I3a9ea9e2f98e0162acf1a85daa3309791221860f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215022 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773050}
-
Patrick Monette authored
Bug: 993029 Change-Id: I87e33b72d6a340c48e4a9780c21de4c8693e42f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175552Reviewed-by:
-
Adam Rice authored
Verify that the QuicTransport constructor rejects incorrect URLs. Also verify that attempting to connect to port 0 fails. BUG=1011392 Change-Id: I57d209569633c351dd408cdced1d7e44f92f1065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217680Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#773048}
-
Jing Wang authored
Implemented a UI change behind the flag: UI with flag disabled: https://screenshot.googleplex.com/osdAbRsrOdw UI with flag enabled: https://screenshot.googleplex.com/k9waaRkjG4x Test: tested with Chrome on Linux Bug: 1086786 Change-Id: Id3b35306289715e8761e874a6b0fcdfed12205ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216139Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773047}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8c643ad793bf..3c272f416f07 2020-05-29 dberris@chromium.org operations: Set a yapf config in the Dashboard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I741fa290e499465df68c8110785a6afa763c27c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220898Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b8de90f2cb72..e4c9e6c19cc8 2020-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3b92a323ffc50392d546b9a7506158026f6d8ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220899Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/43c0d8bfe09b..eb9831d2211c 2020-05-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic27ef5f27867cbb0f47cf31780a026c2bcf616b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220903Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. This CL is thus a no-op. These changes are required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This CL was uploaded by git cl split. R=mpearson@chromium.org Bug: 1026641, 968047 Change-Id: Ifcaee2088907f0cc8347da2f6f37259585b3ac48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219015 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773043}
-
Kent Tamura authored
If the following conditions meet: - A SELECT is in menulist mode. - An OPTION has |selected| attribute. - Another OPTION is selected by a user or JavaScript code. - The owner form is reset. Then, we missed to update a shadow node with the default OPTION label. This CL adds UpdateTextStyleAndContent() to |HTMLSelectElement:: ResetImpl()| to fix this issue. Bug: 1087031 Change-Id: Id92238a400da93fd91939f54cc20ae9da7020857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220128 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Thomas Tellier authored
Bug: 1076841 Change-Id: I23cd802a208718e57fb68eedbfa05aa532d75c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209077 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773041}
-
Mike Jackson (EDGE) authored
The system_web_app_manager tests fail with a crash when attempting to enumerate AllApps. This fix follows the existing pattern in WebAppsBase::ConvertWebApps There is still another crash happening, so the test won't be re-enabled as part of this change. Bug: 1082880 Change-Id: I55615db92629d0c93a56e58b3f60e70e49357f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220269 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
-
Matt Falkenhagen authored
I'm hitting this DCHECK locally when Chromoting to Linux when pasting things. The comments suggest that mismatches can happen, and it says "e.g., on ozone/wayland", which suggests to me that it's also not surprising that it happens when not on ozone/wayland. Therefore, remove the DCHECK so Chrome Linux can be used with DCHECKs enabled. Bug: 931874 Change-Id: I976ab1793be09bd5a6ac7458299b64d87ce1d665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217524 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773039}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590652675-be69972bb8b130c690a24c0cd0561e6e4a5c40c5.profdata to chrome-win64-master-1590710362-c13fe441c8f420f4cd2f4cff6b98279f2ecbf633.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0380e9f8dc5e0efd25037c80d42785098283368d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220889Reviewed-by:
-
Adam Rice authored
Attempting to Tee() a BodyStreamBuffer object when the execution context was destroyed would crash the render process. Instead, explicitly throw an exception. This makes Request and Response clone() throw when there is a body. clone() is still permitted when there is no body, which is convenient for Request. Bug: 1082688 Change-Id: I2d18f7a13b74caa89a9bd6c56eb9241bb2f5513d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217753Reviewed-by:
-
Frank Tang authored
This reverts commit d90baa9e. Reason for revert: reland ICU67.1 after #if 0 the problematic new code Fix in 630b884f84d Original change's description: > Revert "Roll ICU to 67.1 f2223961" > > This reverts commit db2cb995. > > Reason for revert: caused 30ms startup performance regression on Windows > > Original change's description: > > Roll ICU to 67.1 f2223961 > > > > ICU 67.1 release notes: http://site.icu-project.org/download/67 > > ICU 66.1 release notes: http://site.icu-project.org/download/66 > > CLDR 37: release notes: http://blog.unicode.org/2020/04/unicode-locale-data-v37-released_23.html > > > > 1. Update to 67-1 > > Diary https://docs.google.com/document/d/1ZDtSPa3ZkzBIJmqrDVmGmyrTihjx8Me4fKQoQcBj02E/edit# > > > > Size changes: > > 65-1 . 67-1 > > 7786368 7778704 android/icudtl.dat > > 6412768 6400752 android_small/icudtl.dat > > 1418320 1430976 android_small/icudtl_extra.dat > > 5060880 5048912 cast/icudtl.dat > > 10481632 10470736 chromeos/icudtl.dat > > 10506736 10498032 common/icudtb.dat > > 10506736 10498032 common/icudtl.dat > > 900576 . 898416 flutter/icudtl.dat > > 6375984 6363968 ios/icudtl.dat > > > > > > Bug: 1064326, 827538 > > Change-Id: I169e1f99514b36cafd54a6bc8a9914ccf222d008 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Commit-Queue: Frank Tang <ftang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#764138} > > TBR=machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1064326, 827538, 1080367 > Change-Id: I98ebe6e01631b10ecc1955ac9d3bc53be11e23c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209232 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771137} TBR=wittman@chromium.org,machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1064326, 827538, 1080367 Change-Id: I6d255bac08a68d6716ac51d84765acc010c6a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220363Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773036}
-
Joel Hockey authored
Refactor only change. Change places where vm_name and container_name are being used in a function to use ContainerId, and particularly ContainerId::GetDefault. TBR=haraken@chromium.org Bug: 846190 Change-Id: Iaa545c750aa979cceff74c87e89ef4bd21867f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220106 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773035}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590695681-757fb4797cdbf3f0b9decd998cf3c3173838cd05.profdata to chrome-win32-master-1590710362-da8362c2cf2dc829b7840d09501bff322abdb5d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I77cda28cd5c5d87d7504f2c602bcd20e98c83524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220887Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/209cf8fa408b..33004b09f180 2020-05-28 ynovikov@chromium.org Roll VVL and Headers to v1.2.141 2020-05-28 cclao@google.com Add egl::ShareGroup class to abstract the share context group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7cf697c45192608ca0c1a74f6ed80b4f1744c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220702Reviewed-by:
-
