- 21 Jan, 2021 28 commits
-
-
Andrew Grieve authored
Bug: 1168298 Change-Id: I4ddebb5e7e2c21b88b0b98877b1f2e802b58bd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639154Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#845442}
-
Tal Pressman authored
This is no longer the recommended style and, in fact, https://abseil.io/tips/141 recommends against relying on implicit conversions to boolean in conditions. Change-Id: I42c2ea59e23deb6f97ac187bef13d32861873444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636975Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#845441}
-
Charlie Reis authored
The reload detection in NavigationEntryCommitted depends on stale code that is being removed, and using a NavigationHandle in DidFinishNavigation is a more modern approach. This CL updates the check accordingly so that we can remove NAVIGATION_TYPE_SAME_ENTRY. Some duplication occurs due to https://crbug.com/1064974. Bug: 536102, 1064974 Change-Id: I7b908770cfceebc696bff9e900da78c28d1b2f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628652Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#845440}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/extensions. Bug: 1148570 Change-Id: I1e7b85a60ee05d8859fc1d507742a4c08fb6c5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638568 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845439}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea71c6b63417..bb3adfa42822 2021-01-20 syoussefi@chromium.org Rename ShaderVariable::structName to structOrBlockName 2021-01-20 geofflang@google.com EGL: Respect eglMakeCurrent with a null context. 2021-01-20 penghuang@chromium.org Support switch surfaces for external context. 2021-01-20 jmadill@chromium.org Capture/Replay tests: Use failure exit code. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1167718 Tbr: cnorthrop@google.com Change-Id: I0ce4cb4294a1a73c52c826a5d2ab2fd2e6364480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845438}
-
Mila Green authored
Bug: 1144151 Change-Id: I22c49e8d38c9690214b1747bfd3b589e68a950a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640732 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845437}
-
Eugene But authored
Bug: None Change-Id: Ie121c32537557f5868c66e38fc125a48b407638f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638400Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845436}
-
edchin authored
This CL makes it possible to further extract web_contents from the base classes of PasswordProtectionService and PasswordProtectionRequest which will be moved to /core. The content or ios derived class implementations of MaybeReportPasswordReuseDetected can extract WebContents or WebState respectively from the request object. Bug: 1147967 Change-Id: I20788bec17c7e6e99855a52a76260846e930b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633851 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#845435}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib5b87fde60a63d695c4e3d133280adc797cb9511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640887Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d681a1a..f9759b6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8cebc031ef1001edc5eacca8208060998334b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639303Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845433}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/064f33e4416e..762814bd9229 2021-01-20 cwallez@chromium.org ityp_array: Allow using a T whose underlying type is signed. 2021-01-20 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from ed14524b1e81 to afb8cfb2544b (1 revision) 2021-01-20 cwallez@chromium.org Vulkan: Fix texture barriers for readonly storage. 2021-01-20 cwallez@chromium.org Vulkan: Fix buffer barriers for readonly storage. 2021-01-20 cwallez@chromium.org Vulkan: use VK_EXT_debug_utils instead of deprecated extensions. 2021-01-20 senorblanco@chromium.org Implement a glCopyImageSubData() workaround for OpenGL ES 3.1 Also rolling transitive DEPS: https://dawn.googlesource.com/tint from ed14524b1e81 to afb8cfb2544b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I0c95906817294e7b665d85298a54b06ac357bfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641176Reviewed-by:
-
Leonid Baraz authored
After rollback, death test has been removed, since it is dependent on DCHECK, and can fail to die on optimized configuration. Bug: b:159361496 Change-Id: I59232cd8ad1112351deffa2cb2c807dbe99fdf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640646 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#845431}
-
Markus Handell authored
I previously added a CHECK that the heights of all planes match between media::VideoFrame and CVPixelBuffer. This ended up getting hit. Add a DumpWithoutCrashing to see exactly what the triggering parameters were. Be robust to non-matching plane heights or widths by copying only the intersection of the media::VideoFrame and CVPixelBuffer sizes. Bug: 1168112 Change-Id: Ic78d4292d6a89e19119719dc2c105e4266e16902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638520Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#845430}
-
Kent Tamura authored
This CL updates the custom state pseudo class syntax from :state(foo) to :--foo. See https://github.com/WICG/custom-state-pseudo-class/issues/6. This feature is not shipped yet. Bug: 1012098 Change-Id: I71bd92113d89b073cdeba3b6ab78d2c7f0e091dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636075Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#845429}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a9da73687e3..dd069a9188cc 2021-01-20 mtklein@google.com add interleaved load and store instructions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Iede5eb0598f91d1837f18c4f01eae66d39cabbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640229Reviewed-by:
-
Benjamin Beaudry authored
After CL:2610264 landed, I got more feedback. I'm addressing it here. Change-Id: Id05c9671e17496f3cab4eb907b0514ab2f3f2d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638004 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845427}
-
Chris Lu authored
This change move the fullscreen inset updates to happen alongside the size transition animation. The change in web content size will then not happen after the transition finished, producing a cleaner experience. Fixed: 1168154 Change-Id: I048c763ffbc0d3723833a003b3a9a79c8a8c58cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641115Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611165592-b5253c098e9c7fa5265e7248ae4df5f8c48efe50.profdata to chrome-win64-master-1611176356-4b0456d54b0928899e317c11eb73b969caf82aca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40d18df23114d98e185e6dc582a92d8af829a277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641175Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 89.0.4389.9. R=martiniss@chromium.org Bug: 1041619 Change-Id: I30fd20f4e65709bb57703054eef41eaf14afa4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640916 Auto-Submit: Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15c630fcaa35..124f532d052d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968,chromium:1168574 Tbr: harringtond@google.com Change-Id: I1c43e69a278c85ddd979aca02182c51d285e631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640855Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845423}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e27e7488e4ad..1d5174b9dc3b 2021-01-20 srisser@google.com Implement VK_KHR_depth_stencil_resolve 2021-01-20 amaiorano@google.com Move reusable Vulkan code from VulkanBenchmarks to new VulkanWrapper library If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5b929d6d7c833951382d6f812a9ea8a42695f889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641013 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Haiyang Pan authored
With crrev.com/c/2637092, "package_paths" prop is removed so there is no need to keep packager_vars.star. Also set the package_prefix for trybot to "chromium_3pp". Currently 3pp uploads package sources to CIPD, even with "force_build" set to True (Behavior to-be-changed). With this package_prefix, sources will be uploaded to CIPD path "experimental/chromium_3pp" Bug: 1132368 Change-Id: I3b3e7cc36badda7687da967c2e4681bfcea6187f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639229Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#845421}
-
Tim Sergeant authored
The Shadow APKs feature (see crrev.com/c/2548592) needs to convert between ARC++ and App Service types for IntentFilters, and will in the future need to do the same for Intents. This CL moves the conversion functions to intent_util.h, where they can be accessed by Shadow APKs code. BUG=1099134 Change-Id: I291d10c8ce53ed1890453c0f676b94e4c39121cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639055 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845420}
-
chinsenj authored
This CL animates the toggle slider for the alt-tab mode toggle slider. Test: manual Bug: 1157087 Change-Id: Ide73ce93aa0238c8927411cdf4489f7581a22d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638153 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#845419}
-
Haiyang Pan authored
With crbug.com/1166997 fixed, the test suite turns green in trybot now. The test pool usage is a bit high (http://shortn/_unkbNiWpws), but the swarming task pending time is acceptable (http://shortn/_WCL47QSQOd), despite the one on 1/19 due to test regression. Bug: 1111436 Change-Id: Ied1639acdd124d041e2d55dbe02b66a5aa661214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639370Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#845418}
-
Takumi Fujimoto authored
If the DIAL receiver returns an HTTP error, we record in a histogram that we received one, and return the response code to the sender via an SDK message. Bug: 1153895, b/171829399 Change-Id: Ia0487099f426df05e04b8092f0be7fa9a2584ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618519Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#845417}
-
Noel Gordon authored
Bug: 1168436 Change-Id: I59adea182ac7dfaa4dfd2b24e64eb032c83e3b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631397Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#845416}
-
Sebastien Marchand authored
The PerformanceManager page freezing policy doesn't take into account the loading state of a tab when emitting freezing signals. As a result some unloaded tabs can receive a freezing signal and there won't be another freezing attempt once the tab gets loaded. This fix this problem by waiting for the tab to transition to the loaded state before emitting the freezing signal. Bug: 1168735 Change-Id: I13b92600a2df7fa8bfc592a2711cb33b0631e409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641154Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#845415}
-
- 20 Jan, 2021 12 commits
-
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I53ad5058338326c796b35d2141f2051d683aa149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616742Reviewed-by:
Joon Ahn <joonbug@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#845414}
-
Michael Thiessen authored
Adds a new Extra to intents created from the Open In Browser CCT Menu item so that we can differentiate them from other View intents received by ChromeTabbedActivity for the purposes of LaunchCauseMetrics Bug: 1163961 Change-Id: I18550a1b6cf5813771e56f8ae7b7f0a22d4fee3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639301 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845413}
-
Renjie Tang authored
Currently this has no real impact because connection migration isn't enabled in IETF QUIC. But once we start experimentation, an explicit flag check will help us turn on/off the feature. I'll follow up by adding DCEHCK in QuicConnection. Bug: 1155306 Change-Id: I1794edb3c528bfa42910d88f394fd024f0f3021f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641089 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845412}
-
adamta authored
Uses the content suggestions content height to adjust the feed inset and offset correctly. This revealed that the content suggestions height was not taking the safe area insets into consideration, so they are now handled across the refactored NTP. Also fixes occasional crash when changing between NTPs by ensuring that the fake omnibox doesn't have multiple parent views/VCs at once. Bug: 1114792 Change-Id: I458365dc5c494fcc3155cff53e9a368988d83538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635450 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#845411}
-
Peng Huang authored
Bug: 1168584 Change-Id: I7eb840feafb2ba0c734713f88d48bcd822004472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640933 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#845410}
-
Wojciech Dzierżanowski authored
Several Picture-in-Picture browser tests require video playback to have started, but they didn't really enforce it considering that the `play()` method of the media element is asynchronous. In particular, a test verifying the visibility of a control bound to a MediaSession action might never see the control: The control is visible when the video is actually playing and also it's hidden automatically 2.5 s after the start of mouse hover. If playback doesn't start during those 2.5 seconds (which is plausible if the test machines are under heavy load) the hiding timeout will elapse first. Bug: 985303 Change-Id: I7f9d62e8496cb5419445dd27c94fde91d541a6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635156Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#845409}
-
Dirk Pranke authored
The script had a couple of issues that crop up with Python3's str/bytes/unicode changes. Bug: 1168342 Change-Id: Ic1ff68d099245bcf5b39382bc5f3919fd13609a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638785Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#845408}
-
Juanmi Huertas authored
According to the standard https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html when creating a new ImageBitmap that has resizeWidth or resizeHeight equal to 0, it has to throw an exception. As in some cases, user can provide value between 0 and 1, these will be rounded down to zero (as according to the standard those resizeWidth and resizeHeight is a unsigned long, so it cannot have decimal values). Bug: 1137216 Change-Id: I4a0b241fa8a94cc6b59c77bb1313f7a4d7983733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636373Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#845407}
-
Lei Shi authored
When resuming from the end of a nodeGroupItem, findNodeFromNodeGroupByCharIndex returns a node with a -1 offset. This will throw exceptions. This CL fixes this bug. Bug: 1167260 Change-Id: I2fe466a07f3daa2103dec53e6ebcedd5be27d285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638863 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#845406}
-
Gavin Williams authored
Screenshot: http://screen/6yMAYdeURT7ZxWm Bug: 1168641 Change-Id: I019bfed56e7e0f4e26fa3d6b9d4a71939a256348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640637 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845405}
-
Dan Harrington authored
We're no longer blocked on using lottie, see crbug.com/1116501 I was able to confirm a lottie animation works. Bug: 1158468 Change-Id: I05724d6f24630195e8eed0ec985edcc6792e9337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636848Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#845404}
-
Kenton Lam authored
Defaults to the current emoji ordering from emoji-metadata, but this will allow smaller emoji data files to be used for tests. Change-Id: Ibc3ffdeb0c05f7ad9c3880c899c92ef6dc6cbcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639713Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#845403}
-
