GitLab

Previously, this action would only allow setting the text of input fields. Now, it also supports pressing Enter or any other available key on the keyboard.

Bug: 806868
Change-Id: If1617d444790575c14f8f822df8b20938d592863
Reviewed-on: https://chromium-review.googlesource.com/c/1350609
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611355}

There are several uses of |privates| in the guest view js that are used
as if it were a means of making properties inaccessible from outside a
class (like what private does in C++). |privates| only hides
properties from outside the extension system implementation.

We remove uses of |privates| where the receiver is already inaccessible
from outside the extension system implementation.

Bug: 900940
Change-Id: Ib583aefe9daa22e095d387ffab430429870796fc
Reviewed-on: https://chromium-review.googlesource.com/c/1336052Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611354}

When a page requests permissions, a prompt will show on the desktop
display. This change allows a notification to show in-headset so the
user knows to look at the prompt on the desktop display.

BUG=819448

Change-Id: I55801326c41b1b152da5ee80ed7ef62107184de8
Reviewed-on: https://chromium-review.googlesource.com/c/1332690
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611353}

Also changes what happens when the drag ends during a nested move loop.  It
now exits the move loop (which triggers a drag end) instead of immediately
ending the drag.

This is the first step in a larger refactoring for TabDragController:
go/tabdragcontroller-untangling

Change-Id: I6cabc5237a604320c934bb8b5d4bbc9ff6d231f0
Reviewed-on: https://chromium-review.googlesource.com/c/1285085
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611352}

https://pdfium.googlesource.com/pdfium.git/+log/b4c95fe2ded4..adb9e705092b


git log b4c95fe2ded4..adb9e705092b --date=short --no-merges --format='%ad %ae %s'
2018-11-27 tsepez@chromium.org Add Widestring::{To,From,Is}ASCII()


Created with:
  gclient setdep -r src/third_party/pdfium@adb9e705092b

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iac2e589d589766a109f33f92547f6e36dc6cd953
Reviewed-on: https://chromium-review.googlesource.com/c/1352246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611351}

This CL lands server change 221616382 by bnc.

BUG=488484

Change-Id: I2f8d913b85d57a565da11572e8dc87b6c3a6495b
Reviewed-on: https://chromium-review.googlesource.com/c/1341092Reviewed-by: Dianna Hu <diannahu@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611350}

Test parsing and computed value for
https://drafts.csswg.org/css-position/

- bottom left right top
- position
- z-index
- inset-after inset-before inset-end inset-start (not currently implemented)

Change-Id: I586271fe584fadb19e5683a2781c32142fd9001a
Reviewed-on: https://chromium-review.googlesource.com/c/1350409Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611349}

Prior to the conversion to MVC, there was de-duping logic:
https://chromium.googlesource.com/chromium/src/+/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java#1728

In the MVC conversion, this was dropped because the view
de-dupping was enhanced, but that discounted the fact that
notifyDataSetChanged always triggers a relayout on the
ListView even if the data is the same and would be no-op'd
when updating the individual views.

This ensures that we are not triggering unnecessary layouts
as we get duplicate omnibox suggestions.

With naive logging, I was seeing that each keystroke was
getting at least one set of duplicate suggestions received,
so this should save many layouts during the course of typing.

BUG=905742

Change-Id: I8ec9e5794c4e43687c7a30fc944976c6d63cbce9
Reviewed-on: https://chromium-review.googlesource.com/c/1352188
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611348}

Does not remove/change any code except for the simple decision logic that's using the feature.

Bug: 870836
Change-Id: If6f0bc54954cc1d95c6be4f4a1426e51327cefad
Reviewed-on: https://chromium-review.googlesource.com/c/1350909Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611347}

A WebAPK is valid if all the requirements below are true:
Requirement#1: The APK is correctly signed (WebApkValidator#isValidWebApk())
Requirement#2: The APK handles the URL in the intent (WebApkValidator#canWebApkHandleUrl())
Requirement#3: The APK has <meta-data> in a format that Chrome can read.
  (WebApkInfo#create() returns non-null)

This CL changes the logic in WebappLauncherActivity to make Requirement#3 clearer. This CL:
- Introduces WebappInfo#isForWebApk() and makes WebappLauncherActivity use this instead
  of the return value of WebappLauncherActivity#isValidWebApk() which did not check
  Requirement #3.
- Changes WebApkValidator#canWebApkHandleUrl() to no longer check whether the passed in
  APK package is a valid WebAPK. This reduces the number of extras read directly in
  WebappLauncherActivity (outside of WebApkInfo#create/WebappInfo#create)

BUG=901954

Change-Id: I51ef612c641d9d7c2e9535db33f0baee17694edb
Reviewed-on: https://chromium-review.googlesource.com/c/1351456
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611346}

 - remove drive_sync_handler_unittest.html
 - add BUILD rules to auto-generate and compile this unit test
 - BUILD: progress center does depends on cr.EventTarget
 - BUILD: drive sync handler does depend on AsyncUtil.Queue
 - define and use a mockChrome, and install it during tests
 - fix Closure compile errors

Bug: 907964
Change-Id: I464f4fb43e2ab145f1a6c85b53f8292a8a2c69fc
Reviewed-on: https://chromium-review.googlesource.com/c/1352113
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611345}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b1a6401f31b..af1cdca8c140


Created with:
  gclient setdep -r src-internal@af1cdca8c140

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:904780,chromium:767130
TBR=mmoss@chromium.org

Change-Id: Ia8900c03cbe783391f05b9bdf387a46221f1cc10
Reviewed-on: https://chromium-review.googlesource.com/c/1352237Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611344}

The |argument_filter_predicate_| is not set in the GPU process.
The CHECK is triggered in the GPU process when flushing the buffer.

void TraceLog::FinishFlush(int generation, bool discard_events) {
  [...]
    if (trace_options() & kInternalEnableArgumentFilter) {
      CHECK(!argument_filter_predicate_.is_null());
      argument_filter_predicate = argument_filter_predicate_;
    }

7923:197923:1121/151153.522324:FATAL:trace_log.cc(997)] Check failed: !argument_filter_predicate_.is_null().


We tried with a CHECK to catch this case early in
base::trace_event::TraceLog::SetEnabled(...).
Which make the test fail here:

[202280:202280:1121/152013.218605:FATAL:trace_log.cc(587)] Check failed: !trace_config.IsArgumentFilterEnabled() || !argument_filter_predicate_.is_null().

The current solution is to provide a default safe predicate filter in this case.

R=oysteine@chromium.org

Bug: 642991
Change-Id: Id52357299d170e66596081b8a020a42f9589754e
Reviewed-on: https://chromium-review.googlesource.com/c/1348633
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611343}

This will lessen the code review noise in an upcoming commit.

Change-Id: I4e933def4b6a10f45ce7545ce990c646a04a7aa4
Reviewed-on: https://chromium-review.googlesource.com/c/1349512Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611342}

When offering save of expired credit cards with the expiration date fix flow,
disables showing the outdated expiration date initially imported (because it
will be changed to whatever the user enters in the fix flow anyway.)

Bug: 899057
Change-Id: I79c1861046768f0f5470e4c73834784472f29f91
Reviewed-on: https://chromium-review.googlesource.com/c/1350880
Commit-Queue: Hao Zhang <hozhng@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#611341}

This relands commit f481306a. The CL
got reverted because BrowserMainLoopTest.CreateThreadsInSingleProcess
is falling on Windows. In this CL, we remove the call of
BrowserMainLoop#InitilaizeMojo() which isn't necessary for the test.

Beside, also re-enable two tests which were disabled when the reverting
CL landed:
 * RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler

The original cl description is:
This CL instantiates the ServiceManagerContext before creating
the BrowserMainRunner. It splits the startup path into two,
with/without starting the full browser. The changes are implemented
behind a flag "allow-start-service-manager-only".

Bug: 846846,902311
Change-Id: I6e3f6518e414e1298e57b55bd188879461d8f342
Reviewed-on: https://chromium-review.googlesource.com/c/1327413
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611340}

Bug: 889029
Change-Id: Ib8e3967d73a0844ba0d0a9ddb318168e0de1594d
Reviewed-on: https://chromium-review.googlesource.com/c/1349459
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611339}

Move to 4 targets:
common_lib, ui_lib, test_lib, app_framework

Based on the EG2 xcodeproject on github.

Also rolled EG2 to a more recent commit hash.

Bug: 906201
Change-Id: Ifee6d4de17d8df930ac4760714ee32b0cab89cb5
Reviewed-on: https://chromium-review.googlesource.com/c/1340531Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611338}

This is a reland of 409ceb85

Original change's description:
> GWP-ASan: Add crash handler hook.
>
> After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad
> UserStreamDataSource) is responsible for looking at the crash and
> 1) determining if the exception was related to GWP-ASan, and 2) adding
> additional debug information to the minidump if so.
>
> The crash handler hook determines if the exception was related to
> GWP-ASan by finding the AllocatorState address (using a crash key),
> reading the allocator state and seeing if the exception occurred in the
> bounds of the allocator region. If it did, we extract debug information
> about that allocation and report it in the minidump.
>
> CQ-DEPEND=CL:1339246
>
> Bug: 896019
> Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a
> Reviewed-on: https://chromium-review.googlesource.com/c/1330283
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611033}

TBR=bcwhite@chromium.org

Bug: 896019
Change-Id: Ibc35c33ccc816cd2436412e2c6f399908161e7e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351935
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611337}

This change moves the error toast to the dialog when mounting an SMB
share.

Previously the flow was:

- Click add mount
- Dialog closes to SMB Shares parent page
- Error/success string is displayed on parent page

Now the flow will be:
- Click add mount
- Dialog stays open but add button becomes disabled
- Error/success string is displayed on dialog itself

An added advantage of this change is that it improves user experience
as it is easier for users to debug error cases when the dialog is still
open and they can still see the information they entered.

Bug: chromium:887135
Test: browser_tests --gtest_filter=CrSettingsSmb*
Change-Id: I6f68cd71a0002372a45975b3d8602809b36a6754
Reviewed-on: https://chromium-review.googlesource.com/c/1316664
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611336}

As cold mode idle time spellchecker is shipped into M69 Stable
and no regression is obversed, this patch removes the flag as
cleanup.

Bug: 716642
Change-Id: I0b75e7592be063cb53ee9eb68dbf3f0c1af48dd4
Reviewed-on: https://chromium-review.googlesource.com/c/1351869
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611335}

Bug: 581518
Change-Id: Icc8ef5e53428500a54695bf1a70cda139556ba67
Reviewed-on: https://chromium-review.googlesource.com/c/1349669Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611334}

They're not used and this change can be easily reverted to add them back.

Bug: 908717
Bug: 906936
Change-Id: I81f866c7491a84c1c5b0c87c023d3e43cf9d3a8c
Reviewed-on: https://chromium-review.googlesource.com/c/1352330Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611333}

I want to fix some incorrect function ordering in these files, but I
can't upload the CL because it moves a banned base::Closure.  Thus, this
CL fixes that problem first.

Change-Id: I45142929b28015f18d1d848be8cc9eca6ac2f614
Reviewed-on: https://chromium-review.googlesource.com/c/1351256Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#611332}

In https://chromium-review.googlesource.com/c/chromium/src/+/1315962,
code was added to add a separate ImageDecodeCache per color space
(rather than storing color space on the image objects).  However,
because CanvasResourceProviders post a task to clean up these locks,
the high water mark for discardable memory could be much higher if
multiple canvases with different color spaces are used.  This has
resulted in crashes in shared memory allocation.

To work around this for software mode, release locks immediately.
This lets the software decodes rely on the discardable system itself
to handle the caching behavior instead of blindly locking them until
javascript was done executing.

Ideally all of this code can be eliminated in the future, which is why a
workaround is employed here instead of something more complicated.

Bug: 907100
Change-Id: If6380b9e40f6334c125581c2c65f72543d6bb745
Reviewed-on: https://chromium-review.googlesource.com/c/1351773Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611331}

It would be great if I could review changes like
https://chromium-review.googlesource.com/c/chromium/src/+/1352339
since I am taking ownership of benchmarking project as a whole.

Change-Id: I9c7b65adb5e18e30c6b9c6cdf1fb9f74ff064aea
Reviewed-on: https://chromium-review.googlesource.com/c/1351561Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611330}

This reverts commit 282d95d7.

Reason for revert: Still has a missing dep:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928671892382176864/+/steps/compile__with_patch_/0/stdout

Original change's description:
> Reland "Cronet: Simplify Android GN logic for srcjars by not using them"
> 
> No need to zip up the generated source just to unzip it again :P
> 
> This reverts commit f4e7bed3.
> 
> Reason for reland: Fixed missing deps in __final_jni template
> 
> TBR=pauljensen@chromium.org,agrieve@chromium.org
> 
> Bug: 908479
> Change-Id: I1177d550eb33737f47192bd70db5358c6392598c
> Reviewed-on: https://chromium-review.googlesource.com/c/1351930
> Commit-Queue: agrieve <agrieve@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611108}

TBR=pauljensen@chromium.org,agrieve@chromium.org

Change-Id: I5f10f94e023f7413fb19d85624013fbddcb732a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908479
Reviewed-on: https://chromium-review.googlesource.com/c/1352516Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611329}

TBR=bnc@chromium.org

Change-Id: I789217b4d8eac5be728a38077fb0b0ddc238de36
Reviewed-on: https://chromium-review.googlesource.com/c/1351895Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611328}

Previously, out of process calls to AssistantScreenContextController and
AssistantSetupController were proxied through AssistantController. Now,
we expose those subcontrollers directly for binding.

Bug: b:119272394
Change-Id: I136d0e025761b4fe99151218512f83eeb00a6541
Reviewed-on: https://chromium-review.googlesource.com/c/1327532
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611327}

- When suggestions are shown,
- When a suggestion has been selected.

Added UMA histograms, and extended unit test coverage of some metrics.

Also tested manually by looking at local histograms after playing around a test page.

Bug: 907902
Change-Id: I5f7a363416d3c0c4b7e1b44a782d5205ed7a6787
Reviewed-on: https://chromium-review.googlesource.com/c/1352331Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611326}

https://chromium.googlesource.com/angle/angle.git/+log/5552cdf032dd..4f2b94cb9a6b


git log 5552cdf032dd..4f2b94cb9a6b --date=short --no-merges --format='%ad %ae %s'
2018-11-27 geofflang@chromium.org Expose EXT_color_buffer_half_float if RGBA16F is renderable.
2018-11-27 jiajia.qin@intel.com ES31: Add swizzle support in SSBO (Part 1)
2018-11-27 jdarpinian@chromium.org WebGL, D3D: Forbid multiple TF outputs in one buffer


Created with:
  gclient setdep -r src/third_party/angle@4f2b94cb9a6b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866089
TBR=fjhenigman@chromium.org

Change-Id: I2f9f64d4e1a188df1612ecfb8c66b6129dc5a202
Reviewed-on: https://chromium-review.googlesource.com/c/1352244Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611325}

Bounds passed over mojo should be in Screen coordinates since
Chrome and Ash do not share a common window tree in Mash.

For comment-only change to keyboard_controller.mojom:
TBR=tsepez@chromium.org

Bug: 843332
Change-Id: I40cee828ee5872cf69c4589141a9bb79c7c08cee
Reviewed-on: https://chromium-review.googlesource.com/c/1351801
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611324}

I also added a unit test for occlusion tracker pause during
overview transition.

Bug: None
Test: covered by unittests.

Change-Id: I5e8441e176eaa0dc9793d22059edb22e357d899e
Reviewed-on: https://chromium-review.googlesource.com/c/1344888
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611323}

If there are no visible app windows, restoring app window wasn't re-registering
events because OnWindowVisiblityChanged notification wasn't generated for root window.

Add unit test for going from visible to hidden to occluded.

Bug: 813093
Change-Id: I11b5fd7c7dc104ec74699c8e66aa06d9954a5977
Reviewed-on: https://chromium-review.googlesource.com/c/1326621
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611322}

Allowing overflow scrolling lets users with high page zoom
settings scroll across and down overflowing content.

Bug: 899774
Change-Id: I9bb6a8ea622b61c1d7b76d3cadb0f9be694fe4d3
Reviewed-on: https://chromium-review.googlesource.com/c/1343191Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611321}

This CL aligns the IDL with the spec. Intent to Ship:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/Z3RKovFsA1s/DWt78xngAgAJ

Bug: 898768
Change-Id: I88dbc89d30aac7840c47d727d2ed3c8044452b68
Reviewed-on: https://chromium-review.googlesource.com/c/1352429Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611320}

Currently RenderWidgetHostViewAura allocates a new LocalSurfaceId upon
Navigation. However if this navigation is for a hidden view, then we are
allocating very early. This has skewed the statistics for embedding times.

This updates RenderWidgetHostViewAura::DidNavigate to Invalidate the
LocalSurfaceId if hidden. A new one will be allocated once the view is shown.

Bug: 655231
Change-Id: I86cc4efade8b927149f57323281a87b0dcd1aac3
Reviewed-on: https://chromium-review.googlesource.com/c/1347446
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611319}

This is to ensure the memory is properly released on the GPU process side.

Bug: 905495
Change-Id: I152494878a602e748eefb29f0f91f364e6752e42
Reviewed-on: https://chromium-review.googlesource.com/c/1347355
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611318}

This ensures that that token is always at the end of
a token chunk. This is important because the parser can
only yield or pause at token chunk boundaries. Pausing
may be forced by a custom element because its createdCallback
routine may add a stylesheet, which blocks the HTML parser.

Bug: 904966

Change-Id: I9252067f435d048b860cc9725ba23d829c9f644d
Reviewed-on: https://chromium-review.googlesource.com/c/1351366Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611317}

https://skia.googlesource.com/skia.git/+log/4f83c59eea19..09523b43fc28


git log 4f83c59eea19..09523b43fc28 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4ad2322aa9cf..67c93d206431 (1 commits)
2018-11-27 mtklein@google.com Reland "move decal_filter_scale inline, walk decal in 32.32""
2018-11-27 brianosman@google.com Remove tonalshadows GMs
2018-11-27 reed@google.com Revert "migrate to passing paint/ctm for bounds"
2018-11-27 borenet@google.com [infra] Blacklist another SKP for IntelHD405 Vulkan perf bot
2018-11-27 mtklein@google.com Revert "move decal_filter_scale inline, walk decal in 32.32"
2018-11-27 michaelludwig@google.com Reland "Optimize trivial per-edge aa rect tessellation"
2018-11-27 mtklein@google.com move decal_filter_scale inline, walk decal in 32.32


Created with:
  gclient setdep -r src/third_party/skia@09523b43fc28

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: I4c858d036efb7c4ed9c94a64b17c2e563594b677
Reviewed-on: https://chromium-review.googlesource.com/c/1352241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611316}