- 16 Aug, 2018 40 commits
-
-
Annie Sullivan authored
Bug: 874935 Change-Id: Ic5959bd2f22097f6534248d9c1f15323f8ebe57b TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1177890Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583672}
-
rbpotter authored
In Polymerized Print Preview, the event target is always print-preview-app, which does not have an ancestor with a scrollbar even if one exists on the page (e.g. in the settings sections). Examine the event path instead of the target and its ancestors to determine if there is a scrollbar that should receive the arrow key events instead of the plugin. Bug: 872251 Change-Id: I034542d04644e1b47fd1961a9b984a48843b2b40 Reviewed-on: https://chromium-review.googlesource.com/1174995 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583671}
-
W. James MacLean authored
There have been no flakes reported on EmulatedTouchPinchGoesToMainFrame since https://chromium-review.googlesource.com/c/chromium/src/+/1172723 went in, so let's try re-enabling some more tests. Bug: 833380 Change-Id: If406a6f5d7b0a88e84cad84e07d1bba547eb1baa Reviewed-on: https://chromium-review.googlesource.com/1177843Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#583670}
-
Arthur Sonzogni authored
Some builds timed out recently: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester Bug: 874840 Change-Id: I31aa161ef63488debb8c3fe38f71c096fe132207 Reviewed-on: https://chromium-review.googlesource.com/1177703 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583669}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874931 Change-Id: I49375c4593122e9a3a1f8c06ffa3969b6fa1ea1c Reviewed-on: https://chromium-review.googlesource.com/1177904Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583668}
-
Siddhartha authored
Change-Id: I1f9f3f47933ef13a0a69f999e7ddd2b021affa16 Reviewed-on: https://chromium-review.googlesource.com/1177197Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#583667}
-
Gauthier Ambard authored
The FindInPage activity should only be shown when the FindInPage action is doing something. This CL adds a BOOL to know if the page can be searched. It is used to display the activity or not. Bug: 871260 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I35dacc9c1adf1410f1c080af672f9abf2b5ec37f Reviewed-on: https://chromium-review.googlesource.com/1174114Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#583666}
-
Paul Jensen authored
This API was entirely unused so it was allowed to be removed from the API previously in crrev.com/571588. This CL cleans up the ICronetEngineBuilder and api.txt references as they're no longer needed. Removing an API isn't normally allowed, so this required temporary modification of the API update checks to rebuild api.txt. Bug: 857693 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I1bffb016f781aeb5116d8507245630dedacbb14b Reviewed-on: https://chromium-review.googlesource.com/1148019Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583665}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874929 Change-Id: Id81d25adc31cf8c34c0fd5c00b1d1fb7a4390000 Reviewed-on: https://chromium-review.googlesource.com/1177885Reviewed-by:
-
Aldo Culquicondor authored
The RenderLoopFactory is responsible of instantiating the delegates that Ui and RenderLoop require. In this CL, we are still instantiating a VrShellGl object, as the split-up has not been completed yet. Also, we make sure that the variables passed to VrGLThread are freed once the RenderLoop has been built. The testapp starts to be prepared to make use of RenderLoop. We simplify the VrTestContext creation (soon to be the RenderLoop) by initializing it once a GL context was set. Bug=767282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie0f580f77fb109463dc41093919a7c535976e321 Reviewed-on: https://chromium-review.googlesource.com/1175852Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#583663}
-
Gemene Narcis authored
This CL adds six histograms. Three histograms are for HTTP credentials with HSTS enabled and the other three are for HTTP credentials without HSTS enabled, and they are supposed to count the next cases: 1) Number of HTTP credentials for which no HTTPS credential for the same username exists. 2) Number of HTTP credentials for which an equivalent (i.e. same host, username and password) HTTPS credential exists. 3) Number of HTTP credentials for which a conflicting (i.e. same host and username, but different password) HTTPS credential exists. All six are recorded once for the profile on startup with a delay of 60 seconds. Bug: 871140 Change-Id: I231ad82ab1e5d74520cd4c9be4e3cad62645c3d1 Reviewed-on: https://chromium-review.googlesource.com/1163243Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#583662}
-
sunxd authored
The original name is confusing given that there might be passive event handlers, but the function only returns true if event listener property is Blocking or BlockingAndPassive. This CL renames the function name for better readability. Bug: 841364 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia6e28347e33fd28d3cc4954b307010fe2861dbfb Reviewed-on: https://chromium-review.googlesource.com/1176108Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#583661}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874915 Change-Id: Id0fae86ef2e130185d92ad28383c74036dcd96f3 Reviewed-on: https://chromium-review.googlesource.com/1177881Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583660}
-
Oskar Sundbom authored
By putting these parameters in a struct, future changes to parameters accepted by audio sinks can be made easier, without changing so many dependencies. This CL also adds an optional 'processing_id' parameter to audio sinks. It will be used to associate input and output streams for audio processing, when it's running in the audio service. At this point, the id doesn't get transferred along IPC. That's part of the next CL. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Tbr: kinuko@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I59a467d83d1516965bbbf06cd4fc49a3198c6cfb Reviewed-on: https://chromium-review.googlesource.com/1163884 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583659}
-
Annie Sullivan authored
Bug: 874810 Change-Id: I11ff44a55b4f2b14b8ba0a4ab5bb4e0f54cd8ef8 TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1177882Reviewed-by:
-
Fredrik Söderquist authored
Too deep recursions can cause stack overflows. Bug: 874759 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie532e28bceee4e7f1c3ab501b80c0e2f14be083a Reviewed-on: https://chromium-review.googlesource.com/1106378Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583657}
-
W. James MacLean authored
Instead of using GetOuterWebContents, which only return the immediate parent of this WebContents, use GetOutermostWebContents to check against the root of the web-contents tree, which in this case should be the app-view's web-contents. Bug: 873672, 823021 Change-Id: I421a64be495c575d22501328ec732794abc045f4 Reviewed-on: https://chromium-review.googlesource.com/1176342 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#583656}
-
Xida Chen authored
This is a follow up for https://chromium-review.googlesource.com/c/chromium/src/+/1174696 TBR=dtapuska@chromium.org Bug: 851644 Change-Id: I702bd9afc80a82d0b7db02cb8f06a1765c69aaaf Reviewed-on: https://chromium-review.googlesource.com/1177631 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Balazs Engedy authored
Ensure that FidoRequestHandlerBase only instantiates FidoDiscoveries for transports that are in the intersection of those supported by the client, and those allowed by the relying party; where the allowed transports are: (1) For MakeCredential calls: -- {BLE, caBLE, USB, NFC} if `authenticatorAtttachment` == `cross-platform`, -- {Internal} if `authenticatorAtttachment` == `platform`, -- (all) if `authenticatorAtttachment` == `any`. (2) For GetAssertion calls: -- (all) if `allowedCredentials` is undefined or empty, or if it contains an entry with `transports` undefined or empty, -- the union of `transports` lists in all elements of `allowedCredentials`. FidoRequestHandlerBase::Observer::OnTransportAvailabilityEnumerated is also changed to be consistent with this, i.e., the |available_transports| list in TransportAvailabilityInfo will also be this intersection set. Finally, the CL ensure that this method is always called on the observer, even if enumerating transports is finished before the observer is set. Bug: 866601 Change-Id: I00fbd6684fd52851149bdb0dd39800aafda54630 Reviewed-on: https://chromium-review.googlesource.com/1175118 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#583654}
-
Oskar Sundbom authored
It will be used both by content::MediaStreamAudioProcessor and the upcoming media::AudioProcessor. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Change-Id: I794558e46ab01fd2f367e1df2fababdefb712c4f Reviewed-on: https://chromium-review.googlesource.com/1170841 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Bug: 872904 Change-Id: Ia4ea4ff2de48680abc94bb0ff7c678a430c0cae4 Reviewed-on: https://chromium-review.googlesource.com/1176969 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#583652}
-
Juan Antonio Navarro Perez authored
Tag a selection of system health stories chosen to have a wide coverage for catching regressions, but run in a limited amount of time. The stories chosen caught more than 80% of system health memory mobile regressions in Q2 2018, and a single repeat of the entire set runs in under 20 minutes. Bug: 865959 Change-Id: I397cda35bb71dadf94bb2343c389d00cb8e80ec3 Reviewed-on: https://chromium-review.googlesource.com/1177396Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#583651}
-
Stephen McGruer authored
This reverts commit 2b5dfbb0. Reason for revert: Strong suspect for performance regression (https://pinpoint-dot-chromeperf.appspot.com/job/14a343e2640000), and disagreements on original CL implementation. Reverting until they can be resolved. Bug: 872123, 869387 Original change's description: > Add full saturate-to-infinity behavior to base::TimeDelta > > Before this CL TimeDelta had saturation behavior for translating > from/to other values, but had clamping behavior for its computation. > That is, invariants like the following did not hold: > > TimeDelta::Max() - TimeDelta::FromSeconds(1) == TimeDelta::Max() > > This CL fully implements saturation behavior, such that TimeDelta::Max() > and TimeDelta::Min() are treated as positive and negative infinity > regardless, with all the expected mathematical consequences. > > The one exception is that adding/subtracting a saturated TimeDelta to a > TimeClass is still undefined. This was left undefined because we are not > yet making a statement on whether TimeClass should be considered to have > clamping or saturating behavior for values outsied of range. > > See the linked bug, or also the discussion at > https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/S4umX2sOvrk > > Bug: 869387 > Change-Id: I2b3f98c69e7fc5030a6e210d75409d667b73c5ac > Reviewed-on: https://chromium-review.googlesource.com/1155264 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579969} TBR=gab@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869387 Change-Id: I7251e77bd66dc95c9b1aae16fbfc89acd239f19b Reviewed-on: https://chromium-review.googlesource.com/1175470 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#583650}
-
Leszek Swirski authored
Posted blocking ScriptStreamer tasks can end up in a queue, and have their Resource complete loading before the task even starts. When this happens, these tasks will no longer block on network input, but they will still be posted to the blocking task runner, which does not spin up new threads if the running task is not blocked. When there are a lot of small functions posted for streaming, this results in a slightly paradoxical starvation, where the blocking task runner is processing lots of no-longer-blocking tasks all in one thread, as it has no reason to spin up new threads. To avoid this, if a streaming task isn't started before the resource finishes loading, we can cancel this posted task, and instead post a new non-blocking task to the non-blocking thread pool. This frees up the blocking task runner to process only blocking tasks (and thus allows it to spin up new threads for them). Bug: chromium:865098 Bug: chromium:866868 Change-Id: Iceb282582781109ade233366d1009c3be50db3a5 Reviewed-on: https://chromium-review.googlesource.com/1174380 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#583649}
-
Danyao Wang authored
Current expectations assume a buggy behavior of LegacyNavigationManager, which doesn't create a pending item on reload (crbug.com/676129). The test initiates a navigation to the same page to abort the payment request. This navigation is incorrectly classified as renderer-initiated by LegacyNavigationManager, which causes the abort reason for payment request to be incorrectly logged as EVENT_OTHER_ABORTED. WKBasedNavigationManager fixes this bug, so the test should now check EVENT_USER_ABORTED. Bug: 874628 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I74997df64464f196cfcfb34f21b0252d2f2f6e3e Reviewed-on: https://chromium-review.googlesource.com/1176470 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583648}
-
Anders Carlsson authored
When building a framework for macOS that has public headers, this flag is needed for the compiler to find the headers located inside the framework bundle. This same cflag is set when linking with frameworks in the build/config/ios/rules.gni template. E.g. the header may be at `xyz.framework/Headers/x.h` and it is imported with `#import <xyz/x.h>` in the source. We need this for using the WebRTC macOS framework from a demo app. Bug: webrtc:9627 Change-Id: Ib431bacfd85eb4597cb19e60ed575336b76b0598 Reviewed-on: https://chromium-review.googlesource.com/1177400Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Anders Carlsson <andersc@chromium.org> Cr-Commit-Position: refs/heads/master@{#583647}
-
David Bokan authored
A common pattern on the web is to resize a container to the window's innerWidth and innerHeight so that it matches the viewport size and accounts for the URL bar's presence. Unfortunately, these values are do not report fractional CSS pixels, they're floored. So on high DPI devices, innerHeight * devicePixelRatio != initial containing block's size. This patch allows applying the root scroller on pages following this pattern by ceil'ing the bounds values before comparing them to the ICB. Two additional unrelated changes: - Remove unused parameter in FillsViewport This is always true since some changes were made recently. - Early out for non-main frames in ProcessImplicitCandidates We avoid adding implicit candidates for non-main frames already so this is a no-op but this early out is convenient for debugging and logging. Bug: 838683 Change-Id: I740816184a26aa067e135041543170356e90fed5 Reviewed-on: https://chromium-review.googlesource.com/1176550Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583646}
-
Armando Miraglia authored
FYI: I am using this opportunity to test the submission flow on Chrome/Gerrit & co :) R=ossu@chromium.org Bug: None Change-Id: I6d5897a3e64160843d80b423f02c91d68430cb82 Reviewed-on: https://chromium-review.googlesource.com/1177718Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#583645}
-
Xida Chen authored
This reverts commit 902e5475. Reason for revert: <INSERT REASONING HERE> Suspect causing layout test failure: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/15204 Original change's description: > [LayoutNG] Store NGPaintFragment in LayoutObject > > This patch stores a one-way linked list of NGPaintFragment to > their source LayoutObject. Looking up the HashMap consumes > non-ignorable time during paint. > > This patch adds IsInLayoutNGInlineFormattingContext flag to > LayoutObject. This flag represents whether the object is in > LayoutNG inline formatting context, even if the object itself > is laid out by legacy. > > With the flag, the storage used for storing InlineBox in > LayoutText, LayoutInline, and LayoutBox are changed to union > to store the first NGPaintFramgent. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7dfd11fafa9b1527b8d77e1fa3a24abf0e7f551e > Reviewed-on: https://chromium-review.googlesource.com/1170726 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583633} TBR=eae@chromium.org,kojii@chromium.org,mstensho@chromium.org Change-Id: I9a870a209f86cfd061df8c82858b58093dff310b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1177761Reviewed-by:
-
Adithya Srinivasan authored
Makes callsites use mojom::blink::FileSystemType instead. Bug: 787281 Change-Id: If0a3a687fa99b77b3a05ec8c4790f1ee0cbe6dd5 Reviewed-on: https://chromium-review.googlesource.com/1155157Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583643}
-
Xida Chen authored
Mark virtual/new-remote-playback-pipeline/media/controls/modern/doubletap-to-jump-backwards-at-start.html flaky on Mac TBR=wjmaclean@chromium.org NOTRY=true Bug: 874866 Change-Id: Ie04f74b689e1bea6e7c51e5e30ba4a7ce70863fc Reviewed-on: https://chromium-review.googlesource.com/1177633Reviewed-by:
-
Vadym Doroshenko authored
Along the way 2 tests are fixed. Bug: 831123, 852742 Change-Id: If8466bf72cb81be1edbf5f0b95f7da5d309e6f54 Reviewed-on: https://chromium-review.googlesource.com/1169170 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
-
manuk authored
Omnibox: Prevent ctrl-enter behavior when we believe the ctrl key was pressed in order to perform another action. For example, if the user presses ctrl-a to select all the text in the omnibox, then presses enter without releasing ctrl, we do not perform ctrl-enter behavior. On the other hand, if the user releases and represses ctrl after performing a ctrl action, we do perform ctrl-enter behavior. This cl does two changes for the above goal. 1. Previously, ctrl-enter was disabled when the omnibox is focused via ctrl-l but not when the omnibox was already focused and the user presses ctrl-l. Now, we disable ctrl-enter in both cases. 2. Previously, ctrl-enter was disabled if a ctrl action caused either the omnibox selection or text to change; e.g. ctrl-v when the clipboard is non-empty causes a text change, and ctrl-a when the omnibox is non-empty causes a selection change. However, ctrl-enter was not disabled if the ctrl-action did not cause a selction or text change; e.g. ctrl-c, ctrl-v when the clipboard is empty, ctrl-a when the entire omnibox text is already selected, ctrl-left when no omnibox text is selected, etc. Now we disable ctrl-enter if an action was executed, regardless of whether that action caused the omnibox text or selection to change. For example, if text selection is not empty, ctrl-c will disable ctrl-enter, but if selection is empty, ctrl-c will not disable ctrl-enter. Ctrl-left/right/home/end are the 1 notable exception, where they will disable ctrl-enter regardless of whether the cursor was already at either edge. Bug: 75715 Change-Id: I8b2b4829697bf66855879366e4429494c3e95ab9 Reviewed-on: https://chromium-review.googlesource.com/1173424 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583640}
-
Tibor Goldschwendt authored
Monochrome is crashing on startup. Fix this by using the default proguard instead of proguard 6.0.3 for monochrome. In order to stay under the DEX method limit use multidex for monochrome release builds. Bug: 874464, 868770 Change-Id: I9f002c26fb6e2b9b1b5d7471dab890090c446a75 Reviewed-on: https://chromium-review.googlesource.com/1176474 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#583639}
-
A Olsen authored
go/cros-untangle shows that one reason why Chrome OS code depends on all kinds of Chrome internals, is because it uses g_browser_process to get hold of various Chroms OS globals, and g_browser_process keeps a reference to all globals, Chrome and Chrome OS. This CL removes a few easy-to-remove references to g_browser_process from chrome/browser/chromeos. Bug: 446937 Change-Id: I7ed4d1ccede3d0963ab86c80bba6f9327dd0cf61 Reviewed-on: https://chromium-review.googlesource.com/1174448 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583638}
-
Vadym Doroshenko authored
These forms should not be filled. This CL implements that nor PasswordFormManager nor NewPasswordFormManager is created for such forms so as result they are not filled. Bug:871191 Change-Id: I509bb6d1ca500ac2bbbea265712001f61bec3c53 Reviewed-on: https://chromium-review.googlesource.com/1174714 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Leonard Ge authored
Change-Id: Id3e7dfd5a3e60f93ac6653eb7eb32af4a14b4b45 Reviewed-on: https://chromium-review.googlesource.com/1177608 Commit-Queue: Leonard Ge <wangge@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#583636}
-
Juan Antonio Navarro Perez authored
The story should be independently disabled (on separate lines) for each of Android_Go and Android_One. TBR=nednguyen@google.com NOTRY=true Bug: 871708 Change-Id: Ifa5273b546738bf6e3162785590658671e8fe66f Reviewed-on: https://chromium-review.googlesource.com/1177713Reviewed-by:
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874853 Change-Id: I0e28c54f5dfbfa0ae940b48ea5319914e6b49768 Reviewed-on: https://chromium-review.googlesource.com/1177684Reviewed-by:
-
Koji Ishii authored
This patch stores a one-way linked list of NGPaintFragment to their source LayoutObject. Looking up the HashMap consumes non-ignorable time during paint. This patch adds IsInLayoutNGInlineFormattingContext flag to LayoutObject. This flag represents whether the object is in LayoutNG inline formatting context, even if the object itself is laid out by legacy. With the flag, the storage used for storing InlineBox in LayoutText, LayoutInline, and LayoutBox are changed to union to store the first NGPaintFramgent. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7dfd11fafa9b1527b8d77e1fa3a24abf0e7f551e Reviewed-on: https://chromium-review.googlesource.com/1170726 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583633}
-
