- 08 Mar, 2018 40 commits
-
-
Shimi Zhang authored
The original CL is http://crrev/c/923021, we split ClassRegister out from that CL. This is the rest part. Since Chrome uses SurfaceView for compositing, we will get nothing from the ContentView passed to |SelectionPopupController| in |HandleObserver|. In this CL, we are passing SurfaceView to HandleObserver from |CompositorViewHolder| through |WindowAndroid| if it's Chrome's case. We set a flag to |SelectionPopupController| to let it know whether we need to use SurfaceView. Bug: 805531 Change-Id: I2c732231dd161a92d73b29be7f1ab546140eb41b Reviewed-on: https://chromium-review.googlesource.com/953172Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#541869}
-
Sebastien Marchand authored
This reverts commit 69feeeb9 , as well as commit 182f8382 ("Fix 2 access violation in resource_coordinator.") There's also a few minor fixes to fix the presubmits: - tab_manager_delegate_chromeos.cc:144 : Bind -> BindOnce - tab_manager.cc: prepend the crbug urls with https:// - Fix a few minor revert conflicts caused by ddf2a4e4: - tab_manager.h: conflict in the "FRIEND_TEST_ALL_PREFIXES" declarations. - tab_manager_browsertest.cc: Conflict in the anonymous namespace at the top of the file. TBR: thestig@chromium.org Bug: 818454, 819973, 820065 Change-Id: I7c6307859d565769d239ef43c30fb50e5a797467 Reviewed-on: https://chromium-review.googlesource.com/955923 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#541868}
-
https://pdfium.googlesource.com/pdfium.git/+log/04d792fb7510..507fb4ed09d5 $ git log 04d792fb7..507fb4ed0 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 dsinclair Convert Before{Selection|Value}Change to return a bool 2018-03-08 dsinclair Remove BeforeFormImportData and BeforeFormReset 2018-03-08 dsinclair Remove uncalled AfterFormImportData Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5d32f2d2e118b6cc7b63341f9e8d3670e238dc2e Reviewed-on: https://chromium-review.googlesource.com/955776 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541867}
-
Tom Sepez authored
Call it as appropriate in pdf_extension_test.cc Split off from https://chromium-review.googlesource.com/c/chromium/src/+/922727 so as to get a baseline before making further changes. Bug: 809614 Change-Id: I85e947230fd4f87547dac169e2271c2510c41b29 Reviewed-on: https://chromium-review.googlesource.com/953712 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#541866}
-
Mina Almasry authored
The current code includes chromecast/base, but doesn't have a GN dependency on it. I didn't catch this earlier because I missed turning on ENABLE_GN_CHECK while testing locally. I wonder if that should be on by default..? BUG=internal 73746352 TEST=Build libcast_media_1.0_avsync with ENABLE_GN_CHECK Change-Id: I89b0103156c50f83056a5b3be5526396e0f26cd4 Reviewed-on: https://chromium-review.googlesource.com/956228 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#541865}
-
Koji Ishii authored
This patch fixes list marker positioning when the first child of the list item is block-level, and the child does not produce a baseline. Before this patch, list marker is positioned at the synthesized baseline. This is not well-defined, but 3 browsers positions the list marker at the first child that has a baseline. This is filed to CSS WG at https://github.com/w3c/csswg-drafts/issues/2417. By doing so, a new case appears where there are no children that has a baseline. This case is also not well-defined and non- interoperable. Blink/Edge/WebKit creates an empty line box in this case, but this isn't easy as we have to insert an empty line box before the children we have already laid out. This patch follows Gecko behavior to position the list marker at the top of the list item. Also, whether list marker should affect block size or not is not defined and not interoperable. For now, this patch includes the list marker block size into list item's block size because it looks more reasonable to me, and Blink/Edge/WebKit do so. This is filed as: https://github.com/w3c/csswg-drafts/issues/2418 SetListMarkerPosition() is a left over in the last patch and therefore this patch removed it. Some tests turn to good, though they need to rebaseline due to list marker image differences. Bug: 725277 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If47ab7daea214c0593a917a0c8f505274dae5ca2 Reviewed-on: https://chromium-review.googlesource.com/952843 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#541864}
-
Christopher Cameron authored
Now that we aren't crashing when destroying the compositor, crashes in RWHVMac::Hide are cropping up. Also check for shut-down during occlusion and un-occlusion (those are not in the crash logs, but it's hard to prove that they couldn't be called). Bug: 805726 Change-Id: I2a45db2a86aa09e9bfc8b01fee4018dfbdf257ed Reviewed-on: https://chromium-review.googlesource.com/954061Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#541863}
-
Esmael El-Moslimany authored
Bug: 710660 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2a43c8a51c6702d2e79e05b72162133d18f82041 Reviewed-on: https://chromium-review.googlesource.com/949419 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#541862}
-
Min Qin authored
Simple file move, no functional changes BUG=803135 Change-Id: I023c36ebc58adf2e623e2a75eabb3c033aadbd63 Reviewed-on: https://chromium-review.googlesource.com/952276 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#541861}
-
Sammie Quon authored
Test: manual Bug: 818373 Change-Id: I05efc0528fbee5d088947fc2893267d4a601ba93 Reviewed-on: https://chromium-review.googlesource.com/951633Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541860}
-
edchin authored
Bug: 804559 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6af3cfb03402cb9099902f87abe5ebf0948d9ec0 Reviewed-on: https://chromium-review.googlesource.com/955344 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#541859}
-
Fernando Serboncini authored
Previously, BidiCharacterRun used LayoutPartition, which is not thread safe. GIven that now OffscreenCanvas can render text in a thread, those runs need to be allocated/deleted from different threads. Tested performance was neutral. Bug: 799362 Change-Id: Id8766e23d4be1a41effeeb8956fa1b3e06dc49a3 Reviewed-on: https://chromium-review.googlesource.com/953331 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541858}
-
Zhiling Huang authored
This change is to make the generate_buildbot_json script work for downstream jsons. Bug: 803245 Change-Id: I63180304d8bb0fe0b4061565e3ce925d02901a70 Reviewed-on: https://chromium-review.googlesource.com/938315Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541857}
-
Jose Dapena Paz authored
A comment in video_decode_accelerator.h had an unneeded backslash. Remove it. Bug: 819294 Change-Id: I89065637311795b420474d2722330c3fe687d99a Reviewed-on: https://chromium-review.googlesource.com/944410 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#541856}
-
Vasilii Sukhanov authored
When a user clicks "Never save password" no username/password should be recorded. Due to a bug when the page prefills some values there were stored. Now let's iterate the blacklisted credentials and clean those values. Bug: 817754 Change-Id: I68d811ef26d7d17ffd99031897bb01750b86f14b Reviewed-on: https://chromium-review.googlesource.com/951607 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#541855}
-
Boris Sazonov authored
This CL replaces anonymous classes with lambdas in FirstRunIntegrationTest without any changes to the behavior. Bug: None Change-Id: I0ab8e9bc38f6c1dec82c65480b2ccf71eda5538a Reviewed-on: https://chromium-review.googlesource.com/955563Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541854}
-
Koji Ishii authored
742 failures started since the build #4133. Among that, 278 are text-only failures. This patch rebaselines text-only failures that have matched images using the same process as CL:945184. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0f79a7e2f3b02d6de56d36b9691ae46caa4fb3c5 Reviewed-on: https://chromium-review.googlesource.com/956202 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#541853}
-
jonross authored
We sometimes need FrameTokens associated with a CompositorFrame submission. However on a given frame there may be multiple sources requesting a token. This change creates FrameTokenAllocator which only provides one incrementation to the FrameToken per frame submission. Bug: 775103 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I161bee7f4bf0641ebd658cd0e0e7ca707d55f015 Reviewed-on: https://chromium-review.googlesource.com/931992Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#541852}
-
Scott Violet authored
In interactive ui tests we generate events using RemoteEventDispatcher. When there is capture we need to ensure the location matches what happens on device, otherwise we won't find the right target. BUG=817112 TEST=covered by tests Change-Id: Ic47b316058282db85d83b348f3b346f2132cd9a1 Reviewed-on: https://chromium-review.googlesource.com/955925 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541851}
-
David Reveman authored
This removes all dependencies on ash and moves the code to ash/components/fast_ink. Minor changes needed to accomplish this: - Remove ash switch that could be used to set estimated presentation time. This was never actually used and can be restored in the future if needed. - Always use unverified sync tokens. Unlikely to have a performance impact as fast ink doesn't rely on GL compositing for low-latency. - Minor refactor to code that detects if input event is in the stylus tools area. Bug: 814908 Test: ash_unittests --gtest_filter=FastInk* Change-Id: I2a668b92d92726025510e1bf636c20b334c78500 Reviewed-on: https://chromium-review.googlesource.com/932626 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#541850}
-
Sammie Quon authored
This makes icons look better. Test: manual Bug: 817877 Change-Id: I48f11379a6045b6f423e360fb3947233575d3b32 Reviewed-on: https://chromium-review.googlesource.com/953971Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541849}
-
James Cook authored
The observers are used by more than the system tray, so move them out of SystemTrayNotifier. This is a prelude to adding a new observer method for accessibility panel fullscreen state changes. Bug: 628655 Test: ash_unittests Change-Id: Iddaf101c286a2539b5a362b5615db0bcf4f973cb Reviewed-on: https://chromium-review.googlesource.com/953862Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541848}
-
https://chromium.googlesource.com/catapult.git/+log/6fbfa7cb20f4..df668c31259d $ git log 6fbfa7cb2..df668c312 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 eakuefner Disable failing Snap-It test Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I2bc748c12a1a958bb1ea2d18b43fc4361fa35fb4 Reviewed-on: https://chromium-review.googlesource.com/956004 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541847}
-
https://chromium.googlesource.com/angle/angle.git/+log/5164b797cb91..5242d5bf74d3 $ git log 5164b797c..5242d5bf7 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 lucferron Vulkan: Implement scissored clears. 2018-03-08 jmadill Return errors from gl::State::syncDirtyObjects. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie979cff7e2ed47e4203af9656e35e8b406346bb8 Reviewed-on: https://chromium-review.googlesource.com/955935Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541846}
-
Tibor Goldschwendt authored
Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c26701b29d44b6f381fdf67e821d8ebbc0d6a9b Reviewed-on: https://chromium-review.googlesource.com/956003Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541845}
-
Benjamin Pastene authored
Change-Id: Iab7d8a85f5b4ee0bbbf98e72bc69cb6666ed7b6c Reviewed-on: https://chromium-review.googlesource.com/954602Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#541844}
-
Koji Ishii authored
742 failures started since the build #4133. Among that, 460 are image or image+text failures. This patch rebaselines them after manual reviews of #4135. Other failures are to be reviewed and will be in following patches. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibf33461018b983c1decb480b5ada090dbb7f171f Reviewed-on: https://chromium-review.googlesource.com/956162 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#541843}
-
Xida Chen authored
In order to make sure that nothing breaks during our implementation of raster-inducing scroll, we should just hide this new feature behind a flag. Bug: 820048 Change-Id: I38b446cff82aa5f4c9e23b5fdb04f5895d218e2a Reviewed-on: https://chromium-review.googlesource.com/955666Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541842}
-
Jinho Bang authored
When PaymentRequest API is initiated from merchant site, GetAllPaymentApps() will be called to query all installed payment handler on the browser. At this point, we should check a permission whether each payment handler is allowed or blocked. If the permission is BLOCK, the payment handler is not supported in payment request perspective. Bug: 665949 Change-Id: I720ffcaab8068506bb165c0353b6cd658973937e Reviewed-on: https://chromium-review.googlesource.com/948122 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541841}
-
Jun Cai authored
This is a follow-up CL for: https://chromium-review.googlesource.com/c/chromium/src/+/879586 which clamps sensor frequency to maximum supported frequency. However, for fusion sensor, it needs to override PlatformSensor::GetMaximumSupportedFrequency(), otherwise it will get 5Hz as default. This has caused DeviceOrientation API to report sensor data in a low frequency. This CL fixes this issue. Bug: 819413 Change-Id: Ib7c888227d3a09c7df281c06a7dbb3290de34d4f Reviewed-on: https://chromium-review.googlesource.com/953127Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#541840}
-
Simon authored
They seem to have changed on the bot, changing here to match. Bug: 819780, 818877 Change-Id: I305892716bcb337df71a1f1e2d0937c0db8541b6 Reviewed-on: https://chromium-review.googlesource.com/953379Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#541839}
-
Xiaoqian Dai authored
This reverts commit eebaaff0. Reason for revert: Suspect it broke the informational builds, see crbug.com/820129 for details. Bug: 820129 Original change's description: > Use relative path for isysroot > > pkg_config added -isystem in abspath. > > Let me use relative path here for cache utilization on goma backend when building chrome in different directory. > > Change-Id: Id48db3036711c07788bb370753acc7a9b217a89d > Reviewed-on: https://chromium-review.googlesource.com/954526 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@google.com> > Cr-Commit-Position: refs/heads/master@{#541738} TBR=tikuta@google.com,thomasanderson@chromium.org Change-Id: I1eaf74f65f18b3c26607a230da320fae4b1f0f54 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/955677Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#541838}
-
Xiaohan Wang authored
This is for bug investigation. It seems possible there are cases where MojoCdm is destructed on the wrong thread but it's unclear how. Bug: 819269 Change-Id: I3cf984e6eaff119330917c2c627f1267d2988ae3 Reviewed-on: https://chromium-review.googlesource.com/954716Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541837}
-
Reza.Zakerinasab authored
TBR=junov@chromium.org Bug: 728137 Change-Id: I96a8e446679f9edda13217f169b273869e7e48b3 Reviewed-on: https://chromium-review.googlesource.com/953252Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#541836}
-
Sigurdur Asgeirsson authored
The use of a string literal for the channel makes it harder than it should be to see what this is doing. Using the channel constants also allows easy string searching for the use of the concept. Bug: 806661 Change-Id: I1711539886f74549f4ac5db1a16108907b679bd4 Reviewed-on: https://chromium-review.googlesource.com/953071Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541835}
-
Tom Anderson authored
Prior to GTK 3.20, a background-size set to "contain" would actually behave like it was "stretch". This was causing frame button images to render too large on Greybird (XFCE theme) and Breeze (KDE theme). Since the issue the CSS override was fixing is not applicable to GTK < 3.20 (symbolic icons were used for these versions), only apply the CSS if the GTK version is >= 3.20. BUG=819594 R=erg TBR=estade Change-Id: I91807e4b5675b56647e2da1be5284e68a7bc7c3a Reviewed-on: https://chromium-review.googlesource.com/954419Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#541834}
-
Jay Civelli authored
The ImageSanitizer would not call its callback if the data decoder service crashes. Fixing this and introducing a test data decoder service that unbinds when a call is made on an interface to simulate a crasher. That data decoder test service will be used in a subsequent CL to simulate JSON parser crashers. Bug: 819852 Change-Id: Idda0bef2c97513ff0d833d66af1c5777231bfa09 Reviewed-on: https://chromium-review.googlesource.com/954237Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#541833}
-
https://skia.googlesource.com/skia.git/+log/fa303398d503..4997e14c80f1 $ git log fa303398d..4997e14c8 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 fmalita Use kLow_SkFilterQuality when generating shader masks 2018-03-08 egdaniel Add testing only helper to flush and sync gpu. 2018-03-08 bsalomon Delazify wrapped backend textures/render target proxies 2018-03-08 robertphillips Additional DDL playback cleanup 2018-03-08 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ed8b49195..5164b797c (1 commit) 2018-03-07 robertphillips Remove GrRestrictedAtlasManager Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I5cbc36d4a57b76eb23ab6066240f2cc60937edf9 Reviewed-on: https://chromium-review.googlesource.com/955743 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541832}
-
Charles Harrison authored
Bug: 819592 Change-Id: Ic43116c52e1b401aea1f813334a5352441d6d9a9 Reviewed-on: https://chromium-review.googlesource.com/953302Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541831}
-
Peter Collingbourne authored
This makes the behaviour of 'gn clean .' a little more shell-friendly. Previously gn would delete the shell's current directory, which would put the shell session into a confusing state where many commands don't work without re-entering the directory. Bug: 810548 Change-Id: I2f8849a770a394fe4c38ee771d0eb765dcbe1360 Reviewed-on: https://chromium-review.googlesource.com/954703 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541830}
-