GitLab

BUG=237681

Review URL: https://codereview.chromium.org/60273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233187 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233186 0039d316-1c4b-4281-b951-d872f2087c98

Pulls in:
d8b177c c99conv: Use a non-capturing group to shave off a couple seconds.
51449ec c99conv: Don't preprocess to file w/o GOMA. Use stdout. Remove lock.

BUG=172368
TEST=compilation is much faster.  try bots pass.
R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/61243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261451
TEST=On Chrome OS, rapidly enable/disable spoken feedback on user/lock/oobe screens.
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/60373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233180 0039d316-1c4b-4281-b951-d872f2087c98

Enable the test now that the problem with build bot is resolved.

BUG=314971

Review URL: https://codereview.chromium.org/61103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233179 0039d316-1c4b-4281-b951-d872f2087c98

Also:
* use username/password instead of hardcoded test@test.test and ''
* Improve logging.

BUG=308224
TEST=No longer see bad profile popup with this change.
NOTRY=True

Review URL: https://codereview.chromium.org/56533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233178 0039d316-1c4b-4281-b951-d872f2087c98

This keeps the feature as-is but shows a warning in the developer
console so the developers can fix their code before removing the
feature breaks it.

BUG=313986

TEST=When opening a new window with chrome.apps.window.create() if the
options parameter contain a 'singleton' option set to false and a 'id',
the developer console should show a warning.

Review URL: https://codereview.chromium.org/53973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233176 0039d316-1c4b-4281-b951-d872f2087c98

CFLog, which is overridden by content/renderer/renderer_main_platform_delegate_mac.mm, contains the following instruction in 64-bit form on 10.6.8 and 10.7.5:

4881ECD0000000                  sub        rsp, 0xd0

mach_override’s puny simplistic fake disassembler didn’t understand this instruction. This resulted in mach_override failing, which triggered a CHECK failure during renderer startup, with the result that everything would be a sad tab on 10.6 and 10.7 64-bit.

The latest version of mach_override replaces its weak old non-disassembler with libudis86, which should be much more capable in the area of understanding instructions, and which should improve mach_override’s ability to patch code without always having to retrain it.

In the mean time, the upstream change that was probably causing us to be unable to update to the current HEAD (https://github.com/rentzsch/mach_star/commit/498e0ba3)
has been backed out since then (https://github.com/rentzsch/mach_override/commit/1b3aa46f), so it should now be safe to update to HEAD.

Local patches https://codereview.chromium.org/21208002/ and https://codereview.chromium.org/22798004/ have been reapplied with minor fixes to work with the current version.

BUG=315218
R=avi@chromium.org

Review URL: https://codereview.chromium.org/61273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233175 0039d316-1c4b-4281-b951-d872f2087c98

Previously, items in autofill popup couldn't be selected using touch.
Now, gesture events are handled on autofill popup to enable touch.

BUG=290429

Review URL: https://codereview.chromium.org/44543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233172 0039d316-1c4b-4281-b951-d872f2087c98

command_buffer was historically included in nacl-compiled things, and base
wasn't.  These days, base is included in nacl-compiled things too, so the
duplication can be removed.

BUG=none
R=piman@chromium.org

Review URL: https://codereview.chromium.org/59383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314505
R=blundell@chromium.org
TBR=rsleevi

Review URL: https://codereview.chromium.org/58833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233169 0039d316-1c4b-4281-b951-d872f2087c98

Rewrite part of the test using plain C++ Fake pattern.

BUG=134675
TEST=ui_unittests --gtest_filter=AnimationContainerTest.*
R=ben@chromium.org

Review URL: https://codereview.chromium.org/56193006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233168 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/59973010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233164 0039d316-1c4b-4281-b951-d872f2087c98

1) Create a gcm subdir under browser/services and add some initial files.
2) Add GCMProfileService that is profile based and acts a bridge between
GCM API and GCM client. This does not contain the real implementation yet.
3) Add GCMProfileServiceFactory that owns and creates all GCMProfileService
and associate them with profiles

BUG=314924
TEST=none due to no real implementation has been added yet
R=fgorski@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/60673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315160

Review URL: https://codereview.chromium.org/60573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233162 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/50943002/ 

Since I changed everything to mirror aura, the comment becomes unnecessary.

BUG=312582

Review URL: https://codereview.chromium.org/59903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=No behavior change.

Review URL: https://codereview.chromium.org/59863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314532
TEST=chrome://settings/autofill shows card images next to credit card entries.
R=estade@chromium.org

Review URL: https://codereview.chromium.org/59173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233159 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233157 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=304839

Review URL: https://codereview.chromium.org/59773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233156 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161368&mode=html
TBR=
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/59623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233155 0039d316-1c4b-4281-b951-d872f2087c98

BUG=31473
TEST=manual

Review URL: https://codereview.chromium.org/59163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138629

Review URL: https://codereview.chromium.org/59093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233153 0039d316-1c4b-4281-b951-d872f2087c98

These docs refer to commands that are really out of date, and most likely don't even work anymore. Updating them to be more current.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/59043008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233151 0039d316-1c4b-4281-b951-d872f2087c98

Update content on Windows theme changes (Glass->Classic).
Implement BubbleFrameView::OnThemeChanged to fix title/close.
Called via NonClientView::UpdateFrame after being clobbered.

BUG=308262
TEST=Dialogs retain their title and close button after windows theme changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/58863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233150 0039d316-1c4b-4281-b951-d872f2087c98

Title is not displayed in the file select dialog, whereas Message is.

BUG=NONE

Review URL: https://codereview.chromium.org/54493010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233149 0039d316-1c4b-4281-b951-d872f2087c98

complete. That means that the sub_protocol_, extensions_ amd http_read_buffer_
members can be initialised from the constructor.

BUG=314063
TEST=net_unittests --gtest_filter=WebSocketBasicStream*

Review URL: https://codereview.chromium.org/54093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315328
TBR=jvoung@chromium.org

Review URL: https://codereview.chromium.org/59523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233147 0039d316-1c4b-4281-b951-d872f2087c98

This just burned me when I typed "make CONFIG=Relase" and the build system
happily created a directory tree with "pnacl/Relase" in it.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/60343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233146 0039d316-1c4b-4281-b951-d872f2087c98

Welcome toast appears to come from "Notifications" instead of
the service that requested it.  So this changes the behavior
to reuse the notifier ID of the requesting service.

Ultimately when more services get welcome toasts this will
be required, and also provides the nice behavior that if a
service is preemptively disabled by the user, no welcome notification will be shown.

R=robliao@chromium.org
BUG=310229

Review URL: https://codereview.chromium.org/54963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314901
TEST=gpu_unittests
R=bajones@chromium.org, kbr@chromium.org, piman@chromium.org, sievers@chromium.org

Review URL: https://codereview.chromium.org/57633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233143 0039d316-1c4b-4281-b951-d872f2087c98

Upon activation on mixed mode, we only show and use apps of the current user. Furthermore we should not show the menu if an app was created.

BUG=296269
TEST=visual

Review URL: https://codereview.chromium.org/58813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233142 0039d316-1c4b-4281-b951-d872f2087c98

Now that the investigation is over we don't need the special code anymore.

BUG=

Review URL: https://codereview.chromium.org/58233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233141 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionPrefs, which I'm in the process of moving to the
top-level extensions/ directory, depends on an enum value
from the Blacklist class, which appears to be tied to safe
browsing, a Chrome-specific feature. This change replaces
ExtensionPrefs's use of the enum with a bool.

BUG=313284
TBR=thestig@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/57563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233140 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233139 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Desktop builds are successful.

Review URL: https://codereview.chromium.org/56273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233138 0039d316-1c4b-4281-b951-d872f2087c98

The atomic number of arsenic
A normal human spine has 33 vertebrae when the bones that form the coccyx are counted individually
The namesake of the private club, Club 33, located in Disneyland's New Orleans Square.
The number of innings played in the longest baseball game in history (a 1981 minor league game between the Rochester Red Wings and the Pawtucket Red Sox in Pawtucket, Rhode Island).
A song by The Smashing Pumpkins on their album, Mellon Collie and the Infinite Sadness. 
The title of the first episode of the 2004 Battlestar Galactica television series in which the Cylons came every 33 minutes
Pabst Blue Ribbon Beer used to be advertised as "Blended 33 to 1".

Which is to say that 33 will be both refreshing and fun...

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233137 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233136 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca
BUG=315140
NOTRY=true

Review URL: https://codereview.chromium.org/60153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233135 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, simplify the notification container by having individual
notification controllers send messages to the Autofill dialog's controller
directly.

BUG=286528
TEST=(see bug)
R=groby@chromium.org

Review URL: https://codereview.chromium.org/56183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233134 0039d316-1c4b-4281-b951-d872f2087c98