- 24 Jul, 2018 40 commits
-
-
Artem Titov authored
Bug: webrtc:8366 Change-Id: Ieaa4bf30132708570ac76c0957248c1dbb22a611 Reviewed-on: https://chromium-review.googlesource.com/1146922Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#577472}
-
Nick Harper authored
CertVerifyProcInternalTest.EVVerificationMultipleOID uses a certificate from trustcenter.websecurity.symantec.com, but the test fails with the upcoming Symantec Legacy PKI distrust. This replaces the test certificate with another that has the 2.23.140.1.1 OID before 2.16.840.1.113733.1.7.23.6 in X509v3 Certificate Policies extension. Bug: 705285, 796230 Change-Id: I0ed5d50d727a712d7c38babdb9ecfdfd30d50cc5 Reviewed-on: https://chromium-review.googlesource.com/1147665 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577471}
-
tzik authored
After this CL, we can use ComPtr as the |this| pointer of base::BindOnce and base::BindRepeating. ComPtr doesn't have `operator*` nor `operator->*` that are needed to run a method pointer. So we need a special handling for it to use it as a receiver on base::Bind. We currently use scoped_refptr to store COM instance on base::Bind, which happens to work, but that looks fragile. This CL is a preparation to convert these scoped_refptr to ComPtr. Change-Id: I1fe31e23ac627050860fe2c81ead6807a17bb939 Reviewed-on: https://chromium-review.googlesource.com/1145153 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577470}
-
Haruka Matsumura authored
This CL changes the system of slots registration in HeapCompaction. As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause. So, we add HashSet that registeres traced slots. Bug: 864425 Change-Id: Ia63c36abbf160dfea115ebd6c6953c499d895770 Reviewed-on: https://chromium-review.googlesource.com/1145144Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#577469}
-
Vasilii Sukhanov authored
The direction is used if instead of the password generation we trigger the standard password drop-down. Bug: 865469 Change-Id: I3da15c0446753e69f84d352c7095c40d571030ce Reviewed-on: https://chromium-review.googlesource.com/1145300Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Colin Blundell authored
While working on GaiaCookieManagerService, I noticed that SigninClient::AddCookieChangeCallback() is unnecessary to call out to the embedder for: the only embedder-specific parameterization of the //components-level SigninCookieChangeSubscription is for the URLRequestContextGetter, which is already available to the component via SigninClient::GetURLRequestContext(). This CL eliminates that client method in favor of having GaiaCookieManagerService construct SigninCookieChangeSubscription directly. I verified that all production clients were supplying the same URLRequestContextGetter that they return in their implementation of SigninClient::GetURLRequestContext(). TBR=jzw@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic8a9d0c6e3e63cf531408eb6ab46db65bcf3e668 Reviewed-on: https://chromium-review.googlesource.com/1145312 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577467}
-
Philipp Hancke authored
BUG=836871 Change-Id: I16e2419717601e3bb89e83df720eee31cc631edc Reviewed-on: https://chromium-review.googlesource.com/1140781 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#577466}
-
tzik authored
dbus::ObjectManager's reference count is zero at the beginning of its constructor, and used to be incremented at base::Bind there implicitly. However, if PostTaskAndReplyWithResult there failed, the reference is gone and the reference count gets to 0 again. And as the result, `new ObjectManager` may return a stale pointer. This CL adds a static constructor to ObjectManager, and moves the ref count manipulation part out from the constructor. Bug: 866456 Change-Id: I5dd8947a5087359005cbcb75e1bb2a0a42ebeda8 Reviewed-on: https://chromium-review.googlesource.com/1148037 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577465}
-
Matt Falkenhagen authored
There was very similar code, make it the same function. This patch tries to maintain the same behavior as previous to minimize changes. Detailed changelog: - Move |need_to_update|. The point of this upfront was to choose whether to "unblock" association on early return. In the need_to_update case, we know we call an async function, so didn't want to unblock. It's easier to always to unblock upfront, and block before the async functions. RAII would improve this, but avoided that to minimize the diff. - Remove |status| from TRACE when it's already guaranteed to be kOk. - Previously we avoided calling AssociateRegistration until after trying to make the active worker transition ACTIVATING -> ACTIVATED. There shouldn't be a need for that: once there's an active worker, the provider host should "use" the registration. But to minimize the diff, I've maintained this old behavior. When the callback fires, we unassociate there if something failed. Change-Id: I0d8a9bea5f516a42002ecb7e236a8f1e9eced678 Reviewed-on: https://chromium-review.googlesource.com/1143092 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577464}
-
Alan Cutter authored
This CL updates BoxLayout to avoid clipping the main axis alignment point when there isn't enough main axis space. This means for: - left aligned layouts the right most children will be clipped first (existing behaviour). - center aligned layouts the left and right most children will be clipped first. - right aligned layouts the left most children will be clipped first. Where previously the right most children were always clipped first regardless of the main axis alignment position. This fixes hosted app titlebar icons such that they clip from the left instead of clipping out the app menu button first. Analysis of existing alignment use cases here: https://bugs.chromium.org/p/chromium/issues/detail?id=862045#c3 Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347613&signed_aid=Nst_-68AwDajlir_GX00cQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=349265&signed_aid=RgUQgRr8Udaf6_WsZG31ig==&inline=1 Bug: 862045 Change-Id: I073cadced4d9b9172f9c803506c2faadd11683ca Reviewed-on: https://chromium-review.googlesource.com/1143115 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577463}
-
Eliot Courtney authored
Bug: 866370 Test: PIP window no longer has top portion cut off Change-Id: I6a4415162fd2697b49866bbe8698d306315fe074 Reviewed-on: https://chromium-review.googlesource.com/1146524 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#577462}
-
Kenichi Ishibashi authored
We don't use ServiceWorkerContextRequestHandler when S13nServiceWorker is enabled. Bug: 860361 Change-Id: Ib0e73f84b0e014d652941e1d8b3292fc32005149 Reviewed-on: https://chromium-review.googlesource.com/1146138Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Thomas Tangl authored
The spell-check toggle is updated to be a settings-toggle-button because there is no link anymore in the toggle description. This also fixes the issue that the toggle didn't actually turn on spellcheck when it was switched to on. Bug: 857136 Change-Id: I8389bbc5a1d02b0cc849fa18494c4b09e0b3bc47 Reviewed-on: https://chromium-review.googlesource.com/1146571Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#577460}
-
Darren Shen authored
We don't get much out of this being a function. TBR=blakeo@chromium.org Change-Id: If29f63899374d91ab67ab91c9068d31eb0f82a3e Reviewed-on: https://chromium-review.googlesource.com/1148096Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#577459}
-
Kenichi Ishibashi authored
ServiceWorkerURLRequestJob is non-S13nServiceWorker specific class and we don't use it when S13nServiceWorker is enabled. This CL explicitly disable S13nServiceWorker in ServiceWorkerURLRequestJobTest. Bug: 860361 Change-Id: I9432b773b02cdee13ab877395f3d3ed3d5839c87 Reviewed-on: https://chromium-review.googlesource.com/1147897 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Philipp Hancke authored
BUG=836871 Change-Id: Idd0495f538777469043fec30993f5e9399d62c68 Reviewed-on: https://chromium-review.googlesource.com/1140676Reviewed-by:
-
Darren Shen authored
NotificationManager::SendNotifications takes an argument |bounds_affect_layout|, but it's unclear from the name what type of bounds it is. The sole caller of SendNotifications uses occluded bounds, so we assume that that's the intention. (occluded) |bounds_affect_layout| is used to determine what the displaced bounds are. Our naming change exposes a "bug": if the occluded bounds affect layout, we set the displaced bounds to the visual bounds. This is not right; we should be using the occluded bounds. This makes sense, because for future features like fullscreen handwriting where the visual bounds fill the entire screen, we should only displace what is actually occluded. TBR=blakeo@chromium.org Change-Id: Ie6a9d04294cba5b4bf23009f9300698e2946079f Reviewed-on: https://chromium-review.googlesource.com/1146526Reviewed-by:
-
Hajime Hoshi authored
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/?limit=200 The tests have been failing for a long time TBR: hajimehoshi@chromium.org Bug: 866785 Change-Id: Ia884e0aca4fcbb2c8ab47f38cf5ea48c2f22538f Reviewed-on: https://chromium-review.googlesource.com/1148081Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577455}
-
Max Morin authored
They were accidentally messed up when copying AudioInputController->audio::InputController. Bug: 866452 Change-Id: I75eff9fae05bb510d3c5111bb2dad33dff422e1b Reviewed-on: https://chromium-review.googlesource.com/1146732Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577454}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f6c4505..a2437c0a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32ce66b8d22258fdf98ca44913e2ea423cfb96a9 Reviewed-on: https://chromium-review.googlesource.com/1147925Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577453}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2edae10bfbfe..d7a1188a3b5a git log 2edae10bfbfe..d7a1188a3b5a --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dtu@chromium.org [pinpoint] Remove suffix from results2 tasks. Created with: gclient setdep -r src/third_party/catapult@d7a1188a3b5a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7e7343442cf33f424afb29810fdc82b24e05844d Reviewed-on: https://chromium-review.googlesource.com/1147941Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577452}
-
Yuichiro Hanada authored
This reverts commit ce0157f4. Reason for revert: This change breaks text input on ARC windows. Bug: 866784 Original change's description: > Cleanup IsArcAppWindow() in ArcWindowDelegateImpl. > > Now aura::client::kAppType property is set for an ARC notification > window. We can use it for check. > > Change-Id: Id27f5ab83492a4c1a517b1350ae1fc30bfbf8fae > Reviewed-on: https://chromium-review.googlesource.com/1146626 > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577422} TBR=yusukes@chromium.org,yhanada@chromium.org Change-Id: I9a58768a0ae0d84d13d9943674ed60954a9b39d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1148120Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#577451}
-
Orsi Batiz authored
Function String GetString(StringOrTrustedHTML, const Document*, ExceptionState&) has been added to trusted_html.cc All other callsites (setInnerHTML, setOuterHTML, setAttribute in element.cc, parseFromString in dom_parser.cc and createContextualFragment in range.cc, setInnerHTML in shadow_root.cc) have been updated to call this function Bug: 739170 Change-Id: Ie84462cd233669e55f2b76e685d5d3545198ee59 Reviewed-on: https://chromium-review.googlesource.com/1142768 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#577450}
-
Orsi Batiz authored
Function String GetString(USVStringOrTrustedURL, const Document*, ExceptionState&) has been added to trusted_url.cc All other callsites (setAttribute in element.cc, open in local_dom_window.cc, assign, replace and setHref in location.cc) have been updated to call this function setHref in html_base_element.cc has been changed to call a different setAttribute from element.cc (the one mentioned above), this way there was no need to call GetString in there as well Bug: 739170 Change-Id: I07b9fee53ea62aa706bb59814f147a394f214549 Reviewed-on: https://chromium-review.googlesource.com/1144927 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
-
Gauthier Ambard authored
This CL adds an InProduct help to indicate to the user that it is possible to long press on the toolbar buttons to have menus with new options. This in product help should only be displayed after the user opened a new tab. It should also be displayed after having the InProductHelp for the bottom toolbar displayed few days ago. This condition is handled server side. Bug: 849621 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I440cfe7cbf0b230454b1d2615e62d33d73c60b88 Reviewed-on: https://chromium-review.googlesource.com/1138243 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577448}
-
Matt Falkenhagen authored
The ServiceWorkerNavigationPreload feature flag was removed in r494256. Bug: 753230 Change-Id: Ie2fe09c477dbffe1bc19cc050f1e6f413b1a8358 Reviewed-on: https://chromium-review.googlesource.com/1148021Reviewed-by:
-
Hajime Hoshi authored
This function is not used anywhere. Change-Id: I4116ef0634a1db7b1aacfc5326e662ce3abfe136 Reviewed-on: https://chromium-review.googlesource.com/1144816Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577446}
-
Alan Cutter authored
This CL: - Renames FrameHeaderOriginText to HostedAppOriginText as it's not intended to be used for anything other than hosted app windows and for consistency with other HostedApp* views. - Moves HostedAppOriginText from ash/frame to chrome/browser/ui/views/frame. - Moves the animation timing logic from BrowserNonClientFrameViewAsh into HostedAppButtonContainer. This is in preparation to add the origin text animation to GlassBrowserFrameView (see https://chromium-review.googlesource.com/c/chromium/src/+/1136270). There are no behavioural changes in this CL. Bug: 854479 Change-Id: I69934e5b4595356d10e707011a231f9c095338db Reviewed-on: https://chromium-review.googlesource.com/1134713 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Colin Blundell authored
The AccountTracker unittest currently plays fast-and-loose with the notion of an "account ID", which can be either the Gaia ID or the email address for a given account depending on the platform. This is a blocker to porting AccountTracker to use IdentityManager, as the IdentityManager test infrastructure deliberately makes a much more explicit and enforced separation between email address, Gaia ID, and account ID, reflecting how these elements are used in production. In particular: - Adding an account takes in the gaia ID and email and returns an account ID. - Calls that interact with the token service take in the account ID. This CL paves the way for that porting by changing the AccountTracker unittest to be explicit about its usage of the email address, Gaia ID, and account ID of a given account. The test now adds accounts by passing the gaia ID/email, obtains the account IDs of the added accounts, and interacts with the token service via those account IDs. Bug: 809923 Change-Id: Ia0bf7fc90c035976f8c578563e7d81c597d4d635 Reviewed-on: https://chromium-review.googlesource.com/1138082 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577444}
-
Yutaka Hirano authored
...instead of mojom::CORSError. Currently they return a mojom::CORSError and callers need to compose a CORSErrorStatus from it. That requires callers to know which specific errors are returned from the function, which is not good. Bug: 736308 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5b0dfaf5b906e0203c9a72ebaef759a8fafa4ad3 Reviewed-on: https://chromium-review.googlesource.com/1147681Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#577443}
-
Zhongyi Shi authored
Bug: 790547 Change-Id: I68d3afb4a8bce843eee9e3b5456ed3103c7d2914 Reviewed-on: https://chromium-review.googlesource.com/1147545Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577442}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5389d34c833d..b96253cab7d9 git log 5389d34c833d..b96253cab7d9 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 ahassani@chromium.org cros_payload: deprecate it Created with: gclient setdep -r src/third_party/chromite@b96253cab7d9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4e22d4c869c617f04eeefdf80b55f0769991eccc Reviewed-on: https://chromium-review.googlesource.com/1147940Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577441}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I42560e53d8cb727e6ae59e4dc7f698a470c26cea Reviewed-on: https://chromium-review.googlesource.com/1147930Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577440}
-
Hajime Hoshi authored
This reverts commit 47a44d77. Reason for revert: Test failures on some bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2064 ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(892): error: Value of: HasZoneIdentifier(target_exe_path) Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x00007FF663FC6FE0+80] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF663FE254A+90] testing::internal::AssertHelper::operator= [0x00007FF663FE204A+90] chrome_cleaner::DiskUtilTests_ZoneIdentifierWhenProcessIsRunning_Test::TestBody [0x00007FF663EECF4C+2924] ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(897): error: Value of: base::ReadFileToString(stream_path, &content) Actual: false Expected: true Original change's description: > chrome_cleaner/os unit tests, part 1: a-f > > Also add test_util add extra setup that uses it to the test harness/ > > Bug: 830892 > Change-Id: Iae1bb4323f6a0b25339d13e702135c2a3625c99d > Reviewed-on: https://chromium-review.googlesource.com/1141146 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577240} TBR=csharp@chromium.org,pennymac@chromium.org,joenotcharles@chromium.org Change-Id: Icf4ceab27056789e7aeb20f7c979aa9a3e52f3f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1147961Reviewed-by:
-
Luciano Pacheco authored
Fix issues where Files app failed to mount .zip files, and also failed to zip files in M69 dev. Cause was on the Zip Archiver extension failing to load its own JS files due the manifest Content Security Policy (CSP) changes submitted in issue 836412. Bug: 864256, 865197, 836412 Change-Id: I8ffd382671deac0a23dfa5688830d9608a919bf5 Reviewed-on: https://chromium-review.googlesource.com/1147893Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577438}
-
Kenichi Ishibashi authored
This CL adds three tests which basically correspond to ServiceWorkerContextRequestHandlerTest.ErrorCases. Bug: 860361 Change-Id: I57bca1d4ad53ffa53e45fd6b3e340d678133a856 Reviewed-on: https://chromium-review.googlesource.com/1146539Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4206a0a8498a..dcff0bd78e26 git log 4206a0a8498a..dcff0bd78e26 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 buildbot@webrtc.org Roll chromium_revision 0aff707f..bc855194 (577150:577382) 2018-07-23 steveanton@webrtc.org Add CreateIceCandidate overload which takes a cricket::Candidate Created with: gclient setdep -r src/third_party/webrtc@dcff0bd78e26 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e5bc6c6e1e2915692ee15556b8c18a18b541e38 Reviewed-on: https://chromium-review.googlesource.com/1147901Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577436}
-
Matt Falkenhagen authored
Since issue 864731 was fixed in r576288, this workaround is no longer needed. Bug: 854993 Change-Id: I789dfb18cdb82ec51aa0ce5185586163c92269ec Reviewed-on: https://chromium-review.googlesource.com/1147889Reviewed-by:
-
Hiroki Nakagawa authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1146134 Bug: 825740 Change-Id: I401fb219d074546fcc13a49f50aab4a37e485010 Reviewed-on: https://chromium-review.googlesource.com/1147880Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#577434}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a1002b4d937..2edae10bfbfe git log 6a1002b4d937..2edae10bfbfe --date=short --no-merges --format='%ad %ae %s' 2018-07-23 simonhatch@chromium.org Dashboard - Add new mojo linux name Created with: gclient setdep -r src/third_party/catapult@2edae10bfbfe The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863995 TBR=sullivan@chromium.org Change-Id: Id43b4f146c27fedc610a0feb59ba418aa708ec68 Reviewed-on: https://chromium-review.googlesource.com/1147722Reviewed-by:
-
