- 26 Mar, 2020 40 commits
-
-
Nico Weber authored
- Suppresses several -Wunreachable-code warnings - Makes it clearer this is a build-time constant - Removes half a use of GOOGLE_CHROME_BUILD in a .h file No intended behavior change. Bug: 346399,961769 Change-Id: Idb574bc2bb8e55e9b060f7fd743242904b291725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120269 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#753612}
-
Nohemi Fernandez authored
Adds a flag to the upgrade sign-in flow to use the new sign-in architecture and updates the user sign-in coordinator to ensure that the orientation restrictions are applied. Bug: 971989 Change-Id: I9f844029ba81b54c396d72d62e50ea565bf28b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120501Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#753611}
-
David Benjamin authored
Bug: 1053260 Change-Id: I40970424735ff7af4e8476d037adbf88594042d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120457Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#753610}
-
Alice Wang authored
This CL moves the static helper method AccountManagerFacade.canonicalizeName to AccountUtils. This facilitates the extraction of AccountManagerFacade interface for later. Bug: 1057040 Change-Id: I92665e3975d94e36fe05171e77607cf20264e438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115545 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753609}
-
Peng Huang authored
This is a reland of 105f5197 Original change's description: > Reland "VulkanImage: support create from GpuMemoryBufferHandle on Android" > > This is a reland of 838eb034 > > Original change's description: > > VulkanImage: support create from GpuMemoryBufferHandle on Android > > > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > > > Bug: None > > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753394} > > TBR=rjkroege@chromium.org,vasilyt@chromium.org > > Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng > Bug: None > Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753501} TBR=rjkroege@chromium.org,vasilyt@chromium.org Bug: None Change-Id: Ie9c83df2711431373c6eed4794be19640de9702f Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119888Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753608}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12da77257204..95fc5a325168 git log 12da77257204..95fc5a325168 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@95fc5a325168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: If548863428477f4e4a291a2f30cb327dd5d732f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753607}
-
Tim Schumann authored
It's flaky since about March 24. TBR=dtseng@chromium.org BUG: 1064947 Change-Id: I6d725d113dcaa2930953fc54d9a58864cd7cc010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121379Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#753606}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7a58e5b713c3..bf6b8d4a16ae git log 7a58e5b713c3..bf6b8d4a16ae --date=short --first-parent --format='%ad %ae %s' 2020-03-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src fb7f9c9bcd1d..0e78ffd1dcfc (1 commits) 2020-03-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src ff44f21a0178..acbf316040c3 (1 commits) 2020-03-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 540bdf92531d..77090261dabc (10 commits) Created with: gclient setdep -r src/third_party/angle@bf6b8d4a16ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Ie715b41c9008e31c7da86e4c6b70eca172ec359b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121958Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ic349ba3da8ad6ad2a3279c7995ced09bbfa30ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120673 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#753604}
-
Nicolás Peña Moreno authored
Now that FID is fixed in PLM tests, we can successfully add a test where FID is recorded after a click. Change-Id: I31e707afe7cdb8c02ab43f5a781731c9b43ec7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120747Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#753603}
-
Harald Alvestrand authored
Removes the RTCDtlsTransport and RTCSctpTransport features. These have been "stable" since May 2019. Bug: chromium:944027 Change-Id: I47d5aec2d7551980734fb1f13abd26d41955eeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120579 Auto-Submit: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#753602}
-
Roman Aleksandrov authored
Bug: 1063706 Change-Id: I01bb41f49eb8a20e4ffe9bb77f489920404417dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120294Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#753601}
-
Eric Seckler authored
The system tracing producer doesn't currently support startup tracing in the child processes. If we pass on startup tracing flags, the ProducerClient will enable itself in spawned child processes, and thus prevent the SystemProducer to enable tracing when instructed by the service later. Until the SystemProducer supports startup tracing, we shouldn't try to enable it for the child processes. Change-Id: I6d42b2d705f60d935bd104fe66bb159793bebda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116054Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#753600}
-
Sasha McIntosh authored
In the linked bug, we cut a hole in the background that is occluded by the foreground app folder. This hole changes the background blur and we see that around the foreground occluder there is less blur. Bug: 1059734 Test: DisplayTest.DrawOcclusionWithIntersectingBackdropFilter Change-Id: I665b483ed4bede53b9e4640962a3ccf8d16de3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097512 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#753599}
-
Tim Schumann authored
They are still failing on Linux https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests?limit=200 TBR=bsheedy@chromium.org BUG: 1056235 Change-Id: I2b1e47411b2fd450f06494dee2c4864c252e9ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121260Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4f77e105e33d..d3f547209d8b git log 4f77e105e33d..d3f547209d8b --date=short --first-parent --format='%ad %ae %s' 2020-03-26 jacktfranklin@chromium.org Component bridges generation Created with: gclient setdep -r src/third_party/devtools-frontend/src@d3f547209d8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7df0d14aa22567e6210628283acb7b3eefddbc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121959Reviewed-by:
-
Ali Juma authored
This CL makes us use iOS-specific Safe Browsing lists on iOS. Bug: 1028755 Change-Id: I675531f4f2fe155a0480ca31e36d7ceb21122b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121048Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753596}
-
Tim Schumann authored
It's flaky on Mac. TBR=rdevlin.cronin@chromium.org BUG: 1064929 Change-Id: I4e0ffd4da0c154c020882f1d04353005f1cbe5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121258Reviewed-by:
-
Tim Schumann authored
It's flaky on Linux CFI. Bug: 1026064,1063844 TBR=dpapad@chromium.org Change-Id: I326ee2e51362605bc284b8e9388548dbc0168196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121257Reviewed-by:
-
Philipp Hancke authored
signal msid and prefer the event.streams[0] in ontrack. The previous behaviour was probably done for backward-compability. Bug: none Change-Id: Ice7b1763fa8443469031c1555e1d51e473eadcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116220Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#753593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21a3f16268e9..658779b63e6b git log 21a3f16268e9..658779b63e6b --date=short --first-parent --format='%ad %ae %s' 2020-03-26 treehugger-gerrit@google.com Merge "tracing_service_impl: Add support for producer name regex filtering" Created with: gclient setdep -r src/third_party/perfetto@658779b63e6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5b2020d5b8146e6ede93e89cf50547a8e51485dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121957Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3c51099. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes drott@chromium.org: external/wpt/css/css-text-decor drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts kojii@chromium.org: external/wpt/css/css-text/overflow-wrap rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2451cfb11b9404a54ed7d2c2a974c8501a4dd68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121282Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753591}
-
W. James MacLean authored
It seems like the implementation for PDFiumEngine::RotateInternal() was removed, but not the function declaration. This CL removes the declaration. Bug: n/a Change-Id: I978d2173bc085b752af0710b754393a9b6b14e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119380Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#753590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1128ddc5b31..7e1439b863bd Created with: gclient setdep -r src-internal@7e1439b863bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I05add8b578450054149350f9e8c75ed95c7e4132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121956Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753589}
-
Bo Liu authored
Follow up to r654240 Apparently on apps that does not end up resizing the FullScreenView from the WebView, avoiding a resize cause odd problems such as FullScreenView not getting forwarded key events or not being on top of other views as it should be. Instead set the initial height to be arbitrarily 5 pixels less in height. This avoids affecting the compositing pipeline significantly, since height changes generally has small effects on layout. Bug: 1054286 Change-Id: Ia5bbb384a75736784e660567dd7e36bacbc4b5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119802Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753588}
-
Alex Ilin authored
Reauth dialog uses SigninViewControllerDelegateViews as a webview container. Relevant navigation events are handled by ReauthTabHelper. SigninViewControllerDelegateViews required a slight change to display a close button in the top right corner. Bug: 1045515 Change-Id: I688b93eef8e8549aaf1c489c73655378e4e858ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111100 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#753587}
-
Theodore Olsauskas-Warren authored
The new cookies page introduces a new control element for interacting with cookie settings. This CL adds the appropriate managed indicators to the element and disables the appropriate controls when cookie settings are managed or recommended. Bug: 1062649 Change-Id: Ifa2e6abc878a482e045f06fde35fd0723506e615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107864 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#753586}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: Id61c888bd0b2efb1b0232bb172b8e1613512714b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115654 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#753585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee2ec6de995b..12da77257204 git log ee2ec6de995b..12da77257204 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 borenet@google.com [infra] Update infra dep again Created with: gclient setdep -r src/third_party/skia@12da77257204 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Idac3056eda4f09e3dd24ed877e2c8ac77b5d8bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121955Reviewed-by:
-
Tim Schumann authored
This reverts commit e55b73bf. Reason for revert: TooltipControllerCaptureTest.Capture started failing on Chrome OS builds Original change's description: > Have DefaultScreenPositionClient() keep the Aura root window updated. > > It sets itself as the root window's client on construction and nulls > that out on destruction. DesktopScreenPositionClient already did this, > this just hoists that to the base class. > > This makes it harder to introduce bugs like "constructed the client > but forgot to set it on the window" or the more likely (and insidious) > "failed to null the client on shutdown, leaking state into another test > and triggering test flakiness". > > Bug: none > Change-Id: Ib8ddb193d78d7d7e5b0cf48683a7ef9653d31f7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117335 > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753540} TBR=sadrul@chromium.org,pkasting@chromium.org,rdevlin.cronin@chromium.org,shend@chromium.org,yucliu@chromium.org Change-Id: Ia758dbaa0441874217c62cd061cff21aae329740 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121259Reviewed-by:
-
Tim Schumann authored
It's flaky on many platforms. BUG: 1064434 TBR=ricea@chromium.org Change-Id: Ie379e3c39c694f5d4c00d6c8a311b5fa7831e530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121378Reviewed-by:
-
Delan Azabani authored
This CL changes DeprecatedLower calls to LowerASCII where the result is only ever used in a comparison against one or more ASCII constants (including predicates like StartsWith) but is otherwise dead, and I believe it’s the last CL needed to finish our intent to remove Unicode case-insensitivity for ASCII constants [1]. The correctness of the image_encoder_utils.cc change isn’t obvious, but you can verify it by heading to the line in Chromium Code Search [2], hovering over lowercase_mime_type, and observing that the only reads are == MIME type literals and by two functions: • IsSupportedImageMIMETypeForEncoding (line 78), which does the same • ParseImageEncodingMimeType (line 80), which does the same These changes are potentially author-facing, except where the constant in question contains none of {s,k,S,K} [3], but I’ve optimistically made them without any additional tests based on Rick Byers’ reasoning on blink-dev [4]. Please let me know if that’s not sufficient here. [1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/sFOpNuQ91UU [2] https://source.chromium.org/chromium/chromium/src/+/f7455871a37e53362183771af7de36844df73a38:third_party/blink/renderer/platform/image-encoders/image_encoder_utils.cc;l=36 [3] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt [4] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ Change-Id: I10e621bb2a6947bc3004d9a0c156dcae2e05a6e8 Bug: 627682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114510 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Frédéric Wang <fwang@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753581}
-
Andreas Haas authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org BUG= chromium:1057645 Change-Id: I1b73fdee07197a178af5628531af6d5bf63e19d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080251 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#753580}
-
Jana Grill authored
Pass the feature flag's value to the UI so that the corresponding UI toggle can display the correct state (enabled/disabled). Additionally check the feature flag value when checking eligibility for enablind and disabling ADB sideloading. --enable-features=ArcManagedAdbSideloadingSupport parameter in /etc/chrome_dev.conf and check that in this case the toggle in settings is enabled and ADB sideloading can be activated. Test: Powerwash device and initialize with a managed account. Pass the Bug: 1058386 Change-Id: Ic172b8a8a90c485f86aa26d59f2710844a71253c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084554Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#753579}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8e26c5f50e85..2df8c71258de git log 8e26c5f50e85..2df8c71258de --date=short --first-parent --format='%ad %ae %s' 2020-03-26 johnkslang@users.noreply.github.com Merge pull request #2154 from GMNGeoffrey/patch-1 Created with: gclient setdep -r src/third_party/glslang/src@2df8c71258de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I4f2691e737a276f232f8e1acd306962f8ad57e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121758Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/77090261dabc..e322072ab4fb git log 77090261dabc..e322072ab4fb --date=short --first-parent --format='%ad %ae %s' 2020-03-26 bclayton@google.com Merge "Initial drop of LLVM 10 to third_party/llvm-10.0" Created with: gclient setdep -r src/third_party/swiftshader@e322072ab4fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1c7386fcd484f868000757ac1832e7d01a8c7044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121552Reviewed-by:
-
Finnur Thorarinsson authored
The comparator is used for the priority queue and deserves a bit of testing for the different combinations of requests. bug: 1054520, 1054502, 656015 Change-Id: Ic8281b6b69d32e8d8e5d781527e6666ebeadd959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119517Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#753576}
-
Hajime Hoshi authored
This CL breaks down WebSchedulerTrackedFeature:: kOutstandingNetworkRequest into fetch, XHR, and the others. As one of the biggest reasons why the page is NOT cache is outstanding network requests so far, this breaking down would give us more insights. Bug: 1052793 Change-Id: I34a6a3fbea8f91f9b2977349b7daeb1a0c529c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104711Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753575}
-
Mark Cogan authored
Removes use of TabModelList from the external file remover, replacing it with equivalent BrowserList code. The ComputeReferencedExternalFiles() helper function is updated to accept a single Browser parameter. Bug: 1058350 Change-Id: I258fa3c20cd932e9bd5ecdd6da538a5b68b915a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116053Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#753574}
-
Hiroshige Hayashizaki authored
The test seems no longer flaky. A couple of flakes on dashboard seem unrelated. (e.g. "with patch" runs with many other tests failing) Test: http/tests/images/png-partial-load-as-document.html Bug: 813704 Change-Id: Idc9629bb4cf9b2f80af15f96d5f1d97938548b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120997Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#753573}
-
