- 29 Oct, 2018 40 commits
-
-
Andrey Kosyakov authored
Bug: 899303 Change-Id: If13f08e4e45e4f4f4cfc16bd4f2921cab22ecc07 Reviewed-on: https://chromium-review.googlesource.com/c/1303181 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603598}
-
Antonio Gomes authored
BUG=889883 Change-Id: Ia37ffc9bc4dfb0247137b6bfa8cf272332efb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/1304573Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#603597}
-
Nate Chapin authored
Previously task.result sometimes returned the result value directly. Making it always return a promise makes it easily to handle in JS. Bug: 879306 Change-Id: I6c0168d828d8234875a20e1128b14f1ab6603d4f Reviewed-on: https://chromium-review.googlesource.com/c/1303100Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#603596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9201a4e1a936..9ab423a548ac git log 9201a4e1a936..9ab423a548ac --date=short --no-merges --format='%ad %ae %s' 2018-10-29 chrome-bot@chromium.org Update config settings by config-updater. 2018-10-29 hungte@chromium.org Remove amd64-generic-goofy build target. 2018-10-29 martinroth@chromium.org chromeos_config: disable grunt firmware branch configs Created with: gclient setdep -r src/third_party/chromite@9ab423a548ac The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6a3493cb5bf51996ec2b12f09638cdb8ac40fb04 Reviewed-on: https://chromium-review.googlesource.com/c/1305853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603595}
-
bsheedy authored
Re-enables all the VR tests that were marked as flaky now that the root cause has been reverted. TBR=mthiesse@chromium.org Bug: 894796 Change-Id: I34c4b8e10edec2e682c450b1b18c2428f3e29473 Reviewed-on: https://chromium-review.googlesource.com/c/1305211Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603594}
-
Chase Phillips authored
This reverts commit e76b26c9. Reason for revert: Reverting the "move content/renderer/indexed_db/ to Blink" CL. This commit touches a file that was created by that CL, so reverting it. See these bugs for more info: https://crbug.com/899446 https://crbug.com/717812 Original change's description: > [jumbo] Remove 'using' declaration for mojom::blink::IDBCursor > > The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the > 'using' and specify the namespace instead. > > TBR=pwnall@chromium.org > > Bug: 717812 > Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686 > Reviewed-on: https://chromium-review.googlesource.com/c/1301434 > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Daniel Bratell <bratell@opera.com> > Cr-Commit-Position: refs/heads/master@{#603039} TBR=cmp@chromium.org,bratell@opera.com,fs@opera.com,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717812 Change-Id: I29d7de9ef16258d9cc2c6b68d5fb4ac2ad449cca Reviewed-on: https://chromium-review.googlesource.com/c/1305245 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a56061dd6c20..acda68b0292e git log a56061dd6c20..acda68b0292e --date=short --no-merges --format='%ad %ae %s' 2018-10-29 lalitm@google.com trace_processor: overhaul filter and sort system for storage backed tables 2018-10-29 lalitm@google.com Merge "trace_processor: refactor span table to be a bit cleaner" 2018-10-29 ilkos@google.com Merge "Expose a stable TraceProcessor API in include/" 2018-10-29 lalitm@google.com trace_processor: make span joins much more efficient 2018-10-29 taylori@google.com Add support for more events Created with: gclient setdep -r src/third_party/perfetto@acda68b0292e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117588397 TBR=perfetto-bugs@google.com Change-Id: I305ab82ce5116e00107f7e7ca9937ecc654f6646 Reviewed-on: https://chromium-review.googlesource.com/c/1305294Reviewed-by:
-
Evan Stade authored
test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown Bug: 883371 Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc Reviewed-on: https://chromium-review.googlesource.com/c/1305873Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#603591}
-
Chase Phillips authored
This reverts commit 5ac9ece1. Reason for revert: Reverting the "move content/renderer/indexed_db/ to Blink" CL. This commit touches a file that was created by that CL, so reverting it. See these bugs for more info: https://crbug.com/899446 https://crbug.com/717812 Original change's description: > Remove 'using' directives in web_idb_cursor_impl_unittest.cc > > All of the 'blink::*' directives should be unnecessary (now that the code > is within Blink.) Remove the testing::StrictMock 'using' too, and just > "expand" it at its single usage point. > > Change-Id: I3171d05f41364fa134c2ee781e93178d831d4eab > Reviewed-on: https://chromium-review.googlesource.com/c/1301458 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603049} TBR=fs@opera.com,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I10c3fe89cdb7708d8e66978474f6a0299b775af7 Reviewed-on: https://chromium-review.googlesource.com/c/1305395 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Weidong Guo authored
Changes: Only reset views::FocusManager::arrow_key_traversal_enabled_ when power button menu is shown before. Bug: 898716 Change-Id: I01de4fe8b9438e75d1104997aa0e90c61ae52dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1300685 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#603589}
-
Clark DuVall authored
Creating an incognito window was crashing when DRP was enabled with network service. Bug: 721403 Change-Id: I7c97fec3e6dd4b15358c73eb442f441caa45f5af Reviewed-on: https://chromium-review.googlesource.com/c/1305515Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603588}
-
sebsg authored
Change-Id: Ic290185b178ce9944b471d3cfa404684c3ce8aaa Reviewed-on: https://chromium-review.googlesource.com/c/1303881 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603587}
-
James Hawkins authored
This was only used for the EasyUnlock trial which is currently unused and about to be removed. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic3b7271a386d26728e7af4e4ea56dfdd6b19c675 Reviewed-on: https://chromium-review.googlesource.com/c/1302696Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603586}
-
Patrick Noland authored
When saved scroll state is changed, any saved scroll anchor is now stale. This usually doesn't matter, but can bite us in the case of same document loads, where we can mistakenly restore a saved scroll anchor even after scrolling the page manually. To fix this, we clear the stale anchor. It will still get saved before navigating away from the page. Bug: 898142 Change-Id: Ia3a10e54f732d97bd9ebf2162c0f30c9e079280f Reviewed-on: https://chromium-review.googlesource.com/c/1298476Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#603585}
-
Tommy C. Li authored
After this CL, a single Ctrl+L will reveal the full URL. This applies to beth Query in Omnibox and Steady State Elisions. This CL also adds a unit test, as well as an internal-only killswitch in case we need to remotely disable this feature. Bug: 874592, 882348 Change-Id: I6bce176e613b46bfc9b6ce524ddf855bdb14f399 Reviewed-on: https://chromium-review.googlesource.com/c/1285511 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#603584}
-
Adam Langley authored
CBOR{Reader|Writer|Value} were renamed in b4f12f9a to remove the “CBOR” prefix. This change reflects that in the filenames. (TBR for webpackage code since this is just renaming headers of an underlying library.) TBR=kinuko@chromium.org Change-Id: I0262c827181fe8ab51cd08ad41fce14aa1aed331 Reviewed-on: https://chromium-review.googlesource.com/c/1303177 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603583}
-
Nicolas Ouellet-Payeur authored
Adds the "browser_switcher.use_ie_sitelist" boolean pref. When set to true, BrowserSwitcherService will download IE's sitelist after 60s. Once the sitelist XML is downloaded, the rules are parsed and applied. Bug: 884837 Change-Id: Ib7a6c374526c56c42265187667ea2d6febc3628b Reviewed-on: https://chromium-review.googlesource.com/c/1286288 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603582}
-
Jonathan Metzman authored
Get it building and enable it on Windows to increase our coverage of skia on Windows. Change-Id: If88d332d8dcc2fb39e80850a654682fc92530aed Reviewed-on: https://chromium-review.googlesource.com/c/1305208Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603581}
-
Boris Sazonov authored
This test was added by https://crrev.com/c/1293171 and it is failing on KitKat Phone Tester (dbg) builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Phone%20Tester%20%28dbg%29/10119 TBR=bokan@chromium.org Bug: 898987 Change-Id: I82fe04a5d11cbe09a2794fc6daadb33ce5b1463e Reviewed-on: https://chromium-review.googlesource.com/c/1305316Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603580}
-
Toni Barzic authored
Updates crostini installer browser test setup to use fake cros component manager implementation. BUG=None TEST=cq passes Change-Id: I85e19ffeade2a932678ddaee92db8329b0bde426 Reviewed-on: https://chromium-review.googlesource.com/c/1303036Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#603579}
-
Aleks Totic authored
Bug: 898212 Change-Id: I83a8f9e355f2b527db8eabfba40625f60a78822f Reviewed-on: https://chromium-review.googlesource.com/c/1303949 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603578}
-
liberato@chromium.org authored
This fixes SurfaceLayer kOnDemand mode to work with webmediaplayer_ms when the player starts in PIP. Previously, the player wouldn't use SurfaceLayer, since it would wait to enter PIP. Now, it checks if the client is already in PIP, and switches to SurfaceLayer immediately in kOnDemand mode. Bug: 891619 Change-Id: I669003b512152cc22c3e0d1f7d69133304669108 Reviewed-on: https://chromium-review.googlesource.com/c/1301958Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#603577}
-
David Jacobo authored
views::TouchSelectionMenuRunnerViews::Menu should be better by separating it on their own class, this CL introduces TouchSelectionMenuViews. Bug: None Test: Build. Change-Id: I6e23c379abc7eb746713dde1b9224389a98014e6 Reviewed-on: https://chromium-review.googlesource.com/c/1300054 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603576}
-
Yuly Novikov authored
conformance2/vertex_arrays/vertex-array-object-and-disabled-attributes.html on Linux AMD conformance/attribs/gl-disabled-vertex-attrib-update.html on Nexus 5 conformance/reading/fbo-remains-unchanged-after-read-pixels.html conformance/reading/read-pixels-pack-alignment.html conformance/reading/read-pixels-test.html on Nexus 6 TBR=kbr@chromium.org Bug: 899754 Change-Id: Icb1db2a029fa20897baf925609a2ed4dd00cf132 Reviewed-on: https://chromium-review.googlesource.com/c/1305206Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603575}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b7c4a0243e82..ea08d171755b git log b7c4a0243e82..ea08d171755b --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tsepez@chromium.org Fold virtual CPWL_Wnd::OnCreate into subclass constructors. Created with: gclient setdep -r src/third_party/pdfium@ea08d171755b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I30edbacb27ea609d7357f68f0ce62e43b1f55316 Reviewed-on: https://chromium-review.googlesource.com/c/1305295Reviewed-by:
-
Yuly Novikov authored
This reverts commit 10a10dd9. Reason for revert: Suspected for flaky crashes affecting Chromium CQ. Original change's description: > Oilpan: Enable HeapCompaction for incremental marking > > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. > > Bug: 864425 > > Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8 > Reviewed-on: https://chromium-review.googlesource.com/c/1297782 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603477} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org Change-Id: Ie72a2eb04571945b3515ee7374a75a1ab87275c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864425, 899809 Reviewed-on: https://chromium-review.googlesource.com/c/1305833Reviewed-by:
-
David Tseng authored
ChromeVox has "force flush" behavior when it receives user input via qwerty keys, braille keys, and touch (explore/gestures). It also has programmatic queue behaviors via Output.withQueueMode. By default, ChromeVox is ready to queue all other output. This will help ChromeVox be flexible when receiving events and not dropping output. For example, when pressing Ctrl+l, we receive focus on the omnibox and quickly after, a selection event on the listbox option auto completion. This is a separate change to ensure we don't miss any corner cases and have to revert. Test: existing tests/manually on omnibox. Change-Id: Iba069c5794fe8cc2b3318c64a87dbd4cc7df6385 Reviewed-on: https://chromium-review.googlesource.com/c/1302414 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603572}
-
Charlie Harrison authored
This CL shouldn't change behavior. Bug: 899790 Change-Id: Ia59af2fafaa95130dfbb2138356c8783c22030b7 Reviewed-on: https://chromium-review.googlesource.com/c/1305493Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#603571}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a22f4b04619..25224e786ffe git log 4a22f4b04619..25224e786ffe --date=short --no-merges --format='%ad %ae %s' 2018-10-29 syoussefi@google.com Vulkan: add GPU trace events Created with: gclient setdep -r src/third_party/angle@25224e786ffe The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I20bae53b68a653e7e4ee4f607a254074b5532e12 Reviewed-on: https://chromium-review.googlesource.com/c/1304914Reviewed-by:
-
Christian Biesinger authored
It is fairly common to have one or two baseline requests (see NGConstraintSpace::CreateFromLayoutObject, NGBlockLayoutAlgorithm::CreateConstraintSpaceForChild and others), so give the vector some inline capacity to avoid memory allocation in the common case. This can actually save memory, because Vector will allocate space for 4 elements when adding the first element (see wtf/Vector.h, kInitialVectorSize) Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7d1c67a53f0c76ab1804ad5ff7d140b4772e79de Reviewed-on: https://chromium-review.googlesource.com/c/1265130 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603569}
-
Stephen Martinis authored
This CL moves tests for the mixins feature into its own suite. It also moves the test data inputs for those tests near this. Change-Id: Id0e2c97ee59497e239231cc53e300d2f1f655b5c Reviewed-on: https://chromium-review.googlesource.com/c/1303046Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#603568}
-
Ben Pastene authored
It's been at 100% experimental for a while now and it doesn't appear to be blowing out our capacity. Bug: 876494 Change-Id: I90a4fda3350bd96a03244d9b53b0471ce66923a8 Reviewed-on: https://chromium-review.googlesource.com/c/1301971Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#603567}
-
Becca Hughes authored
If the media session feature is enabled then use the media session service to control playback when the next/previous track media keys are pressed. BUG=894255 Change-Id: I0bd99bad14ce9973d10f2c4567dd487bda0ac436 Reviewed-on: https://chromium-review.googlesource.com/c/1289149 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/00755b36f6d2..625dca84765d git log 00755b36f6d2..625dca84765d --date=short --no-merges --format='%ad %ae %s' 2018-10-29 taylori@google.com Handle perfetto protobuf files Created with: gclient setdep -r src/third_party/catapult@625dca84765d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2f310189c8c9eaf06b8ab3682028ad68702ebf0d Reviewed-on: https://chromium-review.googlesource.com/c/1305233Reviewed-by:
-
Dominic Mazzoni authored
This reverts commit 8fe65f6f. Reason for revert: Suspecting that it's causing these tests to fail: services_unittests MemoryTracingIntegrationTest.GenerationChangeDoesntReenterMDM content_browsertests MemoryTracingTest.BrowserInitiatedDump See bug 899813 Original change's description: > Introduce base::trace_event::TraceArguments helper class. > > This CL introduces the TraceArguments helper class to simplify > the way TRACE_EVENTXXX macro named arguments are passed to the > trace log. By using a small dedicated data structure, it is > possible to generate less code at each trace call site, > compared to the old way that relies on passing 5 specially > crafted arguments to TraceLog methods. > > For example, this optimization can save about 12 kiB in > libmonochrome.so for the 32-bit ARM build of Chrome on Android. > For more details, see corresponding bug entry. > > This CL does the following: > > - Introduce the new class in base/trace_event/trace_arguments.h > > - Move the definition of TraceValue to trace_arguments.h and > augment the union with templated methods to support easy > initialization from a large set of C++ value types. > > - Add new TraceLog methods to add trace events using an > optional TraceArguments parameter, instead of a bag of > 5 ones (count + names + types + values + convertables). > > - Simplify internal templates using C++11 universal references > and std::forward<> to remove special-casing convertable > arguments in trace event calls. > > - Remove the now obsolete TraceValueUnion type from trace_event.h > > - Make the TraceEvent class fully C++11 movable, to simplify > its usage (this removes the Initialize() and MoveFrom() methods). > > - Update base/trace_event/ code to use TraceArguments and the > new TraceEvent move operations. > > - Note that this keeps a few forwarding data types, values and > methods to avoid other direct callers from the Chromium tree, > these will be updated in future CLs. One Blink header needs > to be modified though because it specializes a template > defined in trace_arguments.h, to support sending WTF::CString > references as trace arguments. > > BUG=898794 > R=oysteine@chromium.org,chiniforooshan@chromium.org,alexiln@chromium.org > TBR=primiano@chromium.org,torne@chromium.org > > Change-Id: I8fe2225974f7044515a2f64bdc67f6d36abfe004 > Reviewed-on: https://chromium-review.googlesource.com/c/1298997 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603500} TBR=digit@chromium.org,primiano@chromium.org,torne@chromium.org,chiniforooshan@chromium.org,oysteine@chromium.org,alexiln@chromium.org Change-Id: I165b96fde68d927f966bdb4ed8649dd7bb4dd0f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898794, 899813 Reviewed-on: https://chromium-review.googlesource.com/c/1305250Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fea579b6e9b..6d65cf959e1d Created with: gclient setdep -r src-internal@6d65cf959e1d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6de17b91d44dd7bda7f7a7589f7fd8ea29b686fa Reviewed-on: https://chromium-review.googlesource.com/c/1305238Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603563}
-
erikchen authored
Previously, the if/else block was missing the NOTRUN status. Since the statuses are already represented by strings, this CL converts the strings to be expected outputs. This allows us to remove the entire if/else block. Bug: 895027 Change-Id: Ieb426eb268c30dd07a6642dcfd97122cdb07c926 Reviewed-on: https://chromium-review.googlesource.com/c/1305414Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603562}
-
Yuly Novikov authored
conformance/rendering/gl-scissor-fbo-test.html deqp/data/gles2/shaders/swizzles.html on Win NVIDIA Passthrough Vulkan Debug. TBR=kbr@chromium.org Bug: angleproject:2939, angleproject:2940 Change-Id: I8b388eb464b42def465c231d5986852a6517e19a Reviewed-on: https://chromium-review.googlesource.com/c/1305237Reviewed-by:
-
Mason Freed authored
We previously used these two terms semi-interchangeably, which a) was confusing, and b) hindered code search for backdrop-filter related code. I checked carefully - this CL is a pure rename operation. No functionality should change. I did not touch "background blur" and "background zoom" in ash or ui::Layer. Those are similar concepts and names, but don't appear to use the same machinery as CSS-based backdrop-filter. Change-Id: I8f5473c4014ba47b2bbc354126c1a10f4aebc61a Reviewed-on: https://chromium-review.googlesource.com/c/1300035Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#603560}
-
Ben Pastene authored
Increases total time sleeping from 30s to 62s. Bug: 892670 Change-Id: Ib4d631da6c24fb3bb2f9f3a9c692ed82d699b397 Reviewed-on: https://chromium-review.googlesource.com/c/1305413 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
