- 23 Jun, 2020 40 commits
-
-
Tal Pressman authored
1. Add "onload" experiments (instead of FMP). 2. Add experiments that affect all queue types. 3. Refactor feature definitions. Bug: 1090251 Change-Id: Ibb64e7f462f7d6c4722037b85dbf45cfd69a9e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255935 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781240}
-
Saho Kobayashi authored
Send kValue changed event when state description change event of range widget is sent. CL to set kValue when state description of range widget is sent: CL:2224487 AXTreeSourceArcTest.StateDescriptionChangedEvent Bug: b:154433831 Test: ArcAccessibilityUtilTest.FromContentChangeTypesToAXEvent Change-Id: Iea60accbc90a6aa04bdb1b9644ab623c9a8acc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251518 Commit-Queue: Saho Kobayashi <sahok@chromium.org> Reviewed-by:Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781239}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0928d0b13fd..008ec94fc147 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in console/consolePinPane.css 2020-06-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-06-23 bmeurer@chromium.org [third_party] Cherry-pick unreleased CodeMirror wast changes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432,chromium:1083142,chromium:1093322 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I347eb635f25deb7f0df01675aa6db98ea7ee238e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781238}
-
Simon Zünd authored
Design doc: https://bit.ly/browser-issue-storage This CL adds an Issue storage in the browser process, so Issues no longer need to be sent to the renderer process to be stored and reported there. Characteristics of the storage: - The issue count is capped at 1000 issues per WebContent - The storage is cleared for main frame navigations (modulo redirects) - When subframes get deleted, issues associated with the deleted subframe get "re-parented" to the main frame Bug: chromium:1063007 Change-Id: I75f164812770e8c73fc388d27767cc9151e5e4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246139 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#781237}
-
Hayato Ito authored
TBR=skobes@chromium.org Bug: 1098148 Change-Id: I13e6a6fd51735ff6ef6e162b93564f5585c2584e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259397Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781236}
-
Omid Tourzan authored
The links in the banner text hide when window shrinks and ellipsis appears but as their display is visible they can gain focus through tab key. It results in breaking the ellipsis message and scrolling down to show the link text. The following structure of elements used to handle this situation: container > wrapper > link This change adds an observer to check if the ellipsis is shown and hide the wrapper if so, so the <link> can't get focus anymore. The CSS ellipsis is active and applied if the scroll width or height of the element is greater than its client width or height. This is checked every time the size of element changes. The links don't get focus with tab key as their container is hidden when CSS ellipsis active. It behaves good because the links are the last part of the texts, so having overflowed or ellipsis means the links are invisible now and safe to hide their container. The download warning message needed more changes as the link was embedded in the message string, so a wrapper (link-wrapper) added to handle hide. Hiding the link itself leads to removing of ellipsis so a wrapper helps. Bug: 1082539 Change-Id: I13a8e6569da93967963a0f5c919b19e30c0fedca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257459 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781235}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592884413-02978613062131a2d07ebbd18f49e538455b68fd.profdata to chrome-win64-master-1592891992-572d12f4a11aaaeb26a619bef233d3655144eb8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I570168b013289e7b83c05e0f57909328d6d00f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259603Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2641327e3d38..758d13cf2772 2020-06-23 dberris@chromium.org pinpoint: Show hash in commit info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: I4c59e5e850cca7f8136b8e5eefdbefecf350822c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259727Reviewed-by:
-
Gavin Williams authored
On CrOS, printer icons with a status badge will be displayed next to each printer in the dropdown. The printer status responses are saved in a dictionary accessible by the dropdown. When the dictionary is updated with a new status, the printers in the dropdown are triggered to recalculate the color of its status badge. Screenshot: http://screen/nOgp4BEL9i7 Bug: 1059607 Change-Id: I4422d628ab6627ab74fa1810dda89cbe19a9acf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238509 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#781232}
-
Yao Xiao authored
We used to measure overlay-popup-ad. This CL adds another use counter to measure the overlay-popup in general, including both ads & non-ads. This is achieved by adding extra flags to OverlayInterstitialAdDetector to denote whether the current candidate is an ad, as well as whether we have encountered ad and/or general interstitials. Bug: 1048136 Change-Id: I6dc809ceed51aa9b9747af44d8db6ed38721bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250957 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#781231}
-
Yoshifumi Inoue authored
This patch changes "insert-text-at-tabspan-001.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I369a82d7b8c6874d016864f0e6e84bbd3567ad6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259874Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781230}
-
Nohemi Fernandez authored
We take a strong reference in an asynchronous dispatch that delays the called method for kDisplayPromoDelay seconds. This can cause an issue if trying to shut down the scene and app at the same time. Bug: 971989 Change-Id: Ib5165034b9789dd39e6abf2e376bd4f06bcd0032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255610 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781229}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. TBR=kinuko Bug: 1031540 Change-Id: I970f0010731c6190f3fd73e3f4643e1369442ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254326 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#781228}
-
Keita Suzuki authored
https://chromium.googlesource.com/external/github.com/GoogleChromeLabs/pywebsocket3.git/+log/89c922843410..faf478a0453c $ git log 89c922843..faf478a04 --date=short --no-merges --format='%ad %ae %s' 2020-02-26 36944670+quasi-mod Add UnitTests for standalone server 2020-02-26 36944670+quasi-mod Update optparse to argparse 2020-02-18 36944670+quasi-mod Update license year in websocket_server.py (#5) Created with: roll-dep src/third_party/pywebsocket3/src Change-Id: Ifc42a609ed7a7c70eb9ec770faf3715e05375250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257653Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781227}
-
Yoshifumi Inoue authored
This patch changes "paste-text-at-tabspan-001.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I541d054ef7427b17eaa99f35162d6cd4c36697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259396 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
This CL introduces an Abseil component on which all Chromium Abseil clients will have to depend on. Abseil doesn't export symbols explicitly, so for the moment Chromium exports all of them when is_component_build=true. On Android, Linux and Mac -fvisibility=default is used while on Windows a .def file is generated at Abseil roll time. Bug: 1046390 Change-Id: I1697eb9e0179cee01badcf1b687acd94160e5f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174434 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781225}
-
Jérôme Lebel authored
UIApplicationWillEnterForeground doesn't exist with MultiWindow enabled. To keep the same behavior in Chrome, MainApplicationDelegate needs to listen to UISceneWillEnterForegroundNotification notifications. When the first window goes back to foreground, the method needs be called: -[AppState applicationWillEnterForeground:metricsMediator:memoryHelper: tabOpener:] Related to crbug.com/1097080: "AuthenticationService should not rely on foreground/background notifications" Fixed: 1092485, 1090748 Change-Id: Ic248fa9c88a10bb3340b1a4f32efa75b9b751491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252103 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781224}
-
Henrik Boström authored
If we receive a thermal signal we lazily instantiate the ThermalResource and inject it into the webrtc::PeerConnection. The ThermalResource is wired to respond to new thermal measurements. This will make the WebRTC video pipeline be able to react to overuse or underuse due to thermal signals. The ThermalResource is only used if the corresponding base::Feature is enabled, which is DISABLED by default. Both code paths are tested. Bug: chromium:1094844 Change-Id: I9f47c1f4f9bc98349b328d71f0eb71cc4c398444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247837 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781223}
-
Mikel Astiz authored
Commit ordering requirements across entities are relevant for bookmarks only, and no longer implemented within the sync engine. The tests deleted in this patch exercised the legacy Sync Directory, to be deleted soon. Equivalent tests, with modern requirements in mind, already exist in SyncedBookmarkTrackerTest. Change-Id: I4abf6c5231d545d0bd34d397b0855563821bea18 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257237 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781222}
-
Henrique Ferreiro authored
CursorLoader caches cursors, so it should only be used from a single place, the NativeCursorManager implementations. In this case, CursorLoader::SetPlatformCursor() isn't needed anyway, because the cursor is just used to obtain its bitmap and hotspot via GetCursorBitmap/Hotspot, and those don't need the platform cursor. Bug: 1097556 Change-Id: I32e2a867ec2b15374e545d1b268c7f427cd8fab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256220 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781221}
-
Yoshifumi Inoue authored
This patch chnages "5032066.html" to test all platform behaviors instead to detect failure on locally for all platforms for ease of debugging. Bug: 707656 Change-Id: I5f7e477a88b6fdaefe98ec34567f927a9f159dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259700 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
This reverts commit 17ef0754. Reason for revert: Suspected to cause a compatibility issue with Google Play Books Original change's description: > <ruby>: Introduce |text-align: -internal-space-around| > > This CL adds |-internal-space-around| keyword to |text-align| CSS > property. It is used for the default value of ruby annotation boxes > and ruby base boxes. > > We assumed |start|, the initial value of text-align, in ComputedStyle > had a special effect for ruby annotation and ruby base, and we made a > variant of kJustify internally. The code was complicated, and > introducing |-internal-space-around| simplifies the code. > > This CL has a small behavior change: > - If text-align:start is specified to <rt>, we ignored it before this > CL and applied the 'space-around' behavior. > After this CL, we apply text-align:start behavior in that case. > > * LayoutRubyRun.cc > ComputedStyle for LayoutRubyBase was sometimes overwritten by > LayoutObject::PropagateStyleToAnonymousChildren(), and the TextAlign > value was reset to kStart. Uses UpdateAnonymousChildStyle() to keep > the expected TextAlign value. > > * insert-paragraph-into-table-expected.txt > |style="text-align: -internal-space-around;"|, which is unable to > parse, appears. This will be fixed when we implement ruby-align CSS > property. > > Bug: 1069817 > Change-Id: Iecc1e999d11b58dd4d950f3579310546f5db7585 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217673 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773079} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Bug: 1069817 Change-Id: If71faebb37f89fb81b74ddb4a5c6683c34c40751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259393Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#781219}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592870283-bd79a360110f798833aeb2f02d9fe028111bb918.profdata to chrome-mac-master-1592891992-7e90ec0b60a74a0e681805c7cbe855e46353b429.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3a70dbe1018de9c972fb9935074331ebbd424e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259599Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58d0c5d57da6..87cae0e24e81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1097788 Tbr: hayato@google.com Change-Id: I863b86e6a8879f917896bf833aab6f4a8ba8866d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259596Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781217}
-
Ewann authored
This Cl updates TableViewInfoButtonItem and his cell. - Replaces |setIconImage| by |setIconImage:image withTintColor:color|. - Replaces trailing button icon. - Reduces cell vertical padding. Bug: 1095579 Change-Id: I7d7fc26698871e80e1a6b14883b93cdc92796e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252238Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#781216}
-
Wojciech Dzierżanowski authored
After adding VerifyAndClearExpectations() to OnTimeUpdate* tests it became clear that they didn't test the right code paths exactly due to missing pieces of HTMLMediaElement setup. Bug: 1075458 Change-Id: I4995b60fa6b4fada0476ce3a11b2e850ee3bb95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256240Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#781215}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b444943db27d..c2f46c16ab67 2020-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b772a955e70c to 9daab8cbffb7 (13 revisions) 2020-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5964c496 to adf736e2 (505 revisions) 2020-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ae1007957f09 to 9167e1e22a46 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ieeaa854bcc25375992f51b49d147c4a4f55f6c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259721Reviewed-by:
-
Jit Yao Yap authored
Sync server-side changes from cl/314416948, cl/314208411 and cl/315305069. Change-Id: I528a431926a5b43d976129c24a4e9670b6c081d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245614Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#781213}
-
Simon Zünd authored
Drive-by: Use {Set} instead for better readability. R=petermarshall@chromium.org Fixed: chromium:1097229 Change-Id: I9dff25e9beb1c1997a294aa441254ae549f9446b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255608 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781212}
-
Corentin Wallez authored
Compilation on Win10 FYI x64 SkiaRenderer Dawn Release (NVIDIA) started failing after https://chromium-review.googlesource.com/c/chromium/src/+/2257873 but it is not worth reverting for this unsupported configuration. Instead this CL adds the missing include of logging.h TBR=backer@chromium.org Bug: None Change-Id: I5a37a85c56c7e88eef827fda43e63203348be1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259853Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#781211}
-
nancylingwang@google.com authored
This is the preparing for the adaptive icon feature. For kUncompressed and kCompressed, no change, just refactor. Add a new type kAdaptive for ArcAppIcon to fetch both the foreground and background image, which will be used for adaptive icons. Currently no one uses the new type yet. There will be some follow up CLs to change other code to use the new type kAdaptive, hidden with the flag for M85. BUG=1083331 Change-Id: I0c078d6d9c821aa810c849bda04875a4a3155a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249201 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#781210}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592866776-599fc29ec545e33b0a3ff20f5395d165563a3711.profdata to chrome-win32-master-1592884413-6b42064f372939c6b2068eeb31d6b96cefc4be86.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Icc7504168a4a50119877af936e68d1fe6f820163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259595Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5d86efdf299..b0928d0b13fd 2020-06-23 tmathmeyer@chromium.org Add a live-updating timeline view to the Media component in devtools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifabb84fabb001515985ac3445b0ee26e5e115943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259718Reviewed-by:
-
Colin Blundell authored
Chrome's translate infobar disappears when the user selects the overflow menu options of never translate language/site. However, this behavior is contingent on a snackbar then appearing informing the user of their choice and giving them the ability to undo that choice until the snackbar disappears (a few seconds). WebLayer does not currently have snackbars in its infobar implementation. Hence, with the translate UX eng owner (megjablon@) we made the decision to have the selection of never translate lang/site *not* cause the infobar to disappear in WebLayer. The user can then either undo their choice or manually close the infobar as desired. This CL implements that change, including ensure that the relevant overflow menu item is checked and that unchecks of these menu items are properly processed. UX changes discussed in detail here (internal-only link, apologies): https://docs.google.com/document/d/1o6Q6vs5_MCcDNXx6mouhylhzQbfgItxbwe-KqNAbTlo/edit#heading=h.2hzrc3fbkgdf file, which will enable the TranslateCompactInfoBar ForTesting methods to be removed in production. Binary-Size: Will follow up by moving JNI boundary to be on test support Bug: 1093846 Change-Id: I79d4955e4a19d3dc3db1edfc34b63b173d4108d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247024 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#781207}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592873891-9aa969659841cd452b955e25c2ad23336423bfca.profdata to chrome-win64-master-1592884413-02978613062131a2d07ebbd18f49e538455b68fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I092c108fb40f2cd87d71fec1a2e143fac9578c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259717Reviewed-by:
-
Matthias Körber authored
Bug: 1091401, 1096990 Change-Id: Ic88dd8e0ac67ced35127fcdacca90749a6972669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254142 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#781205}
-
Robbie McElrath authored
This CL moves WebView's variations seed proto parsing from Java to C++, which reduces parse time from ~20ms to ~1ms on an emulated Pixel 2. Because the seed doesn't come from Java anymore, we can delete AwVariationsSeedBridge and save the parsed seed in native until it's needed by the native AwFeatureListCreator. This CL also removes the RestartsWithStaleSeed metric, since supporting it with this design would have added additional complexity, which the metric doesn't provide enough value to warrant. Lastly, this CL adds a way to disable seed signature verification in tests so we can properly test this CL by checking that a real seed file (but not signed) gets loaded correctly when the browser process starts. Bug: b/157318961 Test: an build aw webview_instrumentation_test_apk Test: out/aw/bin/run_webview_instrumentation_test_apk --gtest_filter= \ Test: '*VariationsTest#testFeatureEnabled' Change-Id: Id5861eda1f965741c9742e1722e43e36eded8cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247154 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#781204}
-
Noel Gordon authored
This reverts commit 8172d98f. Reason for revert: wrong culprit, change that caused this issue was CL:2214908 and that was reverted. Original change's description: > Disabled flaky `fileDisplayWithoutDriveThenDisable` testcase > > TBR=adanilo@chromium.org > > Bug: 1097013 > Change-Id: I1ed5abccd73b2c8c2ad71dccca8fde5863232d15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253762 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780258} TBR=andypaicu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097013 Change-Id: Id5232de5fe52efe7bdb508280b40e54124fb72b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259872Reviewed-by:
-
Robbie McElrath authored
This CL fixes the coloring on some Site Settings widgets, most importantly the switch. The issue is that the fake Activity we have in WebLayer's classloader doesn't extend AppCompatActivity, so some appcompat functionality doesn't get initialized. I ran into issues making the Activity extend AppCompatActivity instead of FragmentActivity, but was able to perform get the necessary initialization by creating a new AppCompatDelegate. Bug: 1085553 Change-Id: I268f14d616db77cf35ff73edc54d85bf173dfa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258428 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781202}
-
Jiewei Qian authored
We should flush WebContents state between PendingAppManagerImpl tasks. This fix is inspired by crbug.com/1086778, crrev.com/c/2237542 and crrev.com/c/2246044. Before each Install task and registration task, navigate WebContents to about:blank to reset it. This hopefully fix InstallURLRedirected errors spike on System Web Apps since BMO launch. Bug: 1093707 Change-Id: Ia72f39ecc099c486014342c01ece5cbb4f0362f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251418 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#781201}
-
