- 24 Jun, 2020 40 commits
-
-
Yusuf Sengul authored
Bug: 1097407 Change-Id: I80b0fa57cc19196b06b3cbec5afc7c4488ff7325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255113 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#781721}
-
Yutaka Hirano authored
Before this CL blink::mojom::FetchAPIRequestBody was typemapped to blink::EncodedFormData. This was not good for a request body made from ReadableStream because the body is implemented as blink::ResourceRequestBody::stream_body_ which is out of EncodedFormData. Hence this CL changes the type mapping. Now blink::mojom::FetchAPIRequestBody is typemapped to blink::ResourceRequestBody. - encoded_form_data_mojom_traits.{cc, h} are moved to platform/loader/fetch/fetch_api_request_body_mojom_traits.{cc, h}. - encoded_form_data_element_mojom_traits.cc is merged into platform/loader/fetch/fetch_api_request_body_mojom_traits.cc. blink.mojom.FetchAPIDataElement is no longer typemapped. - Add DataPipeBytesConsumer::CompletionNotifier::SignalSize so that it can work with a data pipe coming from ChunkedDataPipeGetter. - Support streaming body in FetchRequestData::Create. Bug: 688906 Change-Id: I8c4ed0f46946aff3f59733dd2138017ead724575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249205 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781720}
-
Alice Boxhall authored
This builds on https://crrev.com/c/2191975 by introducing a preference (also behind the same feature flag) to enable users to turn the focus highlighting feature on and off in Chrome Browser (excluding Chrome OS, which has its own OS-wide preference). When the preference is enabled, the user is also opted in to always matching :focus-visible on the focused element. AX-Relnotes: n/a Bug: 1075862 Change-Id: Iaa85ef5e39a24fdf2127edfecf35f340f6a88ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208480 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781719}
-
Jia authored
Bug: 881215,1094935 Change-Id: I9739565f89daa164e0054126d4eb270a3bdb967f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262095Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781718}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: I2ff9cbc2472c074ccb78ce141016cb2427c2594a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261481 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#781717}
-
Matthias Körber authored
Logs the overall status of an address import on submission time. This is a temporary histogram to assess the impact of features::kAutofillProfileImportFromUnifiedSection. Change-Id: I0d1cee574e99f6d430946f227f63eab735436595 Bug: 1098077, 1097692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258593 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#781716}
-
Gang Wu authored
Omnibox did not use normal UMA to do the log, they use protobuf to report metrics. So we can use existing way to report metrics, only need to update the window open disposition. https://source.chromium.org/chromium/chromium/src/+/master:components/omnibox/browser/omnibox_log.h;l=66 Then OmniboxLog will have it at https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/android/omnibox/autocomplete_controller_android.cc;l=311 Later on, when Omnibox creating protobuf to report at https://source.chromium.org/chromium/chromium/src/+/master:components/omnibox/browser/omnibox_metrics_provider.cc;l=68 server will know this action is switch to tab, and the Omnibox.SuggestionUsed.SelectedTabMatch will appear on UMA report. Bug: 1092269 Change-Id: I0bf7a94985d03c0c6271d71ee79c7303e7598ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259142Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781715}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592953173-dfa217e6d4c03de878e7e0d7393e7f5bccc2ec20.profdata to chrome-win32-master-1592960277-f901daea6b8075bb87053ccb79c202b2253e6908.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I84ff54df540a5eea023ac191af0f2514c2b60652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781714}
-
Jeremy Roman authored
Use it in a handful of places to demonstrate. Bug: 1098539 Change-Id: I605705dead803b6534aa092ce5517f94df2c036e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260946 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781713}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15444a50b912..07a3ce625213 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150 Tbr: johannkoenig@google.com Change-Id: I0899c95f7951b72b57050f6217a738c03f4731f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781712}
-
Tibor Goldschwendt authored
NewTabPageLogoTest.All was disabled for flakiness. Likely, because we embed iframes that do not finish or fail to load. However, it is not material to the test whether the iframe loads. <ntp-untrusted-iframe> provides capability to mock out loading. Therefore, make <ntp-untrusted-iframe> usable for non-chrome-untrusted URL and use it for the doodle iframe. Fixed: 1097035 Change-Id: Ic1008278b957da2873f7e1b2ed56a0c90bbb5707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261716 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#781711}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592953173-8fb0a7663f4cd8da151edd9da48fe9964b3af4db.profdata to chrome-win64-master-1592960277-bc23f7c6050a632e956b7539dc4edff3e9938101.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4c472685b250876350bd165aaeeb21b3835a4dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262225Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6659b733e7804f4ffad8bee952429902fe3bef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262593Reviewed-by:
-
Chris Sharp authored
This reverts commit 4fd81590. Reason for revert: Test is failing on linux-chromeos-dbg Original change's description: > Revert "Disabled flaky `fileDisplayWithoutDriveThenDisable` testcase" > > This reverts commit 8172d98f. > > Reason for revert: wrong culprit, change that caused this issue was > CL:2214908 and that was reverted. > > Original change's description: > > Disabled flaky `fileDisplayWithoutDriveThenDisable` testcase > > > > TBR=adanilo@chromium.org > > > > Bug: 1097013 > > Change-Id: I1ed5abccd73b2c8c2ad71dccca8fde5863232d15 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253762 > > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780258} > > TBR=andypaicu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097013 > Change-Id: Id5232de5fe52efe7bdb508280b40e54124fb72b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259872 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781203} TBR=noel@chromium.org,andypaicu@chromium.org,adanilo@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097013 Change-Id: I7662f32a402a8da0ec77f3454eef6a04e63b1d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261035Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781708}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/babfc6e9a020..57c2dfb200b6 2020-06-24 treehugger-gerrit@google.com Merge "Parse IRQ ftrace events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9da08a2330beba58d703d1492f66f5cb8a087d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262223Reviewed-by:
-
Alan Cutter authored
This CL addresses nits missed in https://chromium-review.googlesource.com/c/chromium/src/+/2251563/6 Bug: 1090227 Change-Id: Ief6c157d7cd53ab52e8267e661d7b65bbfab7cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261912 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#781706}
-
Kuo Jen Wei authored
Add 22th, 23th dimension to capture event with value 0/1 indicating whether it's a video snapshot photo and whether the video ever paused before its recording ended. Bug: 1054314 Test: Test through all related user scenario, check the format of sent out capture event. Change-Id: Ic21a893b1e6dff29f0eaa8b73dfda4299e87f45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255922 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#781705}
-
rajendrant authored
Bug: 1098423 Change-Id: Ib34f10604513f119544af3a4db243ac76af292e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262256 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#781704}
-
Robert Ogden authored
IsolatedPrerender handles cookies in the following way: * Cookies which are set on the prefetched mainframe are kept in the isolated NetworkContext's cookie jar. * Subresources fetched during NoStatePrefetch use the isolated NetworkContext's cookie jar and so send cookies as appropriate. * When the user navigates to a link that was prefetched, any cookies for that page are copied over to the normal profile. * Subresources that were not prefetched before the click use the prefetch cookie when they are made after the click with the normal profile. Note that copying the cookies over to the normal profile is a multi- step process during which the prefetched mainframe is blocked from committing to ensure page correctness. Important: Opaque IsolationInfo's block all cookies so this CL also transitions IsolatedPrerenders to a normal navigation-style NIK and IsolationInfo. This is ok because all prefetches are occuring in a separate NetworkContext from the rest of the browser and therefore were never at risk of having shared resources. Bug: 1096765 Change-Id: I090fc57d46936b4972bd799eab3e4b022019bbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253200 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#781703}
-
Scott Violet authored
This moves the voice ranking from chrome into content. TtsControllerDelegate is now optional, and *only* used on ChromeOS. The logic for looking up prefs remains in the chrome implementation, but is expressed differently so that all the ranking can be in content. BUG=1025626 TEST=covered by existing tests Change-Id: Ib105fe91452dea791e992eb6c70fa7f1d2789985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255314 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#781702}
-
James Cook authored
chrome/browser/BUILD.gn already sets it to an empty list, so we don't need to do it for lacros. Also tweak the comment in //chromeos/lacros/browser/BUILD.gn to match the other ones and mention docs/no_sources_assignment_filter.md This is followup to CL comments in: https://chromium-review.googlesource.com/c/chromium/src/+/2246121 Bug: none Change-Id: I6f868d82b3e5cfc75720ab9affc3a2aa7a1a3037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262114 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781701}
-
Hirokazu Honda authored
This fixes a bug of EncodedDataHelper in reading ivf frame header. Bug: 1098142 Test: video.DecodeAccelSanity.vp9_1 Change-Id: Icaa6d6a41784bbc1b3bc1f7d967a35abb5635743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262022 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#781700}
-
Adam Rice authored
The "cancel should abort a pending read()" subtest of http/tests/streams/transferable/readable-stream.html was flaky because it expected a delay(0) call to complete sending all pending messages, which occasionally didn't happen on the bots. Switch to waiting explicitly for the call to cancel() to happen to ensure that the test is complete. BUG=1073431 Change-Id: I66c2f8b726a5bb6c56596eb9b7327c1458423a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260094Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781699}
-
Mustafa Emre Acer authored
Bug: 1095120 Change-Id: Idb462875093168546ceb11a2566bd784e37f9d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258900 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#781698}
-
Hirokazu Honda authored
memcpy is used in copying from a plane to the other plane, strides of which are different from each other, in some places in media/gpu/test. This CL replaces them with libyuv::CopyPlane because the processing is the same as libyuv::CopyPlane. Bug: None Test: video.EncodeAccel.* on eve Test: video_encode_accelerator_tests on eve Change-Id: Ia57ef4780fd0492dc6ad1a78c5817bee6062ebfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260272Reviewed-by:
-
Richard Li authored
RGB10A2 overlay could be used for displaying HDR content. In some latest Intel platform, RGB10A2 overlay is supported. This CL adds caps checking, displays related info. in chrome://gpu Bug: 1062184 Change-Id: I4f5d5e22ca3088c4ba3ae2a0c099fab4651a7ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242971Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#781696}
-
rbpotter authored
Fix the ChromePrintRenderHelperDelegate's code for pulling the plugin from the document, since it now resides in the pdf viewer element's Shadow DOM. Also update the comment on the JS side, which was inaccurate and resulted in this query for the plugin being missed when updating the viewer. Fixed: 1098504 Change-Id: I0d881b1c583da9c2b16716b9e9abd39873bc71f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261486 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
The call to base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope and to WaitableEvent::wait(...) are generating trace events that are not useful after the thread_id is set. Since it's only done at thread creation, it cannot blocked otherwise and there is no point to get a ScopedBlockingCall trace events. R=gab@chromium.org Change-Id: I1fdaa6b6d3e445fff00c850a1e41a35f95959e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260939 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#781694}
-
Tal Pressman authored
QueueClass::kTimer is too broad and includes other queue types, so this CL introduces a new PrioritisationType and PerAgentSchedulingStrategy uses that to determine whether the queue is a timer queue. Bug: 1090251 Change-Id: I7f2127a41add8c2d5fb3343d3402f4cd81a721cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260132 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#781693}
-
Rakina Zata Amni authored
Since set_should_replace_entry is called from almost all callers of NavigationControllerImpl::CreateNavigationEntry, this CL adds it as a a parameter to NavigationControllerImpl::CreateNavigationEntry instead. Bug: 1015882 Change-Id: I5a0703bc32561178435d0b41f3ffeec6ae2edec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251603 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781692}
-
Aaron Colwell authored
Introducing StoragePartitionConfig to make it easier for code to directly request the StoragePartition they need instead of having to go through the indirection of site URLs. Grouping the 3 attributes of a config into a class also makes several call sites simpler. This is being done as part of an effort to reduce the amount of code that depends on site URLs. - Created class for storing the storage partition <domain, name, in_memory> tuple. - Update GetStoragePartitionConfigForSite() and related code to use this new class. - Create BrowserContest::GetStoragePartition() method that takes StoragePartitionConfig as a parameter so future callers do not need to construct a site URL to get a storage partition. - Remove StoragePartitionImplMap::StoragePartitionConfig struct and convert StoragePartitionImplMap to use the new StoragePartitionConfig class. Bug: 1085275 Change-Id: I6679ee79ce88cf7cbfdfeb2686452d0cfcc1a9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253240 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#781691}
-
danakj authored
Always close all the windows, but do it after leak checks. This removes one main-frame-renderer-controlled step during test end, moving control to the browser process in order to deal with site isolation and render document better. The test runner defaults to not closing windows on the first test run, but then switches to closing windows on future tests. This would make for flaky behaviour. Most tests, when allowing windows to open call this with `true` in order to close their windows at the end of the test. Some call it with no arguments, which does nothing at all. When passed `true` windows were closed by the renderer during Reset() which is run in the ResetRendererAfterWebTest step in the browser. That step is followed by a leak checker (if requested on the cmd line) then we move on to the next test. There should be no legitimate reason to pollute the next test with an open window, so we would like windows to always be closed. However there is one test that closes a window itself and wants to look for leaks if the close failed: LayoutTests/plugins/open-and-close-window-with-plugin.html It was added along with the ability to leak windows in this CL https://github.com/WebKit/webkit/commit/a9fd077f3ec2719eaf12908907fe4bff964af75a It claims: > This tests that opening a window with a WebView that contains a > plugin, and then closing the window without calling -[WebView close] > does not leak the window or the web view. So we replace the renderer-controlled logic with a checkForLeakedWindows(). In the browser, we close all windows opened by the test before checking for leaks, unless checkForLeakedWindows() was called. In that case, we would close the windows after checking for leaks. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I9eb64e997445593bf28b03429cb4d0f34bfe6ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252943 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781690}
-
Giovanni Ortuño Urquidi authored
tsconfig.json files are similar to BUILD files. We can use them to specify the list of files to compile as well as compiler options. We'll need them later when we add support for depending on other mojo targets. Sample generated tsconfig.json { "compilerOptions": { "lib": [ "es6", "esnext.bigint" ], "module": "es6", "strict": true, "target": "es6" }, "files": [ "constants.test-mojom-lite.m.ts", "enums.test-mojom-lite.m.ts", "export1.test-mojom-lite.m.ts", "export2.test-mojom-lite.m.ts", "export3.test-mojom-lite.m.ts", "export4.test-mojom-lite.m.ts", "import.test-mojom-lite.m.ts", "module.test-mojom-lite.m.ts", "structs.test-mojom-lite.m.ts", "other_dir/other_dir.test-mojom-lite.m.ts" ] } Bug: 1002798 Change-Id: I1155d038c93718f706724c99604e2e46917c9b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245855Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#781689}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592936751-767ef07082a8dc3f12048c56b1a9381a023bc8f1.profdata to chrome-win32-master-1592953173-dfa217e6d4c03de878e7e0d7393e7f5bccc2ec20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id0d4bca59c2f07ff27b1796aa1cd1ed75bc2f51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262032Reviewed-by:
-
danakj authored
Instead ask WebTestControlHost to create a JavaScriptDialogManager when it is present. This removes the 2nd-last dependency from shell/browser production code to shell/browser/web_test. The only last one is the WebTestControlHost. R=avi@chromium.org Bug: 866140 Change-Id: Ied37d492c520f5f274dc662f4f8782fb8544de1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260941 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Asami Doi authored
Add a new metric that is used for the Finch experiment (CheckOfflineCapability) to record the time that a fetch event was queued. Bug: 965802 Change-Id: Ie7e579c138c69d96f18c8fff71c2ca5b9ea279bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245970Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781686}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592935173-8e4ecbeaa648b10e168b33ede78da61a4b393ac3.profdata to chrome-win64-master-1592953173-8fb0a7663f4cd8da151edd9da48fe9964b3af4db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iaf237e8756a375d339c7db36968ea5c3431b0882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262053Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/825e09a61fc2..15444a50b912 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150,chromium:1096216 Tbr: johannkoenig@google.com Change-Id: I1b241463c01f0b7c9ed9a22c9a44a53c9eeac0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262052Reviewed-by:
-
Jing Wang authored
The feature is behind the flag imeOptionsInSettings. Now we have real data displayed in these two options pages, and changing the options there will actually change values in prefs. US English and Pinyin are two representative input methods, so I first implement their pages. Add other pages should be easy after these two are done. Screenshots of the implemented UI: US English: https://screenshot.googleplex.com/eZNEF5mjste Pinyin: https://screenshot.googleplex.com/X0aDrc8SkiE Test: tested with Chrome on Linux Bug: 1086786 Change-Id: I083369526805c15f73049b23ce07edce76fe246e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228439 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#781683}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/613777a9..b2720383 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I254a9be54779eb3ad6491c8e22c3b83f1db4d340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260582Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781682}
-
