- 01 Dec, 2020 40 commits
-
-
Sean Harrison authored
Add an additional pref to indicate whether the device in question has the privacy sandbox settings UI available. Modify the 2 existing prefs to be syncing. Create an OWNERS file for chrome/browser/privacy_sandbox, and add some members of the chrome friendly settings team to it. Bug: 1152336 Change-Id: Ie39a763a703fc2c2ee092d14513fca31784037ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565572Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#832294}
-
Francois Beaufort authored
This CL removes all code related to the ended origin trial for Web NFC. See "Changes done after Origin Trial (OT)" section at https://github.com/w3c/web-nfc/blob/gh-pages/EXPLAINER.md Bug: 520391, 1131141 Change-Id: Id34926a0db53462271d88572204cb50a3b4a1bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554598 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#832293}
-
dpapad authored
polymer_modulizer() will process a commented out HTML import statement and convert it to a non-commented JS import statement. For example: <!-- <link rel="import" href="bar.html"> --> will become import './bar.m.js'; Note this CL is only adding new test cases, as the feature itself was already (accidentally) working. This feature is meant to be leveraged in cases where an HTML import does not actually exist in the Polymer2 version of the code, which is happening for some files in FilesApp's case. Fixed: 1152687 Change-Id: Id3a38a1753bdb4a0e7edbfb8d4deacc542d1c489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560805Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832292}
-
Harald Alvestrand authored
This uses the function for creating a PeerConnection that returns an error, rather than returning a null pointer only on error. This allows to differentiate what went wrong when construction failed, such as when failing to parse an ICE server URL. Bug: webrtc:12238, chromium:1044901 Change-Id: I8b634ddb002fb6123b3b7c8e3109661adcb98e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563600 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#832291}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ccd0b7e15e47..df873e5fa6d3 2020-12-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2232da5c to db49fa80 (475 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ib77663bb384f4d385d419ccac27d7b4acd22688d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832290}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iec1488062d71d9275649ef0be4915b0620648008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567668Reviewed-by:
-
Francois Beaufort authored
This CL replaces NotAllowedError with InvalidStateError DOMException when Web NFC interfaces are used in a non top-level browsing context. Spec: https://github.com/w3c/web-nfc/pull/610 Bug: 520391 Change-Id: I1aba5440d34664f65b321f8425609cc7e74488f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560267 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Peter Marshall authored
This was going to be used for HaTS surveys in the DevTools frontend but we ended up going with a different implementation where we share code with the browser implementation, so we don't need our own API key anymore. This was never used as it was just added in preparation. R=msarda@chromium.org Bug: 1112738 Change-Id: Ibb92f40bdb1bad23b90320c5021c642961040e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560499 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#832287}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a827aa2c29aa..a6a7e46e5451 2020-12-01 shaobo.yan@intel.com Enable CopyTextureForBrowserTests on Vulkan/Metal Backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Id1a3934ccf9aa65882a5b1085036fd67708d89d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567662Reviewed-by:
-
Anastasiia N authored
Show device account separate from secondary accounts on Account Manager page in Settings. Screenshots: http://screen/9i9gfgQEoNQVHW2, http://screen/9H2JVQ8iNG7v2ZM (child), http://screen/UDEYqQmEoLXLXcb (managed). Bug: 1144113 Change-Id: Ie1773486fd46c7149ab5a14c6ca16e496a1bc259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547291Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#832285}
-
dpapad authored
Upon entering Presentation mode: - Disable scrolling and hide scrollbars. - Disable zooming with ctrl+wheel and pinch gestures. - Force fit-to-height. - Next/previous page can be shown using the left/right keyboard arrows. The following known issues - Zooming is still possible with ctrl+/- - Rotating is still possible via ctrl]/[ - Using the scroll wheel does not update to the next/previous page will be addressed in a follow up CL. Bug: 1148478 Change-Id: I8b0e3b9ea6c3ed6738bc07f313935c7ea4d770a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539741 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832284}
-
dpapad authored
Part 3 affects a subset of files that need preprocess="true" and not flattenhtml="true". Specifically files affected in this CL use <if> statements, but no <include> statements. Bug: 1152343 Change-Id: I7bc674ad5085738299bf4c6d30702afeeb48902d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565185 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Antonio Sartori authored
This CL stores the raw values of the parsed Content Security Policies directives into the mojo types. This is yet another step to align the mojo types to Blink's CSP implementation, where the raw values are used for reporting and for console messages. Bug: 1021462,1149272,1149926 Change-Id: Iee34cba2fad3a98a483a5e0e9898ce90a5754ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546541 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/56dbd799f56d..ec8113a86a79 2020-12-01 mathias@chromium.org [Dark Mode]: migrate accessibility/axBreadcrumbs.css 2020-12-01 mathias@chromium.org [Dark Mode]: migrate accessibility/animationTimeline.css 2020-12-01 andoli@chromium.org Migrate elements/ extensions of type 'setting' 2020-12-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b870b1cedf178f66af4ad9d1a32b234c47a7985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567660Reviewed-by:
-
Peter Marshall authored
Bug: 1112738 Change-Id: I4bba96de7a669797ee32d0b6fab7b9d5501dc6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560099Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832280}
-
Morten Stenshorne authored
We do not even attempt to honor orphans or widows requests during the initial column balancing pass (since we have no idea which column is going to get which content). Detect unappealing break points during layout instead, and stretch the columns if possible when this happens. This is different from the legacy fragmentation engine, which does this during the initial column balancing pass, but this approach doesn't work so well, since we'll have no idea which lines end up in the same fragmentainer, and the lines may have different heights; see crbug.com/1013151 Also stretch if possible if we violate any break-{after,before,inside}:avoid rules. Note that it was already working for break-inside:avoid, but not for break-after or break-before. css/css-multicol/balance-orphans-widows-000.html also passes without this fix, but it fails in the legacy engine, due to column over-stretching described in crbug.com/1013151 css/css-multicol/balance-break-avoidance-000.html also passes without this fix, but I couldn't find any test like this (break-inside:avoid and how it affects column balancing), so here it is. Bug: 1013151, 1066380, 829028 Change-Id: Ic4fca68644864b8209d49fa5f0d62d6079e6c0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566810 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#832279}
-
Harvey Yang authored
As InitTabletPowerButtonMembers should be called in tablets and convertibles, and clamshells won't get any accelerometer samples, the logic can be simplified to trigger it when receiving on the first accelerometer sample received. BUG=b:174124714 TEST=unit tests Change-Id: I0d0df6cffd668832f1fd7e9449335a6605f65ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557939Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#832278}
-
Fredrik Söderqvist authored
CodeUnitCompareIgnoringASCIICase(...) == 0 is more succinctly expressed as EqualIgnoringASCIICase(...). Change-Id: If5da83661b768d48a9ebbe41a9af8b2d3decf52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556521Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#832277}
-
Morten Stenshorne authored
If the initial balancing pass calculated a block-size that wasn't enough to fit everything, stretch the columns, but not beyond what we have room for in any outer fragmentation context. Part of this fix is the realization that we cannot reliably tell up front that we are going to need more outer fragmentatainers or not (if block-size is auto); hence the rename from needs_more_fragments_in_outer to bool allow_more_fragments_in_outer. Bug: 829028 Change-Id: I2532312ca52cd2980da151f2c0f59177e4521144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566790 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: Iae9522a33ba067adc3aa47d6281c19771371ab99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563393Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#832275}
-
Luciano Pacheco authored
I've searched all references to images from CSS: $ grep '\Wurl(' -iR ui/file_manager/file_manager/ \ | egrep -o '\((.*)\)' |grep '/images' |sort -u Then checked every occurrence to see if it was still in-use, tracking spreadsheet (internal): https://docs.google.com/spreadsheets/d/1ooKj9mrODcic__lhK1dO6wkKireDtmjUge24trmKS0c Most of the images removed are from our old style and can be removed. When the whole CSS selector and rules were easily identified as non-FilesNG I removed the whole section. Bug: 1151829 Change-Id: Ibbe820734d5aa62259332b3a440d141adbc227f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564981Reviewed-by:Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#832274}
-
Jan Krcal authored
This CL reenables the CreateSignedInProfileSigninAlreadyExists test within the ProfilePickerCreationFlowBrowserTest suite. The underlying bug has been fixed by a previous CL. Bug: 1144065 Change-Id: I7b15ff47f4eb8c3e16214269bc98a7f23bddbf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563671 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832273}
-
Rainhard Findling authored
* Introduces a flag for showing both compromised and weak password counts in safety check (SC). * Puts the SC side of this UI change behind the flag. Bug: 1128904 Change-Id: I62c11d6893bd539d59796c3397a5d708b07ce253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562666Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#832272}
-
Marc Treib authored
DataTypeManagerImpl::assocation_types_queue_ only ever contained <= 1 entry. So this CL changes it from a queue to an Optional, and simplifies some code accordingly. Before USS, association was an async step that ran in parallel with downloading, and so multiple association steps could get queued up. Now, StartNextAssociation() is synchronous. When a download is complete, the corresponding StartNextAssociation thus finishes immediately, before the next download is started. So there can never be more than one pending (the one corresponding to the currently-ongoing download). Bug: 1102837 Change-Id: Ifd19f5fa676451a77a58582e0c03a2c20a7107ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565710 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832271}
-
Tim Schumann authored
This reverts commit d3cc95bb. Reason for revert: Suspecting cause of Mac failures due to crashes in web_app::OsIntegrationManager::OnShortcutsCreated(). BUG: 1154195 Original change's description: > [WebAppProvider] Test OS hook uninstallation calls & completion logic. > > This patch adds the virtual methods to the uninstallation path, and adds > corresponding tests for those in the unittests file. > > R=phillis@chromium.org > > Change-Id: I316145e6030d16ff3a28bf7fecb3d2cdbac940d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545864 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832087} TBR=dmurph@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,phillis@chromium.org Change-Id: I9a8b09451117b7597d3b380da3ecab93e797fb7b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566814Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#832270}
-
Yutaka Hirano authored
Provide an experimental function that allows web developers to control the duration which determines whether an outgoing datagram should be discarded due to being in the queue for too long. Bug: 1150350 Change-Id: I3d81771264a8924f3bdfe6e54adb2b0bed1a8ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563107 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832269}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606649289-a1ddd7e3579fd6803de4501ea269c51715a31009.profdata to chrome-win32-master-1606759191-849e6110591039c862ea10277c9aceb1aa0b28d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icb24d3269e561f2087b25d593a366150d20203ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566290 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia5262b5664a860943fefcdd0a35cdcb5cd238c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567436Reviewed-by:
-
Denis Kuznetsov authored
This CL moves ACCELERATOR_KIOSK_ENABLE and ACCELERATOR_SEND_FEEDBACK accelerator handling to the C++ side. It also changes the screen where starting consumer kiosk is possible from GAIA screen to user adding screen. Bug: 1102393 Change-Id: I154a0f801668aa03127fea217637acfb4fe82497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563543Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#832266}
-
Yuzu Saijo authored
This CL makes ExecutionContext know about bfcache status, so that it can set load defer mode correctly (bfcache defer/ normal defer/ no defer). Bug:1137682 Change-Id: I499ab63b336636ce8bba41e303286f82ac12fd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559475 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
PartitionAllocator opens /dev/urandom for address randomization when allocating memory.(c.f. //base/allocator/partition_allocator/random.cc and //base/rand_util_posix.cc) This causes MultiprocessExec.MultiprocessExec test failure. So temporarily disable the test on posix when PartitionAllocator is default. Bug: 1153544 Change-Id: I19ea568745caf01c6c7fe9d2ad3f845891b2a9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562811Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
Make this code use the LayoutImageResource to get the Image to create the DragImage from. This means we can avoid open-coding the SVG image setup since LayoutImageResource::GetImage performs the appropriate setup for us. Move the various validity checks into a new CanDragImage() function and straighten out and simplify DragImageForImage() a bit. In part by splitting out the computation of the drag location/origin to match the link-drag case. Change-Id: I344727973693e28ac4681e0af2154a5a8d263ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563690Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#832263}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I019ef691185669b724e72433a6c27f9922a11a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567486Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832262}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606748271-2b69dce80f38ecf2d66f6209245527ea06788f5d.profdata to chrome-win64-master-1606780634-4bcba867177e99782f7fa7f8d4c0822ffa36a5f3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iabb08f9565d02132c4d2baafb971a87713b07df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566464Reviewed-by:
-
Yoshifumi Inoue authored
This patch utilizes |Position::LastPositionInNode()| instead of constructor with |PositionAnchorType::kAfterChildren| to reduce source code size and preparation of getting rid of |kAfterChildren|. Note: This CL is similar to the CL[2] which utilizes |FirstPositionInNode()|. [2] http://crrev.com/c/2556733: Utilize Position::FirstPositionInNode() Bug: 592887 Change-Id: I882f98033a87d491af77484af8dd0b31b54f287e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566314 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Sergey Poromov authored
DlpRulesManager was initialized in UserCloudPolicyManagerChromeOS::Connect for regular managed users on Chrome OS. However, for MGS and Kiosk it doesn't work and we need to initialize it somewhere during manager user login, e.g.when the managed profile is created. The first use case here would be Imprivata. Bug: 1142699 Change-Id: Iae470401892759b29fd3afb8c248dd2d9900904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555062Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#832259}
-
Patrick Brosset authored
The flex overlay code uses a simple way to detect if flex items belong to the same flex line or wrap on subsequent lines. The logic in the code to do this did not account for row/column-reverse direction. Bug: 1153272 Change-Id: I90466af5d8ffa84cee5a8f3f035bdc8a76e8cb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563782Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832258}
-
Tal Pressman authored
Following this discussion on cxx [1], this CL enables the bugprone-argument-comment check in Tricium. [1] https://groups.google.com/a/chromium.org/g/cxx/c/LysF5a-aUDo Change-Id: I5d81b27bcdc6b2e84c772ddbece7df6eeb86f4e7 Bug: 1016926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557940Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#832257}
-
Colin Blundell authored
This CL was cherrypicked to 88 with the version numbers adjusted there: https://chromium-review.googlesource.com/c/chromium/src/+/2561381/1..5 Hence we can now adjust the version numbers on trunk. Bug: 1149955 Change-Id: I554ae299b43eecfb66870c386e9b1ccc0d07bcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562842Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#832256}
-
Kuo Jen Wei authored
Fixed by not calling |orientPhoto()| on saved photo but only on thumbnail to be scaled. Bug: b/173690479 Test: Manually check exif the result photo taking from different orientation and photo can display correctly in backlight and files app. Change-Id: I7374f0303169dd5e8efb6b7f6d8e04e90aefaf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559474Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#832255}
-
