GitLab

Clean up incorrect guard end comment, and remove unused pp_var.h
Review URL: http://codereview.chromium.org/7310007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91749 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7238012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91748 0039d316-1c4b-4281-b951-d872f2087c98

We were synchronously destroying the RendererGlContext transfer buffers while commands may still be pending in the command buffer that use them. This generated spurious kOutOfBounds errors. kOutOfBounds errors cause us to kill the associated GpuChannel. That leads to lots of bad behavior, such as failing to reload certain WebGL demos.

This change simply lets the command buffer destroy the shared memory in its destructor instead of destroying them explicitly. The GPU-side resources are cleaned up when the command buffer is destroyed.

BUG=88115
TEST=Open NVIDIA Command Buffer Object WebGL demo; Refresh; Verify successful refresh.

Review URL: http://codereview.chromium.org/7301010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91747 0039d316-1c4b-4281-b951-d872f2087c98

Add another test terminate condition in media perf test. This is to catch the video playing error as early as possible (rather than waiting for timeout). This will prevent my script from occupying buildbot.

Review URL: http://codereview.chromium.org/7322015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88679
TEST=none

Review URL: http://codereview.chromium.org/7314026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91745 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we looked at the user gesture state when deciding whether to
dismiss infobars.  Now that WebKit's user gesture state doesn't lie, we can
tell that this behavior is incorrect.  Page-specific infobars, like translate,
should close whenever the main frame navigates to a new page, regardless of
whether that navigation was conducted from a user gesture.

BUG=86417

Review URL: http://codereview.chromium.org/7205026

TBR=abarth@chromium.org

Review URL: http://codereview.chromium.org/7324001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91744 0039d316-1c4b-4281-b951-d872f2087c98

CL that introduced the change:
http://codereview.chromium.org/7292010/
Committed r91742

BUG=none
TEST=none
TBR=apatrick

Review URL: http://codereview.chromium.org/7324004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91743 0039d316-1c4b-4281-b951-d872f2087c98

This CL divvies up the GpuVideoService functionality among the relevant
classes.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7292010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91742 0039d316-1c4b-4281-b951-d872f2087c98

match sharing the same template url. For example, if the results were
'A B C D' with 'A' and 'B' sharing the same provider and 'C' and 'D'
sharing the same provider, then 'A' and 'C' would get descriptions.

As part of this I'm always setting AutocompleteMatch::template_url
(previously we only set it for keywords).

BUG=88322
TEST=see bug, also covered by unit tests.
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/7321001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91741 0039d316-1c4b-4281-b951-d872f2087c98

1 - z-order: make it show on top of the footer
2 - disable uninstall when appropriate
3 - fix appearance of disabled items on linux/gtk (applies to all places menu.js is used)

BUG=none
TEST=see above

Review URL: http://codereview.chromium.org/7227025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91740 0039d316-1c4b-4281-b951-d872f2087c98

  - mac-release-10.5/morejs/times/t (regression at 89864, investigating)

TBR=nsylvain@chromium.org
BUG=88687

Review URL: http://codereview.chromium.org/7310034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91739 0039d316-1c4b-4281-b951-d872f2087c98

Fix crashes in EnterpriseEnrollmentScreenTest.TestCancel. This is independent of any tfarina-induced bustage.

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7313027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91738 0039d316-1c4b-4281-b951-d872f2087c98

Allow that method to be called without a corresponding call to
OnSignalConnected() - the linked bug-report explains how this can happen.

This is only a partial bug-fix; still need to address the problem of this
method being called on the wrong thread from ChromotingHost::Shutdown().

BUG=83788
TEST=Manual


Review URL: http://codereview.chromium.org/7307031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91737 0039d316-1c4b-4281-b951-d872f2087c98

Change the type of valuator_lookup_[kMaxDeviceNum][TP_LAST_ENTRY] from "char" to "signed char".

-1 is set for valuator_lookup_[][] for invalid entry.
Some ARM platform/cross-compiler defaults "char" as
"unsigned char" which does not accommodate negative 
value -1. Fixing it by specifically setting the type 
to "signed char".



BUG=
TEST=


Review URL: http://codereview.chromium.org/7312028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91736 0039d316-1c4b-4281-b951-d872f2087c98

move the rest of the tiles to where they belong when an app is uninstalled

BUG=none
TEST=uninstall an app that is in the middle of an apps page

Review URL: http://codereview.chromium.org/7312016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91735 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=88532
TEST=browser_tests --gtest_filter=TestWebUIFactory*.*


Review URL: http://codereview.chromium.org/7307034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91734 0039d316-1c4b-4281-b951-d872f2087c98

Migrating PPB_FileIO_Dev, PPB_FileRef_Dev, and PPB_FileSystem_Dev dependencies to PPB_FileIO, PPB_FileRef, and PPB_FileSystem.
Also fixed some lint errors.
Review URL: http://codereview.chromium.org/7248047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91733 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91732 0039d316-1c4b-4281-b951-d872f2087c98

New test failure introduced and noted in test_expectations.txt:  fast/canvas/canvas-empty-image-pattern.html

Also, remove layout test failure markers that were resolved by skia r1810.

BUG=88577, 88681
TEST=NONE
Review URL: http://codereview.chromium.org/7317002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91731 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7308009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91730 0039d316-1c4b-4281-b951-d872f2087c98

  if (visible)
    gtk_widget_show(...);
  else
    gtk_widget_hide(...);

with:

  gtk_widget_set_visible(..., visible);

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7310016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91729 0039d316-1c4b-4281-b951-d872f2087c98

Add std:: to find() and replace() calls

BUG=
TEST=

Review URL: http://codereview.chromium.org/7273081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91728 0039d316-1c4b-4281-b951-d872f2087c98

I.e. now host signals that it is ready to accept new data using sockets,
not IPC messages.

That should reduce audio latency.

Right now we are using high latency code path by default, low latency
would be used only when flag --enable-low-latency-audio is specified.

Changed unit tests to test low latency code path, as it should become
default soon.

http://codereview.chromium.org/7253003

BUG=http://code.google.com/p/chromium/issues/detail?id=87640
TEST=Everything should just work. I changed audio_renderer_impl_unittest.cc to explicitly force low latency code path.

Review URL: http://codereview.chromium.org/7253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61140
TEST=Default compilation on Linux builds in smooth scrolling behind a flag - check about:flags to verify.


Review URL: http://codereview.chromium.org/7314015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7316013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91725 0039d316-1c4b-4281-b951-d872f2087c98

Don't start activation process if network doesn't support that.

BUG=chrome-os-partner:4652
TEST=Manual. Navigated to chrome://mobilesetup on GSM network.


Review URL: http://codereview.chromium.org/7313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91724 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7320002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91723 0039d316-1c4b-4281-b951-d872f2087c98

Register the OIDs for the businessCategory and incorporationCountry
attributes.

Add a case for SEC_OID_UNKNOWN as a safety net.

R=mattm@chromium.org
BUG=88612
TEST=On Linux, visit https://servicios.izenpe.com/ and view the certificate.
The subject field should have:
businessCategory = Business Entity
incorporationCountry = ES

Review URL: http://codereview.chromium.org/7313019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91722 0039d316-1c4b-4281-b951-d872f2087c98

The RTCVideoDecoder will eventially need to depend on third_party lib (webrtc, libjinle etc), which is not allowed in media. So move rtc_video_decoder* from media/filter/ to content/renderer/media/.

patch by ronghuawu@google.com

BUG=none
TEST=unit_tests, media_unittests
Review URL: http://codereview.chromium.org/7193001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91721 0039d316-1c4b-4281-b951-d872f2087c98

Caused test failures in views_unittests.

----

BUG=84721
TEST=Switch tabs...no flicker

Review URL: http://codereview.chromium.org/7171025

TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/7312027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91720 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7307038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7316009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91718 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88602
TEST=none

Patch contributed by Charles Lee <charleslee@chromium.org>

Review URL: http://codereview.chromium.org/7312026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91717 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91716 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81795
TEST=Visit https://servicios.izenpe.com and ensure that the EV badge appears.


Review URL: http://codereview.chromium.org/7315010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91715 0039d316-1c4b-4281-b951-d872f2087c98

to fix the crash because CoInitialize() call failed.

BUG=85589
TEST=thread_watcher unit tests
R=willchan
Review URL: http://codereview.chromium.org/7301009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91714 0039d316-1c4b-4281-b951-d872f2087c98

GetCompositingSurface should just return a non-zero value on TOUCH_UI because we use a very different accelerated drawing path. In particular, the GPU process renders offscreen (to a region that it creates) and passes a handle to the video memory for the browser to display.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7314021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91712 0039d316-1c4b-4281-b951-d872f2087c98

This converts the input event from a C struct to a resource to give us more
ability to change over time. This patch includes a proxy and a C++ wrapper for
this resource.

You now have to register for classes of input events. No events are sent by
default. This also allows us to specify whether the events support bubbling
or not, which allows us to better-optimize IPC.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/7285010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84721
TEST=Switch tabs...no flicker

Review URL: http://codereview.chromium.org/7171025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88315
TEST=none


Review URL: http://codereview.chromium.org/7277082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91709 0039d316-1c4b-4281-b951-d872f2087c98