- 02 Nov, 2020 40 commits
-
-
Yuta Hijikata authored
Bug: None Change-Id: I1fbe7c568f0720c702f6b1d0f11ea0e40c280875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507289 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823076}
-
Kunihiko Sakamoto authored
- allow-sxg-certs-without-extension is still used by developers for testing. - enable-sxg-prefetch-cache-for-navigations and enable-sxg-subresource-prefetching are related to SignedExchange Subresource prefetching, which is shipped in September. Being able to disable it with a flag would be useful for diagnosis, so let's keep them for a while. Bug: 862003,935267,968427 Change-Id: Ice8942664b5418a1c0119f65d89eed1fa507a21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509153Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#823075}
-
David authored
Currently we don't record this for JS crash reports. chrome://media-app wants to record the uptime of the renderer process to help track down potential race conditions. The uptime is obtained from metrics::RendererUptimeTracker. Bug: b/169635499, 1143049 Change-Id: Id12667449d9d208048af0a2dad5ed6f282033333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501105 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#823074}
-
Melissa Zhang authored
This reverts commit 2d6200c7. Reason for revert: Relanding as revert did not fix breakage. Original change's description: > Revert "Roll src-internal from 0025d7b0e55d to 83a59aab7480 (1 revision)" > > This reverts commit 7a75607f. > > Reason for revert: Breaking 9 builds including: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20Tests%20%28sandboxed%29/72001 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21094 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/18830 > > > Original change's description: > > Roll src-internal from 0025d7b0e55d to 83a59aab7480 (1 revision) > > > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0025d7b0e55d..83a59aab7480 > > > > If this roll has caused a breakage, revert this CL and stop the roller > > using the controls here: > > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > > Please CC on the revert to ensure that a human > > is aware of the problem. > > > > To report a problem with the AutoRoller itself, please file a bug: > > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > > Bug: None > > Tbr: > > Change-Id: Ib271e08916a66ff838e21fb42b6154748625cdb7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513259 > > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#823002} > > TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com > > Change-Id: Ifa18251fc50818462295af4729e440217f711275 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513308 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823047} TBR=yyanagisawa@chromium.org,tikuta@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,melzhang@chromium.org # Not skipping CQ checks because this is a reland. Bug: None Change-Id: I79494e8c3ce6ffd96dd80007deb093756ac98878 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513311Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#823073}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibd6e594b71f6eea4b8889bbb2ddadaa7266d73f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823072}
-
Luciano Pacheco authored
Nits addressed: - Add type check. - Remove "#export" markup. - Use Object.assign() to export test functions to global scope. - var => const/let. Files updated: - menu_button_test.m.js - menu_test.m.js - position_util_test.m.js - splitter_test.m.js Bug: 1133198 Change-Id: I6dbb9a2928f478cf5b543919c6800b9cd4ca6676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505322 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#823071}
-
Rob Schonberger authored
This reverts commit 0737c281. Reason for revert: Poor behavior on Kohaku noted, candidate is revert for now. Original change's description: > Update the tf native cc/h > > Update the tf native code of neural palm detection. > Model description: > 1. Trained with kohaku + meowth data, the auc on basking data is 0.9478. > 2. Feature vector is the same as the old one, feature size = 193. > > Bug: 1095874 > Test: deployed and tested on a kohaku device > Change-Id: Id62f14f82dfc9d0895aba88765b44407cd35db6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249279 > Reviewed-by: Rob Schonberger <robsc@chromium.org> > Commit-Queue: Rob Schonberger <robsc@chromium.org> > Commit-Queue: Xinglong Luan <alanlxl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779666} TBR=robsc@chromium.org,alanlxl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1095874 Change-Id: I33c72d0159451d954021e79f8bae17b2283adea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511491Reviewed-by:
Rob Schonberger <robsc@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823070}
-
Phillis Tang authored
After remove using SuppressOsHooks for unit testing, it's unnecessary and redundant to have both SuppressOsHooks and GlobalSuppressOsHooks. This change gets rid of SuppressOsHooks. Change-Id: I32ce47a2d74a928cea0b6cf7e19aca8f52cfbee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503832 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#823069}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69c856dc..be169f63 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9368ce700043f18cf74c144701277bd75b746879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512475Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823068}
-
Curtis McMullan authored
The flag code for the cros resizable vk has already been removed in a prior cl (2413679). The flag metadata was missed in that CL and not removed. This CL removes the flag metadata. BUG=b:164919876 Change-Id: Ieba23324b31fc2019a6c0e3b154d50bdf24492e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513847Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823067}
-
Melissa Zhang authored
TBR=estade@chromium.org Bug: 1144598 Change-Id: I388de0ac068a023de69d804debcd2652c970cf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513408Reviewed-by:
-
Phillis Tang authored
Adds In-Product Help that shows a blue bubble indication under PWA install icon. This CL doesn't have any custom triggering logic added. Follow up patches will be made to only show IPH when user shows high engagement with the site, and site-scoped & global dismissal & muting logic. Bug: 1135811 Change-Id: I1b38471baf139ead734ef4063d81a12fc4bcf988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485695Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
third_party/blink/public/common/prerender/ contains only the OWNERS file after https://crrev.com/c/2409890. Bug: 755921 Change-Id: I51f1ec7e0c397592989cc60c581c69eae8ebf484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512487 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests. Change-Id: I24821c0ddf1226effbecb687eded8b2523d526e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500388 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823063}
-
Noel Gordon authored
Files app SWA is disabled on OFFICIAL_BUILD bots [1]. Skip running the SWA load test on those bots. [1] See https://crbug.com/1113981#c14 Test: browser_tests --gtest_filter="*launchFilesAppSwa*" Bug: 1113981 Change-Id: I29dc49cb64ec19a07ea8e812b561523de28fd479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512493Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#823062}
-
Josh Simmons authored
When requests are routed back to ChromeOS via ChromeContentProvider, do not use virtual_file_provider for opening files from FUSE-backed filesystems. This expands existing support for DriveFS to Crostini, smbfs and FUSE-backed archive implementations (fuse-zip, rar2fs). Test: unit_tests --gtest_filter="*ArcFileSystemBridgeTest*" Test: Open mp4 file from Crostini sshfs, fuse-zip and smbfs with VLC Bug: 1132141 Change-Id: I29ec9f99664928b93061b02b94149d761e186a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430524Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#823061}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c2505565a25..6d614919c918 2020-11-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I439ca8b8c0d8ecb902015c7901b70c19fcc335bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513965Reviewed-by:
-
Alexander Dunaev authored
The GPU info collector had an X11-only section that gathered GPU extra info specific for X11. This CL moves the code that gathers the information into //ui/gl so that Ozone/X11 can now use it, and adds a method in the PlatformGLEGLUtility that does the actual gathering. Also this CL fixes one minor thing that had been forgotten in the predecessor change [1], namely does some renames in content/browser/gpu/gpu_internals_ui.cc and in ui::display::Screen for better readability and consistency. https://chromium-review.googlesource.com/c/chromium/src/+/2478362 Bug: 1121945 Change-Id: I48bbbaa047777e3a51220f59a3f907d64130a14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501621 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#823059}
-
Toni Barzic authored
HoldingSpaceTray observes holding space bubble widget, but it was not removing itself from the widget observer list if the bubble got closed without going through HoldingpaceTray::CloseBubble. Without this, holding space tray unittests crash on teardown unless the tray bubble is closed. Bug: None Change-Id: If01f7b23e0268734ba178c566f961e645525438f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504214 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#823058}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=benwells@chromium.org Bug: 1142671 Change-Id: I17252ff848f20fc78acda5fc4bd589ada6314124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500487 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#823057}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I4404cdfe7d0d8350b0a775951c6e1827a0b102be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513569Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823056}
-
Ben Reich authored
Append sourceURL comment to allow Devtools to map parsed scripts back to their source location. This new source location is surfaced in the Sources tab in Devtools as well as the Chrome Devtools Protocol event Debugger.scriptParsed which is used during JavaScript code coverage. This also updates 2 of the vars to const's for the FilesToggleRipple and the FilesRipple. Bug: 1113941 Test: None Change-Id: I3344dc18ec678bd76190ede3a5ee80f440db4e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505743 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#823055}
-
Maggie Cai authored
This CL extends the kAppServiceIntentHandling flag expiry milestone to M89. This is because this feature is landed on M85 and we want to see it in stable for another milestone and possibly collect more data. BUG=853604 Change-Id: I35119ece0ec6a42c84beda1974a5f4872a97e864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513309Reviewed-by:
-
Ye Kuang authored
Bug: 1127205 Change-Id: I4404c078887fddea6c097311401ab25f94816a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509231Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#823053}
-
Hoch Hochkeppel authored
Updating the various fake classes produced for Web Share to reflect best practices brought up during other Web Share reviews. This includes expanding system #defines for types, using 'final' where appropriate, avoiding explicit AddRef calls where possible, including checks on cleanup, and allowing calls to methods that don't require additional functionality of the test class (even if they are not currently in use). The addition of some of these cleanup checks also prompted updates to some of the unit tests that were not closing streams. Bug: 1035527 Change-Id: Iea6c488b735d5877ba307d33c859114611c56dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511629Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823052}
-
Jinsuk Kim authored
This CL relands https://crrev.com/c/2467578 after addressing the bugs reported by https://crbug.com/1141360. - The distinction between the last visible NTP vs. currently shown one was not clearly made in LocationBarPhone/Tablet. - ToolbarLayout.onTabOrModelChanged/onTabContentViewChanged are handled now by a injected callback. This reverts commit 2fc6005e. TBR=tedchoc@chromium.org Bug: 1127732 Change-Id: I875dce57daf03f15b8cf754052bc86ec488f403d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500389Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#823051}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604251409-e846506890af0f839bd08ee89131bb5d743bcf79.profdata to chrome-linux-master-1604271327-859bf76e70bab499db77421e4956351ee35b85b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e28b3e1a35c391a8824aef8c2f68cc45e8e0472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513518Reviewed-by:
-
Bo Majewski authored
Uses the freshly introduced UI delegate to make strings used by Files app available to File SWA. Bug: 1113981 Change-Id: I86abd7c855e0f60f3b50bb20fba703597905a2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507130Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604251409-1e125259f9113bdaacb10d1e80539c23d4c920c1.profdata to chrome-mac-master-1604271327-560fc0565e99076ccb3fc89f6569961e7231f7d6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia79f2e9e946755ad18dc7f7aeb75a87d8e374806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513517Reviewed-by:
-
Melissa Zhang authored
This reverts commit 7a75607f. Reason for revert: Breaking 9 builds including: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20Tests%20%28sandboxed%29/72001 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21094 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/18830 Original change's description: > Roll src-internal from 0025d7b0e55d to 83a59aab7480 (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0025d7b0e55d..83a59aab7480 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: > Change-Id: Ib271e08916a66ff838e21fb42b6154748625cdb7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513259 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823002} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ifa18251fc50818462295af4729e440217f711275 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513308Reviewed-by:
-
Melissa Zhang authored
This reverts commit f9084f27. Reason for revert: Previous roll (https://crrev.com/c/2513259) breaks builders so reverting. Original change's description: > Roll src-internal from 83a59aab7480 to 1d5f49275a2e (2 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83a59aab7480..1d5f49275a2e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: > Change-Id: Ie23f02143d563d50d6f7823fb68554f2cdcd0904 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513374 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823012} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ib7e26fecec2869f29566d7157028f98cf3de935a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512491Reviewed-by:
-
Koji Ishii authored
The spec changed to: > The UA must therefore only automatically hyphenate text for which the content language is known and for which it has an appropriate hyphenation resource. https://drafts.csswg.org/css-text-3/#valdef-hyphens-auto This patch matches the updated spec. Bug: 676270 Change-Id: I79bd9c260bde8e744f1261af38b665e0ebc72500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505692 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#823045}
-
Melissa Zhang authored
This reverts commit af6207c5. Reason for revert: Previous roll (https://crrev.com/c/2513259) breaks builders so reverting. Original change's description: > Roll src-internal from 1d5f49275a2e to 962e0bffb3c6 (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d5f49275a2e..962e0bffb3c6 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: > Change-Id: Idc5db86d3c85a572a20dd3a9a50288dfdb05e02e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513465 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823021} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Iea3862f9991ab6c5cf84cfcfae6fb4bebc6def57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512333Reviewed-by:
-
Melissa Zhang authored
This reverts commit 4b4b97fe. Reason for revert: Previous roll (https://crrev.com/c/2513259) breaks builders so reverting. Original change's description: > Roll src-internal from 962e0bffb3c6 to 4407359581ba (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/962e0bffb3c6..4407359581ba > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: > Change-Id: Icbd942dba5fb9a9483ce0490447ac70304e772cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513507 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823027} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: If22f2e178c4363c58e1415489f9c0b71d926aaf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512490Reviewed-by:
-
Melissa Zhang authored
This reverts commit ee51d8a8. Reason for revert: Previous roll (https://crrev.com/c/2513259) breaks builders so reverting. Original change's description: > Roll src-internal from 4407359581ba to b7a3f15b3631 (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4407359581ba..b7a3f15b3631 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: > Change-Id: Ib1b4953eb7e525e3804775c1feb1677ff15594e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513461 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823032} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ia56f7b760a54a0ded380406bb2d17ffad2eaf6d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512332Reviewed-by:
-
Melissa Zhang authored
This reverts commit 6bb88ef2. Reason for revert: Previous roll (https://crrev.com/c/2513259) breaks builders so reverting. Original change's description: > Roll src-internal from b7a3f15b3631 to c39459b523de (1 revision) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7a3f15b3631..c39459b523de > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: None > Tbr: > Change-Id: If1ff2c7b80a55facae4aa262dd9f13dace8cf2e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513685 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823037} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I77539511a8c23c5985194e8539fdf13d3575ab1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513306Reviewed-by:
-
Alan Cutter authored
This CL removes the //chrome/browser/web_applications:common build target and folds the source files into //chrome/browser/web_applications. The :common build target was originally designed to enforce that the code inside didn't depend on either BMO or bookmark app implementations of web apps such that it would be safe to swap bookmark apps out for BMO when it came time to migrate. The migration has been completed and it is now safe to couple directly to BMO implementations. Bug: 1114966 Change-Id: If6d50c8ca54e34e5c528bdbe12a92387a55e1406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505357Reviewed-by:
-
Koji Ishii authored
r819319 crrev.com/c/2476354 added |NGInlineItem.is_hyphenated| as the flag to indicate whether it is hyphenated or not, but failed to update |ApplyJustify|. This patch changes it to use the flag instead of |hyphen_shape_result|. Bug: 1141755 Change-Id: I49303b54c22c419a2dcf804cf40e4ec3b1a1f4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511151Reviewed-by:
-
Victor Costan authored
Before this CL, AppCacheService's documentation claimed that its methods should be used on the IO thread. However, the method implementations in AppCacheServiceImpl DCHECK that they're used on the UI thread. This CL updates the documentation to reflect reality. Change-Id: I09f1cdbdb27c0e50d55f2ad043b0612eae5287ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513351 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#823038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7a3f15b3631..c39459b523de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If1ff2c7b80a55facae4aa262dd9f13dace8cf2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513685Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823037}
-
