- 20 Nov, 2018 40 commits
-
-
Eric Foo authored
Bug: 868202 Change-Id: Iee7e12d9aa5a1575d542739b99f351589f1ebb76 Reviewed-on: https://chromium-review.googlesource.com/c/1341241Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609828}
-
Robert Liao authored
This test works fine on Linux. BUG=161902 TBR=sky@chromium.org Change-Id: Idaefa2f3f0f1544af4f28ba6e43b211b7a368e0f Reviewed-on: https://chromium-review.googlesource.com/c/1344216Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#609827}
-
Xi Cheng authored
Bug: 701944 Change-Id: Idf06f127aba7d4a50fa23d631ff78604b3a57258 Reviewed-on: https://chromium-review.googlesource.com/c/1342672Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#609826}
-
John Chen authored
Fixing a JavaScript code syntax error in the code intended to cause a two frame wait before dispatching touch events. Bug: chromedriver:2665 Change-Id: I7a69a58500fdae5fdb45ab836eb96c054f8e54b9 Reviewed-on: https://chromium-review.googlesource.com/c/1340582Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609825}
-
Tommy C. Li authored
We have launched this to Stable some time ago. Bug: 900255 Change-Id: I52ea22c451cee3b0bf7df67710978ef272f781ae Reviewed-on: https://chromium-review.googlesource.com/c/1343366 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609824}
-
Mohamed Heikal authored
The Protobuf Java Lite runtime is now separate from the main java runtime. This cl adds the java lite runtime to the repo. In a follow up Bug: 782237 Change-Id: I9f4af1736006ab224dc4230d3a071290974135b8 Reviewed-on: https://chromium-review.googlesource.com/c/1338574Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f1238bc..2ecd5f54 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0cec98aac943d42f6fdcf4d3c6f42812beab8a37 Reviewed-on: https://chromium-review.googlesource.com/c/1344253 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609822}
-
Kevin McNee authored
A GinPort's onDisconnect may invalidate the context (e.g. MessagingApiTest.MessagingBackgroundOnly). Attempting to invalidate the events throws an exception which interferes with the extensions JS testing framework. Now the framework can call more of the safe builtins without triggering the exception, so we do so here. Bug: 803668 Change-Id: I07aa962ba689174a4f35885c72a9c3318256ff50 Reviewed-on: https://chromium-review.googlesource.com/c/1342068Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#609821}
-
Adam Langley authored
There has been confusion about the third-party review process. Try to clarify that chromium-third-party is about licensing review, that the reviewers may simply leave a comment, and that they are not expected to be able to approve a change. Change-Id: I8461f9b416f8d76542230beb770a2cf8f5c44d6f Reviewed-on: https://chromium-review.googlesource.com/c/1338477Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#609820}
-
Jacob Dufault authored
- Remove the webui lock screen tests. - Re-enable flaky test since it should no longer flake because there is no longer webui involved. Bug: 899777 Change-Id: I759ad6d20a08ad48e6a992fcfca9a25572ad16a5 Reviewed-on: https://chromium-review.googlesource.com/c/1327163 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609819}
-
Maggie Chen authored
Screen capture on protected videos will no longer work after software protected videos are supported. This CL handles YUVVideoDrawQuad only. The other part of the support on the gpu side was checked in separately. The main change in this CL is to replace the existing flag |is_protected_video| with |protected_video_type| which includes clear, softwareProtected and hardwareProtected. NOTE: Before this CL, |PROTECTED_VIDEO| means hardware protected video. After this CL, |PROTECTED_VIDEO| means both software and hardware and |HW_PROTECTED| will differentiate whether it's protected by software or hardware. Bug:903552 Change-Id: I8c025bdcbafaed224a5e1f9ea6fa14b42bdfe192 Reviewed-on: https://chromium-review.googlesource.com/c/1334099Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609818}
-
Matt Menke authored
I migrated it to the network service's pref files a year or so back, but didn't realize unregistered prefs weren't automatically pruned from preference files, so never deleted the old entries. Given that this pref can be quite large, it definitely needs to be pruned. Bug: 715695 Change-Id: Ia9f1592a5064cdcdfe22bf144c5c5e66a272ec9d Reviewed-on: https://chromium-review.googlesource.com/c/1344989 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#609817}
-
John Budorick authored
This reverts commit 7d53bc24. Reason for revert: still referenced by cq.cfg. Original change's description: > Remove incorrect named builders ("_" underscores) > > Bug: 868202 > Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138 > Reviewed-on: https://chromium-review.googlesource.com/c/1343081 > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Eric Foo <efoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609559} TBR=hinoka@chromium.org,efoo@chromium.org,jbudorick@chromium.org Change-Id: Ic530f835ef9367cda18f54be54dc712d3f229ded No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868202 Reviewed-on: https://chromium-review.googlesource.com/c/1345234Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#609816}
-
David Benjamin authored
I've left expiry milestones alone for now. tls13-variant should hopefully be unwound quite soon. enforce-tls13-downgrade will depend a lot on how long it takes to clear through the mess of non-compliant Enterprise middleboxes out there. Bug: none Change-Id: Iecdfd86618de36a2ba949f3eb472010fff3d5f24 Reviewed-on: https://chromium-review.googlesource.com/c/1344578Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#609815}
-
Ken Rockot authored
Migrates some miscellaneous stuff from ServiceContext and ServiceTest over to ServiceBinding and plain old unit tests. Introduces new TestService and TestServiceManager helpers for such unit tests to use. This ultimately provides similar functionality to the old ServiceTest framework but with much less hidden magic and only a marginal increase in per-test boilerplate. Bug: 895616,906239 Change-Id: I5c4958f92092ee435efe2c83eaa371f1171a71d4 Reviewed-on: https://chromium-review.googlesource.com/c/1343372 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609814}
-
edchin authored
Change-Id: Id201ca6aba14146bcea4456bd4353c376e38e860 Reviewed-on: https://chromium-review.googlesource.com/c/1341246 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609813}
-
Ken Rockot authored
This switches the IME and Assistant services to use ServiceBinding instead of deprecated ServiceContext & EmbeddedService APIs. Also moves their tests off of the deprecated ServiceTest framework and changes them to be simple unit tests. TBR=dcheng@chromium.org Bug: 891780,906239 Change-Id: I047fd3879da1c4eb89643717cd3d247cf638ef9b Reviewed-on: https://chromium-review.googlesource.com/c/1343037Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#609812}
-
Giovanni Ortuño Urquidi authored
SystemTrayNotifier will be removed, so move the observer list direclty into TrayBluetoothHelper. Bug: 882346 Change-Id: I316a43cc98d879003e378e01994e40038e557f93 Reviewed-on: https://chromium-review.googlesource.com/c/1343588Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609811}
-
Robert Sesek authored
This also removes some now-unused Cocoa control classes in //ui/base and several unneeded resources. Bug: 739386, 832676 Change-Id: I9289cc5613c4303521aaed9271ddc7574e2611a0 Reviewed-on: https://chromium-review.googlesource.com/c/1343055Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609810}
-
Gabriel Charette authored
Friend'ing specific methods is incorrect since the addition of GetIfExits() because, although clang compiles this without warnings, the spec clearly says that friend'ing an undeclared method is not allowed (even if no such method ever exists and hence never uses that friend declaration). Not nearly all singletons need to support GetInstanceIfExists() and hence adding everywhere is undesired. This CL makes Singleton<T> friend all of T. This is fine because that doesn't give much more power to T (beyond the option of naming its GetInstance() method differently...). Bug: 905990 Change-Id: I2d2c721b27f8f3fa3367dff996f37293c98674c3 Reviewed-on: https://chromium-review.googlesource.com/c/1343660Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#609809}
-
Etienne Pierre-doray authored
[TaskScheduler]: Migrate off of ScopedAllowWait in /content/browser/renderer_host/text_input_client_mac.mm base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 766678 Change-Id: I39a4449295407eaf1016cbfdb1e5b8842f1dda7c Reviewed-on: https://chromium-review.googlesource.com/c/1325206Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#609808}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c6195df99b92..44bef83f2be0 git log c6195df99b92..44bef83f2be0 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 lamontjones@chromium.org signing: KeyPair filename extension cleanup Created with: gclient setdep -r src/third_party/chromite@44bef83f2be0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifcc618b9310f5e99ace7f98e084161f02a5cb3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1342954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609807}
-
Michael Lippautz authored
tl;dr: Write barrier elimination in ctors requires white-allocation of objects. Longer: Avoid scheduling GC calls during object allocation (construction) as they would potentially invoke V8 marking steps. Such a marking step is problematic if the object that is currently being constructed has already been published as constructors rely on white-allocation of objects in order to avoid write barriers for initializing stores. A call to V8 may trigger a marking step which in turn may mark an object black if it already has been published. Bug: 903790, 843903 Change-Id: I9ede36f34f074f76b563601fd4bd1dcb30f561c4 Reviewed-on: https://chromium-review.googlesource.com/c/1341997 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#609806}
-
Zhiqiang Zhang authored
Most of the tests are migrated from CastMessageHandlerTest. Some new tests are added as CafMessageHandler has more methods than CastMessageHandler: * testHandleClientConnectMessage* * testHandleClientDisconnectMessage* * testHandleClientLeaveSessionMessage* * testSendReceiverActionToClient * testBuildSessionMessage* Bug: 711860 Change-Id: I821bb91f0c685809c143b60cc4700c47ffec16b6 Reviewed-on: https://chromium-review.googlesource.com/c/1343292 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#609805}
-
Luum Habtemariam authored
Per (https://sites.google.com/a/chromium.org/dev/flag-ownership), we need to tag our chrome flags with owners. Bug: N/A Change-Id: I31b90d6cc736e48edd37982c267ce8d2094b8b42 Tests: Regressions pass Reviewed-on: https://chromium-review.googlesource.com/c/1344581Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#609804}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afe4ec5b3170..5db7ecf7859e Created with: gclient setdep -r src-internal@5db7ecf7859e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I302d191c435115f3647a92d5b357ac8c70f17c70 Reviewed-on: https://chromium-review.googlesource.com/c/1343852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609803}
-
liberato@chromium.org authored
Previously, 'Learner' was a roll-up trainer + model, intended to make it easy for clients to use the learning system. However, since LearningSession can do this too, it makes sense to split the model apart from the particular training algorithm used to build it. Change-Id: If207bf64c6a5b34fb84591b9b149bdd9a3ff6af4 Reviewed-on: https://chromium-review.googlesource.com/c/1327544Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609802}
-
Mirko Bonadei authored
It will be moved to another header and another build target soon. More info: https://groups.google.com/d/msg/discuss-webrtc/F__pbaZxxS0/tP8bMo7GAQAJ. Bug: webrtc:9862 Change-Id: I260dca561db73d65eebb09930d510bec98d236c5 Reviewed-on: https://chromium-review.googlesource.com/c/1343259Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#609801}
-
Javier Ernesto Flores Robles authored
Instead of looking only to the credit cards to suggest, check for all to hide and show the Manual Fallback icon. User can also use this icon to go to the manage cards settings page. Bug: 845472, 906019 Change-Id: I3be2a715ebd00583ec44c5d45517e769c92d57f5 Reviewed-on: https://chromium-review.googlesource.com/c/1340265 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609800}
-
Sergey Ulanov authored
FrameImpl was destroying FocusController without removing it from list of window event handlers, which was causing CHECK in the destructor. Bug: 906785 Change-Id: I78bb13a60e9e56ce663cfba9f6ded0357c3bab4c Reviewed-on: https://chromium-review.googlesource.com/c/1344749Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609799}
-
Xianzhu Wang authored
This corresponds the interest rect expansion for scrolling contents in CompositedLayerMapping::RecomputeInterestRect(). Bug: 792577 Change-Id: Ibcde49ad098f9f3e53ca2af246ce2aa825a21f20 Reviewed-on: https://chromium-review.googlesource.com/c/1335748Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609798}
-
Fabio Tirelo authored
This is the first CL to generalized the keyboard accessory handlers on the Chrome backend, so they can be also used to serve Autofill data. This CL spawns ManualFillingController from PasswordAccessoryController, both controllers are attached to a WebContents object. The new controller which is responsible for: - Coordinating requests from type-specific accessory controllers (Autofill and Password) and forwarding them to the native UI; - Forwarding events from the native UI to the type-specific controllers. To allow mocking of these classes in unit tests, this CL defines an interface and an implementation for each controller. Code review order suggestion: - password_accessory_controller.h: split original class into interface + implementation, this is the interface; - password_accessory_controller_impl.h: class implementing the interface; - manual_filling_controller.h: very similar to password_accessory_controller, but git doesn't understand copies; same idea: interface + implementation; - manual_filling_controller_impl.cc: class implementing the interface; - password_accessory_controller_impl*.cc; - manual_filling_controller_impl*.cc; - everything else, basically minor changes. In order to keep this CL more focused on the split, some steps of the generalization will be done in follow-ups (check TODOs pointing to https://crbug.com/896690), and the ManualFillingCoordinator simply forwards events to PasswordAccessoryController. One example is password generation: in this CL, MFC contains methods to forward password generation events to PAC; in the final state, MFC will define a general function that handles "actions" and will forward events to type-specific coordinators (passwords or autofill) based on action type. Please refer to the linked bug for details on next steps of this refactoring. Once it's done, we will be able to plug in Autofill requests. Bug: 905669 Change-Id: I4fb2fd1b4a729114d3c7e4dd59ec7a582ba8aea0 Reviewed-on: https://chromium-review.googlesource.com/c/1336557Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609797}
-
Jeremy Roman authored
It appears that this is intended to be a public header (at least, Blink is using it as such), so this updates the deps to depend on the appropriate target. Change-Id: I593f77d065b25ce080159f2920816841c9bf7837 Reviewed-on: https://chromium-review.googlesource.com/c/1330033Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609796}
-
Xi Cheng authored
RegisterOrRemovePreviousRunMetricsFile() has 5 arguments already. If we want to tweak and apply it to the code block below TODO, we need to add another 3 arguments to the function at least. The function will end up with having 8+ arguments which is undesired for readability. Change-Id: I9cd5e03287ad661253c0312e48b9d143df35da74 Reviewed-on: https://chromium-review.googlesource.com/c/1343519 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609795}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b81ff9e6c518..0e604f9f1107 git log b81ff9e6c518..0e604f9f1107 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 jmadill@chromium.org ANGLE Perf Test fixes. Created with: gclient setdep -r src/third_party/angle@0e604f9f1107 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2673a61d1c70dcbe635d972a98d0f909bdedee22 Reviewed-on: https://chromium-review.googlesource.com/c/1343853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609794}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: Ifdeeb97fee9a964bca4fdeaece3df139e6c7584c Reviewed-on: https://chromium-review.googlesource.com/c/1344250 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609793}
-
Vikas Soni authored
Update generate_bindings.py to generate android platform specific device functions. Bug: 891060 Change-Id: I88f5b6149c4e955613b64e56c403caf2a970dd6f Reviewed-on: https://chromium-review.googlesource.com/c/1344223Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609792}
-
James Hawkins authored
Bug: 903991 Test: none Change-Id: Ia52137049e6805bae4f04c1251ff1df862a6d644 Reviewed-on: https://chromium-review.googlesource.com/c/1343536Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#609791}
-
John Rummell authored
This reverts commit 45a0df8f. Reason for revert: Mac tests flaky, due to filesystem storing time in second increments only. Original change's description: > Reland "Update BrowsingDataRemoverBrowserTest to include MediaLicenses" > > Original change's description: > > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > > External Clear Key CDM to store the license in the file system, if it is > > available. > > > > This reverts commit 72f2d4cd. > > BUG=808690,879812 > TEST=new browser_tests pass > > Change-Id: Ie9e9229fc85244eed922d93dce82cb3fa09bbe5c > Reviewed-on: https://chromium-review.googlesource.com/c/1342779 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609752} TBR=jrummell@chromium.org,dullweber@chromium.org Change-Id: I1c49014959d10fb9eb2306af0f71cb724ef40070 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808690, 879812 Reviewed-on: https://chromium-review.googlesource.com/c/1344884Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609790}
-
Alexandre Frechette authored
Bug: 907134, 902803 Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45 Reviewed-on: https://chromium-review.googlesource.com/c/1344256Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609789}
-