- 27 Dec, 2019 40 commits
-
-
Pavel Yatsuk authored
This CL moves SnackbarView.java, Snackbar.java, SnackbarCollection.java, SnackbarManager.java. Tests will be moved in a separate CL. BUG=1028382 R=mdjones@chromium.org Change-Id: I847ce100b03fb3b4596ed02c2c32d2f8505ba4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974902 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#727637}
-
Brandon Wylie authored
TBR=cduvall@chromium.org Bug: 1035894 Change-Id: Ie212a40b4aa33390734e3871e68ab03d84cd1db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983347Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727636}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aca963f8ae30..a6a291685941 Created with: gclient setdep -r src-internal@a6a291685941 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I19a4ea780c96ec5d04689f5819692b26c4c30023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982921Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727635}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.86-1577097374-benchmark-81.0.4005.0-r1 to 81-3945.86-1577097374-benchmark-81.0.4008.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2685c0afde88d8a2a7da564a8e60b7a2792d1372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727634}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.0-1577100150-benchmark-81.0.4005.0-r1 to 81-3987.0-1577100150-benchmark-81.0.4008.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibdecb9a788de4aca4975fba7240c1fa1f398c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982926Reviewed-by:
-
Matt Reynolds authored
A prior CL switched HidService::ConnectCallback from RepeatingCallback to OnceCallback, but did not correctly adapt the callbacks passed to PermissionBrokerClient::OpenPath on Chrome OS. OpenPath takes separate success and error callbacks, but both paths should ultimately call the same ConnectCallback. This CL uses base::AdaptCallbackForRepeating to convert the ConnectCallback to a copyable callback that can be bound to both the success and error callbacks. BUG=1036761 Change-Id: I5b39fd0df496e7a614d6a5be688d78653eb9f46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982860 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#727632}
-
Xiaocheng Hu authored
Tests disabled due to flaky failures at https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36521 Bug: 990362 Change-Id: I8a75c46e1868152216fe3cd34a579805fca871f1 NoTry: True Tbr: antrim@chromium.org, rsorokin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982923Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727631}
-
Caleb Rouleau authored
1. Enable run_performance_tests.py to handle shard maps that contain gtests. 2. Convert functional test results output of gtest to a simple json3 format. This allows us to merge json test results from gtests and from telemetry tests when they are both in a single shard. Bug: 921353, 920002 Change-Id: I4b02025b882602a057f582e9a96f91f1e411c882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982681Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727630}
-
Khushal Sagar authored
TBR=ericrk@chromium.org Bug: 1037654 Change-Id: I266e1f38f4e84fffd2f7ced469897cae868225e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982226Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#727629}
-
Tarun Bansal authored
Remove logic for FINAL_STATUS_DEVTOOLS_ATTACHED in prerender since it does not trigger for NoStatePrefetch (it was needed for prerender). Bug: 1038058 Change-Id: I06b4367622ef14814a7d1a01fefab244de8ee452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977830Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727628}
-
Khushal Sagar authored
We assume the ServiceTransferCache must be set if we have a GrContext. This might not be the case if the GrContext is set for non-GL backends. R=zmo@chromium.org Bug: 1037988 Change-Id: I679fb9fe044d4f40af46a12a3e040f79d0d624aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982778 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#727627}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a7ca7a2a393..81158535ed1b git log 0a7ca7a2a393..81158535ed1b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 rmistry@google.com Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers Created with: gclient setdep -r src/third_party/skia@81158535ed1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Ia6f147b63b369d9009204c85d6b0b4ae9f423624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983324Reviewed-by:
-
Andrew Grieve authored
TBR=agrieve # Trivial build script change. Bug: 1036426 Change-Id: I0c10f5024ccbfaafdeae1950e18c72e7651bdd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982774 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727625}
-
Kurt Horimoto authored
Bug: none Change-Id: I7593ce8730acca27d3fb9f2e3bd46fdaf926f7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982772Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#727624}
-
Matthew Mourgos authored
This reverts commit a1297fc3. Reason for revert: Broke test with hotseat feature enabled. Original change's description: > CrOS Shelf: Set right margin on status area based on tablet mode > > With this change, the padding between the edge of the screen and the > status area widget no longer has anything to do with the hotseat > state. This edge padding will now only ever have two possible values, > one value in tablet mode and another value in clamshell mode. > > Bug: 1035716 > Change-Id: I70f8ffe99ddf8e44482a3c9772f72dcf7adb9885 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977025 > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727486} TBR=tetsui@chromium.org,manucornet@chromium.org,mmourgos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035716 Change-Id: If730127fc7471d9a063fb45530c81b99b2abd035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983328Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727623}
-
Will Cassella authored
Previously there were several WebXr feature flags for experimental features (WebXrARDOMOverlay, WebXRAnchors, WebXRPlaneDetection), now they've been placed under a single feature flag (WebXRIncubations). As features mature, they should be moved out from under this flag. New experimental features should be added to this flag. Change-Id: Idb0d26c2745447f1f181dea00399b8bf2a2160d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977190 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727622}
-
Devlin Cronin authored
Remove TestExtensionDir::WriteManifestWithSingleQuotes(). This was a convenience function introduced before we had support for string literals in the language. Now that we have string literals, those are preferred: - They are more consistent - They preserve newlines - They don't clutter each line with double-quotes - It is mildly faster, since we don't have to do string replacement. Remove the old WriteManifestWithSingleQuotes() function, and update all call sites. This CL should have no behavior change. Bug: None Change-Id: I2e65c514530316d2d25fd75cb33ca2ffcb1a244e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975073 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727621}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb1fb6a0..4c53f9a5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I331a408d4bb6ffb6889c1e2dc6dafa9c4f5e38ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983131Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727620}
-
Devlin Cronin authored
Extensions with withheld permissions that are invoked on a page that also need to run before the page finishes loading require a page reload to execute. This is shown to the user via a bubble prompt when the extension is invoked. Add a UI test exercising this flow with the extensions menu (one already existing for triggering and executing the bubble, but not a UI test for displaying the UI). This also serves as a replacement to ExtensionBlockedActionsBubbleTest. InvokeUi_ExtensionBlockedActionsBubble, which is more dependent on the old UI implementation. That test is now only run if the extensions menu is disabled. Also renames ExtensionsMenuViewBrowserTest.ActivationWithReloadNeeded_Accept to ExtensionsMenuViewBrowserTest.TriggeringExtensionClosesMenu, which more accurately describes its behavior and expectations. Bug: 984654 Change-Id: I68c72a1c8ce7cb0d1a70cb023ccd5c5d39083d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982240 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727619}
-
Andrew Grieve authored
Turns out google storage sets a one hour public cache header by default, which means a bad push results in the page being broken for an hour. This leaves the default header on for .size files, but sets all other files (which are tiny) to no-cache. Note: the .wasm file is big, and should probably be cached, but that is handled by the service worker already. Bug: None Change-Id: Ia3c03e4533c37338b924d5ace3f7b5fd4ac8d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981263 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Christopher Cameron authored
This is unused. Bug: 1015599 Change-Id: I80e66a9a7d2b402fd1f794d20a37dd4a834165e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982983Reviewed-by:
-
Christopher Cameron authored
This test fails when DialogDelegate::GetDialogWidgetInitParams is changed to set views::Widget::InitParams::child (that is, to make the dialog not be a top-level widget). The reason this test fails is that, during teardown, focus has not been removed from the dialog, so the line DCHECK(!!focused_now || !new_text_input_client); in NativeWidgetMacNSWindowHost::OnDidChangeFocus fails (because the TextInputClient has not been reset, as would have been done by un-focusing the dialog). The reason that this didn't fail before the patch is that Widget::CloseWithReason would un-focus the Widget's views before deleting destroying them. But only for top-level widgets, for no clear reason. Other places where similar things should be done (e.g, Widget::NotifyNativeViewHierarchyWillChange), do this for all widgets (not just top-level). Add a helper function Widget::ClearFocusFromWidget and change all places that are trying to remove focus from the widget to use that call. Bug: 957362 Change-Id: I9905055fc12a54441e7f918094ba2ec0a61f6e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981265Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#727616}
-
Christopher Cameron authored
There is no current use of constant luminance as an output format, and it is the only remaining transform that uses a LUT. Replace it with NOTREACHEDs. Bug: 1015599 Change-Id: If383bd2638c5959403c43dd3d22c6f7f3c814255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982143Reviewed-by:
-
Kurt Horimoto authored
Several overlay tests require the use of minimal config objects. Rather than requiring each test suite to define OverlayRequestConfigs, the DEFINE_TEST_OVERLAY_REQUEST_CONFIG() macro allows for easy one-line creation of these test configs. Bug: none Change-Id: Iae1d74492ed658b2d60b6bd4b885a28c67412a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982771Reviewed-by:
-
Tarun Bansal authored
This is no longer needed with NoStatePrefetch Bug: 1038055 Change-Id: I4fd28548e0e78aa6d7cb65ed7238eac9fe6a56be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982706Reviewed-by:
-
Sammie Quon authored
They are two functions that do very similar things. Will need to consolidate so future changes to either one affect both. First use case will be the linked bug. TBR=xdai@chromium.org Bug: 1026962 Change-Id: Id6e79a5159ed0fb10abdef1368467ab3dbbbeb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982141Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Avery Musbach <amusbach@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#727612}
-
Christopher Cameron authored
This was added with the idea of finding some reasonable way to display HDR content on non-HDR displays. We aren't in that game. Pages have the responsibility of serving HDR content only to HDR-capable displays. Also remove the colorimetric intent argument from gfx::ColorTransform's internals, because it was being ignored. R=zmo, meacer TBR=dcastagna (exo) Bug: 1015599 Change-Id: I23561654ef5062bfa3913f08a353cca487f4a440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982764 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#727611}
-
Devlin Cronin authored
At one point in the past, the ExtensionErrorUi was responsible for alerting the user about sideloaded extensions (extensions that were added by another binary via registry or preferences modification). This changed in https://chromiumcodereview.appspot.com/11150002/, but some of the old UI was never cleaned up. Remove it, the unnecessary strings, and clean up the related methods. Bug: None Change-Id: Iaea002e4123e64697144dce507d9ecf0cd2ccaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980167Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Mark external/wpt/mathml/relations/css-styling/ignored-properties-001.html as flaky timeout Sample timeout: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16397 Change-Id: Id1a07d979ff2c8f1f3e716c469536ec395c82b32 NoTry: True Tbr: xiaochengh@chromium.org Bug: 6606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983325Reviewed-by:
-
Emily Stark authored
This change moves most of the SlowDownloadHttpResponse functionality into a base class (SlowHttpResponse) in preparation for using SlowHttpResponse in another test that needs to serve a slow text/html response rather than a download. TBR=dtrainor@chromium.org Bug: 1034468 Change-Id: I25e91583742ef320168b08abc560f46efa03ddfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982129Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#727608}
-
Akihiro Ota authored
This change adds functionality to announce capital letters. A <select> has been added to the ChromeVox options page to allow users to choose how they want capital letters to be signaled. The two options are increasing pitch and announcing 'cap' before the letter. This patch does not change the phonetic hint behavior for capital letters. That means even if ChromeVox announces 'cap <letter>', it will still follow-up with the phonetic hint for the letter. Bug: 809094 Change-Id: I05193df0f281b5f1e1fc7ebb8cccc761d61a6ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953645Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#727607}
-
Pavel Yatsuk authored
Snackbar layout is a RelativeLayout with top, left and right shadow views and Linear layout with content. Because left and right shadows' bottoms are not anchored to anything RelativeLayout allows them to grow to maximum height. This causes snackbar to push to the top of the screen. Anchoring bottoms of side shadows to the bottom of content view forces RelativeLayout to set their heights explicitly to the height of top shadow and content, instead of letting shadow views expand to full height. BUG=1035954 R=mdjones@chromium.org Change-Id: I39be9b8db5136fb726ae9cdec5dc5df24823a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977824 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit ded6a689. Reason for revert: re-landing with a fix to address headless test flakyness. Original change's description: > Revert "Headless: fix a crash in ~HeadlessWebContentsImpl" > > This reverts commit 20cefba5. > > Reason for revert: suspected cause of crbug.com/1037652 > > BUG: 1037652, 1034954 > > Original change's description: > > Headless: fix a crash in ~HeadlessWebContentsImpl > > > > ... due to reentrancy while waiting for a [sync] call to > > FrameSink::DestroyCompositorFrameSink() from Compositor destructor. > > > > Bug: 1034954 > > Change-Id: I8b47560d18bdab38e40e67e6506d30a2043f1474 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977741 > > Reviewed-by: kylechar <kylechar@chromium.org> > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#726858} > > TBR=caseq@chromium.org,kylechar@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1034954 > Change-Id: I244a6d9a9e36b8edb1297e9a3aa523b133f764e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982223 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727504} TBR=caseq@chromium.org,kylechar@chromium.org Change-Id: I7fa661b8ba366ca15a91fac741b49ea9170b93c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982773 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727605}
-
Mia Glaese authored
Show HOMEPAGE, when entering Start Surface through Home button in top or bottom toolbar. Show TABSWITCHER, when entering through Tabswitcher button in top or bottom toolbar. Allow for switching between the HOMEPAGE and TABSWITCHER surfaces when both buttons are visible. Not switching to Tabswitcher bottom bar in start surface. Screenshots: https://drive.google.com/drive/folders/1E4VDh_QA8Ac3MJ3R3ORflMKFaampHnJu?usp=sharing In follow up: New top tabswitcher toolbar for Start Surface. Full UX design here: go/clank-start-ux Bug: 1025296 Change-Id: Ib6058596355125f682ab18f30731c01effada667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956187 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727604}
-
Tarun Bansal authored
Use WebContents::GetLastCommittedURL to compute the last URL. Change-Id: I829c01287a9902c302c87d7a127bde70303558a3 Bug: 1037945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982235 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#727603}
-
Devlin Cronin authored
Allow page actions to trigger if they are "overflowed" (not visible on the main toolbar). Instead of gating on view visibility, gate on the enabled state of the page action (which, historically, indicated visibility as well). This allows users to overflow a page action and not have it visible all the time on the main bar, while still being able to trigger it via a keyboard shortcut. Add a regression test for the same. This also fixes the following tests with extensions menu feature: - CommandsApiTest.PageAction - CommandsApiTest.PageActionKeyUpdated - CommandsApiTest.PageActionOverrideChromeShortcut Bug: 1037685, 984654 Change-Id: I64b65abcd79cf746b4428653de505f53b60eff43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982595 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df2c1ee4f270..0a7ca7a2a393 git log df2c1ee4f270..0a7ca7a2a393 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 bsalomon@google.com Avoid div by zero in ProcessorTest to please UBSAN 2019-12-27 herb@google.com Move updating a single texture coordinate to SubRun 2019-12-27 fmalita@google.com Revert "GrGLMakeNativeInterface_{iOS,mac,win}: clean up" Created with: gclient setdep -r src/third_party/skia@0a7ca7a2a393 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I42d4503466f04d7aa28f203ff077fbcdcc8a168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982872Reviewed-by:
-
Xiaocheng Hu authored
Timeouts on https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/3561 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/3564 Change-Id: Ibcc0a9aefb2203e673670b2f55d0c32430b5a834 NoTry: True Tbr: xiaochengh@chromium.org Bug: 856601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982878Reviewed-by:
-
Roman Sorokin authored
The extension was used before on the login screen. Not used anymore Bug: 1036348 Change-Id: I6d3c917a36168e43977a0b311ef3270546c4a667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978745Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Ia6d467c287027902d8d3b40d68774c0de73c75b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979246Reviewed-by:
-
