GitLab

BUG=560603
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/1473533003

Cr-Commit-Position: refs/heads/master@{#361239}

Continuing https://codereview.chromium.org/1412083002 but:
Removed emojis from generated_resources.grd and update the code.
Now we are keeping Emojis in the code rather than resource files.

BUG=498288
TEST=Follow these steps (taken from bug report):
1. Open multiple Chrome windows (optionally with multiple tabs)
2. Play sound clip (e.g via youtube) on a given tab
3. Drop down the Window menu
4. It is also possible to mute the tab and see what will happen but
chrome://flags/#enable-tab-audio-muting should be enable.

Review URL: https://codereview.chromium.org/1432803002

Cr-Commit-Position: refs/heads/master@{#361238}

Check active tree state separately, on each PrepareToDrawOnThread.

The source of the flakiness that the
test previously made assumptions about the timing of draws (when the active
tree's draw properties get updated) vs commits.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1472723002

Cr-Commit-Position: refs/heads/master@{#361237}

Also tweak the newline at the end of the stamp file to be
compatible with update.sh. This way, if either downloads
clang the other will consider it up-to-date.

BUG=494442
NOTRY=true

Review URL: https://codereview.chromium.org/1468243002

Cr-Commit-Position: refs/heads/master@{#361236}

Missing braces when adding code inside an "if" block,
resulting in lots of attributes being marked as editable
when they shouldn't be, breaking VoiceOver.

Regression happened in:
https://crrev.com/6185ca046850b24b92a5dffd9ab7d1ecc3048001
https://codereview.chromium.org/1435113003/

BUG=559210,473220

Review URL: https://codereview.chromium.org/1473483002

Cr-Commit-Position: refs/heads/master@{#361235}

They are not used yet, but will be soon.

BUG=548424
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1471693004

Cr-Commit-Position: refs/heads/master@{#361234}

BUG=560550

Review URL: https://codereview.chromium.org/1471153002

Cr-Commit-Position: refs/heads/master@{#361233}

The breakability of the object doesn't matter here. The space shortage that
prevented an object from fitting in one column may very well be the lowest
space shortage that we'll ever find. So always record it, to avoid
over-stretching columns.

BUG=559133
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1465193002

Cr-Commit-Position: refs/heads/master@{#361232}

Adds translation one-box triggering when the user selects
using long-press.  This currently requires server-side
auto-detection of the source language, but it should not
over-trigger due to a feature of the one-box (suppressed
when the source and target text ends up matching).

Adds a separate flag to control disabling this feature,
currently default-enabled.

BUG=413717

Review URL: https://codereview.chromium.org/1463583004

Cr-Commit-Position: refs/heads/master@{#361231}

Stacks that are truncated due to the Win32StackFrameUnwinder being
unable to unwind are being reported with an extra frame.

BUG=555770

Review URL: https://codereview.chromium.org/1469983002

Cr-Commit-Position: refs/heads/master@{#361230}

We have a large set of histograms that were set up private
before our feature launched, that should now be public.
This adds those existing histograms.
Removing the private ones will be done soon in the private
repository.

BUG=545055

Review URL: https://codereview.chromium.org/1441013004

Cr-Commit-Position: refs/heads/master@{#361229}

This implements proper handling of lost context by exosphere. It
also improves support for software compositing by not crashing.
True software compositing support will be added by follow up
patches.

BUG=549781
TEST=exo_unittests --gtest_filter=BufferTest.IsLost

Review URL: https://codereview.chromium.org/1467943002

Cr-Commit-Position: refs/heads/master@{#361228}

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's no single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=

Review URL: https://codereview.chromium.org/1471523002

Cr-Commit-Position: refs/heads/master@{#361227}

This adds the mock classes and a initial tests for the
ReaderModeManager.

BUG=

Review URL: https://codereview.chromium.org/1469973002

Cr-Commit-Position: refs/heads/master@{#361226}

Revert of Makes window manager include ui pak file (patchset #1 id:1 of https://codereview.chromium.org/1466483003/ )

Reason for revert:
I'm reverting this and will instead include it in the wm.

Original issue's description:
> Makes window manager include ui pak file
>
> We'll need this for cursors and shadows.
>
> BUG=548426
> TEST=none
> R=erg@chromium.org
>
> Committed: https://crrev.com/35b0cd220fd2a788c16055b756e8483936b0e384
> Cr-Commit-Position: refs/heads/master@{#361162}

TBR=erg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548426

Review URL: https://codereview.chromium.org/1472753003

Cr-Commit-Position: refs/heads/master@{#361225}

These tests have never worked on perf bots, and are currently disabled. See
https://code.google.com/p/chromium/issues/detail?id=530405#c10 for more details.

BUG=530405
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1463503003

Cr-Commit-Position: refs/heads/master@{#361224}

Revert of Start calling show/hide onStart/onStop in DocumentActivity (patchset #1 id:1 of https://codereview.chromium.org/1455343002/ )

Reason for revert:
BUG=559197

This was causing an early tab.show call which made the test think the activity is in the foreground.

Reverting my CL for now. Will have to figure out a proper way to hide/show to reland.

Original issue's description:
> Start calling show/hide onStart/onStop in DocumentActivity
>
> This logic in documents diverge from CHromeActivity behavior for
> archaic reasons (crbug.com/451672). Making documents show/hide
> in the same time as all other ChromeActivities with this change.
> Verified that the previous bug that caused the bheavior divergence
> no longer exists after this CL.
>
> BUG=546182
>
> Committed: https://crrev.com/e548d4580bbd915716a855f9195b6f5f2d63d2a1
> Cr-Commit-Position: refs/heads/master@{#360581}

TBR=dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=546182

Review URL: https://codereview.chromium.org/1464313003

Cr-Commit-Position: refs/heads/master@{#361223}

R=michaelpg@chromium.org,apacible@chromium.org
TBR=isherman@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1468623004

Cr-Commit-Position: refs/heads/master@{#361222}

The internal Attribute and AttributeCollection need not know anything
about the web-exposed Attr.

Since Attr::qualifiedName() is not just a trivial getter, calling that
outside of the loop is probably a good idea anyway.

Review URL: https://codereview.chromium.org/1467143004

Cr-Commit-Position: refs/heads/master@{#361221}

BUG=internal b/21639416

Review URL: https://codereview.chromium.org/1473003002

Cr-Commit-Position: refs/heads/master@{#361220}

This problem was already fixed in r360646, but was broken again due
incorrect merge in r361205.

TBR=kelvinp@chromium.org

Review URL: https://codereview.chromium.org/1468283002

Cr-Commit-Position: refs/heads/master@{#361219}

If the frame that called the chrome.webstore.install method to begin an
inline install gets deleted before the user accepts from the dialog, we
don't want the install to continue because a navigation could make it
look like the install request was coming from some unrelated site.

One downside of this approach is that the dialog stays around even after
the frame is deleted, and hitting either accept or cancel buttons both
just cancel the install. It would be better if the dialog is
automatically cancelled, but doing that would involve a lot more
refactoring. The approach in this CL was easier and is probably worth
getting out, and we can improve on it in the future.

BUG=550047

Review URL: https://codereview.chromium.org/1403293008

Cr-Commit-Position: refs/heads/master@{#361218}

One layout test needs rebaselining with the next Skia roll:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/79661/layout-test-results/results.html

BUG=559240
NOTRY=true
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1468053003 .

Cr-Commit-Position: refs/heads/master@{#361217}

This fixes a bunch of positioning and cropped selection bugs.

BUG=548087

Review URL: https://codereview.chromium.org/1461783003

Cr-Commit-Position: refs/heads/master@{#361216}

Force full invalidation after layoutScope.setNeedsLayout() in PaintLayerScrollableArea::finalizeScrollDimensions()

This is a partial revert of https://codereview.chromium.org/799093002
which caused the bug.

This is a temporary measure to workaround crbug.com/560418
for crbug.com/535161.

BUG=535161,560418

Review URL: https://codereview.chromium.org/1471453002

Cr-Commit-Position: refs/heads/master@{#361215}

WKWebView sets the title to blank when the web process dies; ignore that
update so that the navigation item won't end up with a blank title.

BUG=558178

Review URL: https://codereview.chromium.org/1461413004

Cr-Commit-Position: refs/heads/master@{#361214}

Add info to the network part of the timeline flamechart.

BUG=528489

Review URL: https://codereview.chromium.org/1463393003

Cr-Commit-Position: refs/heads/master@{#361213}

SecTrust API is used to make load/no-load decision for certs, while
CertVerifier is used to get rejection reason. Using CRLSets to get
rejection reason is impractical, because iOS blacklist is very
different from Chrome blacklist as well as cost to store CRLSets on
disk is very high.

BUG=None

Review URL: https://codereview.chromium.org/1465513002

Cr-Commit-Position: refs/heads/master@{#361212}

This also makes //win8/* pass "gn check".

BUG=512864,512869

Review URL: https://codereview.chromium.org/1464263003

Cr-Commit-Position: refs/heads/master@{#361211}

Cryptohome does not report this action. We can remove it from
extract_actions.py.
The action is also marked as deprecated in actions.xml.

BUG=560497

Review URL: https://codereview.chromium.org/1470083002

Cr-Commit-Position: refs/heads/master@{#361210}

- only do scrollIntoViewIfNeeded() in a rAF callback to avoid forcing layout;
- get rid of TreeElement.onreveal() as most implementation were a no-op just
    repeating what the call site has already done;
- added `center' parameter to TreeElement.reveal()
- do not center when scrolling with keyboard or searching;

BUG=

Review URL: https://codereview.chromium.org/1461283004

Cr-Commit-Position: refs/heads/master@{#361209}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/01158a14..437819f9

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1470003003

Cr-Commit-Position: refs/heads/master@{#361208}

The InputHandlerProxy in content/renderer implements the logic for
sending the intercepted web input events to the compositor. Move this
logic to ui to be used by mus/blimp.

BUG=550531

Review URL: https://codereview.chromium.org/1415953004

Cr-Commit-Position: refs/heads/master@{#361207}

This is never used outside of //content.

BUG=376003

Review URL: https://codereview.chromium.org/1463013003

Cr-Commit-Position: refs/heads/master@{#361206}

VideoFramePump will not be used for WebRTC-based connection. In a separate
change I plan to move creation of the VideoFramePump to IceConnectionToHost
so the host layer will not need to know when VideoFramePump needs to be
used.

Review URL: https://codereview.chromium.org/1462063004

Cr-Commit-Position: refs/heads/master@{#361205}

pkg_config can't be nested inside a source set. pull out in
media/audio/BUILD.gn

BUG=559487

Review URL: https://codereview.chromium.org/1467843002

Cr-Commit-Position: refs/heads/master@{#361204}

Review URL: https://codereview.chromium.org/1470783003

Cr-Commit-Position: refs/heads/master@{#361203}

BUG=295792
TBR=zmo@chromium.org,jmadill@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1469173002

Cr-Commit-Position: refs/heads/master@{#361202}

This feature is only operative on OS X 10.10 and later, as directed by
CrashpadClient::StartHandler(). This limitation is enforced because the
handler restarter can cause the browser process to become an unreapable
pseudo-zombie on earlier OS versions if it crashes while a handler
restart is pending.

Review URL: https://codereview.chromium.org/1470073002

Cr-Commit-Position: refs/heads/master@{#361201}

Destructuring will be turned on soon in v8, and that will cause
these three tests to start "failing" (though they're actually passing
more, since we support new syntax). Will rebaseline them after the
change rolls successfully into Chromium.

BUG=560503
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1471653005 .

Cr-Commit-Position: refs/heads/master@{#361200}