- 14 Aug, 2018 40 commits
-
-
Sergey Ulanov authored
The new PlatformScreen implementation allows to propagate display settings (such as device_pixel_scale) to the renderer. Bug: 850650 Change-Id: I088c1c46ba57596bd55bf57db854f8b3a2367e83 Reviewed-on: https://chromium-review.googlesource.com/1162426 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582823}
-
Bin Wu authored
Update QUIC flag values. Bundle BbrSender and its BandwidthSampler in memory, hopefully reduces cache misses. Not protected. Merge internal change: 208339929 https://chromium-review.googlesource.com/c/1173696/ Move the delegate from PacketTransportInterface to QuartcPacketTransport. This is the first step of getting rid of the three separate interfaces for QuartcPacketWriter, QuartcPacketTransport, and PacketWriterInterface. Threading requirements, debug info (packet number), and the fact that Quartc owns and manages the entire ICE transport make this somewhat unwieldy at the moment. However, it should get better going forward. This change makes quic::QuartcPacketTransport an interface for network I/O. - Write() sends packets to the network - Delegate::OnTransportCanWrite() indicates that writes are unblocked - Delegate::OnTransportReceived() passes incoming packets to QUIC PacketTransportInterface adds on the signaling and config required for ICE. - Connect() allows the caller to specify initial parameters and start ICE - Disconnect() allows the caller to shut down the ICE transport - SetDeliveryMode() and SetIpPrivacyPolicy() modify ICE parameters at runtime - OnTransportMessageReceived() and OutgoingTransportMessages() provide a channel for signaling ICE candidates Going forward, Quartc will share an ICE transport with other components and will not need to manage the signaling aspects of ICE. PacketTransportInterface can go away once that happens. QuartcPacketWriter remains an implementation of QuicPacketWriter. It handles network output through the wrapped QuartcPacketTransport. It adds two pieces of functionality on top of QuicPacketWriter: it adds packet numbers to every outgoing packet and allows the caller to set the packet transport's delegate. Once QuicPacketWriter::WritePacket() includes packet numbers in its interface, it will also be possible to merge QuartcPacketWriter and QuartcPacketTransport into a single network I/O interface for quic/quartc. Finally, QUIC expects the QuartcPacketTransport::Delegate calls to be serialized with other QUIC operations. The way that Quartc does this serialization today becomes slightly more complex. Since QUIC now calls SetDelegate(), Quartc needs a wrapper to intercept the Delegate and perform the thread hop to the QUIC executor. This is necessary pain induced by thread-hopping. The thread-safe wrapper will become thinner when PacketTransportInterface is deleted. It will go away entirely when we replace quartc_thread_safe with a better synchronization mechanism. FIG_CHANGESET=c4301c7fdf0e83b365a939cc233dc7b006f55884 Merge internal change: 208285103 https://chromium-review.googlesource.com/c/1173695/ In QUIC, when session decides what to write, let IsPacketUsefulForRetransmittableData drops packets earlier. Protected by FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans. Merge internal change: 207934023 https://chromium-review.googlesource.com/c/1173333/ Make QuicSession::GetStream slightly faster by skipping the lookup into the static stream map, when possible. Protected by FLAGS_quic_reloadable_flag_quic_session_faster_get_stream. Merge internal change: 207921542 https://chromium-review.googlesource.com/c/1173332/ In QUIC, if a newer WINDOW_UPDATE frame gets acked, consider all older WINDOW_UPDATE gets acked. Protected by FLAGS_quic_reloadable_flag_quic_donot_retransmit_old_window_update2. Merge internal change: 207915791 https://chromium-review.googlesource.com/c/1173331/ In QUIC, only process stateless resets on the client side. Protected by FLAGS_quic_reloadable_flag_quic_process_stateless_reset_at_client_only. When the flag is on, server won't bother to read |header->possible_stateless_reset_token|, thus saving a small amount of cpu. This is a micro optimization. No externally visible behavior change. Merge internal change: 207883948 https://chromium-review.googlesource.com/c/1172928/ In QUIC, try to aggregate acked stream frame. Protected by FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames. Merge internal change: 207746798 https://chromium-review.googlesource.com/c/1172927/ Improve Quartc's responsiveness to changes in congestion control parameters. Issue a callback from QUIC to Quartc whenever congestion control changes. This callback reports three parameters: bandwidth estimate, pacing rate, and latest RTT. The callback fires whenever QuicSendPacketManager calls OnCongestionChange(). This happens after every ack frame with an rtt update, acked packets, or lost packets. Reporting changes in congestion control parameters to Quartc immediately, rather than waiting up to 200 ms for Quartc to scrape them from stats, should improve responsiveness to congestion control changes, especially on low-RTT networks where changes can happen on timescales much shorter than 200 ms. Quartc now uses the minimum of BWE and pacing rate for rate controls in the Brain. This should avoid building long client-side buffers during PROBE_RTT, DRAIN, or low-gain PROBE_BW phases. During these phases, the BWE is higher than the pacing rate. If Quartc continues to produce data at the BWE, it will overproduce and buffer data. Since low-gain phases tend to last on the order of 1 RTT, it does not make sense to adapt to the pacing rate without also getting a callback as soon as it changes. Scraping every 200 ms may easily miss gain transitions (either obtaining a higher pacing rate just before the low-gain phase starts or obtaining a lower pacing rate just before the low-gain phase ends). FIG_CHANGESET=37546b8b8e52bdc4af9a28f394f1387db4bb597f Merge internal change: 207729769 https://chromium-review.googlesource.com/c/1172926/ Refactor quic::PerPacketOptions Turn it from a class into a struct (since it only exists to carry a bunch of values around). Also make Clone() return unique_ptr. Merge internal change: 207625151 https://chromium-review.googlesource.com/c/1172923/ Remove a bogus DCHECK from QuicStream::SetPriority which would be triggered if a server received a PRIORITY frame after having sent any of the response body. Merge internal change: 207619365 https://chromium-review.googlesource.com/c/1172922/ Reorder an OR statement in IsPacketUsefulForRetransmittableData() to avoid calling HasRetransmittableFrames() when it's not necessary. No functional change, not flag protected. Merge internal change: 207585541 https://chromium-review.googlesource.com/c/1172921/ R=rch@chromium.org Change-Id: I144c4346e80b418ddf8a70b60642e9716e902cf7 Reviewed-on: https://chromium-review.googlesource.com/1173701 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#582822}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/19b70815b4d1..ed176992eb7d git log 19b70815b4d1..ed176992eb7d --date=short --no-merges --format='%ad %ae %s' 2018-08-13 thestig@chromium.org Make CFX_ReadOnlyMemoryStream take a span. 2018-08-13 thestig@chromium.org Change CFDF_Document::ParseMemory() to use pdfium::span. 2018-08-13 thestig@chromium.org Use std::vector in FDFToURLEncodedData(). 2018-08-13 thestig@chromium.org Move FDFToURLEncodedData() into an anonymous namespace. 2018-08-13 thestig@chromium.org Implement CFX_CodecMemory. 2018-08-13 thestig@chromium.org Use CFX_ReadOnlyMemoryStream in more places. 2018-08-13 thestig@chromium.org Mark CPDF_Font::GlyphFromCharCodeExt() and friends Mac only. 2018-08-13 thestig@chromium.org Move CPDFSDK_MemoryAccess to fxcrt. 2018-08-13 thestig@chromium.org Run pdfium_test in only one place in make_expected.sh. Created with: gclient setdep -r src/third_party/pdfium@ed176992eb7d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iec93ed9adbe52be1ed7e6f7a71553c49ed908042 Reviewed-on: https://chromium-review.googlesource.com/1173176Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582821}
-
Weilun Shi authored
[NTP] Allow VoiceOver to select tiles in the custom background dialog and adjust button styling to match GM2 Adding role="button" to each tile allows them to be treated like buttons when using VoiceOver. This includes selection/click with Ctrl+Option+Space. Also, refactored the cancel/done button styling to match GM2 and switched from <div> to <button>. This allows the user to navigate by pressing Ctrl+Option+Left/Right once instead of twice." Bug: 871408, 866056 Change-Id: I5810c20706e2cd178c2129f14a2a1793f45774fd Reviewed-on: https://chromium-review.googlesource.com/1173434 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#582820}
-
Yuki Yamada authored
This CL removed some code that clearing TraceWrapperV8Reference object in its destructor. |listener_| is cleared in the destructor of TraceWrapperV8Reference, so we do not have to clear it in blink::V8AbstractEventListener. Bug: 872138 Change-Id: I4f8e8e67074ee8b2081735053b5b0f7604afadff Reviewed-on: https://chromium-review.googlesource.com/1173195 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#582819}
-
Ken Rockot authored
Changes ServiceProcessLauncher to join service processes from a background task rather than from the launcher's owning sequence. Updates RenderThreadImplBrowserTest so that it actually has a real IO thread and therefore doesn't run all tasks (including "background" tasks) on the same sequence on which Mojo does IPC. This prevents service process joins from blocking internal IPC routing and thus allows ServiceProcessLauncher to be used safely without deadlocking on shutdown, particularly in aforementioned browser tests. Bug: 844078 Change-Id: Idf75dac40a9b16b49703483f0d010be3f3bc68aa Reviewed-on: https://chromium-review.googlesource.com/1173428Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582818}
-
Makoto Shimazu authored
TBR=takumif@chromium.org NOTRY=true Bug: 873912 Change-Id: I890f6aa5f3c1238eea0f083b5401ed86d7918df5 Reviewed-on: https://chromium-review.googlesource.com/1173833Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582817}
-
Brandon Wylie authored
This data will be used to monitor the health of the feed image manager and also to compare to the incoming componentized cached image fetcher. Bug: 868604 Change-Id: I2e9ac800bf602db6963f94c0baa487cf74adbc16 Reviewed-on: https://chromium-review.googlesource.com/1155160 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09fe42b0. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 09fe42b0 "Web Locks API: Convert .html tests to .any.js where applicable" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22695 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I58776b3e57391ab533f6df227764239339f03bdd Reviewed-on: https://chromium-review.googlesource.com/1173716 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582815}
-
Makoto Shimazu authored
TBR=achuith@chromium.org NOTRY=true Bug: 873908 Change-Id: I96073584e422833f3aa16c80945f645dcc5d78c2 Reviewed-on: https://chromium-review.googlesource.com/1173832Reviewed-by:
-
Ken Rockot authored
The issue was raciness between navigation and FrameFocusedObserver setup. Focus can be dispatched to the FrameTreeNode before NavigateToURL* returns, causing the subsequently constructed FrameFocusedObserver to wait forever for an event that has already happened. Because FrameFocusedObserver only monitors the main frame's FrameTreeNode, which is stable, we can construct the observer before NavigateToURL*. That's what all this does. Bug: 872075,867339 Change-Id: I08c68ecb548163ee2097222d549e6985e5c9428a Reviewed-on: https://chromium-review.googlesource.com/1173016Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582813}
-
John Abd-El-Malek authored
Bug: 871542 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iab57f575186577532a7327c3fcf43266f91a1a43 Reviewed-on: https://chromium-review.googlesource.com/1172730 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582812}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I203af22a6ab01df8c281cafedf4d934c544f7962 Reviewed-on: https://chromium-review.googlesource.com/1173702Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582811}
-
Chris Blume authored
This reverts commit 2be1f912. Reason for revert: This CL is a suspect in a failure seen on one of the GPU FYI bots. More info here: https://bugs.chromium.org/p/chromium/issues/detail?id=873814 Original change's description: > Enable Windows NV12 overlays on waterfall > > We plan on shipping this via a finch experiment to Canary/Dev soon, and then > enable it by default if we don't encounter major issues. This should only affect > the DirectComposition pixel tests since we force-enable overlays for those > tests. Other tests don't exercise DirectComposition code because those code > paths are disabled unless the hardware supports it. > > Bug: 869677 > Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a > Reviewed-on: https://chromium-review.googlesource.com/1170385 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582305} TBR=holte@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869677 Change-Id: Ied108cd594931f2463f21cead4a0dac0ecd8206b Reviewed-on: https://chromium-review.googlesource.com/1173572Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#582810}
-
David Black authored
This CL: - Changes font size. - Changes icon size. - Fixes spacing between icons. Also updated suggestion chip font size per the spec. See bug for screenshots. Bug: b:112313532 Change-Id: I40942e15d17e951a66d334164e5a999169a162ce Reviewed-on: https://chromium-review.googlesource.com/1172146 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582809}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b95ef9f9912..d4322a8630bc git log 1b95ef9f9912..d4322a8630bc --date=short --no-merges --format='%ad %ae %s' 2018-08-13 reed@google.com Change cubicmap to eval directly (no table) Created with: gclient setdep -r src/third_party/skia@d4322a8630bc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I6ab48d5c9b0d3d16414dc8c5f5ea72df81d28d1a Reviewed-on: https://chromium-review.googlesource.com/1173367Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582808}
-
John Budorick authored
Bug: 868525 Change-Id: I2e10e438ad41c862a434e8181b5754b6d17e53f2 Reviewed-on: https://chromium-review.googlesource.com/1173502 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#582807}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8405a1536d36..b26e129bfd2a git log 8405a1536d36..b26e129bfd2a --date=short --no-merges --format='%ad %ae %s' 2018-08-14 lannm@chromium.org Add repo_util.Repository.StartBranch and .MustFind 2018-08-13 chrome-bot@chromium.org Update config settings by config-updater. 2018-08-13 dgarrett@google.com chromeos_config: Add nocturne-chrome-pfq. Created with: gclient setdep -r src/third_party/chromite@b26e129bfd2a The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2d70f4dcc923cb84da79265fb6a36640a43f83c Reviewed-on: https://chromium-review.googlesource.com/1173177Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582806}
-
Yutaka Hirano authored
This is a reland of ffc8179c8a7bca7404f1f9463331c9a8f54b69a5. The original CL was reverted due to an infra issue. Original change's description: > Inline ResourceDispatcherHostImpl::CreateBaseResourceHandler > > Now it always creates a MojoAsyncResourceHandler, so there is no need to > have a separate function. > > Bug: None > Change-Id: Iafadf07f8dd5930d8de600ed87c0d2aa62a91038 > Reviewed-on: https://chromium-review.googlesource.com/1169034 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> Bug: None Change-Id: If915cdf70ae06088b7eea366972472d22b71c28e Tbr: csharrison@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1173591Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#582805}
-
Zhuoyu Qian authored
As the comment in assistant_query.h by dmblack@, rename AssistantQueryType::kEmpty to kNull and rename AssistantEmptyQuery to AssistantNullQuery. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ic4948122bef5a90b7e3bbeae13655bc36223f971 Reviewed-on: https://chromium-review.googlesource.com/1170709Reviewed-by:
-
Kurt Horimoto authored
Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I088c5e5cbd24998539aef88eea1a034cb3604891 Reviewed-on: https://chromium-review.googlesource.com/1173714Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#582803}
-
Tetsui Ohkubo authored
This CL makes TrayStep the last step of first run tutorial, and show "Keep exploring" button in TrayStep, which was shown in HelpStep. Screenshot: http://screen/Lh0H2WK1OtT TEST=Works as intended: out/Release/chrome --login-manager \ --enable-features=SystemTrayUnified TEST=Does not change its behavior: out/Release/chrome --login-manager \ --disable-features=SystemTrayUnified BUG=837502 Change-Id: Idcbe96f7729b5ea706dc06641ca11ed1b3c3c66e Reviewed-on: https://chromium-review.googlesource.com/1172223Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#582802}
-
Tom Anderson authored
BUG=873003 R=pkasting Change-Id: I9f2550b32a94c143f443bcb7e0762bd9dde6f7ee Reviewed-on: https://chromium-review.googlesource.com/1173652 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582801}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36668c6ef51c..f727862b7b84 Created with: gclient setdep -r src-internal@f727862b7b84 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:873824 TBR=mmoss@chromium.org Change-Id: Ia2a701561718602b32cfbc8133fa45715a5f8596 Reviewed-on: https://chromium-review.googlesource.com/1173174Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582800}
-
Jérôme Lebel authored
Moving from assign to weak, so it is not required anymore to set |ObservableBoolean.observer| to nil once the observer is deallocated. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I033be7f20225636cf45a7b039d7a8a5b7c815cbf Reviewed-on: https://chromium-review.googlesource.com/1173231Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582799}
-
Makoto Shimazu authored
TwoClientPreferencesSyncTest.SingleClientEnabledEncryptionBothChanged is flaky on ChromeOS bots. This disables it. TBR=vitaliii@chromium.org NOTRY=true Bug: 873902 Change-Id: I72b3692746942c7c8e4cb58e06bc9b7817402f85 Reviewed-on: https://chromium-review.googlesource.com/1173201Reviewed-by:
-
Zhuoyu Qian authored
As the comment in login_user_view.h by jdufault@, rename user_menu_ to menu_. Change-Id: I2658041c0210acc1d41f02790f7d3e7586c58c3a Reviewed-on: https://chromium-review.googlesource.com/1171976Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#582797}
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: none Change-Id: Ifae8faddcd5d719011cd53289067d4f2f7ca958c Reviewed-on: https://chromium-review.googlesource.com/1172706Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582796}
-
Noel Gordon authored
On Mash bots in MSAN ASAN, some test times are near the bot's time-out and sometimes hit the limit causing a flaky timeout (depending on what other load the bot has at the time). The extension idle time-out is fixed value, and it is conjectured that scaling it for the bot type (MSAN/ASAN/etc) will help to keep FilesApp event pages active longer during tests on those bots, and maybe reduce overall test-time. Worth an experiment: set the extensions idle timeout during final test setup, prior to loading the FilesApp component extensions. Bug: 836254 Change-Id: I554358d284cb72dc0c55109d015328c51309c45d Reviewed-on: https://chromium-review.googlesource.com/1172235Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582795}
-
Alexander Alekseev authored
This Cl changes border color and radius. Bug: 867711 Change-Id: Iba4387d14c7a80c42ce814871216da1f5c298a69 Reviewed-on: https://chromium-review.googlesource.com/1171959Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582794}
-
Devlin Cronin authored
Currently, native bindings will send an add/remove unfiltered listener IPC when the first listener is added and last listener is removed from a given v8::Context/ScriptContext, whereas JS-based bindings will report for the first/last listener for a given context owner (e.g., extension). This causes an issue in native bindings, since the browser side will not add duplicate listeners. Thus, if an extension adds two listeners and then removes one, the browser side will remove the listener registration for that extension. Fix this by only reporting when the first/last listener is added/removed for a given context owner with native bindings as well, except for lazy contexts (where a separate IPC needs to be sent to add/remove the lazy listener). Introduce a ListenerTracker to keep track of all active listeners across contexts, given a context owner. Use the ListenerTracker in the native bindings implementation; a follow-up will use the ListenerTracker in JS-based bindings as well (replacing the EventBookkeeper, which the ListenerTracker was heavily based on). Bug: 868763 Change-Id: I6bb80f48973fb84c7cce1c702d667023dac079ba Reviewed-on: https://chromium-review.googlesource.com/1166597 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582793}
-
Sergey Ulanov authored
Added OzonePlatform::CreateScreen(), which returns in instance of the new PlatformScren interface. Also added aura::SceenOzone that implements display::Screen on top of PlatformScreen. Bug: 850650 Change-Id: I3481dda921f564f0c117d9c8a0e8ce060254f4c3 Reviewed-on: https://chromium-review.googlesource.com/1162354 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Remove many expectations as they are obsolete and add two related flaky expecations. Bug: 873873, 838057 Change-Id: Ife7c566fb7b41c21cb7ad2bfeb30c81da62b56f1 Reviewed-on: https://chromium-review.googlesource.com/1173194Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#582791}
-
Toni Barzic authored
When initializing demo session (or preloading demo resoruces), register and attempt to load demo mode resources component. If demo mode resources component is not installed, demo_session will attempt to load demo resources from a preinstalled path on the stateful partition (if that fails, the session will continue without offline demo mode resources). To avoid CrOSComponentManager::Load blocking on component update if the component is not installed, add new UpdatePolicy - kSkip. If set, CrOSComponentManager will report error if a compatible component version is not found after component registration. CrOSComponentManager::Load will srill register the component with component updated, which means that the component will eventually get updated, but the updater will not be run as part of the requested component load. NOTE: Currently, demo-mode-resources component load is expected to fail, as the component config has still not been added to the cros_component_installer_chromeos (this is blocked on server changes). BUG=869455 Change-Id: I2c3b18d60edc44ae8ddbde27d6f31e91092216dd Reviewed-on: https://chromium-review.googlesource.com/1164577 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582790}
-
Marijn Kruisselbrink authored
Bug: 873844 Change-Id: Ib01659c5e072806782bae4682cd1e875d06fc40e Reviewed-on: https://chromium-review.googlesource.com/1173485 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#582789}
-
Devlin Cronin authored
Add restrictions so that code from chrome/browser/extensions is not allowed to include files in chrome/browser/apps. Carve out exceptions for existing includes, which should gradually be cleaned up. Bug: 873872 Change-Id: I50c3338945456ec5b9deba02865cc8d38cf93462 Reviewed-on: https://chromium-review.googlesource.com/1172155 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#582788}
-
Min Qin authored
BUG=871463 Change-Id: Iedc5d50d697252f91c264d47dad529345e576345 Reviewed-on: https://chromium-review.googlesource.com/1167885 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582787}
-
Muyuan Li authored
Bug: b/111900963, b/112102455 Test: Manual Change-Id: I69f296f8eae6eb320eb5be122629b8e1658868ce Reviewed-on: https://chromium-review.googlesource.com/1173478 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b35c655378ee..1b95ef9f9912 git log b35c655378ee..1b95ef9f9912 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 halcanary@google.com SkRegion: Do not assume good input. 2018-08-13 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader c47cd435bf6f..378c434627aa (1 commits) 2018-08-13 mtklein@google.com use legal FirstDirection as kDontCheck sentinel 2018-08-13 mtklein@google.com avoid illegal enum values in PathTest 2018-08-13 scroggo@google.com SkCodec: Always use 0 for filling 2018-08-13 csmartdalton@google.com Add unit tests for src=dst in SkGeometry 2018-08-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a43d7306d87a..35bc74d6d139 (2 commits) Created with: gclient setdep -r src/third_party/skia@1b95ef9f9912 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:873051 TBR=kjlubick@chromium.org Change-Id: Iacdce503576c981ad1f75493dd71f9f91672d8ee Reviewed-on: https://chromium-review.googlesource.com/1173172Reviewed-by:
-
Mathieu Perreault authored
Previously the data was fetched from preferences. Now we introduce an option to get it from PaymentsCustomerData, a sync type. Bug: 870936 Test: components_unittests Change-Id: I5e907868fe8fbc85532b0cc57df040f12a8f6f2a Reviewed-on: https://chromium-review.googlesource.com/1173269Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582784}
-
