GitLab

The feature was never meant to be enabled on other versions than
Windows 10, but I accidentally removed the checks in
https://chromium-review.googlesource.com/c/chromium/src/+/1099976.

Bug: 717696
Change-Id: Ie52736de5dbf609fb702f6aff4a97f8ecac95267
Reviewed-on: https://chromium-review.googlesource.com/1144430
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576957}

Adds logic to register and load/unload components to fake image loader
client, so it can be used to test code that depends on image loader
client.

Introduces SetMountPathForComponent that sets up mount points
LoadComponent/LoadComponentAtPath return as component's mount point when
called (if a mount point has not been set, the LoadComponent methods
will fail).

Implements logic to register/remove components - it keeps mapping from a
registered component name to its version in memory.

BUG=863162

Change-Id: Iffa3504fc92d495cc46a35caffd3acdd4b7038c8
Reviewed-on: https://chromium-review.googlesource.com/1145463
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576956}

Bug: None
Change-Id: Ie767d93e805cb463f1567d04df5f2d6e3602f01c
Reviewed-on: https://chromium-review.googlesource.com/1143593Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576955}

https://chromium.googlesource.com/catapult.git/+log/213eaf4f79bc..c03be1848479


git log 213eaf4f79bc..c03be1848479 --date=short --no-merges --format='%ad %ae %s'
2018-07-20 dtu@chromium.org Revert "[pinpoint] Add --also-run-disabled-tests flag to Telemetry runs."


Created with:
  gclient setdep -r src/third_party/catapult@c03be1848479

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie4930fddb38099b388029930973dbefd85c30256
Reviewed-on: https://chromium-review.googlesource.com/1145600Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576954}

The |browser_context_| member of ExtensionMessageFilter is only supposed to be
read on the UI thread, but is also read in OnMessageReceived which might not be
invoked on the UI thread (for messages not handled by the
ExtensionMessageFilter). This is racy and can lead to accessing the variable
simultaneously on multiple threads.

Remove the check for a valid |browser_context_| in
ExtensionMessageFilter::OnMessageReceived. It's redundant anyway since all the
message handler functions do already check for a valid browser context.

BUG=862597

Change-Id: Ib34ac14b9a1ff609224a9fdf80202070098760e9
Reviewed-on: https://chromium-review.googlesource.com/1144606
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576953}

This CL adds the session entry point info to the telemetry reported by
the iOS client. This allows us to compare metrics on initial vs reconnect
attempt, and reuse error breakdown dashboard without unchecking the
SessionEntryPoint filter.

Bug: 840556
Change-Id: I27b5fd644f024b10953b5bbf919047d8f370b753
Reviewed-on: https://chromium-review.googlesource.com/1141147Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576952}

This CL hides the "Make searches and browsing better" settings from the
privacy settings when unified consent is disabled.

Bug: 863950
Change-Id: Ia392cebae7eb8327b6dcea6427e504d84c11d17b
Reviewed-on: https://chromium-review.googlesource.com/1145315Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576951}

Implement Content Storage API in Java and JNI bridge.

Bug:828935

Change-Id: I6c70d18cfde0891f5c9533458bf453a891b4b2be
Reviewed-on: https://chromium-review.googlesource.com/1137739
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576950}

The benchmark seems to be passing now.

Bug: 853188
Change-Id: I0d502d1210540b8221afd5a90a5c59d63b93c3ad
Reviewed-on: https://chromium-review.googlesource.com/1144123
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576949}

This is a step towards making the GestureDetector detect gestures
triggered by other buttons of the PlatformController.

Bug: 865486
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifbdfc28b850fae81446e21caf42027506f7bf522
Reviewed-on: https://chromium-review.googlesource.com/1143712
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576948}

BUG=865977
TEST=Covered by unit test


Change-Id: I444981ec98241d2a355d23d9711a961010a292c3
Reviewed-on: https://chromium-review.googlesource.com/1144628Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576947}

Bug: 852034
Change-Id: Iac5c70336e3868521b8dbfd81c2238122438b466
Reviewed-on: https://chromium-review.googlesource.com/1144631Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576946}

It's been replaced by ws2.

BUG=865689
TEST=none

Change-Id: I86310a113750d350d24f7d11180b4411a5346d48
Reviewed-on: https://chromium-review.googlesource.com/1145052
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576945}

The code was testing C++ to WebIDL type conversions. It should have not
been using C++ long values since these are dynamic based on the
architecture. Use the C++ type that maps correctly to the WebIDL type.

This didn't cause a layout test failure because it was testing a
roundtripped value. If the C++ interface returned a value that was
out of bounds then it could have gotten truncated because on linux
sizeof(long) == 8 but WebIDL long defines it as 4 bytes.

BUG=596846

Change-Id: I92020c1cbbec0fff7c77b5fe0129eb91bbd70c7a
Reviewed-on: https://chromium-review.googlesource.com/1145138Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576944}

Bug: 630652
Change-Id: Iaacf13e7a3680407a4ead0eb11554f13b17d36a6
Reviewed-on: https://chromium-review.googlesource.com/1142491Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576943}

FlingingRenderer needs to be updated when status changes happen on a
device that it is currently remoting to. Instead of coupling the
MediaController interface to the MediaStatusObserver interface, it is
simpler to add a new interface that groups the MC and MSO.

The best name for this interface is probably MediaRouteController, but
there is a naming collision with media_router::MediaRouteController.
mr::MRC is a class with baked in desktop and Mojo concepts, and
precise lifetime management, that is not immediatly extractable into
an interface. It is simpler to add a new interface now, and have
mr::MRC implement this interface later.

This CL adds the FlingingController as a high level, simple interface.
It will eventually be renamed to MediaRouteController, as part of
the work to unify the desktop and mobile remoting experience
(see crbug.com/820277).

Bug: 790766
Change-Id: I8248f2fd4b2022c371f37a8fd73af267b3735e7e
Reviewed-on: https://chromium-review.googlesource.com/1136008Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576942}

Modify KerberosFilesChangeWaiter to be more robust callbacks called
several times

BUG=chromium:865206

Change-Id: I0c5f22fb26871607257d3b29ad3bd88d5b505c7c
Reviewed-on: https://chromium-review.googlesource.com/1145074
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576941}

Check whether an URL can be handled by a Trusted Web Activity when
launched from background Android Services (such as by notifications).

This change also rolls the custom_tabs_client DEP, this roll includes:
057eae40 TrustedWebActivityService can report notifications enabled.
dde0cb7b Improved error reporting for clients.
e8d760cd Better support for client developers.
81a14bc0 Expose getVerifiedPackages, required by this CL.

Bug: 860104
Change-Id: Ib901a1d4a569e382b168d2c16ea639584913f890
Reviewed-on: https://chromium-review.googlesource.com/1127177
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576940}

Bug: 866035
Change-Id: Ib41ddfd4b353fd739e202d4bac8e6cae945c8eeb
Reviewed-on: https://chromium-review.googlesource.com/1145225Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576939}

The Autofill Captured Sites Interactive Uitest test Chrome on real-world sites. A difficult challenge in working with real-world sites is determining when a page inside Chrome is ready for interaction.

The previous iteration of the test determines page ready by waiting for specific elements on a page to become visible. Using this heuristic, a test author must manually examine each page to identify the right set of elements.

This change adds a universal wait-for-page-ready heuristic. I constructed the new heuristic based on two observations:
1. If Chrome is not done loading a page, the Chrome tab should be busy and Chrome should continuously make paint updates to the page, as Chrome continue to make layout changes to the page.
2. If a page is doing background work and cannot respond to user input, the page will display some form of persistent animation, such as a progress bar or a spinner, to alert the user.

So the new heuristic determines page ready by waiting for the Chrome tab to finish loading and for Chrome to stop painting. The new heuristic monitors Chrome paints by instrumenting an event inside the content::RenderWidget::DidCommitAndDrawCompositorFrame() function.

As part of this change, I also made the following list of minor fixes:
1. Fixed an issue with the WPR certificate and key files the tests use.
2. Updated the JSON deserialization code inside the tests to remove
soon-to-be-deprecated functions.
3. Fixed a segmentation fault inside the GetCapturedSites() function.

Bug: 854828
Change-Id: Ic1d349fd80cc1f877a3a8a604ec4266452a8186d
Reviewed-on: https://chromium-review.googlesource.com/1109312Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Cr-Commit-Position: refs/heads/master@{#576938}

Cleans up //ios/testing:ios_test_support that had been kept around to avoid
breaking ios downstream

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib07bf8aa8d5e70a1980c2517fb3dbe709467c5a5
Reviewed-on: https://chromium-review.googlesource.com/1136903
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576937}

The constructor was initialized with a int (32 bit) yet the data
type was a uint64_t. Incorrect on sign and width.

BUG=596846

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3ef3cdd25748ba0b8ca2b3066ed74dcbee6f1b9e
Reviewed-on: https://chromium-review.googlesource.com/1145469
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576936}

Currently the two functions adds rects from all text fragments intersecting
the input range, even if they only touch at boundaries. For example:

Text fragments:  ABC  DEF  GHI
Text offsets:    012  345  678
Input range: start = 3, end = 6

The current implementation returns three rects, one from each fragment,
even though the rects from "ABC" and "GHI" are collapsed.

This patch stops the inclusion of such collapsed rects; they are included
only when we can't find non-collapsed rects.

Bug: 755750
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1ca65d1aee02e1eb33b8c72605daca4d6dbd119b
Reviewed-on: https://chromium-review.googlesource.com/1142685Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576935}

As eurekasource has moved to using Android O sdk, exposing the new
requestAudioFocus() and abandonAudioFocusRequest() in CastAudioManager.

Bug: 79420443
Test: Verified that request focus and ducking still works.
Change-Id: I60f4109c635dd1047db24071868e2084ec98d169
Reviewed-on: https://chromium-review.googlesource.com/1144520
Commit-Queue: Shyamsundar Parthasarathy <shyamsundarp@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576934}

Changed infocard so that focusing on a node will lock the infocard.
Focus can be removed by pressing the escape key.

The options have been reorganized so that regular expressions are now
higher in the list.

Additionally added a "?" key shortcut to open help, fixed the
toolbar on small screen sizes, and added input validation for the
regex inputs.

Bug: 847599
Change-Id: I124afe3bdc162b55889b25ba35b403aca72a8435
Reviewed-on: https://chromium-review.googlesource.com/1145230Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#576933}

https://aomedia.googlesource.com/aom.git/+log/369ab2088d3f..88e4b0a4ee32

$ git log 369ab2088..88e4b0a4e --date=short --no-merges --format='%ad %ae %s'
2018-07-03 wtc Reset the 'setjmp' flag to 0 before returning.
2018-07-12 wtc Use the more common way to clear a bit.
2018-07-18 wtc Revert 8f44a1dfacfde9ec4ab1dc5fc3bbc0b0b5bd2fba.
2018-07-03 binpengsmail Merge av1_build_interintra_predictors_sb{y/c}
2018-07-12 binpengsmail Disable global_motion for disabled ref_frames
2018-07-18 wtc Check size limit in aom_realloc_frame_buffer.

Created with:
  roll-dep src/third_party/libaom/source/libaom

Change-Id: I6c95ffd11f04519f91d775a16a4c08fdc146bac4
Reviewed-on: https://chromium-review.googlesource.com/1144318
Commit-Queue: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576932}

This reverts commit 28a79156.

Reason for revert: Causes build break
device/bluetooth/bluetooth_low_energy_advertisement_manager_mac.mm:26:35: error: comparison of two values with different enumeration types ('CBManagerState' and 'CBPeripheralManagerState') [-Werror,-Wenum-compare]
  if ([peripheral_manager_ state] < CBPeripheralManagerStatePoweredOn) {
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Mac Team Request: Please add a Mac reviewer for this reland. Thanks!

Original change's description:
> First pass at supporting BLE advertisement on macOS.
> 
> This very basic implementation currently only supports one active
> advertisement.
> 
> Future work will add tests and better handle concurrent advertisements.
> 
> BUG=846881
> 
> Change-Id: I48b76e84d67060e7265533759752fcc0e84f5cc6
> Reviewed-on: https://chromium-review.googlesource.com/1142294
> Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Tim Song <tengs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576712}

TBR=tengs@chromium.org,sacomoto@chromium.org,ortuno@chromium.org

Change-Id: I13eec942b3a76ad5baa6b9dca624c41c5fc29178
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846881
Reviewed-on: https://chromium-review.googlesource.com/1145444Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576931}

Bug: b/78190629
Test: Manual Test
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ic87f99c00c51bbb92c036e5cb954cffe79c43f48
Reviewed-on: https://chromium-review.googlesource.com/1144057
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576930}

UIButton's don't handle dynamic types well. So we'll keep it fixed at a bold 17px.

Screenshots: https://drive.google.com/file/d/1befS0btYrluxxdfjZ-RJJ4aUnluyylX8/view?usp=sharing
https://drive.google.com/file/d/1tQSYQrDqmWuWhNVmJkYxjHy9Yp75OZ9L/view?usp=sharing

Bug: 865008

Change-Id: Ic76e8264123b647cfe19e580e1abdd98b9e6a229
Reviewed-on: https://chromium-review.googlesource.com/1145227
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576929}

Bug: 840967
Change-Id: I3f9e8396cc2cc394bcde660cc8bfd8ff183fa663
Reviewed-on: https://chromium-review.googlesource.com/1144053
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576928}

When dragging a window in overview grid, if the window is dragged into
the preview area, and a left or right semitransparent preview window
shows up indicating the dragged window will be snapped to left or right
side of the screen after releasing the mouse/touch, we should clear the
selection widget on the current selected overview window item and also
clear the ash::kIsDeferredTabDraggingTargetWindowKey property to prevent
the dragged window to merge into the selected overview window item.

See before https://drive.google.com/open?id=14fwUX8yXUoAnJrOklOGDcG2ChZFMpIVJ
and after https://drive.google.com/open?id=1Ps1VXj03UMceMDeZ3_puMSG-PluHAQG2

Bug: 823769
Change-Id: I0cc1a009dc6efc07f3baca5519cbc26e9dbb1ec3
Reviewed-on: https://chromium-review.googlesource.com/1142483Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576927}

Instead of storing the scroll position only when the main button is clicked,
store the position right before each sinks update, so that the scroll position
is retained across updates.

Bug: 852851
Change-Id: I0052e55eec1de532987dbc211ac04496b67b847d
Reviewed-on: https://chromium-review.googlesource.com/1137345
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576926}

Since it is possible for a module to be blocked even though the feature
is disabled, the class that drains the log of blocked modules is now
part of the ModuleDatabase and always initialized.

Also, the ModuleDatabase is now aware of blocked modules and they are
shown in the chrome://conflicts page.

Bug: 846953
Change-Id: I993a51571e4d4f630ab6852b54920598bad26ac3
Reviewed-on: https://chromium-review.googlesource.com/1141158
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576925}

This reverts commit b28da169.

Reason for revert: This is a dependent revert for 
https://chromium-review.googlesource.com/c/chromium/src/+/1142294

Root Reason:

Causes build break
device/bluetooth/bluetooth_low_energy_advertisement_manager_mac.mm:26:35: error: comparison of two values with different enumeration types ('CBManagerState' and 'CBPeripheralManagerState') [-Werror,-Wenum-compare]
  if ([peripheral_manager_ state] < CBPeripheralManagerStatePoweredOn) {
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Original change's description:
> Fix BLE advertisement on macOS.
> 
> The CoreBluetooth APIs expect CBUUID objects instead of raw UUID strings.
> 
> BUG=865851
> TBR=ortuno
> 
> Change-Id: I1ad7ac21a9213d0ee19edafe54f7de096b283347
> Reviewed-on: https://chromium-review.googlesource.com/1144657
> Commit-Queue: Tim Song <tengs@chromium.org>
> Reviewed-by: Tim Song <tengs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576793}

TBR=tengs@chromium.org,sacomoto@chromium.org,ortuno@chromium.org

Change-Id: I99fd190bc75a8f572d2129cb3843e8fb747c503d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865851
Reviewed-on: https://chromium-review.googlesource.com/1145562Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576924}

Makes the following changes:
1. Changes runnables to lambdas
2. Changes all uses of Criteria to Criteria instead of Criteria<Boolean>
3. Adds failure statements to asserts and Criteria
4. Fixes failure statements that described the check condition, not the
   failure itself
5. Adds pollJavaScriptBooleanOrFail and changes uses of
   assertTrue(pollJavaScriptBoolean()) to it.

Bug: 863256
Change-Id: I7965fbf2f9d62199a9dbcf6f8040c2b71e5f1651
Reviewed-on: https://chromium-review.googlesource.com/1144410
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576923}

Change text on the update screen:
- During rollback:
    "Your administrator is rolling back this device (25%)"
    https://screenshot.googleplex.com/WrMrGxdOU86.png
- After rollback:
    "Your administrator rolled back this device. Please save important
     files, then restart. All data on the device will be deleted."
- Button text:
    "Restart and reset"
    https://screenshot.googleplex.com/Zq2QsMTXUdt.png

Change text of the notification:
- https://screenshot.googleplex.com/vVdBEHcKzKR.png
- Title:
    "Device will be rolled back"
- Text:
    "Your administrator is rolling back your device. All data will be
     deleted when the device is restarted."
- Button:
    "Restart and reset"

Notification is also shown at warning level.

Bug: 863088
Change-Id: I99cd590fee90d7ac1ad5927b3459f9cb97a051a1
Reviewed-on: https://chromium-review.googlesource.com/1143481
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576922}

This reverts commit e87203b9.

Reason for revert: This caused the Mojo builders to start failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/16264

Test still fails with --enable-features=NetworkService

Original change's description:
> [OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS
> 
> external/wpt/service-workers/service-worker/navigation-timing.https.html
> has an expectation file consisting of two FAILs and one PASS, but in
> virtual/outofblink-cors[-ns] the test result changes to two PASSes and
> one FAIL. Since PASS is better than FAIL let's accept that result.
> 
> Bug: 736308
> Change-Id: I4bc33bf2c7c68b16528371cc1b0987dd6048e324
> Reviewed-on: https://chromium-review.googlesource.com/1144597
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576797}

TBR=falken@chromium.org,yhirano@chromium.org

Change-Id: I7424a1f9267ae4e7fcd0589752c6fae9e488df89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 736308
Reviewed-on: https://chromium-review.googlesource.com/1145443Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576921}

This CL adds a warning dialogue that is shown when a
signal via SaveCalled is received. Currently this
signal is only wired up for app.execMenuItem("SaveAs")
in XFA JS, but will be added in other locations where
saving is attempted.

Once saving of PDFs is fully implemented this warning
can be removed.

BUG=pdfium:953,chromium:61248

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib89c394a07459692ee1302ea97f7b0b291b42b92
Reviewed-on: https://chromium-review.googlesource.com/1115205Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576920}

It seems that SSL interstitial presented during captive portal detection
calls WKBasedNavigationManager::AddTransientItem() without adding a
pending item. This breaks an assumption in code. This CL is the same
fix patched for LegacyNavigationManagerImpl in crbug.com/822908.

Bug: 834263
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibac582427415db956a5887c153bf6499e73c1faa
Reviewed-on: https://chromium-review.googlesource.com/1144268Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576919}

This change enables WebUSB on Dedicated Workers by default.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dKj0z6n6n5s

Bug: 837406
Change-Id: I7bbc299dddf215cbe83bf563554c3c09dcdd943f
Reviewed-on: https://chromium-review.googlesource.com/1137215
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576918}