- 21 Jul, 2020 40 commits
-
-
Chris Thompson authored
This adds a SCT auditing cache to the NetworkService, and integrates it with TransportSecurityState so that new SCT reports are sent to the cache during CT policy verification. This also adds feature flags and params to control SCT auditing behavior, and unit tests covering the cache implementation. Bug: 1082860 Change-Id: I24b53c655d960390089e7746e116c9978a4b3a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248862Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790253}
-
Liquan (Max) Gu authored
In order to share the PRImpl logic for WebLayer, the class dependencies of PRImpl should be moved into //components. The moved classes include: * PaymentAppFactoryParams * PaymentManifestWebDataService * SslValidityChecker * SupportedDelegations Bug: 1102522 Change-Id: I9d2732b547a4532a9cb88104bca51b544d675613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307812 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790252}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-015.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I21610ac3f25936f3bd0f9e651fa822848c0c8690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308556 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790251}
-
Jiewei Qian authored
This CL adds SchemeType::SCHEME_DEVTOOLS to ContentSettingsPattern, so it's easier to handle auto-granted permissions registered with WebUIAllowlist in site settings. This is a followup based on discussions in https://crrev.com/c/2262758. Fixed: 1101889 Change-Id: I761a8df60f4fc05c1f92e0ca9761be749b29b88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279346Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#790250}
-
Fan Yang authored
Change-Id: I01d2cdcbbe12e4980415e2f04f61352b74f0a44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308135Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790249}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d71ded6e61c7..97f9923235cf 2020-07-20 mark@chromium.org Fix macOS arm64 GN build by building llvm RWMutex.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1107585 Tbr: swiftshader-team+autoroll@google.com Change-Id: If8caef964bbf0fd7b9ca1ca5b06439e83f4ea769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790248}
-
Rakina Zata Amni authored
Some tests are failing after we split proactive BI swap check and BFCache check. Bug: 1102629 Change-Id: I37db349cb94c1f249ec49ebea01def98ca8beb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297206Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#790247}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3dc4386e20653013d77ac0a1b47f335d88ff4176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308993Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ee5fa86..df4466ba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd37d7e60d83f48b3f9e5b67e11a7f52ffc25648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308233Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790245}
-
Yan, Shaobo authored
This is a reland of 46c9a968. Original is in patch set 1. Disable gpu backing in D3D9 to handle the failure case. Original change's description: > Support imageBitmap generated from video by GPU resource > > This patch replaces the backed resource of imageBimap generated from > video element to GPU resource. > > The old path has been used as fallback path. > > BUG=1098445 Bug: 1105923, 1098445 Change-Id: I08606e3a9c91b5ecc5e91359689680a0c3981f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304209Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#790244}
-
Justin DeWitt authored
Bug: 1106425, b/161395958 Change-Id: I3820e5f67b6695a4cd61d370aaabbe479b44daa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303364 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#790243}
-
Joel Hockey authored
Fix text to include location information as per UX spec. See bug. Bug: b/161645291 Change-Id: If6524cf9608f75579af33923cc6e2a171c428086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306114 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790242}
-
Bailey Berro authored
Bug: 1070122 Change-Id: I867303003042b9129a1f6bbcf203aa41d29f6615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274155 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#790241}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62a87ddd43fa..f9491204a8a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107471 Tbr: karandeepb@google.com Change-Id: Ibcf74e746173975612191da6b9634c9bd3bb660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790240}
-
Nathan Zabriskie authored
Previous CL's have added information regarding an image's origin and alpha type to SharedImageBacking. This CL uses that info in place of assumed defaults when creating SkSurfaces for write access. Bug: 1034086 Change-Id: I82f1a400acc09724b0667318a34208ebeb91d549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307533 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit a1374a65. Reason for revert: suspect causing compile failure on linux-chrome. Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/12421 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8874206257427658528/+/steps/compile/0/stdout?format=raw --- Error processing node <?xml version="1.0" encoding="UTF-8"?> <include file="${root_gen_dir}/chrome/browser/media/kaleidoscope/internal/resources/ks-content-worker.js" name="IDR_KALEIDOSCOPE_CONTENT_WORKER_JS" type="BINDATA" use_base_dir="false" />: [Errno 2] No such file or directory: '../../out/Release/gen/chrome/browser/media/kaleidoscope/internal/resources/ks-content-worker.js' --- Original change's description: > [Kaleidoscope] Public side of the color code > > Change-Id: I98b421dfac9adda34448c645c0432d7a9ad2455c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303854 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790186} TBR=beccahughes@chromium.org,steimel@chromium.org Change-Id: I53a2df3a2758584bda59ccd67a7088f6027a655a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308618Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#790238}
-
Owen Min authored
Rename the policy to AutoplayAllowlist. The old policy is kept for backward compatibility. Bug: 1095632 Change-Id: Ia5ad0c36860eac82e67668e0b4d94dbe5ce317dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303792Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790237}
-
Kent Tamura authored
NGBlockNode::ComputeMinMaxSizes() should return values for border-boxes. So, the values should contain padding and border sizes. Its min_size returned 0 for <marquee>, <select>, and <input type=file> in some cases even though they have paddings or borders. Bug: 1107291 Change-Id: Idef8f092df0beabff5dc8e5f815886f46c056a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306135 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790236}
-
Lei Zhang authored
This reverts commit d3db9d99. Reason for revert: Causes ODR violations in component builds. Original change's description: > Change //pdf:pdf target's type to component. > > The existing target is a static_library, which generated libpdf.a, and > libpdf.a has to be linked into the chrome target. With a component > target, it generates libpdf.so, and the chrome target does not need to > change. This makes rebuilding the chrome target much faster in component > builds. > > Change-Id: I0a6f2fde66c7a3a2e46968b5ff387de8e73a5eb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293325 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789768} Tbr: dhoss@chromium.org Bug: 1107602 Change-Id: Icbfabd2fbe2388c79ed20a2a1ef0f1929534b81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309135 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790235}
-
Pavol Marko authored
Add unit tests for CertificateProvisioningUiHandler. Introduce mock variant of CertProvisioningScheduler to make unit testing possible. Bug: 1081396 Test: unit_tests Change-Id: I66cd3c70bb331de60e192f022d10f751153eefef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288792 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#790234}
-
Alan Cutter authored
This CL adds a basic test for the uninstall_and_replace feature of ExternalWebAppManager and fixes two issues: - On Chrome OS the uninstall was getting blocked on a user prompt. - On non-Chrome OS the uninstall never happened. The changes in this CL are: - Use AppServiceProxy::UninstallSilently() to avoid user prompt. - Move ExtensionAppsChromeOs::Uninstall() to ExtensionAppsBase. - Instantiate ExtensionApps publisher for non-Chrome OS app service. - Refactor ExternalWebAppManager's ParseConfig() out of ScanDir() and expose it for testing. Bug: 809304, 1058265 Change-Id: I86caeeb072ec18a4c16a181a01f3c795d2735648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306139 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790233}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d0ab954e90c..68e5f29d849a 2020-07-20 michaelludwig@google.com Keep a scratch block around for reuse in GrBlockAllocator 2020-07-20 jvanverth@google.com Avoid some unnecessary D3D state changes. 2020-07-20 mtklein@google.com remove stray weakref include 2020-07-20 brianosman@google.com Catch SkRuntimeEffects w/o "main" earlier If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I30e998a633cf96c6fab65b61b71766e7c8198153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309258Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 860403 Change-Id: I859c54261415e224d97813595a4531c314f65718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308551 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#790231}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I16dde19dab7c5f085f9c72f14a3726ad94891d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309557Reviewed-by:
-
Tomasz Wiszkowski authored
This is a corresponding change to https://crrev.com/c/2255131. Addresses Suggestions List height updates on Android versions preceding R. The change fixes suggestions list not resizing accordingly when the software keyboard is hidden. Bug: 1091880 Change-Id: I5e20235c7bc4d2f0b2424d41855dd6706a315e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307693 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790229}
-
Gyuyoung Kim authored
This CL migrates PageMsg_AudioStateChanged to the blink's PageBroadcast interface. ExecutePageBroadcastMethod function is added to RenderFrameHostManager in order to execute the given callback in every RenderView similar to SendPageMessage function. Bug: 1102424 Change-Id: I92524a643be10d82d40f9dd6ff66094430f9a932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282634 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#790228}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fa504e744f9b..539e8783de62 2020-07-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db5fc682..be103000 (790000:790129) 2020-07-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9a6944e0..db5fc682 (789857:790000) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief29d200b4e2ccd37d14252a385da63fb12e225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309148Reviewed-by:
-
Tommy Martino authored
This adds a GIF view that will eventually be used for cryptid rendering. The general approach is: * The existing logo is wrapped in a FrameLayout with a new ViewStub. * When we get a callback indicating that no doodle is present, the NTP requests a drawable from the PCR and injects it into an ImageView inflated from the ViewStub. Out-of-scope for this CL is to actually populate the GIF image data; I have been testing locally with a res/raw file read into a byte array. Change-Id: Ib5deae5322856c9d8e8a68f0fd46cdb2aaadbe79 Bug: 1061949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245888Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790226}
-
Andrew Grieve authored
* Delete java_warnings_as_errors * Use treat_warnings_as_errors for android rules * warnings-as-errors is now default true for debug builds * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py so that these warnings can all be turned off locally. * Made build_utils.CheckOutput fail by default when stderr or stdout is printed. This should prevent build logs from creaping in. * Added "you should use treat_warnings_as_errors=false" into error message when builds fail due to warnings. Bug: 1029357 Change-Id: Ia69e545a110554d76e190cb2da8b20fe10d4d6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232809Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790225}
-
Luis G Garcia authored
Allow camera access feature to be available only to devices with the WebXRIncubations feature flag and with support for buffers. Fixed: 1101140 Change-Id: I44a15f8ad53e2fff425618f58d74f4ccfaac998d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300365 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#790224}
-
David Tseng authored
This reverts commit 6c45baae. Reason for revert: <INSERT REASONING HERE> Need to stop propagation of key events even if they are repeated. Original change's description: > Prevent repeated keys from providing output in learn mode > > R=akihiroota@chromium.org > > Fixed: 1106462 > AX-Relnotes: only announce a modifier once, when holding down modifiers like Search in ChromeVox Learn Mode. > Change-Id: Iaa9de466462450ccef889a2b789b0c150127c814 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308489 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790193} TBR=dtseng@chromium.org,akihiroota@chromium.org Change-Id: I4d2646397a765a6e78b11dd2ebdd777ed45be8ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309563Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790223}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I6f871712c18e353845e2c971e056d5a1fa42b65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309451Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790222}
-
Sammie Quon authored
This reverts commit d939a1e1. Reason for revert: breaks RTL Original change's description: > views: Remove InkDropMask from tab close button. > > Modify the highlight path generator to use a round rect override so > that the ink drop clipping code will pick it up. Tab close buttons use > the content bounds, all other usages use the local buttons + fixed > inset, so tweak the API to allow for this. > > Test: manual > Bug: 1056490 > Change-Id: I9815c50ba1f79b3a40284c628eafcf50bcd9ce58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307694 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790197} TBR=pbos@chromium.org,sammiequon@chromium.org Change-Id: I2b62776dd91ab269059fb589528b2fcb0107f37f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308946Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790221}
-
Sophie Chang authored
This will allow us to continue to evaluate preconnect accuracy even if the prefetch experiment is on. Change-Id: I1a0d0d2f10203413fc31b6241b0c9b8bbd49af28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308856Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790220}
-
Karandeep Bhatia authored
Plumb DOMWrapperWorld into ResourceLoaderOptions for xhr requests. BUG=1099975 Change-Id: Ib48d522c57239d1c5bbe80c5b5a64b8093c18612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305231Reviewed-by:
-
Tomasz Wiszkowski authored
This change addresses the case where an empty suggestions list is received, following a very rich suggestions list from previous Omnibox interaction. Mediator's internal logic clears up the locally stored AutocompleteResult as user completes interaction with the Omnibox, making the subsequently received empty list detected as a no-op. Bug: 1107562 Change-Id: Ifa50c9aea78e730a0424af411ea5d08c7dd5b015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308134 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
Reilly Grant authored
This change swaps sets of ScriptPromiseResolvers into local variables in a number of places where it was possible for script to execute during the call to Resolve() or Reject() and modify the set being iterated over, thus invalidating the iterator. Bug: 1106773 Change-Id: Id4eb0cd444a7dbb5de23038ec80f44fee649cfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304538 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#790217}
-
Oksana Zhuravlova authored
This change updates WebContentsObserverProxy::RenderFrameCreated() to pass process id and render frame id to Java instead of always creating a Java RenderFrameHost. This addresses a memory regression and will allow future code to get a Java RenderFrameHost object on demand. Bug: 1101948 Change-Id: I61bd8dfdf7eedfd57af10c65747aecc42d1cee8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308213Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790216}
-
nancylingwang authored
This CL modifies the default app icon handling in ArcAppIcon to get the foreground and background images separately for the adaptive icon. Bug: 1083331 Change-Id: I7a4d0b5bc2ad5d40c50a33ad8a24cea94d7aea3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299945Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790215}
-
Brian Sheedy authored
Removes the too-many-arguments PyLint disable in //content/test/gpu and fixes or suppresses the resulting errors. Bug: 1076144 Change-Id: I3742360b524c45f9e5fe01deecb3b7cfeba1419c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305006 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790214}
-
