- 03 Dec, 2019 40 commits
-
-
arthursonzogni authored
This test doesn't pass, because there is a problem with Chrome's implementation (See https://crbug.com/980127) and because there are two problems in the test itself. 1) t_spv.done() is never called. 2) A typing mistake in "tsv_unreached_func" Bug: 980127 Change-Id: I91949f64db3f3d7d3033d559d8e277b2cb980b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946482Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#720890}
-
Friedrich Horschig authored
This CL disables some KioskUpdateTests which are incredibly flaky on debug builds and have been disabled on release builds anyway. In the last 200 builds, 30 failures were due to KioskUpdateTests, so I consider disabling the test on debug in general (since they seem more flaky there). TBR=xiyuan@chromium.org Bug: 949490 Change-Id: I09a31f794339bc55a2acba2b12d01f048454f597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948426Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#720889}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db299863e0c5..d405652ad675 Created with: gclient setdep -r src-internal@d405652ad675 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9dfcc82f1684785ef89289594210ca1fddc8e013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720888}
-
Pawel Baran authored
TabRendererData is moved moving_tab->SetData(std::move(data)); then is used in layout_helper_->SetTabPinned(...data.pinned ?...) Change-Id: I5b9ac8122b942985cb354f90726e78270113e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944676Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#720887}
-
Kalpak Tapas authored
This CL adds support for passing text highlight information from PDFiumEngine to mimehandler process using appropriate AccessibilityHighlightInfo structs. Add GetAccessibilityHighlightInfo() which works similar to GetAccessibilityLinkInfo() called from within GetAccessibilityInfo() in pdf/accessibility.cc. Also includes corresponding unit test. Bug: 1008775 Change-Id: I7916177fef5e864f0e3b4b0a0b8c1693bf09f19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871492Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kalpak Tapas <katapas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#720886}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47f3eb42641b..3ed4586044f2 git log 47f3eb42641b..3ed4586044f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 stevenperron@google.com Folding: perform add and sub on mismatched integer types (#3084) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3ed4586044f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I8ceda5cb6c6253d03ce360b5fc18473190483d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947757Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720885}
-
Koji Ishii authored
The offset in |NGFragmentItem| is relative to the inline formatting context even when they are in inline boxes. When painting self-painting inline boxes, |paint_offset| is relative to the box itself. This patch adjusts it to relative to the containing block. Bug: 982194 Change-Id: Ie9b9233f1f78a4c79fdfb73932298701be2a19c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947608Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720884}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75ba8e350e55..1e3659a4633a git log 75ba8e350e55..1e3659a4633a --date=short --first-parent --format='%ad %ae %s' 2019-12-03 szuend@chromium.org Reland "Remove top-level await pre-processing" 2019-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. 2019-12-02 etiennep@chromium.org Revert "Remove top-level await pre-processing" Created with: gclient setdep -r src/third_party/devtools-frontend/src@1e3659a4633a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021921,chromium:1029863 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5466dd4d5508c5102bd395e55313b227136bea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947755Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has below goals, 1. Use To<SVGDefsElement> and DynamicTo<SVGDefsElement> as new downcast helper 2. Use IsA<SVGDefsElement>(element) in place of IsSVGDefsElement(element) 3. Use To<SVGCircleElement> and DynamicTo<SVGCircleElement> as new downcast helper 4. Use IsA<SVGCircleElement>(element) in place of IsSVGCircleElement(element) 5. Use DynamicTo<SVGAElement> as new downcast helper 6. Use IsA<SVGAElement>(element) in place of IsSVGAElement(element) Bug: 891908 Change-Id: If2c1706899083e924a7efc762e403c81a6c6c211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946193 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720882}
-
Ella Ge authored
Removed unused a few functions and variables in MainThreadEventQueue They were used for recording metrics and metrics were removed a while ago. Change-Id: I724ff6a4b80d34f7a0b9de0db2376f5fa35eb6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946480Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#720881}
-
Rune Lillesveen authored
TBR=ericwilligers@chromium.org Bug: 1029640, 1029997 Change-Id: Ie1bae0880e4ee1610bc03e88f73237ddc6501a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947263Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#720880}
-
Friedrich [CET] authored
This reverts commit 8061760f. Reason for revert: Seems to break windows test, see linked bug. Original change's description: > Roll src/third_party/angle ca1b0fb895ca..fb40d231c3e2 (5 commits) > > https://chromium.googlesource.com/angle/angle.git/+log/ca1b0fb895ca..fb40d231c3e2 > > git log ca1b0fb895ca..fb40d231c3e2 --date=short --first-parent --format='%ad %ae %s' > 2019-12-02 jmadill@chromium.org Add new test runner harness. > 2019-12-02 syoussefi@chromium.org Vulkan: implement external semaphore barriers > 2019-12-02 syoussefi@chromium.org Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test > 2019-12-02 syoussefi@chromium.org Add test for multithreaded shared-context resource > 2019-12-02 geofflang@chromium.org D3D: Log why a renderer fails to initialize. > > Created with: > gclient setdep -r src/third_party/angle@fb40d231c3e2 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC geofflang@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1026673,chromium:1029091 > Tbr: geofflang@google.com > Change-Id: Ie7249b58c3681e8f2a2238cfc86689216142593c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947424 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#720769} TBR=geofflang@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I33c8e7a4a8f9da17c1551f2ab0bda284f12778cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1026673, chromium:1029091, 1030192 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948424Reviewed-by:
-
Maksim Sisov authored
This CL fixes a corner use case that was caught by one of the users of Ozone/Wayland. The problem appeared when the Chromium compositor sent a next frame into the same buffer that had just been submitted and a OnSubmission callback had been sent to the viz process located WaylandBufferManager. This happened only when the remote inspector was attached and the screencast was enabled. In this case, Wayland compositor will not send an OnRelease callback and we should not wait for that. Instead, we must complete the submission immediately and set the |WaylandBuffer::released| member to be false. Once another buffer is committed, Wayland compositor will release the previous buffer. Bug: 1029777 Change-Id: Ib74c16f41f128298998bc9699f8d9ded3697cd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946479 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#720878}
-
Andy Paicu authored
As a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1930820 this CL ensure that the "Inform quietly" checkbox is not visible if the `QuietNotificationPrompts` feature is disabled. Bug: 1014874 Change-Id: I205d46c86c1714f06e62849a10b1348252631930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946484Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720877}
-
jameshollyer authored
Windows sometimes sends OnConnectionStatusChange events when the status has not changed. Previously we had assumed the status changed and acted accordingly. This change keeps track of the connection status and if OnConnctionStatusChange fires with the same status it is now ignored. Bug: 127810 Change-Id: I64c5b3d99e0ac827f05ca1618d570ff83296a053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939827Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720876}
-
Oriol Brufau authored
Markers should have the following styles by default: - unicode-bidi: isolate - font-variant-numeric: tabular-nums Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo Bug: 457718 TEST=external/wpt/css/css-pseudo/marker-default-styles.html TEST=external/wpt/css/css-pseudo/marker-font-variant-numeric-default.html TEST=external/wpt/css/css-pseudo/marker-font-variant-numeric-normal.html TEST=external/wpt/css/css-pseudo/marker-unicode-bidi-default.html TEST=external/wpt/css/css-pseudo/marker-unicode-bidi-normal.html The unicode-bidi tests fail in legacy because of bug 1012289. And marker-font-variant-numeric-normal.html fails everywhere because nested ::marker pseudo-elements are not supported yet. Change-Id: I80360d0e2bfa78ebca1c10e1064daa17e66e6f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943228Reviewed-by:
-
Francois Buergisser authored
This is a reland of 3b866120 There is no changes in the code itself. BUG=1029856 TEST=Confirmed on the kevin that the test pass with or without the changes below. Original change's description: > media/gpu/v4l2: abstract request logic in V4L2 framework > > Currently, the request creation and submission logic are handled > inside the decoder's backend. > This patch moves the request handling inside the V4L2 framework and > provides new classes to abstract the request creation and submission. > > BUG=chromium:1009921 > TEST=tast video.DecodeAccelVD.h264* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelVD.vp8* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelPerf.vp8* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelPerf.h264* on veyron_minnie-kernelnext > > Signed-off-by: Francois Buergisser <fbuergisser@chromium.org> > Change-Id: Idacff87aa4324c26b287ce2617398c51dee2721a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918794 > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720402} Bug: chromium:1009921, chromium:1029856 Change-Id: I32fe681693049291378e4f120cd66a5d6f4d9e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947511Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#720874}
-
Ken Rockot authored
It seems that the dialog's show() can be invoked prior to attached(), resulting in a null object being indexed. This adds a null check to prevent the race from completely breaking login flow. Bug: 1028852 Change-Id: I9bfae2e420b1a694a77479f49aa4633089689a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948185 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#720873}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f888b87a74bc..9fe91522ae86 git log f888b87a74bc..9fe91522ae86 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8a450048..bd8110e5 (424 commits) Created with: gclient setdep -r src/third_party/skia@9fe91522ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Idff662860342f55de18df94613527d7f37d5f15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947718Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=oksamyt@chromium.org Bug: 891670 Change-Id: I427b68c5f57b6a779f9f3912790b3e6c22d674b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944853 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720871}
-
Miyoung Shin authored
This change converts RestrictedCookieManager mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I2d8a4cee3b7f039ea350cffedfa15d96447c9df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844754 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Incognito tab launcher intents are followed by focus on Omnibox and partially hiding incognito NTP message and totally hiding incognito tab counter. This behavior is moved behind "kFocusOnOmniboxInIncognitoTabIntents" feature. The feature is disabled by default until appropriate privacy notice is added. Bug: 1029018 Change-Id: I9e1152b747f6d0d02aa6e31263a36c345ff77dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941309Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#720869}
-
Kunihiko Sakamoto authored
This will be used for variant matching of web bundles. Bug: 1029406 Change-Id: I65d1851cd6b9b6d446cc35981d3e9472203ab857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948003Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Joel Hockey authored
Some system apps such as settings will only ever show in a single window. Others such as terminal allow multiple windows of the app. Bug: 1028861 Change-Id: Ifc4348a13f9f92c39e39e3c52e072bc0cfe97d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942598Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#720867}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=servolk@chromium.org Bug: 891670 Change-Id: Iac49c1e9081eb47841bfe92eacad0efd52dc65d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946229 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720866}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=nyquist@chromium.org Bug: 891670 Change-Id: Ica327fbc1bc3d3a328c3fd60dc211b8b1f752162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944854 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720865}
-
Alan Cutter authored
This CL adds support to InstallableManager for PWA manifest icons to be of type image/svg+xml. We can now support SVG icons for PWAs after https://chromium-review.googlesource.com/c/chromium/src/+/1541185 landed enabling SVG support for WebContents::DownloadImage(). Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=423623&signed_aid=lwWpysp1maLWhXdbkb21bg==&inline=1 Bug: 578122 Change-Id: I111889f134c0046f9f8048f009d6793f7d1aeff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923216Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#720864}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=sorin@chromium.org Bug: 891670 Change-Id: Ifb3bb37fe4bfa36d11422dba619c7ade2f84d151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944668 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720863}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=oshima@chromium.org Bug: 891670 Change-Id: I4687dda8e4a49d0064ff9dfe7b68173223d56a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946230 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720862}
-
Mikel Astiz authored
BookmarkModel can only be used from the UI thread, so this patch enforces that with DCHECKs by adopting base/sequence_checker.h. Such enforcement surfaces a few questionable usages in chrome/browser/android/provider and corresponding tests, both of which are updated. Most importantly, bookmarks::ModelLoader is plumbed separately because it's thread safe, whereas access to BookmarkModel is strictly limited to the UI thread. Bug: None Change-Id: I70e526e42982faf9e17d7d54f4a71eed34e2d5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903130Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/83af46951202..a4af7676feb0 git log 83af46951202..a4af7676feb0 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 johnkslang@users.noreply.github.com Merge pull request #2004 from ianromanick/document-other-test-requirements Created with: gclient setdep -r src/third_party/glslang/src@a4af7676feb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I20011820442d45267e195f31decbc68a808fb2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948357Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=zmo@chromium.org Bug: 891670 Change-Id: Ie1657d67a62df040a9ee074cc83af4297fcd6fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945810 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720859}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 891670 Change-Id: I444463f03ff009d296f846a459b3bc6f6fdc1038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946227 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720858}
-
nancy authored
Move AppService instance registry browser test to ui/ash/launcher directory, because most status setting is related with ui part. Currently there are several CLs still in review process, not commit yet, so it's difficult to test other app types, e.g. ARC, multiple windows, etc. When those CLs are committed, I will add more test cases. TODO: 1. Add ARC apps app windows tests. 2. Add multi-profile related tests. BUG=1011235 Change-Id: I58fac4699bab2b4cfc233a20c9af8832dad6ca07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943085 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1bad5558240..9af0784b509e git log b1bad5558240..9af0784b509e --date=short --first-parent --format='%ad %ae %s' 2019-12-03 treehugger-gerrit@google.com Merge "protozero: Fix use-of-uninitialized-value in MessageHandleBase" Created with: gclient setdep -r src/third_party/perfetto@9af0784b509e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic396891469d0e10152ed28679e2463e944838ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948355Reviewed-by:
-
Alan Cutter authored
This CL enables PWA manifest updating to detect when sites update their "icons" field (but not when the icon contents themselves change). Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=423127&signed_aid=pWxFmMl1EjQvs_LiPg2zog==&inline=1 Bug: 926083 Change-Id: I6ff14e7b813c9526f8e423b4d3de50c7f5349abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935297 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#720855}
-
Jan Wilken Dörrie authored
This change renames base::WriteIntoW into base::WriteInto, to be more consistent with existing base::WriteInto overloads. In order to avoid redefinition errors, this overload is guarded by a macro that will only be set if std::wstring and base::string16 are distinct types. Bug: 911896 Change-Id: Ic95b6ae796127043383bed01774805c40e6b1679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943172Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#720854}
-
Noel Gordon authored
Files-ng allows a very narrow tree, and if too narrow, the .tree-row's .align-right-icon can be elided (disappear). In files-ng, add style so that .align-right-icon are never elided. Bug: 992819 Change-Id: I8c2930a5093eeb77fe534a76dc6188eff5fb2f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947503Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720853}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49e564e5e02c..f888b87a74bc git log 49e564e5e02c..f888b87a74bc --date=short --first-parent --format='%ad %ae %s' 2019-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ea0dcd4bda18..fb40d231c3e2 (10 commits) Created with: gclient setdep -r src/third_party/skia@f888b87a74bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I52b7f69f432fafdeb4d0cdbb4696c5988203601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948212Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e899ffa92b9..db299863e0c5 Created with: gclient setdep -r src-internal@db299863e0c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I431751d3ade7ba5aca4830c35ab6a0a8740e78ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948349Reviewed-by:
-
