- 23 Sep, 2016 35 commits
-
-
ccameron authored
This leaks IOSurfaces on 10.9. Include 10.10 in the blacklist because it has not been sufficiently tested. BUG=632178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2366433002 Cr-Commit-Position: refs/heads/master@{#420543}
-
twellington authored
During multi-instance migration, if tab_state0 already exists, do not overwrite it by renaming tab_state. tab_state0 should not already exist when multi-instance migration is run, but if it does and it is overwritten then users may lose tabs. BUG=649384 Review-Url: https://codereview.chromium.org/2360183003 Cr-Commit-Position: refs/heads/master@{#420542}
-
twellington authored
BUG= TBR=donnd@chromium.org Review-Url: https://codereview.chromium.org/2366813002 Cr-Commit-Position: refs/heads/master@{#420541}
-
sashab authored
Renamed EFloat members to match its keywords (none, left, right). This is pre-work to move it to be generated in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2358473002 Cr-Commit-Position: refs/heads/master@{#420540}
-
alph authored
BUG=406277 Review-Url: https://codereview.chromium.org/2347033002 Cr-Commit-Position: refs/heads/master@{#420539}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/e33d22aee513e6e4385251d3160dc94308cbf262 Revert of [swarming/api] Add text in to indicate whether a shard is failing (patchset #4 id:70001 of https://codereview.chromium.org/2362733002/ ) (nednguyen@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=chromium:639321 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2366833002 Cr-Commit-Position: refs/heads/master@{#420538}
-
ananta authored
This is based off clamy's original patch https://codereview.chromium.org/1485693002/ This patch gets the StreamPrivate API which is exposed for extensions to work with PlzNavigate. This should fix top level PDF file loads and in turn some browser tests like MaterialPDFExtensionTests, PDFExtensionTests, etc. Changes in this patch are as below: 1. Allow stream based requests to be handled in navigation_resource_handler.cc. 2. Fixing the way WebContents is obtained in the other places with the ResourceRequestInfoImpl::GetWebContentsGetterForRequest function. 3. The MimeHandlerStreamManager::AddStream function takes in the WebContents pointer. 4 A getter has been added to the ResourceRequestInfo class to get the frame_tree_node_id field. 5. The EmbedderObserver class now uses the WCO::RenderFrameHostChanged notification to determine if a RFH is swapped with another. This is used to determine when we should clean up the stream. The RFH being swapped out is tracked in a map. 6. We use the WebContentsObserver::DidStartNavigation method in the EmbedderObserver to detect a navigation on the main frame and use that to cleanup the stream. BUG=504347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2331343005 Cr-Commit-Position: refs/heads/master@{#420537}
-
sashab authored
Changed EFloat to an enum class and gave it an unsigned underlying type. This is pre-work to move it to be generated in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2354843002 Cr-Commit-Position: refs/heads/master@{#420536}
-
klausw authored
On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. The implementation will use these localized strings, to be submitted separately. (See https://codereview.chromium.org/2363553003 for context.) R=blundell@chromium.org, bshe@chromium.org BUG= Review-Url: https://codereview.chromium.org/2368443002 Cr-Commit-Position: refs/heads/master@{#420535}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b803018ac776..7bd10eda47f1 $ git log b803018ac..7bd10eda4 --date=short --no-merges --format='%ad %ae %s' 2016-09-22 nednguyen Make use_live_traffic in FakeNetworkController default to False 2016-09-22 jbudorick [Android] Attempt to grab the forwarder daemon logs on map failure. 2016-09-22 aiolos Remove warning when a ref build is set as monitored. 2016-09-22 charliea [trace model] Add .range accessor for Event 2016-09-22 nednguyen [Telemetry] Enable typ's discovery flags for telemetry's unittest_runner framework 2016-09-22 sullivan Add ability to query for test patterns of length 8. 2016-09-22 bccheng Explicitly initialize the network controller 2016-09-22 nednguyen Add logging to _FileLock to debug race condition when multiple processes download a same file 2016-09-22 nednguyen [Telemetry] Start ts_proxy_server with host=None when --use-live-site flag is enabled BUG=634052,643649,647340,643320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2365803002 Cr-Commit-Position: refs/heads/master@{#420534}
-
estade authored
Things I missed in the first pass. BUG=648281 Review-Url: https://codereview.chromium.org/2363473002 Cr-Commit-Position: refs/heads/master@{#420533}
-
estade authored
Initially I only intended to remove pre-MD code from OpaqueBrowserFrameView, but this led to removals in other files as well. I did not attempt to remove all pre-MD code from all of these files, so, for example, tab.cc still has some pre-MD code. BUG=648281 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2360803002 Cr-Commit-Position: refs/heads/master@{#420532}
-
lazyboy authored
In CL https://crrev.com/2344783004, I've made compile exclude custom bindings of fileBrowserHandler in non-chromeos builds. However, it seems I've missed the schema definition file itself, this CL does that. BUG=376319 Test=No visible change, dev only instruction: You can test it by compiling chrome: 1. In non-chromeos build chrome target. 2. Inspect out/Debug/gen/chrome/common/extensions/api/generated_schemas.cc 3. There shouldn't be any entry for fileBrowserHandler any more (just search for the string). If you build chromeos instead, you should see kFileBrowserHandler and its friends (e.g. kFileBrowserHandlerInternal). Review-Url: https://codereview.chromium.org/2362963002 Cr-Commit-Position: refs/heads/master@{#420531}
-
dpranke authored
This allows users to override the hostnames to use local mirrors. Also, fix the indentation of the file to be consistent. R=mmoss@chromium.org Review-Url: https://codereview.chromium.org/2365753002 Cr-Commit-Position: refs/heads/master@{#420530}
-
dpranke authored
This change cleans up a bunch of things now that we don't need to support GYP: 'gn' becomes the default build type, so we no longer need 'gn_' in the config name or need to specify the 'gn' mixin. 'swarming' and 'noswarming' are no longer needed in the config names since the swarming flag was only needed for GYP. 'archive_gpu_tests' is also gone, for the same reason. The 'none' builder type is gone; builders that don't build simply aren't listed. The 'configs' and 'mixins' sections are sorted and de-duped. Any non-clang win builder that was specifying both goma and minimal_symbols is now just goma, since goma + win + !clang implies minimal symbols. A follow-on CL should make goma imply minimal symbols across the board ... 'x64' no longer needs to be specified explicitly on windows since it is the default. The 80-col line limit in mb_config.pyl was dropped so that configs can be listed on one line. The 'symbolized' config is being removed; it was never implemented in GN since we dropped those builders; the one remaining v8 builder has been reporting warnings since :). R=thakis@chromium.org, machenbach@chromium.org BUG=634184 Review-Url: https://codereview.chromium.org/2357483002 Cr-Commit-Position: refs/heads/master@{#420529}
-
tkent authored
* Check in the result of html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/src.html It doesn't contain a local file path any longer. * Remove html/semantics/forms/constraints/form-validation-validate-expected.txt It doesn't contain FAIL lines. * Remove html/semantics/forms/the-input-element/month-expected.txt It doesn't contain FAIL lines. * Rebaseline platform/win7/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt BUG=649258 TBR=nzolghadr@chromium.org Review-Url: https://codereview.chromium.org/2362963003 Cr-Commit-Position: refs/heads/master@{#420528}
-
timav authored
We convert the coordinates from DIP to pixels and pass them to this method but no one seems to use them. This CL proposes to remove the coordinates altogether. BUG=620929 Review-Url: https://codereview.chromium.org/2357413003 Cr-Commit-Position: refs/heads/master@{#420527}
-
jbroman authored
BUG=148757 Review-Url: https://codereview.chromium.org/2362463002 Cr-Commit-Position: refs/heads/master@{#420526}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/e74be45a4a7929bc3210776e5467d31bf9c6961e Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/7a3dd3570e2c3daa403d71fff2d71bc10b5eb0c4 Change usage of deprecated flag. (stip@chromium.org) https://crrev.com/f3cc160f0c5b5359fe359831b01ed09c7cc08602 Delete unneeded test. (stip@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=Every time I run 'git cl upstream' I get "The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to." Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2363923002 Cr-Commit-Position: refs/heads/master@{#420525}
-
eroman authored
parse an entire Certificate. (Part of a series of changes for simplifying the parsing tests to be in terms of just certificates for consistent entry point and expectations) BUG=634443 Review-Url: https://codereview.chromium.org/2359003003 Cr-Commit-Position: refs/heads/master@{#420524}
-
johannkoenig authored
Allow the library to process 8 bit (plus high bitdepth internal), 10 bit, and 12 bit files. Only for x86 targets. Performance for 8 bit (regular internal) is within 1-2% for these targets. BUG=445071 R=jzern Review-Url: https://codereview.chromium.org/2361263002 Cr-Commit-Position: refs/heads/master@{#420523}
-
xdai authored
[CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome OS. Activating the button should take the user to the Printer Management Settings subpage (chrome://md-settings/cupsPrinters). BUG=625374, 626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2351023002 Cr-Commit-Position: refs/heads/master@{#420522}
-
mpearson authored
Revert of Generating autocomplete results with and without word breaks in the Omnibox. (patchset #13 id:240001 of https://codereview.chromium.org/2187343002/ ) Reason for revert: Reverting. Will be replaced by cleaner implementation: https://codereview.chromium.org/2363463002/ --mark Original issue's description: > Generating autocomplete results with and without word breaks in the Omnibox. > > The goal is to support mid-word autocomplete in the Omnibox. Currently, if the user types "funtimes", inserts the cursor between the "n" and the "t" and begins typing the word "good" the Ominbox will search for URL results that match "fungood times" only. We want to also search for "fungoodtimes". > > BUG=591979 > TEST=0. Clear browser history. > 1. Visit the following link: https://twitter.com/fungoodtimes > 2. Open a new browser tab. > 3.Type into the Omnibox "funtimes". Note the lack of the suggestion for the above URL. > 4. Insert the cursor between the "n" and "t" in "funtime" and type "good". > 5. The above URL should show in the autocomplete list. > > Committed: https://crrev.com/e3235816f23e9eb733d11bdecdfd5f8ca67cec9f > Cr-Commit-Position: refs/heads/master@{#418054} TBR=open.hyperion@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591979 Review-Url: https://codereview.chromium.org/2364523003 Cr-Commit-Position: refs/heads/master@{#420521}
-
chenwilliam authored
Revert of DevTools: add devtools builder as CQ experiment (patchset #1 id:1 of https://codereview.chromium.org/2324573003/ ) Reason for revert: No longer need devtools experiment. Original issue's description: > DevTools: add devtools builder as CQ experiment > > I added a builder for devtools on tryserver.chromium.linux here: > https://codereview.chromium.org/2319213002/ > > I've tried a few builds for the builder on the tryserver > and it seems to be working OK: > https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools > > BUG=642046 > > Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 > Cr-Commit-Position: refs/heads/master@{#417756} TBR=sergiyb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642046 Review-Url: https://codereview.chromium.org/2350533002 Cr-Commit-Position: refs/heads/master@{#420520}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/ae6e4869c945..5a9c2f110e4f $ git log ae6e4869c..5a9c2f110 --date=short --no-merges --format='%ad %ae %s' 2016-09-22 brianosman sRGB cleanup in image filters. Ensure we configure paints correctly. 2016-09-22 brianosman It is possible to try and draw to an unsupported format. Let this go. 2016-09-22 halcanary SkPDF: do not assert when openStream return nullptr 2016-09-22 reed document.close from bool to void BUG=163892 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2363893002 Cr-Commit-Position: refs/heads/master@{#420519}
-
mgiuca authored
This deletes the IsExperimentalAppListEnabled and related functions (which were vestigial) and cleans up all call sites to always do the "experimental" behaviour. Also renames some variables and cleans up comments to reflect that the "experimental" behaviour is now the norm. BUG=531059 TBR=plundblad@chromium.org Review-Url: https://codereview.chromium.org/2339523004 Cr-Commit-Position: refs/heads/master@{#420518}
-
dbeam authored
R=tsergeant@chromium.org BUG=648522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2361973002 Cr-Commit-Position: refs/heads/master@{#420517}
-
ftirelo authored
BUG=634434 Review-Url: https://codereview.chromium.org/2347753002 Cr-Commit-Position: refs/heads/master@{#420516}
-
vakh authored
1. Store list information in ListInfo (was: StoreIdAndFIleName). This includes the list identifier, list filename on disk, the SBThreatType for the list, and whether to fetch updates for this list. 2. Fixed potential leaks by inserting the client into pending_clients_ before calling GetFullHashes (based on shess@'s feedback in 2349603003) BUG=543161, 608075 Review-Url: https://codereview.chromium.org/2353413002 Cr-Commit-Position: refs/heads/master@{#420515}
-
derekjchow authored
CastMediaBlocker is a class which can prevent media from being played on a web page. This CL relands 502bcc94 BUG=NONE TEST=ChromecastShellMediaBlockingBrowserTest Review-Url: https://codereview.chromium.org/2360443002 Cr-Commit-Position: refs/heads/master@{#420514}
-
chrishtr authored
BUG=636463 TBR=pdr@chromium.org Review-Url: https://codereview.chromium.org/2362943002 Cr-Commit-Position: refs/heads/master@{#420513}
-
kbr authored
I'm not optimistic that this will work with the current test harness, but it's worth a try. These tests need to be cut over to the new harness. BUG=648369 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2359373002 Cr-Commit-Position: refs/heads/master@{#420512}
-
servolk authored
Also implemented reading color metadata from the Colour element in WebM containers. BUG=645626 Review-Url: https://codereview.chromium.org/2333663003 Cr-Commit-Position: refs/heads/master@{#420511}
-
dpranke authored
R=brettw@chromium.org, phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2361693002 Cr-Commit-Position: refs/heads/master@{#420510}
-
junov authored
This is a follow-up to https://codereview.chromium.org/2356803002 to add testing. BUG=647896 TBR=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2362473002 Cr-Commit-Position: refs/heads/master@{#420509}
-
- 22 Sep, 2016 5 commits
-
-
sashab authored
Add a generated ComputedStyleBase class that ComputedStyle extends from, as well as a generated ComputedStyleBaseConstants file that ComputedStyleConstants includes. Moved the 'visibility' field to be generated in ComputedStyleBase and it's type, the EVisibility enum, to be generated as well. This patch adds the 'keyword_only' field to CSSProperties.in, which is used to detect keyword-only properties that can be stored as bitfields, as well as enough generation code to generate enum bitfields. Other field types, as well as support for custom storage and methods, will be added in future patches. This is the beginning of an effort to move properties across to ComputedStyleBase and then, eventually, remove ComputedStyle and rename the base to ComputedStyle. Design doc: https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tWxg/edit BUG=628043 Review-Url: https://codereview.chromium.org/2187493004 Cr-Commit-Position: refs/heads/master@{#420508}
-
jrummell authored
The latest EME spec has changed the attibutes of MediaKeyMessageEventInit to required, so update the IDL to match. Also adds a test to verify that both attributes are required, and that the valid values of |messageType|. BUG=647693 TEST=added test passes Review-Url: https://codereview.chromium.org/2354083003 Cr-Commit-Position: refs/heads/master@{#420507}
-
rsleevi authored
This sub-CA does not meet the independence criteria to be exempt from CT. BUG=620178 Review-Url: https://codereview.chromium.org/2362593002 Cr-Commit-Position: refs/heads/master@{#420506}
-
fdoray authored
browser_tests fail without this when redirection to TaskScheduler is enabled. Wait on the UI thread is disallowed by a call to base::ThreadRestrictions::DisallowWaiting() in BrowserMainLoop::PreMainMessageLoopRun(). BUG=553459 Review-Url: https://codereview.chromium.org/2361543002 Cr-Commit-Position: refs/heads/master@{#420505}
-
estade authored
by screen readers. BUG=648280 Review-Url: https://codereview.chromium.org/2355963002 Cr-Commit-Position: refs/heads/master@{#420504}
-