GitLab

This is an alternative solution to http://codereview.chromium.org/10332114/

RenderViewObserver is actually destroyed in the same order as they are created. 
Ie 
P2PSocketDispatcher::P2PSocketDispatcher 
MediaStreamImpl::MediaStreamImpl 
P2PSocketDispatcher::~P2PSocketDispatcher 
MediaStreamImpl::~MediaStreamImpl 

Since MediaStreamImpl holds an observer object to P2PSocketDispatcher and the P2PSocketDispatcher require all observers to have unregistered before it is deleted, it is required that the MediaStreamImpl is either destroyed before P2PSocketDispatcher or that it is notified that the 
PSocketDispatcher will be destroyed. 

BUG=127782
TEST= Please see the defect


Review URL: https://chromiumcodereview.appspot.com/10387135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138066 0039d316-1c4b-4281-b951-d872f2087c98

Convert GdkPixbufToSkBitmap to GdkPixbufToImageSkia

BUG=124566
TEST=Compiles

Review URL: https://chromiumcodereview.appspot.com/10377122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138064 0039d316-1c4b-4281-b951-d872f2087c98

bug=128734
r=rvargas

Review URL: https://chromiumcodereview.appspot.com/10392163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138063 0039d316-1c4b-4281-b951-d872f2087c98

ListModel is intended to be used as composition not inheritance, so it's
unlikely these functions will be needed to be overridden, and they aren't until
now, so let's not make them virtual for now.

R=xiyuan@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10332264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138062 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138059 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r138055 with a fix for DCHECK failures.

The new API is used to fetch the metadata of files in a particular
directory. More specifically, the new API is used to fix the stale
thumbnail URL issue.

BUG=127697
TEST=added a unit test.

Review URL: https://chromiumcodereview.appspot.com/10386226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138057 0039d316-1c4b-4281-b951-d872f2087c98

Broke unit_tests on Debug build.

The new API is used to fetch the metadata of files in a particular
directory. More specifically, the new API is used to fix the stale
thumbnail URL issue.

BUG=127697
TEST=added a unit test.

Review URL: https://chromiumcodereview.appspot.com/10386226

TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10332267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138056 0039d316-1c4b-4281-b951-d872f2087c98

The new API is used to fetch the metadata of files in a particular
directory. More specifically, the new API is used to fix the stale
thumbnail URL issue.

BUG=127697
TEST=added a unit test.

Review URL: https://chromiumcodereview.appspot.com/10386226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138055 0039d316-1c4b-4281-b951-d872f2087c98

Turned out /-/ part was also necessary for these URLs...

BUG=127697
TEST=confirm the API dev that /-/ is needed

Review URL: https://chromiumcodereview.appspot.com/10332260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138054 0039d316-1c4b-4281-b951-d872f2087c98

TBR=petermayo@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10332266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128572
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10407054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138051 0039d316-1c4b-4281-b951-d872f2087c98

Revert 138044 - Allowed BinaryValue to take a NULL buffer.

BUG=127630

Review URL: https://chromiumcodereview.appspot.com/10389088

TBR=mitchellwrosen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138050 0039d316-1c4b-4281-b951-d872f2087c98

TEST=DRT no longer crashes
BUG=none
TBR=apatrick@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10407055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138049 0039d316-1c4b-4281-b951-d872f2087c98

Wrote a small sample TTS Engine that prints text to a small window on the bottom
of the screen rather than synthesizing speech.

BUG=117480
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/9688004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138047 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138046 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r8627: (jvoung) Add hook to whitelist glibc library files as 'web-accessible-resources',
r8628: (robertm) Added function to toolchain builder for shared newlib support.
r8629: (dschuff) Stage pnacl extension into chromebinaries directory, and add the nacl_irt_test environment to the scons mode.
r8630: (khim) Bump REVISIONS
r8631: (dschuff) Run Pnacl browser tests on nacl-chrome integration bot
r8632: (jvoung) Add a test to check that our nexe ARM float abi is hard, not soft.
r8633: (jvoung) Advertise debug options in pnacl-clang script's help message.
r8634: (bradnelson) Adding support for 'sources' 'sources!' and 'sources/'
r8635: (kschimpf) Clean up model.h in validator_arm to follow C++ style guide.
r8636: (mcgrathr) Further harmonize Gyp configuration for ARM with Chromium
r8637: (kschimpf) Allow bfc as another way to mask loads/stores.
r8638: (mseaborn) Cleanup: Remove unused arguments from nc_thread_starter()
r8639: (bbudge) Update Chrome revision in NaCl DEPS.
r8641: (kschimpf) Define baseline decoders for store/load (register) instructions.
r8642: (robertm) Corrected some paths inside the shared newlib experiment
r8643: (bungeman) Add dep of reverse_service to simple_serivce.
r8644: (mseaborn) Cleanup: Remove libpthread's unused __thread_exit_hook
r8645: (robertm) Roll PNaCl toolchain deps to r8628
r8647: (dschuff) Disable pnacl browser tests on windows integration bot
r8648: (bradnelson) Switching scan_sources to be used as a module for speed + line length.
r8649: (mseaborn) Fix pthread_kill() to return an error number instead of setting errno
r8650: (mseaborn) libpthread: Make pthread_t a pointer instead of a small integer ID
r8651: (mcgrathr) Fix mcgrathr account name in OWNERS file
r8652: (mcgrathr) Fix objdump command name in validation-report.py
r8653: (jvoung) Remove redundant and local/custom LLC flag -arm_static_tls from driver,
r8654: (mseaborn) ARM: Remove another malloc()-avoidance hack now that the bottom 1GB is reserved
r8655: (bsy) Test to verify that NaClMutex objects are actually binary mutexes.

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10411041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127630

Review URL: https://chromiumcodereview.appspot.com/10389088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138044 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138043 0039d316-1c4b-4281-b951-d872f2087c98

Picks up another attempt at fixing the mac shared build.

BUG=none
TEST=none
TBR=rsleevi

Review URL: https://chromiumcodereview.appspot.com/10332265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10407048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138041 0039d316-1c4b-4281-b951-d872f2087c98

Implementation of a new API, launchAuthFlow, that allows the apps
to perform any auth protocol with any provider.

- Add the API boilerplate (patches from Jon's CL)
- Create a new ExtensionAuthFlow class that encapsulates the
  WebContents / WebView / Widget code to perform the auth flow
- Use ExtensionAuthFlow in the API implementation.

Note that we currently allow two URL formats for redirect back
from the provider:
1. chrome-extension://<extension-id>/
2. https://<extension-id>.ext.chromium.org/

We would ideally want just 1, but providers don't currently allow such a scheme.
So we allow 2 as a workaround and if/when providers add support for 1, we can
remove 2.
Review URL: https://chromiumcodereview.appspot.com/10178020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138039 0039d316-1c4b-4281-b951-d872f2087c98

A previous CL delayed the destruction of Off The Record profiles, but there are cases where they are delayed post destruction of their original profile... no good...

So we now delay the destruction of both the off the record profile and it's original profile when either of them is still referenced by a render process host.

BUG=114245
TEST=unittest --gtest_filter=ProfileDestroyerTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123082

Got reverted because of failures in extension api tests, so trying again with fix in extension tests to avoid an infobar leak, which was keeping a render process host alive for too long and causing an assert that not all profiles were destroyed...

Review URL: https://chromiumcodereview.appspot.com/9420036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138038 0039d316-1c4b-4281-b951-d872f2087c98

R=atwilson@chromium.org
TBR=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10382229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138037 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138034 0039d316-1c4b-4281-b951-d872f2087c98

No idea if this'll help, but it probably can't hurt.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/9116028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138032 0039d316-1c4b-4281-b951-d872f2087c98

Enable the Clang error that makes it a warning/error to derive from
base::RefCounted/RefCountedThreadSafe directly and have a public
destructor for Linux and Mac builds.

For ChromeOS builds, do not yet enable the warning, as it does not
yet build cleanly.

BUG=123295
TEST=it compiles
R=thakis


Review URL: https://chromiumcodereview.appspot.com/10414016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138031 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10387205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138030 0039d316-1c4b-4281-b951-d872f2087c98

This broke sometime during the m19 branch, seemingly after 19.0.1081.2 but
before 19.0.1084.46.

TEST=inspect chrome://histograms/Media.Acc after playing <video> with and without accelerated compositing.


Review URL: https://chromiumcodereview.appspot.com/10387202

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138029 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138028 0039d316-1c4b-4281-b951-d872f2087c98

Speculative fix for mac_shared

BUG=none
TEST=mac_shared goes green
R=thakis


Review URL: https://chromiumcodereview.appspot.com/10387204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138027 0039d316-1c4b-4281-b951-d872f2087c98

normal 1x -> default_100_percent
normal 2x -> default_200_percent
touch 1x -> touch_100_percent
touch 2x -> touch_200_percent

I didn't move images used by windows installer/system and used by webui.

git cl upload failed to upload the change due to its side. comming without it.
(got ok from sky)

TBR=sky@chromium.org
BUG=123162
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10383257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=none
TBR=battre@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10414017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138025 0039d316-1c4b-4281-b951-d872f2087c98

After r136220, having a layer bigger than the texture would stretch the texture instead of keeping a smaller web layer
This fixes it.

BUG=None
TEST=run chrome with aura, load complex page, resize, observe no stretching.


Review URL: https://chromiumcodereview.appspot.com/10389221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128841
TEST=XP bots are happy
TBR=gavinp@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10399098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138023 0039d316-1c4b-4281-b951-d872f2087c98

normal 1x -> default_100_percent
normal 2x -> default_200_percent
touch 1x -> touch_100_percent
touch_2x -> touch_200_percent

I didn't move aura wall papers and a few resources used by webui and oak.png that are used for debugging.
They'll be handled separately.

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10332254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138022 0039d316-1c4b-4281-b951-d872f2087c98

executed script when the action box is enabled.

This is platform independent but will only work on GTK until cocoa and views
have been updated to use the ActionBoxController interface.


BUG=127988


Review URL: https://chromiumcodereview.appspot.com/10332235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128704
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10409025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138020 0039d316-1c4b-4281-b951-d872f2087c98

have URL_REQUEST_BLOCKED_ON_DELEGATE events right
after creation.

R=eroman@chromium.org
BUG=117931

Review URL: https://chromiumcodereview.appspot.com/10392169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138019 0039d316-1c4b-4281-b951-d872f2087c98

no need to do that, and it makes debugging easier to have the value.

BUG=127931
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10388202

TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/10383256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128724
TEST=none
TBR=steveblock
Review URL: https://chromiumcodereview.appspot.com/10411040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138017 0039d316-1c4b-4281-b951-d872f2087c98