GitLab

AppListView::last_fling_velocity_ is used to decide whether app list
should be dismissed when swipe occurs, but it's not reset once the
gesture ends, which means the last recorded value will influence
reseults of subsequent drags (if they do not generate
ET_GESTURE_SCROLL_UPDATE event which updates the cached velocity value;
e.g. for mouse drags)

BUG=1008702

Change-Id: I3e55b05321388c39f354bf78e6a70e78370544d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828498
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700844}

This CL is part of the shift away from NonInterpolableValues to instead
having more InterpolableValue subclasses. It introduces a new subclass,
InterpolableFilter, which can represent a blink::FilterOperation. This
should enable us to more easily implement the correct additive behavior
for filter, see [0].

There should be no behavioral change from this CL, it is (intended to
be) a pure refactoring.

Bug: 1005828

[0]: https://docs.google.com/document/d/1aAvTNwxSSl0OWP3hQAV-Q7ru5-o5MzV4UEz7Uw9VHZk/edit#heading=h.9b2xtih585di

Change-Id: Ib60b5857167db8950f3eb457cfaeec98ee781ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817284
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700843}

This patch makes document.body.insertAdjacentHTML('afterend', '<p>')
insert the <p> as a sibling of document.body rather than creating a
duplicate body and putting <p> in the duplicate.

This fix was made in webkit in 2016:
https://github.com/WebKit/webkit/commit/e3ca66a98a2a5edd553c411d6249a3a6a176174a

fast/dom/insertAdjacentHTML-DocumentFragment-crash no longer produces a
console message because using insertAdjacentHTML to create a child of a
DocumentFragment now works, just as it does in safari and firefox.

Bug: 978148
Change-Id: I22248b914753a450e54f0a72066f5b0dcf584cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824030Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700842}

Currently breaks on component builds (see bug).

Bug: 1008962
Change-Id: Ifaf717b248b623ef7d32d3939e405015b1bd4b2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829543Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700841}

******************************Resource Sizes Diff******************************
Specifics:
       +73,728 bytes main lib size
      +621,920 bytes main dex size
    +1,048,949 bytes normalized apk size
InstallSize:
      +402,200 bytes APK size
    +1,129,846 bytes Estimated installed size (Android Go)
    +2,914,757 bytes Estimated installed size
InstallBreakdown (+2,910,135 bytes):
        +3,954 bytes Native resources (no l10n) size
        +2,702 bytes Non-compiled Android resources size
       +73,728 bytes Native code size
        +3,412 bytes PNG drawables size
          +705 bytes Package metadata size
    +2,797,566 bytes Java code size
       +28,068 bytes Compiled Android resources size
Dex:
        +2,960 entries fields
        +2,522 entries strings
        +3,793 entries unique methods
        +1,275 entries types
        +3,793 entries methods

Bug: 948739, 1006189
Change-Id: I78326484208068aa7b9b40b1ec2bf9833bc4cb10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829821Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700840}

Bug: 1001309
Change-Id: I49d9b7adc9f62efed2c6f403ba7f3ab0e51a9e0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828457Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700839}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2ed47b33935..30058d417f4c


Created with:
  gclient setdep -r src-internal@30058d417f4c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: None
Change-Id: I9679e7540f34fe006e10694e8ed0fd44b1d3e9d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829999Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700838}

This reverts commit f6ce0a33.

Reason for revert: compilation errors were caused by lint complaining
that chrome/android/java/res_template/xml/syncadapter.xml is unused,
so now it is removed as well (downstream usage has been removed in
the meantime).

Original change's description:
> Revert "[Android] Remove ChromeBrowserSyncAdapterService from manifest"
>
> This reverts commit 230b08fa.
>
> Reason for revert: android-builder-perf and android_arm64-builder-perf failures.
> See:
> https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115865
> https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/114816
>
> Original change's description:
> > [Android] Remove ChromeBrowserSyncAdapterService from manifest
> >
> > This is a follow-up to https://crrev.com/c/1821784 that removes
> > ChromeBrowserSyncAdapterService from AndroidManifest.
> >
> > Please note that chrome/android/java/res_template/xml/syncadapter.xml
> > is kept in the repo for the time being, as it is being used downstream.
> > This file will be removed in subsequent CLs.
> >
> > Bug: 1002894, 1008314
> > Change-Id: I7aa5fd7e2b5c982192aa07970d7400945f95116f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827413
> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
> > Commit-Queue: Marc Treib <treib@chromium.org>
> > Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#700703}
>
> TBR=treib@chromium.org,bsazonov@chromium.org,mamir@chromium.org
>
> Change-Id: If68359d7398372debbaec730e7df22e4cf91602a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1002894, 1008314
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829339
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Commit-Queue: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#700729}

TBR=treib@chromium.org,mamir@chromium.org

Bug: 1002894, 1008314
Change-Id: I7a05b2fcc3e91267f67c4db70b91a5498efa9396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829201
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700837}

In the past we were calling UpdateMemoryUsage with the old size.
Make it clear that the canvas is being reset if the size is not
changing.

Change-Id: Iea8b9d50ce4b01b82611bc8ff665b5cf673f79db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829801
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700836}

Bug: 995916
Change-Id: I19886e1608085745ae686a86f560eaa484a39760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829644Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700835}

This adds a "More docs" link to the end of the navbar, which links to
the /android_webview/docs/ directory listing. Not all docs are in the
navbar (not everything is relevant to everyone), but there should still
be a way to navigate there from the navbar interface.

This adds a comment to tell future contributors to leave this entry
last.

Bug: 918221
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Ibfd27d9d3724d31543532da0e5507dc97a6ba11f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829241
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700834}

At least on Mac, a "splitter" is an interactable thing that allows
the user to adjust the boundary between two groups of things. The
Views splitter is not like this - it is basically just an <hr> type
line. The Views control is more or less purely presentational and
should not have an AX role.

Bug: 961324
Change-Id: I8cfcd657c2ee9cae462a208e616dd8364cdb6428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827944Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700833}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b8293682955..b37784118cd4

git log 2b8293682955..b37784118cd4 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 ehmaldonado@chromium.org Reland "depot_tools: Use vpython to execute fetch."

Created with:
  gclient setdep -r src/third_party/depot_tools@b37784118cd4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1002153
Change-Id: Idaebcf08ad056bc056ab3f2a5a93bf9f5c6e78c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829284Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700832}

(1) Regex for replacing the thousands delimiter needs to use an escape,
because the thousands delimiter may have another meaning (e.g. in the
case of '.').
(2) Remove thousands delimiters before replacing the decimal delimiter
with '.', because the thousands delimiter may be '.', in which case
replacing decimal delimiters with this value first will lead to them
being removed.

Also adding a test to run all current textbox parsing logic test cases
with a metric unit system and different delimiters, which would have
caught this bug.

Bug: 1005816
Change-Id: I7bf84fe819bdfecfc344ff0e9fefd1322a5b622a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827682
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700831}

Animations on these chips are used to get the user's attention; as such
they should also cause screenreader alerts with their text, if they have
such text.

Bug: 801764
Change-Id: I7a111a1484de5752d83b9243c101291546293045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829949
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700830}

Bug: 1002704
Change-Id: Ic8d882f2c3a7e1955827c00332824afc095d82ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828061
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700829}

This CL:
(1) Calls DebugLogsManagerFactory::GetInstance() within
    ChromeBrowserMainExtraPartsProfiles to ensure that DebugLogsManager
    is created as soon as the user logs in, regardless of whether
    chrome://bluetooth-internals is visited.
(2) Converts the <cr-toggle> used in the page into an <input> instead.
    This was necessary because chrome://bluetooth-internals is also used
    by Chromium for Android, which doesn't use Polymer.
(3) Adds the chromeos::bluetooth namespace to these classes.

Bug: 1006293
Change-Id: Ib163f55af376ff646f69790948af852e2ca07aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825171
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700828}

This CL adds parity between Android and Desktop for new battery
monitors. Currently, the second observer that is added for battery will
only receive new updates. This cl pushes the latest battery status
update to the new observer.

Bug: 999063
Change-Id: I6cfa7eeb6a355d03f2b1f0d9e8b7a73ffd8452e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829023Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700827}

Bug: 1008408
Change-Id: I1998eb54d4645741dd1f311147a0cacdb1b136c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829540
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700826}

WPT for animation and transition shorthand computed values.

Open spec issues:
    https://github.com/w3c/csswg-drafts/issues/2031
    https://github.com/w3c/csswg-drafts/issues/4034
    https://github.com/w3c/csswg-drafts/issues/4223

Change-Id: I3cac663f8a4cdce53856a9152e7b38033be9a76b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827317
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700825}

Add check for |cache_controller_| in ~VizProcessContextProvider().
It can be nullptr if InitializeContext() failed.

Bug: 1008966
Change-Id: I13204bdf56996850186dcfd312374b05c8161b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829546Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700824}

This CL updates the TestExpectation for the
toggle-class-with-state-source.html test to also include
virtual/audio-service

Bug: 981303
Change-Id: Ifd3c452299d55ccd90aebb00d1830f8694334999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829238Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700823}

Make it a pure virtual interface. Per the style guide, classes should
have no more than one superclass that actually provides implementation.
This fixes BrowserView in that regard. This is also necessary for
upcoming ScopedObserver updates.

Bug: 998625
Change-Id: I387e2ef98af0035023a72853b10cc5fba8db1df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828280Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700822}

https://android.googlesource.com/platform/external/perfetto.git/+log/7505235b577c..f96bdd640172

git log 7505235b577c..f96bdd640172 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 eseckler@google.com Merge "processor: Parse TrackEvent track associations"

Created with:
  gclient setdep -r src/third_party/perfetto@f96bdd640172

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I329795f0df72b2390870672c28cb39ae9ae2197a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829282Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700821}

This parameter is not needed now, when NetworkService has successfully
shipped on all platforms.  In particular, even before this CL the
|blob_data_handle| parameter was not used at all by
DownloadManagerImpl::BeginDownloadInternal.

Change-Id: I41393ebfc93ea671d43727485980fe7837198f88
Bug: 1008917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828108
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700820}

Currently, OffscreenCanvas may get registered before we catch the
execution context.

Bug: 995235
Change-Id: Ied98f7aa5ddef9926b512d2d01ad836c96ea1e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827946Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700819}

Bug: 994676
Change-Id: I920c6cf18d44a91f2a90b4aae416024695c9ad74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827880
Commit-Queue: Max Li <themaxli@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700818}

A recent CL [1] got past CQ without check_network_annotations.py
running, because remoting/client/ is not in the deps of
shipped_binaries.

TBR=mkwst@chromium.org

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1825484

Change-Id: I94d8bf6f50699c367a145950e342e28fcc8d06e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830057Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700817}

The bug was caused when a relative font size (ch, ex, em) is used to
define the value of the filter attribute of a canvas. The crash
happens because the document to which the canvas is attached is
frame-less.

Example JS that can repro the crash:

    var doc = new Document();
    var canvas = doc.createElementNS('http://www.w3.org/1999/xhtml',
				     'canvas')
    var ctx = canvas.getContext('2d')
    ctx.filter = 'blur(1ch)'
    document.body.appendChild(canvas)
    ctx.strokeRect(75, 140, 150, 110)

When the filter is created, the font is not, as seen here:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc?l=432

As per the spec, "If the computed values are undefined for a particular
case (e.g. because the font style source object is not an element or is
not being rendered), then the relative keywords must be interpreted
relative to the default value of the font attribute."

The fix uses the root document's font, when the font_for_filter_ was
not previously set.

Bug: 996070
Change-Id: I6e1d8839407833338f3772291f559b4beca6ad7c
Reference: https://html.spec.whatwg.org/multipage/canvas.html#filters
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814548Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Jonah Chin <jochin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700816}

Adds all necessary plumbing for the pref/policy associated with the
Enterprise Memory Limit project, described here:
https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714#heading=h.7nki9mck5t64

Bug: 980965
Change-Id: I7e86bdfb58aa48813c5367bf0a369cebf95cdb5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787080
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700815}

Prevent AffiliatedInvalidationServiceProvider from disconnecting in case of TRANSIENT_INVALIDATION_ERROR

Currently AffiliatedInvalidationServiceProvider disconnects and connects
again even in the case of TRANSIENT_INVALIDATION_ERROR. If there are
lots of TRANSIENT_INVALIDATION_ERROR a lot of connection and
disconnection of AffiliatedInvalidationServiceProvider will eventually
cause throttling of registration requests. Handle the case of
TRANSIENT_INVALIDATION_ERROR in the following way:
1. If there is an enabled InvalidationService, do not cause
disconnection
2. If there is no InvalidationService available yet, do not cause
connection, wait until TRANSIENT_INVALIDATION_ERROR is gone (Existing
behaviour).
3. Upon receiving TRANSIENT_INVALIDATION_ERROR, post delayed task that
will check InvalidationService to see if it switched to
INVALIDATION_ENABLED. If InvalidationService still in
TRANSIENT_INVALIDATION_ERROR state, cause the disconnection.
4. If the number of TRANSIENT_INVALIDATION_ERROR followed by
disconnection in delayed task is above certain limit, do not disconnect.
This is the best effort behaviour, keep registered topics registered and
failed ones as failed.


Bug: 1006706
Change-Id: Ie06f987eec12bc0f50a4c59098daf39ecf8bb12e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821529
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Askar Aitzhan <askaraitzhan@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700814}

We've always asserted that section sizes are the same, but couldn't rely on
them being aligned. This commit tries to match up start addresses and updates
test golden data to match, allowing SuperSize to cross-reference addresses
between linker map and readelf without breaking on test data.

Bug: 872796
Change-Id: I6f116c641f0520d5fd0d4768cf69a58e1e8ed907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829301Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700813}

* Adds a default constructor for notification client that reads
  platform, locale, and other information from the device.
* Adds message_id and dev_mode support to the notification rule.

Bug: 1001291
Change-Id: Iecad79896c3daddf9c15bb474ca3615d8a36cff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828227
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700812}

Since we can have more than one nested WebContents, we should make
sure to get the outermost WebContents when initializing a popup
window.

Bug: 1002598
Change-Id: I568d31813e46af441760ef22afb9d3e4ae4c65ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819559
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700811}

AppMenuButton overrides ToolbarButton::OnBoundsChanged because it's not
always hosted inside the toolbar. Color and text treatment for
ToolbarButton assumes that it is. Since BrowserAppMenuButton is hosted
in the toolbar area, and can make use of text / color it needs to use
ToolbarButton::OnBoundsChanged too.

Bug: None
Change-Id: I20282139da46e4160e00e23b29ea61a5ff32ef30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829279
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700810}

Using wpt-import in Chromium 6e011bf4.
With Chromium commits locally applied on WPT:
03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I06bb0f6aa123d1d721bdda9614d6545d9f67708e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829320Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700809}

The category field is unused in LUCI.

Change-Id: Iafb35ecc9b8167b742919bfeb605e5078f647639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829952Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700808}

This registers a CPUMetricsProvider, which will fill
ChromeUserMetricsExtension.system_profile.hardware.cpu.* fields.

Bug: 1008534
Test: Manual - verify fields in AwMetricsLogUploader::UploadLog
Change-Id: Ie5d5ff7f16fb79a055b91f5dc2b8023405718ffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828127Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700807}

This test tries to set a cookie in its PRE_ step, then read it back from disk in
its normal step; to ensure that that actually happens, it should also flush the
cookie store and wait for the flush to complete :)

This should de-flake this test on all platforms.

Bug: 868667,998740
Change-Id: I1f169122b10db9c6288cbb5226a51668e8b3350f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827860Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700806}

This CL:
  1) Sets constructor priority to 0, instead of 100 to ensure that it
    is loaded first.
  2) Adds TODO to look into dl_iterate_phdr instead of magic array.
  3) Removed ifndef clang since DoNotOptimize is not clang specific.
  4) Fixes the phdr sorting order to comply with the standard.

Bug: 998082
Change-Id: Id9967f2b8cc004be5284153da45f46e479908e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829203
Commit-Queue: Denis Solonkov <solonkovda@google.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700805}