- 01 Nov, 2018 40 commits
-
-
Guido Urdaneta authored
This CL exposes the current resizeMode setting to the Web Platform. As of this CL, the resizeMode is 'none' if the track resolution corresponds to the native resolution of the video source, without any resolution adjustment. It is 'crop-and-rescale' if rescaling is necessary. The resizeMode currently cannot be set explicitly with getUserMedia() or applyConstraints(), but this functionality will be added in a follow-up CL. Drive-by: Add separate WPT tests for all getSettings() properties. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE Bug: 854980 Change-Id: Id4c683e6b2f228b17cf2354cb7fc589ca9e593a6 Reviewed-on: https://chromium-review.googlesource.com/c/1307448 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#604562}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e008d6feb2d0..763fc966993d git log e008d6feb2d0..763fc966993d --date=short --no-merges --format='%ad %ae %s' 2018-11-01 halcanary@google.com docs: fix ASAN instructions Created with: gclient setdep -r src/third_party/skia@763fc966993d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I94f9f271e420739a98033e9921061a7594837859 Reviewed-on: https://chromium-review.googlesource.com/c/1312638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604561}
-
Rune Lillesveen authored
It was almost the same. The kNeedsReattachLayoutTree flag was already set explicitly after creation when needed. The only difference apart from that was the kChildNeedsStyleRecalcFlag. Having that set on pseudo elements also should not hurt. Change-Id: I354beda2cee8c5c0f3c585a79141a74e3675bced Reviewed-on: https://chromium-review.googlesource.com/c/1311921Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f92910970a44..c39d9737dc28 git log f92910970a44..c39d9737dc28 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 perezju@chromium.org [telemetry] Fix bad timeout=None in platform.PathExists Created with: gclient setdep -r src/third_party/catapult@c39d9737dc28 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900877 TBR=sullivan@chromium.org Change-Id: I985b1740a83d54391b95bcdfba6cd6d35a6a4c84 Reviewed-on: https://chromium-review.googlesource.com/c/1312639Reviewed-by:
-
Robert Sesek authored
This isn't supported by posix_spawn. Bug: 179923 Change-Id: I26527e25ffb7c6bfb72f1d7b4f885866f8d277f4 Reviewed-on: https://chromium-review.googlesource.com/c/679076Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604558}
-
Sam McNally authored
While Drive is mounting, a fake Google Drive entry is shown in Files app. If mounting fails, begin returning false for the is drive enabled "pref" to Files app and dispatch an event notifying it about the change in prefs. Bug: 889732 Change-Id: Ia79c19a36904bb73f7a3a8ed86ab52dd685689dc Reviewed-on: https://chromium-review.googlesource.com/c/1312442 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#604557}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bdc5b6f6574..682dcdd0a083 Created with: gclient setdep -r src-internal@682dcdd0a083 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie38b1b3089be442827e27f11dc745ef9d70f1b42 Reviewed-on: https://chromium-review.googlesource.com/c/1312637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604556}
-
Stephane Zermatten authored
Before this change, the stop action, which indirectly calls AutofillAssistantUiController.onShutdown, would just leave the UI open, even after deleting the native instances. This isn't what should happen; stop/shutdown should close the UI. This also causes crashes, if the user tries to dismiss the UI. With this change, the UI is hidden by stop/shutdown before the native instances are deleted. Bug: 806868 Change-Id: Ia5d4d2e8973d0a68fb5bca4c3841429d91d1b98f Reviewed-on: https://chromium-review.googlesource.com/c/1309735 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#604555}
-
Jordan Demeulenaere authored
Before this CL, progress animations worked on debug builds but not on release builds. I suspect that it was because of ProGuard or some other mechanism that stripped away some classes/reflection information previously used by the ObjectAnimators (which only knew about the name of the property to set during the animation). This CL fixes progress animations by defining progress and color properties to use in the ObjectAnimators. Change-Id: Idcfe71e63547672d42bf50274fd838b9efcd48ad Reviewed-on: https://chromium-review.googlesource.com/c/1312477Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#604554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59844ce57e1f..7f4dfa4106c9 git log 59844ce57e1f..7f4dfa4106c9 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 saza@webrtc.org Remove locks from AEC2 and move it into private_submodules_ Created with: gclient setdep -r src/third_party/webrtc@7f4dfa4106c9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c3df3bee953ab0939d76946319691d56eba167a Reviewed-on: https://chromium-review.googlesource.com/c/1312636Reviewed-by:
-
Rune Lillesveen authored
kNeedsReattachStyleChange is meant to be used on DetachLayoutTree, it behaves the same as kSubtreeStyleChange on Document, and we would like to get rid of it altogether. Change-Id: I21e525206c879229c85eb57304d23bf01f3ca3a9 Reviewed-on: https://chromium-review.googlesource.com/c/1311920Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604552}
-
Asami Doi authored
with different script type and identical script content. These tests check that a registration is updated correctly with different script type. At first Service Worker is registered as classic script type, then it is re-registered as module script type, and vice versa. A main script is identical. Bug: 824647 Change-Id: I2a3f87da1013f84c6e9495f362899dfe6ab97b45 Reviewed-on: https://chromium-review.googlesource.com/c/1298822 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604551}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37be071f8e8..e16778c0abc9 git log f37be071f8e8..e16778c0abc9 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com Merge "Improve performance of /proc/pid/status poller" 2018-11-01 primiano@google.com Merge "perfetto-ui: Add process tracks" 2018-11-01 primiano@google.com Merge "Add signal_deliver ftrace events to ftrace parser" Created with: gclient setdep -r src/third_party/perfetto@e16778c0abc9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I31f88750147f48f70ae660b2889dcfb591d5855f Reviewed-on: https://chromium-review.googlesource.com/c/1312635Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d56eff921808..7bdc5b6f6574 Created with: gclient setdep -r src-internal@7bdc5b6f6574 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I527fe3bb20e9a1b14d96e2f6614ecb2157663034 Reviewed-on: https://chromium-review.googlesource.com/c/1312634Reviewed-by:
-
Henrik Boström authored
It may be possible that a peer connection is closed, garbage collected and that any local track adapters associated with it is destroyed before the setLocalDescription/setRemoteDescription observer callback is invoked on the signaling thread due to webrtc::PeerConnection invoking the observer with an asynchronous delay. TransceiverStateSurfacer::Initialize() will crash if local track adapters are missing. This CL makes WebRtcSet[Local/Remote]DescriptionObserverHandler not surface any transceivers if the webrtc-layer peer connection is closed. This should be fine, because the spec says to abort the SLD/SRD steps if the PC has been closed. This is a speculative fix for https://crbug.com/897251. The stack trace produced by the new unittest before the fix is the same as that bug, but the cause of the referenced bug being that the PC was closed and GC'd, as assumed by this CL, has not been confirmed. NOTE: This CL contains just the fix. https://chromium-review.googlesource.com/c/chromium/src/+/1309792 contains tests too but we broke up the CL to allow this to land before a dependent testing related CL lands. TBR=guidou@chromium.org Bug: 897251 Change-Id: Ibf621c45fd5a683d847596edeea1f88018783289 Reviewed-on: https://chromium-review.googlesource.com/c/1311919Reviewed-by:
-
Adam Rice authored
This reverts commit 947d8086. Reason for revert: Caused failure on memory bot: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20CFI/builds/11050 Original change's description: > [s13n] Convert c/b/ui/webui/settings/people_handler_unittest.cc to IdentityManager > > This CL converts the PeopleHandler unittests away from SignManager and > ProfileOAuth2TokenService, in favor of the new IdentityManager. > > Production code has been converted in [1]. This is a follow up steps. > > [1] https://crrev.com/c/1261637 > > BUG=890810 > > Change-Id: I405e46d2126180a2da61393bf32263ae43877b6b > Reviewed-on: https://chromium-review.googlesource.com/c/1311093 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#604377} TBR=xiyuan@chromium.org,tonikitoo@igalia.com Change-Id: Idbab8bee31fd8a61ca66bb60cf2a680506866d39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890810 Reviewed-on: https://chromium-review.googlesource.com/c/1312152Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#604547}
-
Eric Seckler authored
The new test verifies that system tracing output on CrOS, Cast and Win actually ends up in a trace - in preparation for porting the respective tracing agents to the new perfetto service. Bug: 900603 Change-Id: I8383a907d2aa843cb2f67f5300e82c7684f116fc Reviewed-on: https://chromium-review.googlesource.com/c/1309835 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604546}
-
yoshiki iguchi authored
Now this method is used for cancelling not only long presses but also normal presses. The change itself has been done in ARC side (ag/5382077), so that this chromium-side CL just changes the names in the code. Bug: b/116513513 Test: none Change-Id: Ief379a954a560de7e4aff13caceb2f7660f60fbb Reviewed-on: https://chromium-review.googlesource.com/c/1309384Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604545}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3b4b23f8816..e008d6feb2d0 git log c3b4b23f8816..e008d6feb2d0 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e008d6feb2d0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I3cd3897ff5c5b7b0bd0d31cb4b601840aa20c331 Reviewed-on: https://chromium-review.googlesource.com/c/1312268Reviewed-by:
-
Kenichi Ishibashi authored
Before this CL, we called ResourceLoadContinuesBeyondScope() only after StartLoad() succeeded. This wasn't enough to cover all loading cases and ResourceLoader::DidFinishLoading() could be called when we already record END marks for tracing. This CL changes to call ResourceLoadContinuesBeyondScope() when resource still needs loading or is loading. Bug: 900815 Change-Id: I478e1e36c41b0fdc50f43c7d99687ea615eaaf2a Reviewed-on: https://chromium-review.googlesource.com/c/1312174Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604543}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. DEFINE_*ATTRIBUTE_EVENT_LISTENER() macros supposed onfoo IDL attribute name and EventTypeNames::foo used identical 'foo' string. However after this CL IDL attribute name is on*foo*, and C++ symbol name is kFoo. So we need to update these macros so that they take two arguments. We had DEFINE_MAPPED_ATTRIBUTE_EVENT_LISTENER() for such cases, and we don't need it any longer because we need to support the case by default. This CL has no behavior changes. Bug: 889726 Change-Id: I88137316debf5ed3eaa40945d2bf3fce481a9087 Reviewed-on: https://chromium-review.googlesource.com/c/1312434Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#604542}
-
Jinho Bang authored
To avoid cyclic references between V8 and Blink, we should use TraceWrapperV8Reference instead of ScriptValue. This CL introduces a new static method-ToWorldSafeScriptValue()- and use it instead of V8ValueFor() to create a clone across worlds as needed. Related discussion: https://chromium-review.googlesource.com/c/chromium/src/+/1262968#message-e08afac4b75f8a1893fbaf7b536607e146a9bed6 Bug: none Change-Id: Ib95bd8f47de55c7c42740373ebf80587af2b39f8 Reviewed-on: https://chromium-review.googlesource.com/c/1267155 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604541}
-
Shu Chen authored
Bug: 859432 Change-Id: I427c07ab10df62f0d7377737236afc986d2fafc1 Reviewed-on: https://chromium-review.googlesource.com/c/1309893Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604540}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eb2c6415a975..59844ce57e1f git log eb2c6415a975..59844ce57e1f --date=short --no-merges --format='%ad %ae %s' 2018-11-01 qingsi@webrtc.org Revert "Use the factory instead of using the builtin code path in `VideoCodecInitializer`." 2018-11-01 qingsi@google.com Improve the documentation of MdnsResponderInterface and rename MDns.* Created with: gclient setdep -r src/third_party/webrtc@59844ce57e1f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ife958377c7e309ef44005cef766fcffc42b68bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1312270Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9b30833b099..f37be071f8e8 git log f9b30833b099..f37be071f8e8 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com trace_processor: handle NULL results Created with: gclient setdep -r src/third_party/perfetto@f37be071f8e8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I49d1eb0d1bf044e22cc294d63c17cbf3c1df878c Reviewed-on: https://chromium-review.googlesource.com/c/1312266Reviewed-by:
-
Clemens Arbesser authored
Added support to restrict the set of supported basic-card networks for a payment request (e.g., accept only visa cards). An optional array of card issuers (e.g., `visa`, `mastercard`, ...) can now be specified in GetPaymentInformationProto. The default is as before: all cards are allowed. If the field is non-empty, the PaymentRequestUI will only show the subset of basic-card payment methods that matches the specified cards. Also, interactively adding payment methods will be restricted to the specified cards only. In the future, we may want to expand the proto even further as defined by the w3c specification for payment requests (https://www.w3.org/TR/payment-request/), but for now this filter should be good enough (we currently only support basic-card payment methods). Bug: 806868 Change-Id: I41b3017c06104045699818f8fe5a98bb63927ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1307447 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Hiroki Nakagawa authored
ServiceWorkerGlobalScopeProxy::DidCloseWorkerGlobalScope() is called after WorkerGlobalScope::close() to report the event somewhere. close() is a common way to stop worker global scope, so its report function should also be common. Otherwise, it's difficult to use close() for general purposes. For that, this CL avoids error handling specific to failures on loading installed scripts from DidCloseWorkerGlobalScope(). Change-Id: Icd36425f33727c0ea703471a7b376e33e9663784 Bug: 900429 Reviewed-on: https://chromium-review.googlesource.com/c/1309558 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
Previously, when an exception happens in an internal callback to fulfill a promise passed to waitUntil or respondWith, it invokes rejected callback too, though we expect that either of those is called. This CL correct it by using ScriptPromise::Then() twice. Previously, we used ScriptPromise::Then() as like Then(f, g), and it means calling a promise.then(f).catch(g); in the JavaScript world. I changed it to Then(f, _), Then(_, g), which is equivalent to promise.then(f); promise.catch(g);. Bug: 889567 Change-Id: Id2e2848762b50df633293571c01c5f60d106de7c Reviewed-on: https://chromium-review.googlesource.com/c/1312141Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34d730fce981..d56eff921808 Created with: gclient setdep -r src-internal@d56eff921808 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic6185f6ba151f0a30cb1f5683bde29c17e3c8849 Reviewed-on: https://chromium-review.googlesource.com/c/1312267Reviewed-by:
-
Eliot Courtney authored
Bug: b/115291749 Bug: 841886 Bug: 883098 Test: Added unit test Test: manually tried flinging around and it went in the direction of fling. Change-Id: Ic1b999f4a6596302a584a37888b5edadf0bce342 Reviewed-on: https://chromium-review.googlesource.com/c/1224150 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#604533}
-
Eliot Courtney authored
We would like to automatically trigger Picture-in-Picture when a certain amount of the window is occluded. To do this, we need a way to know how much of a window is occluded by other windows. This occlusion could come from multiple windows, and an occlusion tracker for aura already exists. This CL extends the existing occlusion tracking functionality to also track an occluded region for tracked windows. Bug: 883157 Bug: 841886 Bug: b/112668686 Bug: b/110011377 Test: unit test Change-Id: I0d6618ab05109cc46af0cfd72ecc5cbca2f200d4 Reviewed-on: https://chromium-review.googlesource.com/c/1179433 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#604532}
-
Min Qin authored
Currently when pausing a download, we remove the download controller from observing the download item in DownloadManagerService. This CL moves the logic to DownloadController itself when onDownloadUpdated() is called and the download is paused. This should have no impact on the existing flow since calling download->Pause() will trigger a onDownloadUpdated() call. However, this helps the servicification path as when downloadManager is created, it calls DownloadUIController::OnDownloadCreated() for all the downloads. And the DownloadUIController will call DownloadController::OnDownloadStarted() to add the DownloadController as an observer to the already paused download. BUG=900280 Change-Id: I58dd004b74e738cbe49db9b103357df2d0f52d3c Reviewed-on: https://chromium-review.googlesource.com/c/1311795Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604531}
-
Yutaka Hirano authored
Move SignalComplete and SignalError from DataPipeBytesConsumer to the class to separate them from BytesConsumer interface. Bug: 894815 Change-Id: Ib592ba7615c9c0d0fa24e9a9e1a7a07f56cca8ab Reviewed-on: https://chromium-review.googlesource.com/c/1304115Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
-
HyeockJinKim authored
Always call SetPlaceholderVisibility if !placeholder to prevent :placeholder-shown style from being applied Bug: 884696 Change-Id: I5f078dad825de91253bc99d133dc7978a59bbda3 Reviewed-on: https://chromium-review.googlesource.com/c/1292666Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: HyeockJin Kim <kherootz@gmail.com> Cr-Commit-Position: refs/heads/master@{#604529}
-
Findit authored
This reverts commit 0b5ca9b6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 604473 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGI1Y2E5YjY5NzIwMGVhNTdlMDQyMGJlYjE0N2Y0ZmE4ZmJkMTUzZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8644 Sample Failed Step: views_mus_unittests Sample Flaky Test: DesktopWindowTreeHostMusTest.WindowMoveShouldNotTransfersBack Original change's description: > Transfer touch events back to the original when the window move ends > > The current behavior makes TransferEventsTo() before the window > move starts, but don't care at its end. This causes errors like > crbug.com/900363. But we can't simply transfer back to the original > window unconditionally since someone (like TabDragController) may > also want to continue dragging on a window other than the original > source window. > > This CL introduces a new scoped class to control this; it makes > TransferEventsTo first, and then invokes TransferEventsTo back > again at the end, but it skips invoking the second transfer if > someone else also transfers the touch events on the same window. > > BUG=900363 > TEST=the new test case > > Change-Id: I81792872a13f0e4bb2c88b526c92cf689d656b71 > Reviewed-on: https://chromium-review.googlesource.com/c/1310501 > Commit-Queue: Jun Mukai <mukai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604473} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=900363, 900848 Change-Id: Ie326f3b57b2869b0981beb73344fbb530ca21721 Reviewed-on: https://chromium-review.googlesource.com/c/1312613 Cr-Commit-Position: refs/heads/master@{#604528}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be142178aaf6..eb2c6415a975 git log be142178aaf6..eb2c6415a975 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 mellem@webrtc.org Delete the default implementations of MediaTransportInterface methods. Created with: gclient setdep -r src/third_party/webrtc@eb2c6415a975 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7483c0b05684e4bf8f49d10e4861091707d60c98 Reviewed-on: https://chromium-review.googlesource.com/c/1312263Reviewed-by:
-
Joel Hockey authored
Map paths into the container as /mnt/chromeos/MyFiles/Downloads rather than /mnt/chromeos/Downloads to prepare for coming changes with MyFiles. Made all crostini mappings to use CamelCase for dir names. Bug: 878324 Change-Id: I7c1635dab406242d43d95ee7d44730ee11f6758f Reviewed-on: https://chromium-review.googlesource.com/c/1309555 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604526}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/628f0a57d102..c3b4b23f8816 git log 628f0a57d102..c3b4b23f8816 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 580baf379673..2197dc529052 (1 commits) Created with: gclient setdep -r src/third_party/skia@c3b4b23f8816 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Iab180d06ab0110ab4939f28fe88eb1fa3462c553 Reviewed-on: https://chromium-review.googlesource.com/c/1312265Reviewed-by:
-
Eliot Courtney authored
in the direction of initial movement and then locked on the axis off-screen and didn't dismiss if not. off-screen. screen doesn't allow a swipe-to-dismiss to initiate. the screen correctly disables initiation of another swipe-to-dismiss for the rest of the drag-to-move. Bug: 883114 Bug: 841886 Bug: b/115291749 Test: Added unittests Test: tried swipe-to-dismiss from all four corners, it started swiping Test: Tried swiping on the edges of the screen Test: Tried swiping around 50% area - correctly dismissed if >50% area Test: Popped back after swiping out with less than 50% of the area Test: Starting drag-to-move while not on the edge or corner of the Test: Starting to swipe-to-dismiss but then dragging into the middle of Change-Id: I350a8824a0d21162f7356a01632cd4787bd0392c Reviewed-on: https://chromium-review.googlesource.com/c/1221646 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
-
Eliot Courtney authored
We are looking for the minimum displacement of the PIP window that makes it not intersect any system trays or the floating keyboard. There are four cases for how the PIP window could move. Case #1: Touches 0 obstacles. This corresponds to not moving. Case #2: Touches 1 obstacle. The PIP window will be touching one edge of the obstacle. Case #3: Touches 2 obstacles. The PIP window will be touching one horizontal and one vertical edge from two different obstacles. Case #4: Touches more than 2 obstacles. This is handled in case #3. To handle all these cases, we just need to check a few candidate points. If the PIP window is displaced by one obstacle, the shortest displacement is to move along the horizontal or vertical axis to be directly adjacent to one of the edges of that obstacle. If it is displaced by two obstacles, the shortest displacement is to move to be directly adjacent to a horizontal and vertical edge - one from each obstacle. keyboard and unified system tray update, and the PIP window moved out of the way of both the floating virtual keyboard and unified system tray. Bug: 883118 Bug: 841886 Bug: b/115291749 Test: Added unittest Test: Patched in code calling GetPositionAfterMovementAreaChange on Change-Id: I2b500d5ba4a67fe2e309b809ec667248a19518ca Reviewed-on: https://chromium-review.googlesource.com/c/1221427 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
-
