- 27 Jun, 2018 40 commits
- 
- 
Ryan Sleevi authoredIn the long-ago times, OCSP stapling at the TLS layer was only enabled if the certificate verification layer would be able to use these OCSP responses as part of verification - which was true on Windows > XP and 'bleeding edge' versions of NSS at the time. However, this conditional enabling at the TLS layer has been long replaced with unconditional enabling, to support both Certificate Transparency (~2015) and Expect-Staple experiments. As a result, it's no longer necessary to report the platform capabilities to enable this optimization. BUG=none TBR=mmenke@chromium.org, bartfab@chromium.org Change-Id: Ia3c0d4cb161da47738ccb287a8286d6ce6248162 Reviewed-on: https://chromium-review.googlesource.com/1117034 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570862} 
- 
Andrew Grieve authoredNoticed that when d8.jar was updated recently, the dex was not rebuilt. This is because d8.jar was missing from the inputs list for md5check. Since inputs to dex.py are all generated files, it does not benefit from using md5check anyways (the main point of it is to not rebuild files when timestamps change to to changing git branches). Change-Id: Ia429556911bd6f9f0d276845ec614befea92dde0 Reviewed-on: https://chromium-review.googlesource.com/1117120Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570861} 
- 
Andrew Grieve authoredThe "overhead" symbols are often larger than most other individual symbols in a diff, but are completely unactionable. This moves them to the bottom of a diff so that they draw less attention. Bug: 702625 Change-Id: Iddb4f2a75a8807cafce62e223a64a69886f1d0b2 Reviewed-on: https://chromium-review.googlesource.com/1116071Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570860} 
- 
Sadrul Habib Chowdhury authoredAdd some more flow trace-events for the various stages during a frame. For example: . [client] Reception of BeginFrame (ReceiveBeginFrame). . [client] Generation of RenderPass, DrawQuad etc (GenerateRenderPass). . [client] Generation of CompositorFrame (GenerateCompositorFrame). . [client] Submission of CompositorFrame (SubmitCompositorFrame). . [server] Aggregation of surfaces from various clients in the DisplayCompositor (SurfaceAggregation). An example screenshot: https://imgur.com/a/ZJGfq2J BUG=855328 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iccb7b61d485b20256cc8f35a5a4efef4c8ed63ea Reviewed-on: https://chromium-review.googlesource.com/1116345Reviewed-by:Fady Samuel <fsamuel@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570859} 
- 
Peter Mayo authoredRevert "Truncate string attributes in the accessibility tree" This reverts commit db409e20. Reason for revert: <INSERT REASONING HERE> Original change's description: > Truncate string attributes in the accessibility tree > > Adds the helper function > BlinkAXTreeSource::TruncateAndAddStringAttribute, which truncates string > attributes when Blink's tree is serialized for accessibility. String > attributes are truncated at BlinkAXTreeSource::kMaxStringAttributeLength > bytes, currently set to 10000 bytes. > > Bug: 644805 > Change-Id: Ibd1af03a77814aa524dcb067ad1be3f3f4291c8b > Reviewed-on: https://chromium-review.googlesource.com/1113946 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570818} TBR=dmazzoni@chromium.org,dtseng@chromium.org,jamwalla@chromium.org Change-Id: Id8d54a3a1767d8fa75f54a9c0d954c44c376018f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 644805 Reviewed-on: https://chromium-review.googlesource.com/1117222Reviewed-by: Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570858} 
- 
Peter Mayo authoredRevert "[chrome_elf, third-party block support] Pass file path in registry." This reverts commit ea1974d4. Reason for revert: <INSERT REASONING HERE> Original change's description: > [chrome_elf, third-party block support] Pass file path in registry. > > Due to rare case of install_static::GetUserDataDir() path expansion, > this API cannot be used inside DllMain(). The full, expanded path to > the packed blacklist file will be dropped into install_static::GetRegistryPath(), > in the kThirdPartyRegKeyName subkey, in the kBlFilePathRegValue REG_SZ value. > This has no other impact on existing functionality. > > - This change includes comments, constants, and tests. > > - LogLoadAttempt() will now include the section path for any 'blocked' logs > as well. Friendly reminder that log.AddEntry() will still not add duplicate > 'blocked' logs, to protect against spammy logging. > > - Removed old bit of uninstaller touching old blacklist. > > Test: chrome_elf_unittests.exe, ThirdParty* > Bug: 769590 > Change-Id: Id9ada49215aa110db9fb72a4712da9d3fb7ccf31 > Reviewed-on: https://chromium-review.googlesource.com/1109600 > Reviewed-by: Robert Shield <robertshield@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570849} TBR=robertshield@chromium.org,tsepez@chromium.org,pennymac@chromium.org Change-Id: I8f734013213e0fa1e1321e3b573172ed9a85a649 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769590 Reviewed-on: https://chromium-review.googlesource.com/1117399Reviewed-by: Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570857} 
- 
Dmitry Gozman authoredThis is the only case when we don't even ask the client to decide the navigation policy, and it breaks a very nice assumption that DecidePolicyForNavigation is always called for renderer-initiated navigations. For reference: this was introduced [1] in 2002 (sic!) and being copied around since then. [1] https://chromium.googlesource.com/chromium/src/+/80834d145816195289a30e4168a0659380a00d75%5E%21/ Bug: 789577 Change-Id: Ic4a4671bcc34db46f70d53d4281d2ce68017ec1a Reviewed-on: https://chromium-review.googlesource.com/1114199Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570856} 
- 
Jacob Dufault authoredChange-Id: I1abf5400e9c3dea53d22e6c0142887d37ca5e5e3 Reviewed-on: https://chromium-review.googlesource.com/1115429 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570855} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/81f51975125c..42f0d78f1ee8 git log 81f51975125c..42f0d78f1ee8 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 titovartem@webrtc.org Roll back checking in the third_party directory 2018-06-27 mhoro@webrtc.org Revert two instances of num_active_spatial_layers. 2018-06-27 alexnarest@webrtc.org Allows audio bitrate allocation in video calls without enabling TWCC (Transport Wide Congestion Control as defined at https://tools.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01.html) for audio stream. Created with: gclient setdep -r src/third_party/webrtc@42f0d78f1ee8 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icdc652eb9deb1f121940060d7f912dc8bf492587 Reviewed-on: https://chromium-review.googlesource.com/1117139Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570854} 
- 
Nicolas Pena authoredThis CL adds a browsertest to ensure that performance.memory is not bucketized when sites are isolated. Change-Id: Icd6b1ee73a5f4e03f9e27c5f60d0cf741f66ba5c Reviewed-on: https://chromium-review.googlesource.com/1106306Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570853} 
- 
Torne (Richard Coles) authoredDon't print an error message if the address is invalid on Android, because Android uses UNIX domain sockets, which don't have an IP address. Bug: 854472 Change-Id: I169450b658fb22e036e70182dabc4e6193feacad Reviewed-on: https://chromium-review.googlesource.com/1108754 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570852} 
- 
Nasko Oskov authoredThe DebuggerNotAllowedOnOtherExtensionPages test navigates to non-existing URL and threfore results in an error. This CL fixes it to succeed and unblock isolating error pages. Bug: 838161 Change-Id: I38a8bb656fab0992d9343ba39a2c5f3da497c7fb Reviewed-on: https://chromium-review.googlesource.com/1117262 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570851} 
- 
pdfium-chromium-autoroll authoredhttps://pdfium.googlesource.com/pdfium.git/+log/bdf3f682d14d..2d7cb9267899 git log bdf3f682d14d..2d7cb9267899 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 tsepez@chromium.org Use unowned ptr for IFWL_ delegates Created with: gclient setdep -r src/third_party/pdfium@2d7cb9267899 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib724b6598fd450565305eac5f292548f2992412e Reviewed-on: https://chromium-review.googlesource.com/1117141Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570850} 
- 
Penny MacNeil authoredDue to rare case of install_static::GetUserDataDir() path expansion, this API cannot be used inside DllMain(). The full, expanded path to the packed blacklist file will be dropped into install_static::GetRegistryPath(), in the kThirdPartyRegKeyName subkey, in the kBlFilePathRegValue REG_SZ value. This has no other impact on existing functionality. - This change includes comments, constants, and tests. - LogLoadAttempt() will now include the section path for any 'blocked' logs as well. Friendly reminder that log.AddEntry() will still not add duplicate 'blocked' logs, to protect against spammy logging. - Removed old bit of uninstaller touching old blacklist. Test: chrome_elf_unittests.exe, ThirdParty* Bug: 769590 Change-Id: Id9ada49215aa110db9fb72a4712da9d3fb7ccf31 Reviewed-on: https://chromium-review.googlesource.com/1109600Reviewed-by: Robert Shield <robertshield@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#570849} 
- 
Bence Béky authoredUse CompletionOnceCallback instead of CompletionCallback in //net/quic/chromium. Most of these changes are private member types and method signatures, some are temporaries passed into already changed APIs, and in one instance an unused member is removed. In another instance, CompletionRepeatingCallback is used for a member that is expected to be used multiple times. Most affected callback members are already always run through ResetAndReturn, making it clear that it is safe to change type to CompletionOnceCallback. Bug: 807724 Change-Id: I94b57cec2db22bd91a09478b494185a48614266a Reviewed-on: https://chromium-review.googlesource.com/1116898 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570848} 
- 
Tommy C. Li authoredThis reverts commit 0830cdf0. Reason for revert: UX direction change. Original change's description: > Omnibox UI Refresh: Align Omnibox text to new Suggestion text > > The goal of the CL is to re-align the Omnibox text to match the new > Refresh spec. > > In the new Refresh spec, the text has a different indentation depending > on whether or not the popup is open, so this CL resets the insets > of the OmniboxViewViews whenever the popup opens or closes. > > It also updates LocationBarView to no longer ignore the left-inset > value of the OmniboxViewViews. We used to also ignore the right-inset > value, but we stopped doing that recently [1]. > > After no longer ignoring the left-inset value, we update the > non-Refresh value to the correct value of 0 (to keep things looking > the same), and update the Refresh value to 2, which matches mocks. > > We are updating the inset of the OmniboxViewViews textfield instead of > the bounds of the textfield because we want the whole area to remain a > clickable I-beam, even if we indent the text a bit. > > [1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc > > Bug: 849779, 823535 > Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4 > Reviewed-on: https://chromium-review.googlesource.com/1096491 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566834} TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 849779, 823535 Change-Id: Icf9e2f004042be6f25b9a86d23f269f5ebf0fd90 Reviewed-on: https://chromium-review.googlesource.com/1117218 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#570847} 
- 
bsheedy authoredUpdates the framebufferScale used by WebXR performance tests to correspond to the recommended scale and the 1:1 pixel mapping scale. The implementation was changed recently, but these values were not updated at the same time, causing the perf tests to render WebXR scenes at significantly lower resolution than before. Bug: 853400 Change-Id: I247682ea97ac5910d0195fdba1004698c4c0679b Reviewed-on: https://chromium-review.googlesource.com/1116190Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570846} 
- 
Tarun Bansal authoredThe hints are expected to get a bit more complicated, so move them to a separate file instead of an inner class. There is no loss in test coverage, but I am planning to add separate unittests file in a subsequent CL. Change-Id: I8c94ffc93de2e4b0e7e88c9c50344f499ab03cf3 Bug: 856243 Reviewed-on: https://chromium-review.googlesource.com/1116518Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570845} 
- 
Bence Béky authoredUse OnceCallback instead of Callback, and CompletionOnceCallback instead of CompletionCallback, in ChannelIDService. Also restructure ChannelIDService::JoinToInFlightRequest() to use early return if in flight request in not found. Bug: 807724 Change-Id: I45b55b0713ca9460fda8480d4f8ac14d5ead4435 Reviewed-on: https://chromium-review.googlesource.com/1117029Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570844} 
- 
Mike Frysinger authoredThe patch to the kernel that required this usage has been dropped, so we can drop this suid usage on CrOS now. Bug: 576409, 850457 Change-Id: I8ea9321f4f233618a239db62a1ecf7a132bc54c8 Reviewed-on: https://chromium-review.googlesource.com/1112815Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#570843} 
- 
Qiang Xu authoredchanges: * Move kTapToClickEnabled and kOwnerTapToClickEnabled handling to ash * In this CL, above pref registrations are still in chrome side because ash side doesn't have device owner info yet. TBR=stevenjb@chromium.org Bug: 817643 Test: manual and test coverage Change-Id: I6b11eb65a40968eada67ebf2e8b4fb3f1f0eaddc Reviewed-on: https://chromium-review.googlesource.com/1116210 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#570842} 
- 
Klaus Weidner authoredThe "GpuFence" and "SharedBuffer" WebXR render modes use a frame-separating GpuFence, the Renderer is supposed to do a server wait for that before the second and following frames. The "is this the first frame" status is tracked by xr_frame_transport, but the property wasn't being cleared correctly when exiting and re-entering VR, with the effect that it could end up erroneously waiting for a separating fence for the first frame. BUG=855722 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5508f184e4687d1b0a20d3da543cbbaf2e8535c1 Reviewed-on: https://chromium-review.googlesource.com/1115421Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#570841} 
- 
Eric Orth authoredInstead of relying on sleeping and the actual clock, use a mock taskrunner to simulate the passage of time. Makes the test more accurate and stable, and it also speeds things up significantly (~1.5s->60-70ms). Also convert ProcTask to use unique_ptr and WeakPtrs instead of ref counting to more cleanly cleanup the memory on completion instead of waiting for unused scheduled retries. Change-Id: I22b741d8b29d8eb419d125147ef98eba01c658e4 Reviewed-on: https://chromium-review.googlesource.com/1108078Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#570840} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/37b7e4714558..059a9ab4bcd0 git log 37b7e4714558..059a9ab4bcd0 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 egdaniel@google.com Revert "Make GrVkBackendContext no longer derive from SkRefCnt." 2018-06-27 caryclark@skia.org sync docs up with tip of tree 2018-06-27 bungeman@google.com Implement SkFontMgr_FontConfigInterface::onMatchFamilyStyle 2018-06-27 egdaniel@google.com Revert "Move Vulkan DebugCallback code into tools." 2018-06-27 jcgregorio@google.com Increase number of concurrent requests that fiddlecli makes to fiddle.skia.org. 2018-06-27 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 97bcdb1d73a1..4268c0b12bf2 (1 commits) 2018-06-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 82af620e0559..09303e448d17 (1 commits) 2018-06-27 egdaniel@google.com Revert "Let client pass in full extension to GrVkBackendContext." 2018-06-27 egdaniel@google.com Let client pass in full extension to GrVkBackendContext. Created with: gclient setdep -r src/third_party/skia@059a9ab4bcd0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ib7d9410881883d948ca5b6bd1f3f16336d8f34bc Reviewed-on: https://chromium-review.googlesource.com/1117238Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570839} 
- 
stkhapugin@chromium.org authoredShow a fake placeholder and hide the share button on the non-incognito new tab page. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1502112b15c60ad1f0844c71baa9461d87192423 Reviewed-on: https://chromium-review.googlesource.com/1115128Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570838} 
- 
Boris Sazonov authoredThis CL removes ARGUMENT_ACCOUNT from SyncCustomizationFragment and AccountManagementFragment. This was a fragment argument before https://crrev.com/1239083007, but now it's not used and can be safely removed. Bug: 856182 Change-Id: Ib6ce0050b6222ef39fbf25fd280218af2c4051ba Reviewed-on: https://chromium-review.googlesource.com/1114854Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#570837} 
- 
Matt Wolenetz authoredFor this interface method and implementation, adds comments, renames |type| parameter to |content_type|, and removes unnecessary .data() following Utf8(); all per CR comments on the recently added similar WebSourceBuffer::{Can}ChangeType() methods. BUG=605134 Change-Id: I0cd259a1a1508edff91287eb60b49721d61e9187 Reviewed-on: https://chromium-review.googlesource.com/1115578Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570836} 
- 
Muyuan Li authoredChange-Id: I7d632fe07f24f006c594da04b0648794d4293434 Reviewed-on: https://chromium-review.googlesource.com/1116283 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#570835} 
- 
Chris Lu authoredSet text color to a custom gray color and do not set the background color provided by the fallback style. Bug: 851390 Change-Id: I185b609577652f8b23a92d0dcc76a485fb967f28 Reviewed-on: https://chromium-review.googlesource.com/1112632 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570834} 
- 
Hector Carmona authoredThe flag made sense when developing initially to allow development on linux, but as we hit windows only bits, the flag no longer makes sense. Bug: 832938 Change-Id: I0a1da618114714bc82e0b6e20a2e31ed781a5e10 Reviewed-on: https://chromium-review.googlesource.com/1112710Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#570833} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/484f9f764dc5..e82ab88bd0dd git log 484f9f764dc5..e82ab88bd0dd --date=short --no-merges --format='%ad %ae %s' 2018-06-27 eyaich@google.com Removing benchmark_duration and benchmark_total_duration Created with: gclient setdep -r src/third_party/catapult@e82ab88bd0dd The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:856293 TBR=sullivan@chromium.org Change-Id: I4e6f6bf4cff7ae3585b8975415d6a2352667d371 Reviewed-on: https://chromium-review.googlesource.com/1117140Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570832} 
- 
Steven Bennetts authoredBug: 855251 Change-Id: Ic751c558b5f8ecb5a8334e2c5499ad9e1bbcf80e Reviewed-on: https://chromium-review.googlesource.com/1112759 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570831} 
- 
Mugdha Lakhani authoredThis will abort all ongoing fetches, and mark their data for deletion. Bug: 841385 Change-Id: I19eba7a294dd348c0c0a5324f3b23b438b571c03 Change-Id: I19eba7a294dd348c0c0a5324f3b23b438b571c03 Reviewed-on: https://chromium-review.googlesource.com/1103559 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570830} 
- 
lanwei authoredThere was an issue when we handled multiple touch pointer actions. SyntheticPointerAction should handle different actions from multiple touch pointers. Bug: 856638 Change-Id: I771181bcfe452631074c95874fd5c1a7807d3e74 Reviewed-on: https://chromium-review.googlesource.com/1113898 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570829} 
- 
Parastoo Geranmayeh authoredThe case where the first field was rationalized would crash. If the first field is rationalized, and we want to apply the rationalization to the fields before that, we would end up at the biggest unsigned int (since it's a size_t), which would cause a crash. Solution: If the first field is rationalized, we don't need to apply the rationalization to the fields before that obviously. Just return. Test added. Bug: 856962,857011 Change-Id: I0f4471e57fa0fa8bae9b7345ce774122f25e3410 Reviewed-on: https://chromium-review.googlesource.com/1117131 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570828} 
- 
Tiger Oakes authoredContinuation of work in bug 646094. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 846456 Change-Id: Ied7851bf95858ac7c9580c028cb11cf2b8290374 Reviewed-on: https://chromium-review.googlesource.com/1095984Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#570827} 
- 
Jacob Dufault authoredFix bad rebase. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1093882. TBR=xiyuan@chromium.org Bug: 839583 Change-Id: I70d994b15131404f479e3d0c1e585549fecbf6af Reviewed-on: https://chromium-review.googlesource.com/1115724 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570826} 
- 
David Roger authoredInvalidated cookies were not handled correctly. This CL adds proper support for them. TBR=treib Bug: 854799 Change-Id: Iad3ee729172a7e44d737b25fb665f0009d78de84 Reviewed-on: https://chromium-review.googlesource.com/1110218 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#570825} 
- 
Eli Ribble authoredThis is one more step towards making the bluetooth service fully async. Bug: 76155468 Test: chromecast/device/bluetooth::cast_bluetooth_unittests Change-Id: Icc9cc151fbf54c5686b56d40008f573fb85ea736 Reviewed-on: https://chromium-review.googlesource.com/1114221Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#570824} 
- 
Takumi Fujimoto authoredThis CL adds a dialog that will pop up when the Media Remoting feature is about to kick in, to ask the user whether the feature should be enabled. This CL just adds strings/layout, so the dialog is not functional yet, and the code path to open it is missing. Screenshot: https://drive.google.com/open?id=12CVIusU7nNR-uALCrRThnJMynZpPqU27 Bug: 849020 Change-Id: I3c85b62df495fc699e5b600a0dbb54808a198daf Reviewed-on: https://chromium-review.googlesource.com/1095571 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570823} 
 
-