GitLab

chrome fails to start with user namespace sandboxing:

[866:866:0120/134742:FATAL:zygote_host_impl_linux.cc(182)] Check failed: process.IsValid().
Failed to launch zygote process

With strace..

clone(child_stack=0x7ffd28fd98, flags=CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWNET|SIGCHLD) = -1 EINVAL (Invalid argument)

Which compared to kernel sources[1], shows that stack needs to be 16
bytes aligned. because stack grows downward, this patch assumes
PTHREAD_STACK_MIN is dividable by 16 too.

[1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L267

BUG=581018
R=keescook@chromium.org,jln@chromium.org,rsesek@chromium.org,thakis@chromium.org
TEST=base_unittests ProcessUtilTest.* and sandbox_linux_unittests NamespaceSandboxTest.*

Review URL: https://codereview.chromium.org/1617763002

Cr-Commit-Position: refs/heads/master@{#371809}

Most of our painting-related operations take place after fragmentation, i.e.
via PaintLayerPainter::paintFragmentWithPhase(). All such operations can just
sit back and relax and not worry about fragmentation, since translation and
clipping for a given fragmentainer (column) has already taken place.

This is not the case for filters, though. They are set up before fragmentation.
Therefore, we need to make the bounding box of the layer visual (convert out of
the flow thread coordinate space) on our own. We now do this specifically for
filters, or we'd upset other parts of the code, such as clip path.

BUG=530074
R=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1645583002

Cr-Commit-Position: refs/heads/master@{#371808}

This CL :
  * deletes is_hidden
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001 (http://crrev.com/1588093004#ps250001)

Review URL: https://codereview.chromium.org/1633203002

Cr-Commit-Position: refs/heads/master@{#371807}

This is a combined revert of
https://codereview.chromium.org/1491653002
and https://codereview.chromium.org/1614173002. One more
additional edit is the addition of
"testRunner.dumpAsText();" in canvas-toBlob-defaultpng.html
and canvas-toBlob-toDataURL-race.js.

Reason for this revert is that we found out idle-task
performs much better (has less negative impacts on other
activities) than threaded implementation on majority of
machines.

BUG=581574

Review URL: https://codereview.chromium.org/1637163002

Cr-Commit-Position: refs/heads/master@{#371806}

BUG=551995

Review URL: https://codereview.chromium.org/1646513002

Cr-Commit-Position: refs/heads/master@{#371805}

Remove status text "OK" from SpdyTestUtil::ConstructSpdyPush() and
SpdyTestUtil::ConstructSpdyPushHeaders(), because HTTP/2 bans the use of status
text.  Update net_unittests.

Review URL: https://codereview.chromium.org/1637033002

Cr-Commit-Position: refs/heads/master@{#371804}

[Password Manager] Enables processing invisible username fields even if visible password field was found.

BUG=554052

Review URL: https://codereview.chromium.org/1645493002

Cr-Commit-Position: refs/heads/master@{#371803}

Review URL: https://codereview.chromium.org/1643523003

Cr-Commit-Position: refs/heads/master@{#371802}

trace_event.h is redundant in header file. It also causes compilation
issues when Blink precompiled headers are used on Windows (Bug 495697).

BUG=

Review URL: https://codereview.chromium.org/1585693002

Cr-Commit-Position: refs/heads/master@{#371801}

This started out as the Mac counterpart to https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none

Review URL: https://codereview.chromium.org/1631283002

Cr-Commit-Position: refs/heads/master@{#371800}

Rather than having these tests being forced into the flaky bucket,
condition their execution on a new restriction. It has the nice
side-effect that one bad bot or configuration doesn't cause the test to
get disabled and hopefully these will be running *somewhere*.

Tested locally that the tests passed, then removed all updates to google
play services and they were ignored.
BUG=514449

Review URL: https://codereview.chromium.org/1582513003

Cr-Commit-Position: refs/heads/master@{#371799}

BUG=None

Review URL: https://codereview.chromium.org/1640003002

Cr-Commit-Position: refs/heads/master@{#371798}

BUG=561837

Review URL: https://codereview.chromium.org/1634043003

Cr-Commit-Position: refs/heads/master@{#371797}

BUG=none
R=yhirano,isherman,mkwst

Review URL: https://codereview.chromium.org/1612993003

Cr-Commit-Position: refs/heads/master@{#371796}

This was usually already an origin, and is used for security-sensitive
purposes such as de-duplicating permission bubble requests (see also
https://codereview.chromium.org/1610753002), so renaming it to GetOrigin
to be explicit.

BUG=577313

Review URL: https://codereview.chromium.org/1637913002

Cr-Commit-Position: refs/heads/master@{#371795}

This reverts commit 5897360a.

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581693

Review URL: https://codereview.chromium.org/1641573003

Cr-Commit-Position: refs/heads/master@{#371794}

https://chromium.googlesource.com/skia.git/+log/727b7d27afd0..f42fca4027ed

$ git log 727b7d27a..f42fca402 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 robertphillips Add gpu implementation of OverdrawXfermode GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
2016-01-26 caryclark move more geometry to simd

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1639303002

Cr-Commit-Position: refs/heads/master@{#371793}

The spec has changed and now all the implicit lines should be considered
when we're resolving named grid lines with an unknown name.

The relevant part of the spec is
(http://dev.w3.org/csswg/css-grid/#line-placement):
"If a name is given as a <custom-ident>, only lines with that name
 are counted. If not enough lines with that name exist,
 all implicit grid lines are assumed to have that name
 for the purpose of finding this position."

Modified the code to resolve named grid lines in GridResolvedPosition.
We need to keep the old behavior of considering "auto" unknown named
grid lines for the case of positioned grid items.

Updated current tests to the new expected behavior and created a new
test checking different cases explicitly.

BUG=442954
TEST=fast/css-grid-layout/grid-item-unknown-named-grid-line-resolution.html

Review URL: https://codereview.chromium.org/1576993003

Cr-Commit-Position: refs/heads/master@{#371792}

Ensure that ancestors that no longer need to track percentage descendants
after the split have them removed from their tracking lists.

BUG=568387

Review URL: https://codereview.chromium.org/1551573002

Cr-Commit-Position: refs/heads/master@{#371791}

BUG=

Review URL: https://codereview.chromium.org/1646483002

Cr-Commit-Position: refs/heads/master@{#371790}

Followup to https://codereview.chromium.org/1631073002/ to make sure
that the OnMessageReceived returns false for unhandled IPC messages.

BUG=558602

Review URL: https://codereview.chromium.org/1640263002

Cr-Commit-Position: refs/heads/master@{#371789}

We always create new animations with unique ids. So the removeAnimation(unique_id, target_property) call on adding a new animation is meaningless.

This change allows us to forward declare WebCompositorAnimation class for WebLayer interface.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1637083004

Cr-Commit-Position: refs/heads/master@{#371788}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/89d5fb66..aa81c816

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1643543002

Cr-Commit-Position: refs/heads/master@{#371787}

This cl will fix the bug reported at https://crbug.com/253465#c26.
With this patch, MediaMetadataRetriever can get the metadata of the local video file which is selected with the file input element.

BUG=253465

Review URL: https://codereview.chromium.org/1626283002

Cr-Commit-Position: refs/heads/master@{#371786}

BUG=410201

Review URL: https://codereview.chromium.org/1636613002

Cr-Commit-Position: refs/heads/master@{#371785}

Removes dependencies on chrome/ and content/ and moves the file to
components/omnibox/browser.

BUG=581108
TEST=None

Review URL: https://codereview.chromium.org/1635653002

Cr-Commit-Position: refs/heads/master@{#371784}

http://crrev.com/1623073003 introduced a bug where moveTos only update
the subpath point when immediately following a closePath.

This is incorrect: moveTos should always update the subpath point.

BUG=581451
R=fs@opera.com,pdr@chromium.org

Review URL: https://codereview.chromium.org/1635323002

Cr-Commit-Position: refs/heads/master@{#371783}

Changes to Skia polynomial evaluation caused a slight difference
in cubic path measure, causing a few tests to fail. Suppressing
these failures until they can be rebaselined.

R=fmalita@chromium.org
BUG=581661

Review URL: https://codereview.chromium.org/1645483002

Cr-Commit-Position: refs/heads/master@{#371782}

Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't ping the model after bubble destruction.

Rename some classes for good.

BUG=579726

Review URL: https://codereview.chromium.org/1645503002

Cr-Commit-Position: refs/heads/master@{#371781}

BUG=580113
TEST=e2e tests with replacing the current script with the new one.

For Chrome 50, the new version of cast_sender.js will be served that doesn't
use PresentationRequest.join("_receiver-action") to get the receiver action
event. Instead, the PresentationConnection is returned immediately after
the user picked a device for PresentationRequest.start() and the receiver
action message is sent back to the page via the corresponding MediaRoute.

This in particular means the route will exist without the CastSession and
some messages need to be handled by CastMediaRouteProvider, as well as queued
until "client_connected" is sent to the route.

Review URL: https://codereview.chromium.org/1614023002

Cr-Commit-Position: refs/heads/master@{#371780}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/deb8260a..89d5fb66

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1640203002

Cr-Commit-Position: refs/heads/master@{#371779}

The genereated Ogg/Opus files don't seem to play in Chromium (which uses
ffmpeg) while they do VLC or Gstreamer. Turns out we have the wrong flag
set on the OpusTags packet and a wrong size written for one of the strings.

BUG=none
TEST=play the generated file on Chromium

Review URL: https://codereview.chromium.org/1640703002

Cr-Commit-Position: refs/heads/master@{#371778}

A PeriodicWave object can use half a MB and v8 needs to know about that
or it will not schedule garbage collects when memory usage increases.

BUG=578351

Review URL: https://codereview.chromium.org/1632753002

Cr-Commit-Position: refs/heads/master@{#371777}

|ReplaceSelectionCommand| stores the inserted range after |doApply()|.
This range may be invalidated if |Editor::appliedEditing()| modifies the
DOM, causing spellcheck run on an invalid range.

This CL moves the spellcheck request into |Editor::appliedEditing()|
before dispatching any event, ensuring spellcheck run on a valid range.

BUG=580950
TEST=LayoutTests/editing/pasteboard/paste-webkit-editable-content-changed-crash.html

Review URL: https://codereview.chromium.org/1636883003

Cr-Commit-Position: refs/heads/master@{#371776}

Tiny bit of cleanup: Some timers used to be 'snapped' to an 'aligned'
fire time so that work would get batched, particularly when suspended
timers were rescheduled. This sort of thing is now the responsibility of the
scheduler; nobody is using Timer::alignedFireTime any more.

Because alignedFireTime had no tests :O no tests were harmed in the
preparation of this changelist. :D

BUG=331912

Review URL: https://codereview.chromium.org/1625413002

Cr-Commit-Position: refs/heads/master@{#371775}

A crash of crbug.com/537815 was due to an editable <p> as document.documentElement.
Supporting such invalid HTML structure is costly.  So we correct such HTML structure
before executing execCommands.

- We show a console warning if the autocorrection happens.
- After the autocorrection, document.write() doesn't work because the document tree
is complete.

BUG=537815

Review URL: https://codereview.chromium.org/1637323002

Cr-Commit-Position: refs/heads/master@{#371774}

This was an "alias" for -webkit-column-span:none. '1' is not a valid value,
according to the spec. The only valid values are 'none' and 'all'. In an older
version of the spec, '1' and 'all' were the valid values. In the latest version
(2011), '1' was changed to 'none'.

It's highly unlikely that removing this should cause compatibility problems.
The initial value is 'none' (which is what '1' was mapped to), so in order to
cause trouble, one would need a declaration -webkit-column-span:all to be
overridden by a -webkit-column-span:1. I went through httparchive to verify.
No sites were found to do this.

R=timloh@chromium.org

Review URL: https://codereview.chromium.org/1635993002

Cr-Commit-Position: refs/heads/master@{#371773}

If a ScriptRunner has been disposed of already, allow ScriptLoaders
to notify of their failure without asserting.

R=haraken
BUG=570012

Review URL: https://codereview.chromium.org/1644483002

Cr-Commit-Position: refs/heads/master@{#371772}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/45f7b52d..deb8260a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1636383002

Cr-Commit-Position: refs/heads/master@{#371771}

This CL removes the support for the CHROME_PROFILER_TIME env var,
originally introduced by crrev.com/9212025 more than 3 years ago, which
allows to change the time source for the profiler via the environment.
Reason for deleting it: could not find any active user of that.
See also discussion in project-trim@chromium.org @ goo.gl/p3GEUy .

After this CL (almost*) nothing outside of base depends on tcmalloc.
This is the place where we want to be, as base should be the only thing
knowing about allocator internals.

* There is only one dep left in content_child_helpers.cc, which is
relied on by old-style telemetry memory benchmarks. But that code is
literally a dead man walking and there is no point refactoring it.

BUG=564618, 581365

Review URL: https://codereview.chromium.org/1632253002

Cr-Commit-Position: refs/heads/master@{#371770}