- 03 Dec, 2017 2 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1ec99b9b8e27..d75f3f99d47b $ git log 1ec99b9b8..d75f3f99d --date=short --no-merges --format='%ad %ae %s' 2017-12-01 fmalita Fix SVGPong slide crash in Viewer Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Idff805c9e8eeb8ab6a3fffc4c5e26152ae9235d0 Reviewed-on: https://chromium-review.googlesource.com/804705Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521223}
-
Jungshik Shin authored
Explicitly disallows the following blocks. Latin Ext B (Pinyin subblock), Latin Ext D, Cyrillic Ext B/C, Greek Ext, Latin Additional (other than Vietnamese). Note that Latin Ext C & E, Cyrillic Ext A do not belong to [:IdentifierStatus=Allowed:] and need not be explicitly banned. 218 characters are blocked. In the Unicode set notation, they're [:IdentifierStatus=Allowed:] & [:Ll:] & [[\u01cd-\u01dc] [\u1c80-\u1c8f][\u1e00-\u1e9b] [\u1f00-\u1fff][\ua640-\ua69f][\ua720-\ua7ff]] Below are the number of domains blocked before and after this CL out of about a million .com domains as of 2017-11-30. 6400 : before this cl 7058 : after this cl 658 : additional domains blocked with this CL Bug: chromium:770709 Test: components_unittests --gtest_filter=*IDN* Change-Id: I4de1df5f79b43d9ceddfd01c7dd9af61d1a0e130 Reviewed-on: https://chromium-review.googlesource.com/802978 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521222}
-
- 02 Dec, 2017 38 commits
-
-
Wez authored
The test created an ASYNC-mode ScopedTaskEnvironment, but then applied expectations to it that are only valid in QUEUED (synchronous) mode. The test is fixed to use a QUEUED-mode instance. A brief delay is also added to the test, to make it more likely to fail if the behaviour regresses to being asynchronous & racey. Bug: 789712 TBR: gab Change-Id: I73808b1633bd7afcb6e0204a4030e16ef323f868 Reviewed-on: https://chromium-review.googlesource.com/804691Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521221}
-
Jamie Madill authored
Bug: 791289 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6f7f3da80dcbb6190e8a05b02e3eed535ac9c6fe Tbr: zmo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/804701Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#521220}
-
Wenzhao Zang authored
1) Removes the Chrome dependency of wallpaper decoding. 2) wallpaper_decoder.h is very similar to ash/login/ui/image_parser.h. 3) Aimed to introduce zero regression. The only difference with the current decoder is that some of the PostTask calls are removed. Bug: 789649 Change-Id: Ia13da24a8911d71d2c1d503f2160c58c8d781267 Reviewed-on: https://chromium-review.googlesource.com/801935 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521219}
-
Thomas Anderson authored
This reverts commit 978bcb16. Reason for revert: Broke linux msan builder: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/7457 Original change's description: > enable libaom > > Check out and build libaom by default. > > AV1 playback is still guarded by a flag. > > BUG=783519 > > Change-Id: Iac481ca03cc39b6241b3ffcf834689626c7e39f1 > Reviewed-on: https://chromium-review.googlesource.com/780581 > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521207} TBR=dalecurtis@chromium.org,johannkoenig@google.com Change-Id: I6e86090b9d56c5ccf6b3a30bcc57248aee945661 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783519 Reviewed-on: https://chromium-review.googlesource.com/804686Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521218}
-
Matthew Braithwaite authored
Most changes are cosmetic. Bug: 780299 Change-Id: I346ec1b6bd11ef20ef8018989b51c9c5842c4dee Reviewed-on: https://chromium-review.googlesource.com/701468 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#521217}
-
Erik Chen authored
Previously, DumpProcess would create a full trace, with metadata provided by ProfilingProcessHost, and write the result to a file. This duplicated functionality of DumpProcessesForTracing, which uses the Tracing service to create a fully-fledged trace. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibca11524f23b7fe8d9808370e05225298a0794a5 Reviewed-on: https://chromium-review.googlesource.com/798152 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521216}
-
Stuart Langley authored
This changes is for files in the path //t_p/WebKit/Source/core/loader/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: Ia142fe6223698056e1c2d74219ace9865ae4b419 Reviewed-on: https://chromium-review.googlesource.com/805014 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#521215}
-
Helen Li authored
This test hangs after crrev.com/518838 which added a new quic config option. This is the build where the test first started failing: https://ci.chromium.org/buildbot/chromium.perf/Linux%20Perf/2054 Bug: 788771 Change-Id: I5197a98612fc9c4f83655643b2e845b2c5477f0d Reviewed-on: https://chromium-review.googlesource.com/803950Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521214}
-
Stuart Langley authored
This CL deletes platform/wtf/WeakPtr.h and replaces and code that was still using it in WebKit/ with base::WeakPtr(Factory). In some cases the file was included but was not needed, so we just delete the header. Bug: 789697 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I60409333fb2cc49be475521b51b65c76824811d9 Reviewed-on: https://chromium-review.googlesource.com/798810Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#521213}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/713571f9afcf..1ec99b9b8e27 $ git log 713571f9a..1ec99b9b8 --date=short --no-merges --format='%ad %ae %s' 2017-12-02 angle-deps-roller Roll skia/third_party/externals/angle2/ 76746f9bc..d5f44c986 (1 commit) 2017-12-01 egdaniel Add cap on intel to avoid calling abs and floor on the same line in a shader. 2017-12-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 361df0703..76746f9bc (1 commit) 2017-12-01 herb Initialize dst image memory for small sigma 2017-12-01 bsalomon Revert "Revert "Fix rendering of drrects with small circular inner rrects."" 2017-12-01 bsalomon Exit from GLTestAtlasTextRenderer early if GL version is not supported. 2017-11-30 bsalomon Reland "Set multitexturing image threshold for PowerVR." 2017-12-01 csmartdalton Add Store3 to Sk2f 2017-12-01 robertphillips Add explicit GPU resource allocation of deferred proxies 2017-12-01 bsalomon Revert "Fix rendering of drrects with small circular inner rrects." 2017-12-01 caryclark fix pathops handling of tiny wrapback quads and cubics 2017-11-30 bsalomon Reland "Set multitexturing threshold for NVIDIA" 2017-12-01 bsalomon Fix rendering of drrects with small circular inner rrects. 2017-12-01 mtklein add OWNERS file 2017-12-01 liyuqian Try to bypass the false-positive clang thread analysis warning 2017-11-30 mtklein add Load2() to Sk4f 2017-12-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 5b18f487c..361df0703 (2 commits) 2017-12-01 halcanary Fuzz: RasterN32CanvasViaSerialization, 2017-12-01 caryclark working on skimage 2017-12-01 brianosman Remove more views code, just to simplify things 2017-12-01 brianosman Add 'Save to SKP' option to Viewer 2017-12-01 bsalomon Revert "Revert "Use a dst size threshold for multitexturing images."" 2017-12-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 035419fad..5b18f487c (3 commits) 2017-12-01 scroggo Add comments explaining use of "-Wno-over-aligned" 2017-12-01 brianosman Move some bits from views to sk_app 2017-12-01 angle-deps-roller Roll skia/third_party/externals/angle2/ da854a272..035419fad (2 commits) 2017-11-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 9f2a86134..da854a272 (1 commit) 2017-11-30 ethannicholas fixed a few SPIR-V generation errors 2017-11-30 benjaminwagner Remove IntelIris640 bot. 2017-11-30 reed remove read/write rawpixels 2017-11-30 scroggo Revert "Renaming and refactoring to prepare for init-once threaded backend" 2017-11-30 angle-deps-roller Roll skia/third_party/externals/angle2/ e218f15fc..9f2a86134 (1 commit) 2017-11-30 reed encode kAlpha_8 as grayalpha with sigbits for gray==1 2017-11-30 scroggo Add "-Wno-over-aligned" to Android.bp for x86 Android 2017-11-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 97fa85579..e218f15fc (1 commit) 2017-11-30 liyuqian Renaming and refactoring to prepare for init-once threaded backend 2017-11-30 robertphillips Revert "Enable explicit GPU resource allocation" 2017-11-30 bsalomon Revert "Use a dst size threshold for multitexturing images." 2017-11-30 bsalomon Revert "Set multitexturing threshold for NVIDIA" 2017-11-30 bsalomon Revert "Set multitexturing image threshold for PowerVR." 2017-11-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 18841310d..97fa85579 (1 commit) 2017-11-30 robertphillips Enable explicit GPU resource allocation 2017-11-30 bsalomon Set multitexturing image threshold for PowerVR. 2017-11-30 bsalomon Set multitexturing threshold for NVIDIA 2017-11-30 robertphillips Flesh out SkSurfaceCharacterization 2017-11-29 liyuqian Add a GM to test the fix in 73200 2017-11-30 benjaminwagner Promote experimental tryjob to be blocking. 2017-11-29 bsalomon Fix SkInternalAtlasTextContext to update advance the flush token after issuing each draw. 2017-11-29 csmartdalton Add "lazy" texture proxies 2017-11-30 kjlubick Turn up Nexus10 CPU frequencies 2017-11-29 mtklein bug fix in matrix color filter 2017-11-30 bsalomon Use a dst size threshold for multitexturing images. 2017-11-30 hcm Update Skia milestone to 65 2017-11-30 robertphillips Add a GrContextThreadSafeProxy to SkSurfaceCharacterization 2017-11-30 kjlubick Make cpu scaling more robust 2017-11-29 csmartdalton Make sure to visit clips and dst proxies during gather Created with: roll-dep src/third_party/skia BUG=789812,769026 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I18df2567ff439a1fdd21851d24333a5b5f5431ab Reviewed-on: https://chromium-review.googlesource.com/805216Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521212}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/76746f9bc29d..d5f44c986038 $ git log 76746f9bc..d5f44c986 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 oetuaho Simplify parsing struct field declarators Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I3b8849bdba7b65534d293ee79223dd69f1160ad7 Reviewed-on: https://chromium-review.googlesource.com/805215Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521211}
-
Zhongyi Shi authored
it is running with. QUIC Connection Migration: add a label in each URLRequest to indicate connection migration mode it's running with so that URLRequest and associated QuicSession can be differentiated in a single NetLog if multiple CronetEngines with different experiment configurations are running at the same time. Bug: 774622 Change-Id: I003f0ac83efbec7ac41d16a83ef5d0230d4aa7d1 Reviewed-on: https://chromium-review.googlesource.com/804296Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521210}
-
Yuki Shiino authored
There are misuse or undesired use of bindings APIs in the codebase, and this patch fixes them. This is a resulting work of my review after https://crbug.com/788453 . Bug: Change-Id: I7bb0e20ee9b4593ce1a37354abfc9852fc69352a Reviewed-on: https://chromium-review.googlesource.com/802613Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#521209}
-
Wenzhao Zang authored
All the temporary code have been explicitly marked as TODO. Those without the mark is the 'permanent' code. 1) Replace RemoveUserWallpaper with a mojo call via |WallpaperControllerClient|. 2) Add additional directory paths in |SetClient| and rename it to |SetClientAndPaths|. 3) Add additional unit tests for |WallpaperController|. TBR=jdufault@chromium.org Bug: 779221 Change-Id: Ife3bc79b4c353ed9d7e6e0332a9bf048cef3bbf6 Reviewed-on: https://chromium-review.googlesource.com/776216 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521208}
-
Johann authored
Check out and build libaom by default. AV1 playback is still guarded by a flag. BUG=783519 Change-Id: Iac481ca03cc39b6241b3ffcf834689626c7e39f1 Reviewed-on: https://chromium-review.googlesource.com/780581 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521207}
-
Xianzhu Wang authored
- Add SetLayerState for MaskLayer (using LocalBorderBoxProperties plus Mask), BackgroundLayer and DecorationOutlineLayer (using LocalBorderBoxProperties()). - Ensure property update on GraphicsLayer tree structure change. - Add default layer state for page overlay layer. Bug: 790548 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I72df09089d11d76afc34072371523a404412f32e Reviewed-on: https://chromium-review.googlesource.com/802254 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521206}
-
Emil A Eklund authored
Bug: 720287 Change-Id: I5f4d92c4049035634614d5103cc9c719e55b0cad Reviewed-on: https://chromium-review.googlesource.com/803901 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521205}
-
Findit authored
This reverts commit 1cb7ac27. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 521202 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFjYjdhYzI3ZDVjN2IxYjUxYzNiYzExOGM4OWYwYmVjYzUxMzE0OGMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20%28dbg%29/115798 Original change's description: > ResourceLoadScheduler: add traffic monitoring metrics > > This patch adds TrafficMonitor to count number of resource > requests and bytes of received data. Data are counted > per-frame basis, and classified by main frame vs sub-frames, > and throttled vs not-throttled. > > Bug: 789354 > Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff > Reviewed-on: https://chromium-review.googlesource.com/795482 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521202} Change-Id: I1e51232d6ff3f974b2447c3890d45e606af751f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789354 Reviewed-on: https://chromium-review.googlesource.com/804976 Cr-Commit-Position: refs/heads/master@{#521204}
-
Mark Pearson authored
This was broken by https://chromium.googlesource.com/chromium/src/+/31c2066fb04ade8b1474c27054f425fe8a72d04f Tested interactively using repro steps on bug. Also re-enables programmatic test for this bug. Bug: 789913 Change-Id: I43a59ef112da6f1e69c30a46c55586d5f9280f41 Reviewed-on: https://chromium-review.googlesource.com/804676 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521203}
-
Takashi Toyoshima authored
This patch adds TrafficMonitor to count number of resource requests and bytes of received data. Data are counted per-frame basis, and classified by main frame vs sub-frames, and throttled vs not-throttled. Bug: 789354 Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff Reviewed-on: https://chromium-review.googlesource.com/795482 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521202}
-
Christopher Grant authored
With the new DMM scaler class, element sizes can be represented in DMM. The URL bar subtree should move over to match the editable omnibox, to avoid mismatches. Other elements can follow. This change should functionally not change anything. The loading indicator is a little odd in that it tries to position itself between other non-planar elements, but DMM helps here. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6fd1beb0a23038afafbc6a6fb44e182a356a4f91 Reviewed-on: https://chromium-review.googlesource.com/803913 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#521201}
-
Yunchao He authored
BUG=782317 TEST=bots Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I96ae1e737dc2ce91a08c930110bc7bf16ce97bbf Reviewed-on: https://chromium-review.googlesource.com/804684 Commit-Queue: Yunchao He <yunchao.he@intel.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521200}
-
Xianzhu Wang authored
Getting all selected tests in a single line is a frequently used feature. However, it needed several clicks/keystrokes to get it: 1. Choose plain wrapped format (2 clicks); 2. Ctrl-A 3. Ctrl-C 4. Choose the previous format because we can do nothing else useful with the plain wrapped format (2 clicks). With the new button, we can copy the selected tests in a single line by one click. BTW also added one click copy of the tests in the current format (which can be also done with Ctrl-A + Ctrl-C). Change-Id: If1e7fcc12c799c384a0759b4dbd00b5df1aed6cb Reviewed-on: https://chromium-review.googlesource.com/804735Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521199}
-
Philip Rogers authored
InspectorLayerTreeAgent::BuildLayerTree assumed there was a root scrolling layer but this is not true with root layer scrolling if there is no scrolling present. This patch changes the code to not assume a root scrolling layer exists, fixing many crashes. devtools/layers/layer-scroll-rects-get.js now no longer crashes and the RLS/non-RLS difference is present in the new expectation because the test does not scroll the root layer. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: Ia2c6c2a2a8e2e11d840151b9fbe8d3cb54acb063 Reviewed-on: https://chromium-review.googlesource.com/804828Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521198}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I1c1ea7e2a0e09f5afd36e6ccbda5d11dd566b0a3 Reviewed-on: https://chromium-review.googlesource.com/804561Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521197}
-
Mike Baxley authored
This class was copied into 4 different egtest files. Move it to a shared location where it can be re-used. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I729755a9b211374a301923d2b9777a3ede2ca17c Reviewed-on: https://chromium-review.googlesource.com/779943 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521196}
-
Alexey Kozyatinskiy authored
With this change user can update return value when paused at return position. Bug: chromium:656150 Change-Id: I8e31799461be21d839e256cc63f8bf8748875fc1 Reviewed-on: https://chromium-review.googlesource.com/802695 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521195}
-
Xianzhu Wang authored
Previously we always re-created the whole CompsositorFilterOperations in FragmentPaintPropertyTreeBuilder::UpdateFilter(). Because we don't have value-comparing == operator for reference filters, re-created reference filter wouldn't equal to the previous one even if there was no actual change in the filter, causing we always treated a FilterPaintPropertyNode as changed when it was updated. This caused different results for some layout tests with DCHECK enabled and disabled, because forced update by FindPropertiesNeedingUpdate forced re-creation of CompositorFilterOperations. We can't use CompositorFilerOperations::EqualsIgnoringRefrenceFilters() when detecting paint property change because it will cause false negatives. It requires much code to implement deep value-comparing == operator for reference filters, and the comparison would be also expensive. It's also unnecessary to re-create CompositorFilterOperations then detect its change if the filter style and reference box don't change. Now let PaintLayer record filter changed status. If the filter and the reference box didn't change, we reuse the cached CompositorFilterOperations. In this way we simply use the current pointer-comparison of reference filters. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8a872270c10562d8243ce46c3d2861c83531c074 Reviewed-on: https://chromium-review.googlesource.com/791919Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521194}
-
Chris Mumford authored
There are several uses (some indirect) of base::File which either use errno or ::GetLastError() when the file open fails. Indirect users (like callers of CreateTemporaryFileInDir()) don't have access to File::error_details(). Setting errno, or calling ::SetLastError() to enable these clients to properly handle/log the cause of failure. Bug: none Change-Id: Ifc580068a08ce8e726faa645468c1e9b1c57936c Reviewed-on: https://chromium-review.googlesource.com/802617Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#521193}
-
tzik authored
This CL allows empty functors on base::BindOnce and base::Repeating, and adds base::BindLambdaForTesting that is a test-only variant of Bind that binds any callable object to a RepeatingCallback. Bug: 789805 Change-Id: I7fa34acd2a6b79e8c26d3f6ded67e91bd8d6b966 Reviewed-on: https://chromium-review.googlesource.com/798817 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521192}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership complex. After this CL, the clock instances are always un-owned by injectees. Instead, an injecter owned one is used on testing, and the shared instance is used on production path. Bug: 789079 Change-Id: Ic91e3cbb16c8d66131936b6b4c6e74ed212602c2 Reviewed-on: https://chromium-review.googlesource.com/803154Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#521191}
-
Zhenyao Mo authored
It doesn't make sense we open the lib and create a subset of bindings and use our own code to do context related GPUInfo collection. We should just use the same code on any other platforms. We saw a surge of crashes related to this piece of code, my suspicion is the current code path isn't doing the right thing. Let's see if we switch path and order, situation changes. BUG=787737,738414 TEST=bots R=piman@chromium.org,kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If1e094faa38777c051d6e8fa559d133cce444c1a Reviewed-on: https://chromium-review.googlesource.com/804659Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521190}
-
Steven Bennetts authored
This change does two things: 1. Improves error handling to ignore InvalidNetworkGuid errors which may happen e.g. when a device is disabled. 2. Uses 'set' to property update an active network state and notify observers. Bug: 781776 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37e584870c63676a885d19167f1c2bdadf7be6b3 Reviewed-on: https://chromium-review.googlesource.com/804595Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521189}
-
Alex Moshchuk authored
This CL adds several process model tests for hosted apps and tries to keep same-site iframes in the hosted app's process. There are additional ways to improve --site-per-process behavior around hosted apps (e.g., same-site popups), but this CL doesn't address them yet. This CL is a continuation of creis@'s https://chromium-review.googlesource.com/c/chromium/src/+/792605. Bug: 718516 Change-Id: I10c6ecc6799aa92bbd789efb5e8dcfebd1aa90da Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/798120 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521188}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/c8947ecc4964..c796cbc3a6e6 $ git log c8947ecc4..c796cbc3a --date=short --no-merges --format='%ad %ae %s' 2017-12-01 rnephew [Telemetry/TADA] Make TADA parser return structured data instead of dictionary. 2017-12-01 nednguyen Fix startup browser breakage when clear_sytem_cache_for_browser_and_profile_on_start is set Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9660ec3acb5116decaef72cbecddd43195c52fe7 Reviewed-on: https://chromium-review.googlesource.com/804938 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521187}
-
Wenzhao Zang authored
Migrate |SetOnlineWallpaper| (used by wallpaper picker) to WallpaperController. The goal of the CL: 1) Make sure not to introduce regression in |WallpaperManager| under Config::CLASSIC. (Have to use some 'hacks' within |WallpaperManager| to avoid forking the code.) 2) MASH does not crash when setting wallpaper, but it won't be able to save wallpaper. The wallpaper newly set during an active session will be lost when the session ends. TBR=brettw@chromium.org Bug: 779221 Change-Id: I7b6f1d1d95a8a4b0ad20d31bc4dcc957207f246e Reviewed-on: https://chromium-review.googlesource.com/770711Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521186}
-
Hiroshige Hayashizaki authored
According to TODO comments, it can be removed as Issue 594645 was already closed as fixed. Bug: 594645, 779730 Change-Id: I2e7c2722023624d580a4f300c4aa520f2be895ab Reviewed-on: https://chromium-review.googlesource.com/794016Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521185}
-
kapishnikov authored
An invocation of StreamFactoryImpl::JobController::ResumeMainJob() may be posted with a delay. During the delay, the pending jobs (including the main job) can be canceled. This CL adds a check that the main job is still alive before resuming it. This change may also fix 790776. BUG=789560,790776 Change-Id: I16ac35e44c1b894794b03f1c4561664a56f1eb11 Reviewed-on: https://chromium-review.googlesource.com/805034Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#521184}
-