- 12 Mar, 2018 40 commits
-
-
Helen Li authored
This CL adds TCP socket API to network service. This is partly based on mandoline implementation (https://codereview.chromium.org/1873463003/) Two TCP socket interfaces are added. - TCPConnectedSocket - TCPServerSocket TBR=miu@chromium.org Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64 Reviewed-on: https://chromium-review.googlesource.com/868711Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#542606}
-
Tien-Ren Chen authored
Similar to the previous alike-titled CL "[Blink] Avoid O(n) lookup during scroll parent computation", this CL changes CompositingInputsUpdater to keep track of clip chain information in recursion context for different type of positioned descendants to achieve O(1) lookup. And conveniently workaround crbug.com/817175 BUG=818768,817175 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib8bb76eb219a7056d6488484cc8439d44e7d7aac Reviewed-on: https://chromium-review.googlesource.com/956503 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542605}
-
Greg Thompson authored
Also: - Update the code to use PathService to get various locations. - Check both per-user and per-machine locations for Desktop shortcuts. - Remove stale comments and replace a stale constant with its documented name. - Perform expensive checks outside of the critical path to startup. BUG=none R=tmartino@chromium.org Change-Id: Ib8e4cdb91def96660095fbfbb18ae59e77d8e8da Reviewed-on: https://chromium-review.googlesource.com/955655Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#542604}
-
Anna Offenwanger authored
Bug: 791130 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7d9ab135ce43d7670b04083437889caacad93874 Reviewed-on: https://chromium-review.googlesource.com/949052Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#542603}
-
Daniel Murphy authored
Bug: 782356 Change-Id: I426c455e028fb70fa86eb39ba0d651bddf3cad2f Reviewed-on: https://chromium-review.googlesource.com/930241Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#542602}
-
Lukasz Anforowicz authored
http/tests/devtools/appcache/appcache-iframe-manifests.js: - This test was associated with crbug.com/678481 and that bug is now fixed, and the test-related expectation has already been removed from LayoutTests/TestExpectations in r527386 http/tests/media/autoplay/document-user-activation-* - These tests are flaky regardless of site-per-process and are already covered by LayoutTests/TestExpectations. This CL just extends TestExpectations entry to also cover Win. external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html - New bug has been opened prior to this CL: https://crbug.com/819800 external/wpt/fullscreen/api/element-ready-check* - New bug has been opened prior to this CL: https://crbug.com/820617 external/wpt/css/css-fonts/font-display/font-display.html - This test is simply slow and often takes more than 5 seconds to finish - see https://crbug.com/816026#c7 - The timeout of this test is (since 2018-03-12) covered by the main LayoutTests/TestExpectations (see r542490). Other entries removed by this CL simply seem to have "healed" themselves and are currently passing on the waterfall and on the tryjobs. Bug: 477150, 794631, 678481, 788390 Bug: 819800, 820617, 788390, 801992 Change-Id: If24ec321df9593ab217f50b7f1b39b3496faceef Reviewed-on: https://chromium-review.googlesource.com/957683 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542601}
-
Donn Denman authored
This is a reland of the commit listed below, with a fix for a missing dependency that was causing an intermittent compile error. TBR=yfriedman@chromium.org, kinuko@chromium.org BUG=820262, 754862 Original change's description: > [TTS] mojo-ify ShowUnhandleTapUIIfNeeded. > > Replaces the whole call chain for ShowUnhandledTapUIIfNeeded > between Blink and Chrome/WebView with Mojo messaging. > > Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo > that sends a Mojo construct of the same name to the Browser which > has a service installed via a RenderHostFrame observer. > > All functionality should remain unchanged. > > NEW CODE: > The CSTabHelper now creates an UnhandledTapWebContentsObserver that > connects the Mojo service via UnhandledTapNotifierImpl. That Impl > calls back through Java to the CSTabHelper to the CSManager to notify > that a Tap has occurred. The CSTabHelper ignores these notifications > when CS is disabled. > > The mojo message is only sent to the browser if the tap is unhandled > and the other required conditions are met. > > UPDATED TESTS: > Test notification is now done through mojo messaging, so we now only > know if the tap was unhandled, not whether the page changed or other > details about why the tap was unhandled. > > Updated the test page by adding nodes that do not trigger, and removed > the mousemove handler since it's unrelated to tap handling. > > BUG=754862 > > Change-Id: I18111f2537cfb16a4523d7f0cc766037fbf6050a > Reviewed-on: https://chromium-review.googlesource.com/841544 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540629} Change-Id: I91f1a3a6b6cfd410b49187beed94fc2191cae928 Reviewed-on: https://chromium-review.googlesource.com/957443 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542600}
-
Michael Giuffrida authored
Dumps symbols for app_shell to a file called "app_shell.breakpad.x64", which official builders will soon start uploading to the crash server. Also moves the logic for extracting Chrome Linux symbols into a new "extract_symbols" GN template at //build/linux/extract_symbols.gni. Bug: 818078 Change-Id: I68bafd10860040e105fde7abeddd52f35f12d07e Reviewed-on: https://chromium-review.googlesource.com/957981Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542599}
-
Jiaquan He authored
When we set a whole truck of model data to Ash, every item will have its folder id set properly. This may fail in the folder id checks in AddItemToFolder and AddItemToFolderItemAndNotify. Bug: 733662 Change-Id: I6d33353c6dd068be016da7d3af679c2f31a86b03 Reviewed-on: https://chromium-review.googlesource.com/958023Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#542598}
-
Antonio Gomes authored
Code in //ui/ozone/platform/wayland/fake_server.cc|h is quite convoluted today. This a 1/n of a series of patches that clean it up. CL adds a GetUserDataAs templatized function, where the actual type is passed in. BUG=None Change-Id: Ie4d5ceb006c8c4d5fb7efb9a2fc3873b1f29ddf0 Reviewed-on: https://chromium-review.googlesource.com/959481 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#542597}
-
Balazs Engedy authored
This is a reland of 0588d062, as it was concluded not to have been the culprit for the compile breakage. Original change's description: > Introduce a generic ScopedU2fDiscoveryFactory override. > > -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a > base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory > derive from that. > -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could > not care less about when a discovery starts, add a version of the fake > discovery where SimulateStarted()/SimulateStopped() is called automatically. > > Bug: 785955 > Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a > Reviewed-on: https://chromium-review.googlesource.com/959001 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542507} TBR=jdoerrie@chromium.org Bug: 785955 Change-Id: I4c9f42d81793567b6536d303f8a4d020fbe147d9 Reviewed-on: https://chromium-review.googlesource.com/959322 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542596}
-
Richard Bustamante authored
This tests fails commonly due to additional range requests happening that turn out to be expected. After discussion we decided the 2 response verification doesn't make sense and should be removed. See comment 8 in the bug. Bug: 809161 Change-Id: I57c60520c7a74a03cec3fff9e22dd1311ef78b47 Reviewed-on: https://chromium-review.googlesource.com/959452Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Richard Bustamante <bustamante@google.com> Cr-Commit-Position: refs/heads/master@{#542595}
-
Jonathan Backer authored
It's no longer necessary now that GpuImageDecoderCache does not rely on RasterInterface. Change-Id: I914f2ece1c7ff7b8a98dbf6e2b7100be0631e228 Reviewed-on: https://chromium-review.googlesource.com/956403Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#542594}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibc0839322eb9abf33ad10898670281969e71bb04 Reviewed-on: https://chromium-review.googlesource.com/959457Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#542593}
-
Maria Khomenko authored
The call to fetch Instant Apps status can read off disk occasionally. Ensure we're not doing that on UI thread. Bug: 819504 Change-Id: I2484081be656018a5e67cf273471a88fa07c724c Reviewed-on: https://chromium-review.googlesource.com/957449Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#542592}
-
https://pdfium.googlesource.com/pdfium.git/+log/83a01491dbd9..0c6b98182403 $ git log 83a01491d..0c6b98182 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 rharrison Remove all usages of FXSYS_iswASCIIspace Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3b6e323d2b7618b9138e4b2eebba39e762aedea9 Reviewed-on: https://chromium-review.googlesource.com/959386 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542591}
-
Devlin Cronin authored
In manifest v1, page actions had support for different keys, including a list of icons (instead of a single icon), "popup" (vs "default_popup"), "name" (vs "default_title"), "type" (deprecated), and "id" (deprecated). Remove parsing support for the deprecated keys. Update unit tests to manifest v2 where applicable, and remove manifest v1-specific tests. Bug: 816677, 816679 Change-Id: Id4db2558e0f5b9006c89a0f3ef89aed230a7b359 Reviewed-on: https://chromium-review.googlesource.com/953179Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542590}
-
https://skia.googlesource.com/skia.git/+log/cf81fa995f38..24f25dc8bca7 $ git log cf81fa995..24f25dc8b --date=short --no-merges --format='%ad %ae %s' 2018-03-12 herb Move ComputeAxisAlignmentForHText to Rec. 2018-03-12 reed move blur impl into core 2018-03-12 kjlubick Add oss-fuzz endpoint for PathMeasure 2018-03-12 robertphillips Temporary patch for Mus/Viz 2018-03-12 herb Expose SkGlyphCache's alloc 2018-03-12 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 391bda23b..e98b1b5d4 (4 commits) 2018-03-12 reed fix writeImage when encode step fails, since data is null 2018-03-12 herb Make SubpixelAlignment public 2018-03-12 herb Remove unused SkAutoGlyphCache constructor 2018-03-12 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ e5ac7a7c8..3ca91a31d (1 commit) 2018-03-12 bungeman SkReadBuffer.h shouldn't include itself. 2018-03-12 brianosman Remove SK_SUPPORT_LEGACY_ADOBE_XYZ Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie3388d65099b65f1974c44dbba639992df3977da Reviewed-on: https://chromium-review.googlesource.com/959356Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542589}
-
Michael Spang authored
Change-Id: Id0c1bf82488905578d0ed1cac0fd498ff118b2c4 Reviewed-on: https://chromium-review.googlesource.com/958230Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542588}
-
Evan Stade authored
Bug: none Change-Id: Id4c4d26cd02c673b820a4b2cfcdcb226ac1f2759 Reviewed-on: https://chromium-review.googlesource.com/958092Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#542587}
-
Michael Thiessen authored
This reverts commit 2702f2e5. Reason for revert: Making fixing DLAs on P too difficult. Will reland once P issues are fixed. Original change's description: > Reland "VR: Use isInVrSession API to keep Chrome in VR until user has left VR" > > This reverts commit 0e39bd62. > > Original change's description: > > Revert "VR: Use isInVrSession API to keep Chrome in VR until user has left VR" > > > > This reverts commit dc55fd14. > > > > Reason for revert: Suspected to have broken chrome_public_test_vr_apk on main waterfall > > https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Phone%20Tester%20%28rel%29/?limit=200 > > first failing build contains this cl: > > https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Phone%20Tester%20%28rel%29/3088 > > > > Original change's description: > > > VR: Use isInVrSession API to keep Chrome in VR until user has left VR > > > > > > This fixes the Daydream Dashboard issues so that if Chrome is simply > > > stopped/started in VR without any intents, Chrome stays in VR. > > > > > > Also makes resuming Chrome from DD home way faster if Chrome was > > > already in VR. > > > > > > Bug: 780887 > > > Change-Id: Iab7f713bfc5b85972f908ea141e3b495297d7286 > > > Reviewed-on: https://chromium-review.googlesource.com/944547 > > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#540403} > > > > TBR=mthiesse@chromium.org,ymalik@chromium.org > > > > Change-Id: I7ae67f5d23d816796cc7f567792e181900b3012a > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 780887 > > Reviewed-on: https://chromium-review.googlesource.com/946709 > > Reviewed-by: Benjamin Pastene <bpastene@chromium.org> > > Commit-Queue: Benjamin Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#540588} > > TBR=mthiesse@chromium.org,ymalik@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 780887 > Change-Id: I690474b0dd7b8dff7e7a5b2dbd036b0f97eacb52 > Reviewed-on: https://chromium-review.googlesource.com/949083 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540950} TBR=mthiesse@chromium.org,ymalik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 780887 Change-Id: If259e45f972b4ccc24e39304ca2e1a683f295059 Reviewed-on: https://chromium-review.googlesource.com/958020 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542586}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe2035ca. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13765 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I20a325811671c02273b763cc36fa7ae31b49379e Reviewed-on: https://chromium-review.googlesource.com/959146 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542585}
-
Christopher Cameron authored
Do not set the ui::Compositor's LocalSurfaceId until after it allocated, which is done by resizing its aura::Window. Just changing the order of the calls breaks the behavior of UpdateRootWindowSizeInPixels. This is a function that specifies pixels and commits the sin of not specifying a device scale factor. It needs a DSF, so it grabs one from the ui::Compositor (which now is out of date). To fix this, snapshot the device scale factor from the display::Display in OnHostResizedInPixels, where it should have been specified to begin with. This opens up the question of why the value of OnHostResizedInPixels is not snapshotted itself, so add comments indicating this potential source of inconsistency. While exploring that rabbit hole, some surface invariant violations in DesktopWindowTreeHost were also discovered, so add comments to remember them. Bug: 818085 Change-Id: I88d5b59e031ef6c57b5a7ef778540ae4a8b95bc8 Reviewed-on: https://chromium-review.googlesource.com/958329Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#542584}
-
Adam Langley authored
The replacement attestation certificates didn't provide a self-signature because nobody can validate our certificates. However, fastmail.com expects to be able to parse an ECDSA signature even if they don't check it. Therefore this change provides a syntactically valid signature in the certificate and fixes enrollment on fastmail.com Bug: 821099 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I332e078227eb36ba81e4cb089bd1f63ceb0bcbea Reviewed-on: https://chromium-review.googlesource.com/959304Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#542583}
-
Steven Bennetts authored
In preparation for supporting OpenVPN.ExtraHosts, we need to support string arrays in network-property-list. Some issues with policy indicators were discovered as well. This CL: * Adds support for an editable StringArray type. * Only shows policy indicators for fields that may be user editable. (Other indicators just provide noise). * Treats properties with no entry in policy controlled configurations as not user editable. Bug: 742666,819837 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I601e4cc0839bd1560bd1dc5af099aba3b19623dc Reviewed-on: https://chromium-review.googlesource.com/955934 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#542582}
-
Steven Bennetts authored
This adds some additional network configuration logging: * Logs an error when fields are stripped from an ONC configuration since this indicates an incorrect policy or UI configuration. * Adds additional logging during configuation (an uncommon event) to help track down the source of configuration failures. Bug: 742666 Change-Id: I9db246c953e2e0f47c82f1069b226f91434c1f90 Reviewed-on: https://chromium-review.googlesource.com/955928Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542581}
-
Patrick Monette authored
It was possible to have repeated call to OnFocusChangedEvent() between the time the name was written in the search box, and the actual destruction of the automation controller, which unregisters the event handlers. Bug: 819792 Change-Id: Ied95051f7ebb07e954b8c5d7d3cff0d3e7574daa Reviewed-on: https://chromium-review.googlesource.com/955744 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#542580}
-
Robert Iannucci authored
R=nodir@chromium.org Bug: 811974 Change-Id: I5959edc280c02937b66417ea035f8012feb5bb33 Reviewed-on: https://chromium-review.googlesource.com/958038 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#542579}
-
Benjamin Pastene authored
Bug: 817779 Change-Id: If4599943937ea5c628bfc3cc96f5df9b9b4065f1 Reviewed-on: https://chromium-review.googlesource.com/959345Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#542578}
-
Dale Curtis authored
Clients don't care about these copies once they destroyed the pool; we also don't want to waste resources copying these unused frames after Reset(). BUG=801245, 820685, 820944 TEST=updated tests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I15ccf0c5a00b14e87522f923c4ec9c93416d9342 Reviewed-on: https://chromium-review.googlesource.com/958042 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#542577}
-
liberato@chromium.org authored
Some devices seem to be sending multiple EOS output buffers to MCAD, which doesn't handle them well. This CL makes it possible for a MediaCodecLoop client to signal an error when an EOS buffer arrives, to transition MCL into the error state safely. Bug: 818866 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic40b2a10ee4d983be28211b18ee9268a379f13d5 Reviewed-on: https://chromium-review.googlesource.com/957642Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#542576}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbbe951b..fc5740ae Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4ed1484c2f676f72325c39e74702f4a01d93afa1 Reviewed-on: https://chromium-review.googlesource.com/957920Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542575}
-
Robert Liao authored
Browser unhandled keyboard event forwarding was added for 130131, but is incompatible with the way Mac dispatches events. Views unhandled keyboard event forwarding was added for 145184 and should be the main way to cover this scenario for all platforms. BUG=130131,145184,820208 Change-Id: Ia6fd96b6059a5b5932e186299a0769b6a931c356 Reviewed-on: https://chromium-review.googlesource.com/957975Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#542574}
-
Daniel Cheng authored
This method doesn't really make sense on Frame, as it is a property of a LocalFrame. Putting it on Frame implies that there are situations where it would return true for RemoteFrame, but that acn never happen. There are a few places that walk all frames in the frame tree looking for local roots and thus need to do an extra IsLocalFrame() check now: - PropagateZoomFactorToLocalFrameRoots: visits all the local roots in a frame tree to update the zoom factor. - DidExitFullscreen: this one is slightly unusual in that it only notifies the *topmost* local root. - FocusedOrMainFrame: arguably wrong and should be removed. If there are a more instances in the future of needing to walk the frame tree for all local roots, it might be worth adding a helper. Change-Id: Ie4f9a5ffc4b9b50331a7139b2c4935de53875659 Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/959230Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542573}
-
Michael Thiessen authored
This reverts commit 848f0ea0. Reason for revert: Reland after reverting enums.xml change Original change's description: > Revert "VR: Remove VR Launch Intents flag" > > This reverts commit c83231b7. > > Reason for revert: Should not have removed flags from enums.xml > > Original change's description: > > VR: Remove VR Launch Intents flag > > > > This flag was really only for development while we weren't sure how to > > handle VR Intents. With Chrome VR browsing already shipped, there's no > > reason not to allow Intents to launch it. > > > > Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f > > Reviewed-on: https://chromium-review.googlesource.com/959051 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542508} > > TBR=yfriedman@chromium.org,mthiesse@chromium.org > > Change-Id: I6b92369c483f7f0d8a11290bb9a50f6cfd1ea766 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/958021 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542550} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Iadb349fe60ea6a3a843228f3a4dcf24c6b9f9589 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/958103 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542572}
-
Adrienne Walker authored
Bug: 820399 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6911388373a2e12397db9ae2d995c9769cd10033 Reviewed-on: https://chromium-review.googlesource.com/958335Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542571}
-
Khushal authored
For PaintRecord backed shaders, skia performs the rasterization of the shader's record at the required scale before tiling. In order to decode images in these records using cc's decode cache, we create a temporary SkPicture with images replaced with decodes from cc's cache and use that in a new SkPictureShader each time the PaintShader is rasterized. Skia internally maintains a cache of rasterized pictures used in these shaders, keyed on the SkPictureShader's uniqueID. Since a new SkPictureShader is created for each raster call, we don't get a cache hit in skia and end up re-rasterizing the shader's record. The ideal solution for this would be to maintain a PaintShaderCache which caches rasterized records. But given the rarity of these cases, its not worth duplicating skia's picture cache. However, if any of the images in these records are animated, they must go through cc's decode stack to update them and use cached animation frames. The change ensures that we only decode shaders in cc if they have animated images. Note that the performance hit of re-rasterization of records in these cases will still exist. R=chrishtr@chromium.org, enne@chromium.org, ericrk@chromium.org Bug: 817640 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd1f3db9902f21fca20c99be1cf9e36b54cd7085 Reviewed-on: https://chromium-review.googlesource.com/952529 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542570}
-
https://pdfium.googlesource.com/pdfium.git/+log/735eda96cf24..83a01491dbd9 $ git log 735eda96c..83a01491d --date=short --no-merges --format='%ad %ae %s' 2018-03-12 hnakashima Fix crash when creating a CFX_DIBitmap with FXDIB_Invalid. 2018-03-12 rharrison Add test that non-ASCII characters to not foul hyphen processing Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8ba1dafad38e6148569cad231238be54fa3796bf Reviewed-on: https://chromium-review.googlesource.com/958332 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542569}
-
Farah Charab authored
Change-Id: I78a42bdb82f83b0d64386def369253ef4087bbe5 Reviewed-on: https://chromium-review.googlesource.com/955857Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#542568}
-
Sonny Sasaka authored
This adds sender='<name>' filter as the match rule for subscribing to signal in ObjectProxy. This is needed to reduce the unnecessary polluted log of rejecting some signals. The manual sender verification is still needed because as mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=507206#c14 service_name_ might be empty and sender='' means to not filter by sender at all. BUG=chromium:812468 TEST=Tested on device and checked that communications to D-Bus services (e.g. power, bluetooth) don't break Change-Id: I0ef4e03b5d9d8aa4412ef97286b971c30f458e99 Reviewed-on: https://chromium-review.googlesource.com/958324Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#542567}
-