- 20 Nov, 2018 40 commits
-
-
Ben Pastene authored
Should have enough bots. R=jbudorick, dpranke Bug: 902468 Change-Id: If699354b2747c77a11741972fe8b531d9d500234 Reviewed-on: https://chromium-review.googlesource.com/c/1344689Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#609841}
-
Thomas Guilbert authored
The RemotePlaybackAppLauncher CL was reverted due to a regression (see cb04d0bc). Since the revert, needs have changed, and we no longer need a fully dynamically chosen app ID. This CL adds the ability to define a custom RemotePlayback app ID from the AndroidManifest, which can be overriden downstream. The info is stored in a static field, since it does not change at runtime. Bug: 790766 Change-Id: I2b2d466304234f4c07a4b617dc336f936aabc585 Reviewed-on: https://chromium-review.googlesource.com/c/1334660 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609840}
-
Qiyu Hu authored
Deadcode Bug: 111367421 Test: CQ Change-Id: I51d4f187aacd6f9594f74c612ca49d1e99d62a09 Reviewed-on: https://chromium-review.googlesource.com/c/1338089Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#609839}
-
Tom Anderson authored
These were only needed for GTK2, which we've since dropped support for. BUG=None R=sky Change-Id: Ibbceaad8230361b7f114c96f489433cc77ef13f7 Reviewed-on: https://chromium-review.googlesource.com/c/1344877Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#609838}
-
Carlos Knippschild authored
Allows the offline content list on the dino page to be collapsed by the user, mirroring the UX used on the NTP for collapsing the list of suggested articles. These two collapsible lists also share the same PrefsService setting so that the expanded/collapsed state of one is reflected on the other. This also fixes a small issue with the background color appearing between a suggestion image and its border. Bug: 852872 Change-Id: I47ed7abaa777fe233ec79153a033482812ae478a Reviewed-on: https://chromium-review.googlesource.com/c/1318630Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#609837}
-
Thomas Tangl authored
If the unified consent feature is disabled, always show the "Enhanced spell check" toggle. Bug: 905470 Change-Id: I0fde90d956945a4089db4cfad95475635b94dc58 Reviewed-on: https://chromium-review.googlesource.com/c/1344050Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#609836}
-
Thomas Tangl authored
- The unified consent master toggle is removed from the "Sync and Google services" settings page. - The UnifiedConsentGiven pref is removed from settings. - The sync-everything toggle is added under the sync section. Bug: 906031 Change-Id: I01c82cba206d2c98c053864226907cb9663f1796 Reviewed-on: https://chromium-review.googlesource.com/c/1342557 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Katie D authored
Set the --enable-experimental-accessibility-features flag to never expire. This flag is used by multiple a11y features and will continue to be used for the forseable future. Change-Id: I18cf355e1116a69c87c45928e250295eeb2787b3 Reviewed-on: https://chromium-review.googlesource.com/c/1340783 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609834}
-
Xiaoqian Dai authored
The CL is to improve the smoothness of tab dragging in tablet mode. See before video with two heavy web pages: https://drive.google.com/open?id=1aN02WfhPo-qd33EzQgbTQUSYpoAupXm_ and after video with two heavy web pages: https://drive.google.com/open?id=1GjJteBEu29Q_8i8zubRyYbXYgA9Mkm_g Bug: 896015 Change-Id: I90612120c370e391d003beb463da087fa378bfac Reviewed-on: https://chromium-review.googlesource.com/c/1330834Reviewed-by:
-
Sam McNally authored
Currently, the hover color for dialog ok buttons is not set, so it falls through to the default button color, which varies depending on whether check-select is applied to the body. This causes hovering to make the text color dark instead of remaining unchanged. Set the color for both with and without hover to avoid this. Bug: 842130 Change-Id: I67a02346a7aa173de91ac41366cbdd5057e9e6c3 Reviewed-on: https://chromium-review.googlesource.com/c/1345169 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609832}
-
Evan Stade authored
BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview This test was disabled due to flake (classic Ash), which I can't repro now. But while it was disabled, it quit passing because some updates to the test broke it, and because the home launcher now means that tablet mode affects the visibility of caption buttons. This fixes the test for all configurations including multi process Mash. Bug: 818170 Change-Id: Ia0a029f52872b84f6ce6d37c1e433719c243eb56 Reviewed-on: https://chromium-review.googlesource.com/c/1327529Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Christian Biesinger authored
Change-Id: Iec7f382006b6215b6ac1b847722511f66ff82db2 Reviewed-on: https://chromium-review.googlesource.com/c/1344200Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Change-Id: I29dbfa090291d933582fdeaece594808dea5e046 Reviewed-on: https://chromium-review.googlesource.com/c/1344580Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#609829}
-
Eric Foo authored
Bug: 868202 Change-Id: Iee7e12d9aa5a1575d542739b99f351589f1ebb76 Reviewed-on: https://chromium-review.googlesource.com/c/1341241Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609828}
-
Robert Liao authored
This test works fine on Linux. BUG=161902 TBR=sky@chromium.org Change-Id: Idaefa2f3f0f1544af4f28ba6e43b211b7a368e0f Reviewed-on: https://chromium-review.googlesource.com/c/1344216Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#609827}
-
Xi Cheng authored
Bug: 701944 Change-Id: Idf06f127aba7d4a50fa23d631ff78604b3a57258 Reviewed-on: https://chromium-review.googlesource.com/c/1342672Reviewed-by:
-
John Chen authored
Fixing a JavaScript code syntax error in the code intended to cause a two frame wait before dispatching touch events. Bug: chromedriver:2665 Change-Id: I7a69a58500fdae5fdb45ab836eb96c054f8e54b9 Reviewed-on: https://chromium-review.googlesource.com/c/1340582Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609825}
-
Tommy C. Li authored
We have launched this to Stable some time ago. Bug: 900255 Change-Id: I52ea22c451cee3b0bf7df67710978ef272f781ae Reviewed-on: https://chromium-review.googlesource.com/c/1343366 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609824}
-
Mohamed Heikal authored
The Protobuf Java Lite runtime is now separate from the main java runtime. This cl adds the java lite runtime to the repo. In a follow up Bug: 782237 Change-Id: I9f4af1736006ab224dc4230d3a071290974135b8 Reviewed-on: https://chromium-review.googlesource.com/c/1338574Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f1238bc..2ecd5f54 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0cec98aac943d42f6fdcf4d3c6f42812beab8a37 Reviewed-on: https://chromium-review.googlesource.com/c/1344253 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609822}
-
Kevin McNee authored
A GinPort's onDisconnect may invalidate the context (e.g. MessagingApiTest.MessagingBackgroundOnly). Attempting to invalidate the events throws an exception which interferes with the extensions JS testing framework. Now the framework can call more of the safe builtins without triggering the exception, so we do so here. Bug: 803668 Change-Id: I07aa962ba689174a4f35885c72a9c3318256ff50 Reviewed-on: https://chromium-review.googlesource.com/c/1342068Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#609821}
-
Adam Langley authored
There has been confusion about the third-party review process. Try to clarify that chromium-third-party is about licensing review, that the reviewers may simply leave a comment, and that they are not expected to be able to approve a change. Change-Id: I8461f9b416f8d76542230beb770a2cf8f5c44d6f Reviewed-on: https://chromium-review.googlesource.com/c/1338477Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#609820}
-
Jacob Dufault authored
- Remove the webui lock screen tests. - Re-enable flaky test since it should no longer flake because there is no longer webui involved. Bug: 899777 Change-Id: I759ad6d20a08ad48e6a992fcfca9a25572ad16a5 Reviewed-on: https://chromium-review.googlesource.com/c/1327163 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609819}
-
Maggie Chen authored
Screen capture on protected videos will no longer work after software protected videos are supported. This CL handles YUVVideoDrawQuad only. The other part of the support on the gpu side was checked in separately. The main change in this CL is to replace the existing flag |is_protected_video| with |protected_video_type| which includes clear, softwareProtected and hardwareProtected. NOTE: Before this CL, |PROTECTED_VIDEO| means hardware protected video. After this CL, |PROTECTED_VIDEO| means both software and hardware and |HW_PROTECTED| will differentiate whether it's protected by software or hardware. Bug:903552 Change-Id: I8c025bdcbafaed224a5e1f9ea6fa14b42bdfe192 Reviewed-on: https://chromium-review.googlesource.com/c/1334099Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609818}
-
Matt Menke authored
I migrated it to the network service's pref files a year or so back, but didn't realize unregistered prefs weren't automatically pruned from preference files, so never deleted the old entries. Given that this pref can be quite large, it definitely needs to be pruned. Bug: 715695 Change-Id: Ia9f1592a5064cdcdfe22bf144c5c5e66a272ec9d Reviewed-on: https://chromium-review.googlesource.com/c/1344989 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#609817}
-
John Budorick authored
This reverts commit 7d53bc24. Reason for revert: still referenced by cq.cfg. Original change's description: > Remove incorrect named builders ("_" underscores) > > Bug: 868202 > Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138 > Reviewed-on: https://chromium-review.googlesource.com/c/1343081 > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Eric Foo <efoo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609559} TBR=hinoka@chromium.org,efoo@chromium.org,jbudorick@chromium.org Change-Id: Ic530f835ef9367cda18f54be54dc712d3f229ded No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868202 Reviewed-on: https://chromium-review.googlesource.com/c/1345234Reviewed-by:
-
David Benjamin authored
I've left expiry milestones alone for now. tls13-variant should hopefully be unwound quite soon. enforce-tls13-downgrade will depend a lot on how long it takes to clear through the mess of non-compliant Enterprise middleboxes out there. Bug: none Change-Id: Iecdfd86618de36a2ba949f3eb472010fff3d5f24 Reviewed-on: https://chromium-review.googlesource.com/c/1344578Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
-
Ken Rockot authored
Migrates some miscellaneous stuff from ServiceContext and ServiceTest over to ServiceBinding and plain old unit tests. Introduces new TestService and TestServiceManager helpers for such unit tests to use. This ultimately provides similar functionality to the old ServiceTest framework but with much less hidden magic and only a marginal increase in per-test boilerplate. Bug: 895616,906239 Change-Id: I5c4958f92092ee435efe2c83eaa371f1171a71d4 Reviewed-on: https://chromium-review.googlesource.com/c/1343372 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
edchin authored
Change-Id: Id201ca6aba14146bcea4456bd4353c376e38e860 Reviewed-on: https://chromium-review.googlesource.com/c/1341246 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609813}
-
Ken Rockot authored
This switches the IME and Assistant services to use ServiceBinding instead of deprecated ServiceContext & EmbeddedService APIs. Also moves their tests off of the deprecated ServiceTest framework and changes them to be simple unit tests. TBR=dcheng@chromium.org Bug: 891780,906239 Change-Id: I047fd3879da1c4eb89643717cd3d247cf638ef9b Reviewed-on: https://chromium-review.googlesource.com/c/1343037Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#609812}
-
Giovanni Ortuño Urquidi authored
SystemTrayNotifier will be removed, so move the observer list direclty into TrayBluetoothHelper. Bug: 882346 Change-Id: I316a43cc98d879003e378e01994e40038e557f93 Reviewed-on: https://chromium-review.googlesource.com/c/1343588Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609811}
-
Robert Sesek authored
This also removes some now-unused Cocoa control classes in //ui/base and several unneeded resources. Bug: 739386, 832676 Change-Id: I9289cc5613c4303521aaed9271ddc7574e2611a0 Reviewed-on: https://chromium-review.googlesource.com/c/1343055Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609810}
-
Gabriel Charette authored
Friend'ing specific methods is incorrect since the addition of GetIfExits() because, although clang compiles this without warnings, the spec clearly says that friend'ing an undeclared method is not allowed (even if no such method ever exists and hence never uses that friend declaration). Not nearly all singletons need to support GetInstanceIfExists() and hence adding everywhere is undesired. This CL makes Singleton<T> friend all of T. This is fine because that doesn't give much more power to T (beyond the option of naming its GetInstance() method differently...). Bug: 905990 Change-Id: I2d2c721b27f8f3fa3367dff996f37293c98674c3 Reviewed-on: https://chromium-review.googlesource.com/c/1343660Reviewed-by:
-
Etienne Pierre-doray authored
[TaskScheduler]: Migrate off of ScopedAllowWait in /content/browser/renderer_host/text_input_client_mac.mm base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 766678 Change-Id: I39a4449295407eaf1016cbfdb1e5b8842f1dda7c Reviewed-on: https://chromium-review.googlesource.com/c/1325206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c6195df99b92..44bef83f2be0 git log c6195df99b92..44bef83f2be0 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 lamontjones@chromium.org signing: KeyPair filename extension cleanup Created with: gclient setdep -r src/third_party/chromite@44bef83f2be0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifcc618b9310f5e99ace7f98e084161f02a5cb3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1342954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609807}
-
Michael Lippautz authored
tl;dr: Write barrier elimination in ctors requires white-allocation of objects. Longer: Avoid scheduling GC calls during object allocation (construction) as they would potentially invoke V8 marking steps. Such a marking step is problematic if the object that is currently being constructed has already been published as constructors rely on white-allocation of objects in order to avoid write barriers for initializing stores. A call to V8 may trigger a marking step which in turn may mark an object black if it already has been published. Bug: 903790, 843903 Change-Id: I9ede36f34f074f76b563601fd4bd1dcb30f561c4 Reviewed-on: https://chromium-review.googlesource.com/c/1341997 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#609806}
-
Zhiqiang Zhang authored
Most of the tests are migrated from CastMessageHandlerTest. Some new tests are added as CafMessageHandler has more methods than CastMessageHandler: * testHandleClientConnectMessage* * testHandleClientDisconnectMessage* * testHandleClientLeaveSessionMessage* * testSendReceiverActionToClient * testBuildSessionMessage* Bug: 711860 Change-Id: I821bb91f0c685809c143b60cc4700c47ffec16b6 Reviewed-on: https://chromium-review.googlesource.com/c/1343292 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#609805}
-
Luum Habtemariam authored
Per (https://sites.google.com/a/chromium.org/dev/flag-ownership), we need to tag our chrome flags with owners. Bug: N/A Change-Id: I31b90d6cc736e48edd37982c267ce8d2094b8b42 Tests: Regressions pass Reviewed-on: https://chromium-review.googlesource.com/c/1344581Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afe4ec5b3170..5db7ecf7859e Created with: gclient setdep -r src-internal@5db7ecf7859e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I302d191c435115f3647a92d5b357ac8c70f17c70 Reviewed-on: https://chromium-review.googlesource.com/c/1343852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609803}
-
liberato@chromium.org authored
Previously, 'Learner' was a roll-up trainer + model, intended to make it easy for clients to use the learning system. However, since LearningSession can do this too, it makes sense to split the model apart from the particular training algorithm used to build it. Change-Id: If207bf64c6a5b34fb84591b9b149bdd9a3ff6af4 Reviewed-on: https://chromium-review.googlesource.com/c/1327544Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609802}
-
