GitLab

BUG=101996
TEST=NA
TBR=dimich@chromium.org


Review URL: http://codereview.chromium.org/8568018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=PPAPI tests still pass (perhaps even less flakily)


Review URL: http://codereview.chromium.org/8468017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101774
TEST=NONE


Review URL: http://codereview.chromium.org/8527015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110202 0039d316-1c4b-4281-b951-d872f2087c98

Added Media.URLScheme histogram.

BUG=none
TEST=manual observation of chrome://histograms/Media


Review URL: http://codereview.chromium.org/8468011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=FindInPageControllerTest.FindMovesWhenObscuring on windows, linux_chromeos and aura bots.

Review URL: http://codereview.chromium.org/8573012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110200 0039d316-1c4b-4281-b951-d872f2087c98

The window gets removed in RemovedFromWidget, so it is not necessary to do
this again in NativeViewDetaching. This fixes a couple of failing DOMViewTest
tests.

BUG=103487
TEST=DOMViewTest.TestRemoveAndDelete, TestReparent (browser_tests)

Review URL: http://codereview.chromium.org/8574016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110198 0039d316-1c4b-4281-b951-d872f2087c98

After improving v8 API to allow us to pass in an extension source string
length field, use that to refer directly to the in-image source rather
than copying it and holding it in memory, thus saving memory.

It bums me out that I have to call GetRawDataResource() twice, but I don't s
a way around that without abandoning inheritance from v8::Extension and
switching to composition/delegation.

Moved DEPS for v8 to r9534, the newest to include r9365. I don't know whethe
this matches our convention; perhaps we always move DEPS to the latest.

BUG=95147
TEST=relying on existing extensions unit tests, which all still pass.


Review URL: http://codereview.chromium.org/8277020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110197 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110196 0039d316-1c4b-4281-b951-d872f2087c98

Fix to v8-i18n was submitted in http://codereview.chromium.org/8570009

BUG=104011
TEST=Load crash1.html from bug report and check it doesn't crash browser. 
Review URL: http://codereview.chromium.org/8573014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110195 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8520021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110194 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit_tests --gtest_filter=BookmarkBarGtkUnittest*
R=sky@chromium.org


Review URL: http://codereview.chromium.org/8568011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110193 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8463031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Original review: http://codereview.chromium.org/8136027/
Review URL: http://codereview.chromium.org/8520011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8554001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110189 0039d316-1c4b-4281-b951-d872f2087c98

No longer using libcros to call the method.  Part of libcros removal.
Instead chrome will call the method directly.

BUG=chromium-os:16558
TEST=none
Signed-off-by: Simon Que <sque@chromium.org>

R=satorux@chromium.org,stevenjb@chromium.org,tbarzic@chromium.org


Review URL: http://codereview.chromium.org/8566024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103999
TEST=see bug
Review URL: http://codereview.chromium.org/8570015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110187 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8510074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100276
R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8551002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110185 0039d316-1c4b-4281-b951-d872f2087c98

Linux directory detection is now done in the driver instead of in the frontend, so let the plugin test script invoke the driver instead of clang -cc1 (else it won't find <string> etc on linux).

Previous attempt at http://codereview.chromium.org/8538027/

BUG=104323
TEST=none
TBR=hans


Review URL: http://codereview.chromium.org/8572021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110184 0039d316-1c4b-4281-b951-d872f2087c98

   
This failure path has not received a lot of testing until now.  Here are
the issues addressed by this patch:
    
- We usually check the return value of step() calls.  However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step().  This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().
    
- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure.  This will allow us to test these
error paths.
    
- Be careful in ShutdownOnSyncThread().  The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database.  The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was.  However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore.  If this code
were to get executed it would put us into an inconsistent state.  See
issue 103824.  However, it's unlikely this code would get executed.  If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().
    
- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails.  Such a failure could
be due to bad local state.  We don't know the actual cause because the
information is not available from the ProfileSyncService callback.  The
safe course of action is to clear our local sync state and try again
later.  It's the easiest way to get back to the most well travelled sync
initialization path.

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase

Review URL: http://codereview.chromium.org/8496002

TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/8570016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110182 0039d316-1c4b-4281-b951-d872f2087c98

r=rvargas
bug=102940
Review URL: http://codereview.chromium.org/8487004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110181 0039d316-1c4b-4281-b951-d872f2087c98

Initialization of the profiler is supposed to happen while
single threaded.  The tests however often skip affirmative
initialization, and rely on lazy initialization.  This
CL tightens up that process, to reduce changes of races
(even benign races) during testing.

I also added a suppression for examination of the state,
which is always a benign race.  At initialization time
we rely on a lock (now) to ensure race freedom (if we
get a racy value of state).

r=rtenneti
Review URL: http://codereview.chromium.org/8570007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110180 0039d316-1c4b-4281-b951-d872f2087c98

This solves the problem when chrome.windows.create() is used to create a panel with a tabid. Panel was watching for NOTIFICATION_TAB_ADDED, which is only sent upon browser navigation. As there is no navigation when existing tab contents are used, the Panel does not set up auto-resize in this scenario.

BUG=None
TEST=PanelBrowserTest.CreateWithExistingContents

Review URL: http://codereview.chromium.org/8539025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/8571015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110178 0039d316-1c4b-4281-b951-d872f2087c98

   
This failure path has not received a lot of testing until now.  Here are
the issues addressed by this patch:
    
- We usually check the return value of step() calls.  However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step().  This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().
    
- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure.  This will allow us to test these
error paths.
    
- Be careful in ShutdownOnSyncThread().  The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database.  The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was.  However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore.  If this code
were to get executed it would put us into an inconsistent state.  See
issue 103824.  However, it's unlikely this code would get executed.  If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().
    
- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails.  Such a failure could
be due to bad local state.  We don't know the actual cause because the
information is not available from the ProfileSyncService callback.  The
safe course of action is to clear our local sync state and try again
later.  It's the easiest way to get back to the most well travelled sync
initialization path.

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase

Review URL: http://codereview.chromium.org/8496002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tfarina@chromium.org

Review URL: http://codereview.chromium.org/8570013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110175 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=72188

I've refactored backer's swizzle/flip code as it was needed by compositor_cc as well as compositor_gl.

BUG=None
TEST=compositor_unittests

Review URL: http://codereview.chromium.org/8463024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110174 0039d316-1c4b-4281-b951-d872f2087c98

These updates keep CF casts between CFTypeRef and specific CoreFoundation types consistent across the project.

BUG=104200

Review URL: http://codereview.chromium.org/8528013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110173 0039d316-1c4b-4281-b951-d872f2087c98

The leaks were fixed in crrev.com/110013
The user-after-free was fixed in crrev.com/109815

TEST=valgrind won't report errors
BUG=104029


Review URL: http://codereview.chromium.org/8571012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

R=eroman


Review URL: http://codereview.chromium.org/8572018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110168 0039d316-1c4b-4281-b951-d872f2087c98

This change updates strings used by the Spelling UI and moves the local suggestion above the one from the Spelling service.

BUG=103840
TEST=right click on a misspelled word.

Review URL: http://codereview.chromium.org/8463008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110167 0039d316-1c4b-4281-b951-d872f2087c98

Also a harder one of a CancelableTask timeout task, which was replaced
with a callback-owned flag.


Review URL: http://codereview.chromium.org/8548003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110166 0039d316-1c4b-4281-b951-d872f2087c98

This will drop the frequency of update error 6 (SYSTEM_LEVEL_INSTALL_EXISTS). There's no good reason to block updates in this case, only new installs.

BUG=103374
TEST=Install user-level Chrome, Install system-level Chrome, Update the user-level Chrome. Expect the update to succeed.


Review URL: http://codereview.chromium.org/8570006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles and tests pass.

Review URL: http://codereview.chromium.org/8556001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8572016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110162 0039d316-1c4b-4281-b951-d872f2087c98

GlobalErrorBubble.xib Changes: Hooked up the new layoutTweaker_ and buttonContainer_ outlet. Made the GTMWidthBasedTweaker slightly wider so that if the bubble was expanded there would be some extra padding on the left side.

BUG=100854
TEST=Hard coded some long titles for the accept and cancel buttons. Verified that they were no longer clipped. Hard coded short titles and verified that the buttons looked the same as before.


Review URL: http://codereview.chromium.org/8447014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110161 0039d316-1c4b-4281-b951-d872f2087c98

Hopefully you agree that this makes the code a whole lot easier to understand.

BUG=None
TEST=net_unittests


Review URL: http://codereview.chromium.org/8515020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110159 0039d316-1c4b-4281-b951-d872f2087c98

Fixes GetContainerBounds in tab_contents_view_mac.mm to return the position of the view in screen coordinates.

Currently GetContainerBounds would return origin of (0,0) which is inconsistent with GTK and Windows implementation.

BUG=104178

Review URL: http://codereview.chromium.org/8491062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110157 0039d316-1c4b-4281-b951-d872f2087c98