- 03 Jan, 2019 40 commits
-
-
Tommy Steimel authored
Test is flaky on ci bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/30508 Change-Id: I3b2658193ac62f53eed1db9d470c67b28987fc38 Reviewed-on: https://chromium-review.googlesource.com/c/1393664Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619664}
-
Jeremy Roman authored
ListHashSet is deprecated. Bug: 614112 Change-Id: I7b726aed29a92e8e61499b7a2455de0855735267 Reviewed-on: https://chromium-review.googlesource.com/c/1392273Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619663}
-
Dan Harrington authored
It is possible to reach this function in incognito mode, in which case offline_page_model will be null. Added code to handle this condition instead of crash. Bug: 918119 Change-Id: Iddad53677e168c565a20dfc888d1ccb213a54fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1393465Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#619662}
-
Kevin Ellis authored
Update interpolation of transform lists to reflect recent changes to the spec (https://drafts.csswg.org/css-transforms/#interpolation-of-transforms). * If the transform lists are of different lengths, but the transformations are pairwise compatible to the end of the shorter list, extend the shorter list with corresponding identity transforms. * If the transform lists are incompatible, perform pairwise transforms for compatible entities at the start of the list and fallback to matrix interpolation for the remaining transformations. * Fix discrete fallback. Bug: 860391, 267348, 918643 Change-Id: I8b2d770e354f3d77dad00e088a2eafe6c1ad655a Reviewed-on: https://chromium-review.googlesource.com/c/1372025 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619661}
-
Mike Reed authored
Change-Id: Ia01ee627f15389ca8fc79d87b93227d434719ecf Reviewed-on: https://chromium-review.googlesource.com/c/1394011Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#619660}
-
Brandon Mayer authored
Enabled edge embedding computation in subgraphs via feature flag. Additionally, the named_template_arguments allows graph template arguments to be modified at runtime via legacy javascript API until IPC refactor work is complete. This cl looks to support m72 and should be deprecated either at the end of beta m72 or early m73. Bug: 914959, b/120986539 Change-Id: I2b42c0989800afa9339ae8176a1a833c85ddcbdd Reviewed-on: https://chromium-review.googlesource.com/c/1376812Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Brandon Mayer <bmayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#619659}
-
cathiechen authored
If the zero-height marker container is triggered in the previous layout pass, and in this layout pass, marker become inside or marker container has other child, we need recover from zero-height, the height of marker container should be restored to auto not the height of li. This test passes in Firefox, WebKit as well as LayoutNG. Bug: 918488 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3c65a2d27f1b8dfef13c41bfe804cd1f9aab89c5 Reviewed-on: https://chromium-review.googlesource.com/c/1393129 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#619658}
-
Mason Freed authored
This should have been cleared, but wasn't. Likely the cause of https://crbug.com/917589. Bug: 917589 Change-Id: I68c54ea84dba60c67fea5566a057055c6349f36e Reviewed-on: https://chromium-review.googlesource.com/c/1394085Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#619657}
-
Elly Fong-Jones authored
This change: 1) Splits up NativeWidgetMacTest.MiniaturizeExternally, which was a bit too big; 2) Adds an override on NativeWidgetMacNSWindow of _canMiniaturize, which always allows Views windows to be miniaturized; this is the behavior that the rest of Views (and the tests) expect, and is what happened on older SDKs. Bug: 780980 Change-Id: Ic3356787433d9325aa13f1e01a8165c4ddd07b0a Reviewed-on: https://chromium-review.googlesource.com/c/1394010Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#619656}
-
edchin authored
Pre-bijou, infobars were on displayed on top of the web content below the omnibox. Today, infobars are on the bottom, having no difference with the phone form-factor. This CL removes special casing code for snapshotting in iPad. This should have been removed when bijou was launched. Bug: 918759 Change-Id: Ic18524ac47606b2d1b6ee1c254220465d64a8d71 Reviewed-on: https://chromium-review.googlesource.com/c/1394423Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619655}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/f620af75bd69..2cf86e5ab6dc $ git log f620af75b..2cf86e5ab --date=short --no-merges --format='%ad %ae %s' 2018-12-24 junyer Compute num_captures_ eagerly. 2018-12-21 junyer Make AddState actually POD. Mea culpa. 2018-12-21 ckennelly Use PODArray<> for stacks and also for nodebyid in Prog::IsOnePass(). 2018-12-21 ckennelly Use PODArray<> for temporary Regexp* arrays. 2018-12-18 ckennelly Make Compiler and Prog use PODArray<> for Insts. 2018-12-18 junyer Revert the commits for the shard_cache_mutex option. 2018-12-14 junyer Add a benchmark for the shard_cache_mutex option. 2018-12-13 junyer Make NumCPUs() in util/benchmark.cc work better. 2018-12-13 junyer Fix a bug in the DFA destructor. 2018-12-13 junyer Use NUMA topology to shard the DFA state cache mutex. 2018-12-13 junyer Prepare to shard the DFA state cache mutex. 2018-12-13 junyer Introduce the shard_cache_mutex option. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 0 Change-Id: Ic96608d666c6af5639a098d0d772d6e4de516a50 Reviewed-on: https://chromium-review.googlesource.com/c/1394372Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619654}
-
Alexei Svitkine authored
- Moves IsMetricsReportingForceEnabled to the base class, so that leaf clients don't have to override it. - Removes CreateEntropyProvider() wrapper in favor of GetMetricsStateManager() which was already implemented by both clients. - Reorders functions. - Removes unnecessary .get() calls. No functional changes. TBR=olivierrobin@chromium.org Bug: None Change-Id: Ia6666d8c82c394a01bf4fb3980603ddf86335c17 Reviewed-on: https://chromium-review.googlesource.com/c/1391783 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619653}
-
Tomasz Wiszkowski authored
Bug: 918685, 918578 Change-Id: I96799594c1fae2f10c00b8d2d2f54bd09ed0d012 Reviewed-on: https://chromium-review.googlesource.com/c/1393888 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619652}
-
Joshua Peraza authored
When SystemWebview.apk is pre-installed in an Android image, native libraries are loaded from the apk, so libcrashpad_handler.so isn't available to exec directly. Bug: 912739 Change-Id: Ica26df15481ade6951dd5e330425d0ff50b45e05 Reviewed-on: https://chromium-review.googlesource.com/c/1366494Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#619651}
-
Rohit Rao authored
AllWebStateObservationForwarder forwards observer methods for all the WebStates in a WebStateList, keeping track of WebStates as they are added, removed, and replaced. ActiveWebStateObservationForwarder forwards observer methods for just the currently-active WebState, even as the active WebState in the WebStateList changes. These classes are intended to remove some of the boilerplate bookkeeping that is necessary when trying to perform either of these common tasks. Change-Id: I8320f1d1c6aef180a79adf9cbe614cd2066b84fb Reviewed-on: https://chromium-review.googlesource.com/c/1393531Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0a1f2d4e2ab..031b028c78a9 Created with: gclient setdep -r src-internal@031b028c78a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62948de8aefe11a960ebf3c4ecefc87a4cb8c72d Reviewed-on: https://chromium-review.googlesource.com/c/1394448Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619649}
-
Sidney San Martín authored
App shims from a component build previously wouldn't launch without the DYLD_LIBRARY_PATH environment variable set to the path to the out directory. This change embeds the path so that they can be launched normally. Change-Id: I5c88b0e70172d385d93e8de8d096b03ea408d942 Reviewed-on: https://chromium-review.googlesource.com/c/1393533Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619648}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/24bb5c49673b..d9f036200e10 git log 24bb5c49673b..d9f036200e10 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 perezju@chromium.org [soundwave] Add services.Request(accept=..) option Created with: gclient setdep -r src/third_party/catapult@d9f036200e10 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917377 TBR=sullivan@chromium.org Change-Id: I457430283fe4cf86809bf6ed7bf7931f8d7db876 Reviewed-on: https://chromium-review.googlesource.com/c/1394200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619647}
-
Peter Wen authored
Broken by revert of CL that introduced use_r8: https://crrev.com/c/1394528 TBR=smaier@chromium.org Bug: 918796 Change-Id: I1c059625de3ebc0482a3be79302c535035c17f12 Reviewed-on: https://chromium-review.googlesource.com/c/1394648Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619646}
-
Lucas Furukawa Gadani authored
The RenderFrameProxy will be used for rendering the portal in a future CL. Bug: 865565 Change-Id: I8a14881da3d26716b2564607fb3582d7b3a1f065 Reviewed-on: https://chromium-review.googlesource.com/c/1280279 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619645}
-
Lowell Manners authored
iOS tests don't use BuildFakeGaiaCookieManagerServiceWithOptions, so it is dead code and can be deleted. This functionality can always be added later if/when there is a test which needs it. This is part of step 1a of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: Ia924bd8f41e6f7090646eae02841a01743f104a2 Reviewed-on: https://chromium-review.googlesource.com/c/1384370 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#619644}
-
Jeremy Roman authored
Pointed out here: https://chromium-review.googlesource.com/c/chromium/src/+/1340784/10#message-30c972195a41ceef15c7d9447bb8f75c8ca60e63 Change-Id: Ie420f10a93ab95bfa2b792e8c09ee5b44c246fea Reviewed-on: https://chromium-review.googlesource.com/c/1394385Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619643}
-
Allen Bauer authored
Bug: 915609 Change-Id: Iabc4219958f5d0411e8911b9a2f4e9de1573b68d Reviewed-on: https://chromium-review.googlesource.com/c/1393262Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#619642}
-
Leonard Grey authored
Bug: 918553 Change-Id: I03c20eedeede033bcfb912672ab29f02e8090c14 Reviewed-on: https://chromium-review.googlesource.com/c/1393532Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619641}
-
Lowell Manners authored
None of the iOS tests need a TestUrlLoaderFactory, so we should not create one by default. Once FakeGaiaCookieManagerService is eliminated, tests will need to own the TestUrlLoaderFactory themselves, so it's better not to have a TestUrlLoaderFactory be created except when it will actually be used. This is part of step 1a of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: I420748e43f468858c33bd3d6c8b32f182e50a88f Reviewed-on: https://chromium-review.googlesource.com/c/1382497 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b924e20a..5efb17b5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I646ea4b6820cad608d94f64dbb15f7d6267eb19a Reviewed-on: https://chromium-review.googlesource.com/c/1394380Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619639}
-
Ian Kilpatrick authored
This adds a new test expectation file for the width-avoid-floats.html test. We believe that if/when fill-available does get specified, it should avoid floats similar to 'auto'. Bug: 635619 Change-Id: I1c112952ea70176c55106d9bd396034cbf5ca531 Reviewed-on: https://chromium-review.googlesource.com/c/1393667Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#619638}
-
Gabriel Charette authored
R=etiennep@chromium.org TBR=fdoray@chromium.org Bug: 915207 Change-Id: I3283dee3dad0d6f64cc70bb9bb49cebdac49616a Reviewed-on: https://chromium-review.googlesource.com/c/1394589Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Nico Weber authored
See https://github.com/erikdoe/ocmock/issues/369 TBR=rnk Bug: none Change-Id: Ice9aca9e524d54eecb4bb41615f36c9926de1e2e Reviewed-on: https://chromium-review.googlesource.com/c/1394430Reviewed-by:
-
Kevin Ellis authored
This patch improves test coverage for the interpolation of transform lists. Specifically, the new tests cover: * mismatched list lengths with a partial prefix match * mix of exact and primitive (e.g. scaleX & scaleY --> scale) matches These new tests fail in Chrome without the patch (https://chromium-review.googlesource.com/c/chromium/src/+/1372025) to implement the algorithm outlined in transforms spec (https://drafts.csswg.org/css-transforms-1/#interpolation-of-transforms), but pass when tested in Firefox version 64.0. Bug: 918643 Change-Id: I65bfe5b3c13c2fb33b3d2b926dc153135b140a63 Reviewed-on: https://chromium-review.googlesource.com/c/1393460Reviewed-by:
-
Egor Pasko authored
This reverts commit 09f15bdb. Reason for revert: http://crbug.com/918796 Original change's description: > Android: Turning on R8 instead of Proguard for public targets > > We are in the process of migrating to R8 to replace Proguard. This is > the first step - move all usages of Proguard in public targets to R8. > > Some refactorings were natural with the few forced changes this caused. > > TBR=smaier > > Bug: 908988, 913554 > Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c > Reviewed-on: https://chromium-review.googlesource.com/c/1357306 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619471} TBR=wnwen@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Ieb34a24da7c001e78d832f7300855c7c7c749add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988, 913554 Reviewed-on: https://chromium-review.googlesource.com/c/1394528Reviewed-by:
-
Eric Noyau authored
Bug: None Change-Id: Iea5db9ccf1b792b45d4d0bf542f3900111802ccb Reviewed-on: https://chromium-review.googlesource.com/c/1394526Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdde2926df92..8966b55644c2 git log fdde2926df92..8966b55644c2 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 reed@google.com Reland "undefine SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE" Created with: gclient setdep -r src/third_party/skia@8966b55644c2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I61cd4ef210740e401c1d34069f4dea5e7dccd00d Reviewed-on: https://chromium-review.googlesource.com/c/1394447Reviewed-by:
-
Henrik Boström authored
The tests started failing in an earlier WPT import, see https://crbug.com/832501. TBR=hta@chromium.org Bug: 832501 Change-Id: If53c927e03dabb60158c61befc5a29d1c45bba1f Reviewed-on: https://chromium-review.googlesource.com/c/1394307Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619631}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4abc078d238b..d0a1f2d4e2ab Created with: gclient setdep -r src-internal@d0a1f2d4e2ab The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d3a8449745e4047f95143a19ab85eac8aa29bdf Reviewed-on: https://chromium-review.googlesource.com/c/1394199Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39e8ad8f..b924e20a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4af2c35a9ed69cdec2f5a6f055b29be450fb04dc Reviewed-on: https://chromium-review.googlesource.com/c/1394379Reviewed-by:
-
Xida Chen authored
This CL does the plubming for the PaintWorkletLayerPainter. It follows the same implementation as the existing LayerTreeMutator which is designed for animation worklet. Change-Id: I173a61173e025d257f1782c5270e41ca24538e9e Reviewed-on: https://chromium-review.googlesource.com/c/1350332 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619628}
-
Colin Blundell authored
This CL inverts the dependency between SigninManager and SigninErrorController: rather than the former depending on the latter, the latter now depends on the former. The concrete motivation is that SigninManager forms part of the core implementation of the Identity Service, whereas SigninErrorController is fundamentally a client-side class: it coalesces authentication errors from various underlying sources in order to conveniently present global information to the UI. The inversion of the dependency is conceptually straightforward. Currently, SigninManager updates SigninErrorController's primary account ID when its own primary account is set/cleared. This CL changes SigninErrorController to explicitly check SigninManager's primary account ID and to observe SigninManager for changes to the primary account. Note that this change means that if the primary account were to be set/cleared on ChromeOS in an ongoing session, SigninErrorController would not be notified (since the SigninManager observer callbacks are not invoked on ChromeOS). However, in production on ChromeOS the primary account is set when SigninManagerBase is created and is never cleared. As of this CL, SigninManagerBase will be created before SigninErrorController (since the latter now depends on the former). This CL was unfortunately difficult to subdivide: the changes to make SigninErrorController depend on SigninManager and the changes to have SigninErrorController *use* SigninManager need to be made atomically in order to avoid the two objects depending on each other, which is an antipattern for KeyedServices. The meaningful changes are the ones to signin_error_controller.* and signin_manager_base.*. To test this change, I verified the following: - Start Chrome - Sign in to the browser - Sign out on the web (e.g., in gmail) - Observe that the "sync paused" error shows up in the avatator button on the top right of the chrome - Restart Chrome - Observe that the "sync paused" error is still present - Sign in to the browser again - Observe that the "sync paused" error goes away I also verified that the above behavior is dependent on SigninErrorController being correct by changing SigninErrorController::Update() to return immediately and verifying that the avatar button never changes through the above set of steps. Followup CLs will move signin_error_controller.* out of the signin_internals GN target and will port SigninErrorController to talk to IdentityManager. TBR=droger@chromium.org Bug: 917836 Change-Id: I7e4a66bcffa4c1d3a8f296dabbf6a7c38602b5fa Reviewed-on: https://chromium-review.googlesource.com/c/1390012 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4cfddf92. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2a9c667753b136145712e4f4944a514cdf3a4b29 Reviewed-on: https://chromium-review.googlesource.com/c/1394378Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619626}
-
Mark Cogan authored
The ViewControllerSwapping method -showTabSwitcher: had a completion parameter that was no longer being used. Change-Id: Ife1b0609191868d9a3505d8ea0657c54c8ed25dc Reviewed-on: https://chromium-review.googlesource.com/c/1392341 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619625}
-
